duckdb 0.3.2-dev739.0 → 0.3.2-dev782.0

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "duckdb",
   "main": "./lib/duckdb.js",
-  "version": "0.3.2-dev739.0",
+  "version": "0.3.2-dev782.0",
   "description": "DuckDB node.js API",
   "gypfile": true,
   "dependencies": {

package/src/duckdb.cpp

@@ -27591,8 +27591,6 @@ public:
 private:
 	unique_ptr<TreeNode> CreateTree(PhysicalOperator *root, idx_t depth = 0);
 	void Render(const TreeNode &node, std::ostream &str) const;
-	//! The lock used for flushing information from a thread into the global query profiler
-	mutex flush_lock;
 
 public:
 	DUCKDB_API bool IsEnabled() const;
@@ -27633,6 +27631,8 @@ private:
 
 	//! Whether or not the query profiler is running
 	bool running;
+	//! The lock used for flushing information from a thread into the global query profiler
+	mutex flush_lock;
 
 	//! Whether or not the query requires profiling
 	bool query_requires_profiling;
@@ -27645,7 +27645,7 @@ private:
 	Profiler main_query;
 	//! A map of a Physical Operator pointer to a tree node
 	TreeMap tree_map;
-
+	//! Whether or not we are running as part of a explain_analyze query
 	bool is_explain_analyze;
 
 public:
@@ -27675,12 +27675,12 @@ private:
 class QueryProfilerHistory {
 private:
 	//! Previous Query profilers
-	deque<pair<transaction_t, unique_ptr<QueryProfiler>>> prev_profilers;
+	deque<pair<transaction_t, shared_ptr<QueryProfiler>>> prev_profilers;
 	//! Previous Query profilers size
 	uint64_t prev_profilers_size = 20;
 
 public:
-	deque<pair<transaction_t, unique_ptr<QueryProfiler>>> &GetPrevProfilers() {
+	deque<pair<transaction_t, shared_ptr<QueryProfiler>>> &GetPrevProfilers() {
 		return prev_profilers;
 	}
 	QueryProfilerHistory() {
@@ -33840,13 +33840,14 @@ void ValidityMask::Slice(const ValidityMask &other, idx_t offset) {
 		Initialize(other);
 		return;
 	}
-	Initialize(STANDARD_VECTOR_SIZE);
+	ValidityMask new_mask(STANDARD_VECTOR_SIZE);
 
 // FIXME THIS NEEDS FIXING!
 #if 1
 	for (idx_t i = offset; i < STANDARD_VECTOR_SIZE; i++) {
-		Set(i - offset, other.RowIsValid(i));
+		new_mask.Set(i - offset, other.RowIsValid(i));
 	}
+	Initialize(new_mask);
 #else
 	// first shift the "whole" units
 	idx_t entire_units = offset / BITS_PER_VALUE;
@@ -33854,7 +33855,7 @@ void ValidityMask::Slice(const ValidityMask &other, idx_t offset) {
 	if (entire_units > 0) {
 		idx_t validity_idx;
 		for (validity_idx = 0; validity_idx + entire_units < STANDARD_ENTRY_COUNT; validity_idx++) {
-			validity_mask[validity_idx] = other.validity_mask[validity_idx + entire_units];
+			new_mask.validity_mask[validity_idx] = other.validity_mask[validity_idx + entire_units];
 		}
 	}
 	// now we shift the remaining sub units
@@ -33869,15 +33870,17 @@ void ValidityMask::Slice(const ValidityMask &other, idx_t offset) {
 	if (sub_units > 0) {
 		idx_t validity_idx;
 		for (validity_idx = 0; validity_idx + 1 < STANDARD_ENTRY_COUNT; validity_idx++) {
-			validity_mask[validity_idx] = (other.validity_mask[validity_idx] >> sub_units) |
-			                              (other.validity_mask[validity_idx + 1] << (BITS_PER_VALUE - sub_units));
+			new_mask.validity_mask[validity_idx] =
+			    (other.validity_mask[validity_idx] >> sub_units) |
+			    (other.validity_mask[validity_idx + 1] << (BITS_PER_VALUE - sub_units));
 		}
-		validity_mask[validity_idx] >>= sub_units;
+		new_mask.validity_mask[validity_idx] >>= sub_units;
 	}
 #ifdef DEBUG
 	for (idx_t i = offset; i < STANDARD_VECTOR_SIZE; i++) {
-		D_ASSERT(RowIsValid(i - offset) == other.RowIsValid(i));
+		D_ASSERT(new_mask.RowIsValid(i - offset) == other.RowIsValid(i));
 	}
+	Initialize(new_mask);
 #endif
 #endif
 }
@@ -97524,7 +97527,7 @@ struct ActiveQueryContext {
 };
 
 ClientContext::ClientContext(shared_ptr<DatabaseInstance> database)
-    : profiler(make_unique<QueryProfiler>(*this)), query_profiler_history(make_unique<QueryProfilerHistory>()),
+    : profiler(make_shared<QueryProfiler>(*this)), query_profiler_history(make_unique<QueryProfilerHistory>()),
       db(move(database)), transaction(db->GetTransactionManager(), *this), interrupted(false),
       temporary_objects(make_unique<SchemaCatalogEntry>(&db->GetCatalog(), TEMP_SCHEMA, true)),
       catalog_search_path(make_unique<CatalogSearchPath>(*this)),
@@ -97619,7 +97622,7 @@ string ClientContext::EndQueryInternal(ClientContextLock &lock, bool success, bo
 			auto &prev_profilers = query_profiler_history->GetPrevProfilers();
 			prev_profilers.emplace_back(transaction.ActiveTransaction().active_query, move(profiler));
 			// Reinitialize the query profiler
-			profiler = make_unique<QueryProfiler>(*this);
+			profiler = make_shared<QueryProfiler>(*this);
 			// Propagate settings of the saved query into the new profiler.
 			profiler->Propagate(*prev_profilers.back().second);
 			if (prev_profilers.size() >= query_profiler_history->GetPrevProfilersSize()) {
@@ -107895,6 +107898,7 @@ void QueryProfiler::StartExplainAnalyze() {
 }
 
 void QueryProfiler::EndQuery() {
+	lock_guard<mutex> guard(flush_lock);
 	if (!IsEnabled() || !running) {
 		return;
 	}
@@ -108053,10 +108057,10 @@ void OperatorProfiler::Flush(const PhysicalOperator *phys_op, ExpressionExecutor
 }
 
 void QueryProfiler::Flush(OperatorProfiler &profiler) {
+	lock_guard<mutex> guard(flush_lock);
 	if (!IsEnabled() || !running) {
 		return;
 	}
-	lock_guard<mutex> guard(flush_lock);
 	for (auto &node : profiler.timings) {
 		auto entry = tree_map.find(node.first);
 		D_ASSERT(entry != tree_map.end());
@@ -120731,8 +120735,8 @@ void Executor::Initialize(PhysicalOperator *plan) {
 		lock_guard<mutex> elock(executor_lock);
 		physical_plan = plan;
 
-		auto &profiler = QueryProfiler::Get(context);
-		profiler.Initialize(physical_plan);
+		this->profiler = context.profiler;
+		profiler->Initialize(physical_plan);
 		this->producer = scheduler.CreateProducer();
 
 		auto root_pipeline = make_shared<Pipeline>(*this);
@@ -121143,9 +121147,7 @@ void Executor::ThrowExceptionInternal() { // LCOV_EXCL_START
 } // LCOV_EXCL_STOP
 
 void Executor::Flush(ThreadContext &tcontext) {
-	lock_guard<mutex> elock(executor_lock);
-	auto &profiler = QueryProfiler::Get(context);
-	profiler.Flush(tcontext.profiler);
+	profiler->Flush(tcontext.profiler);
 }
 
 bool Executor::GetPipelinesProgress(double &current_progress) { // LCOV_EXCL_START
@@ -153713,6 +153715,7 @@ void __fastpack64(const uint64_t *__restrict in, uint32_t *__restrict out);
 // LICENSE_CHANGE_END
 
 
+
 #include <stdexcept>
 
 namespace duckdb_fastpforlib {

package/src/duckdb.hpp

@@ -11,8 +11,8 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 #pragma once
 #define DUCKDB_AMALGAMATION 1
 #define DUCKDB_AMALGAMATION_EXTENDED 1
-#define DUCKDB_SOURCE_ID "2bb221361"
-#define DUCKDB_VERSION "0.3.2-dev739"
+#define DUCKDB_SOURCE_ID "7473f3eb0"
+#define DUCKDB_VERSION "0.3.2-dev782"
 //===----------------------------------------------------------------------===//
 //                         DuckDB
 //
@@ -9869,6 +9869,7 @@ class DataChunk;
 class PhysicalOperator;
 class PipelineExecutor;
 class OperatorState;
+class QueryProfiler;
 class ThreadContext;
 class Task;
 
@@ -9968,6 +9969,8 @@ private:
 	vector<pair<ExceptionType, string>> exceptions;
 	//! List of events
 	vector<shared_ptr<Event>> events;
+	//! The query profiler
+	shared_ptr<QueryProfiler> profiler;
 
 	//! The amount of completed pipelines of the query
 	atomic<idx_t> completed_pipelines;
@@ -17117,7 +17120,7 @@ public:
 	DUCKDB_API ~ClientContext();
 
 	//! Query profiler
-	unique_ptr<QueryProfiler> profiler;
+	shared_ptr<QueryProfiler> profiler;
 	//! QueryProfiler History
 	unique_ptr<QueryProfilerHistory> query_profiler_history;
 	//! The database that this client is connected to