duckdb 0.10.1-dev13.0 → 0.10.1-dev22.0

package/.github/workflows/NodeJS.yml

@@ -11,8 +11,8 @@ concurrency:
 
 env:
   GH_TOKEN: ${{ secrets.GH_TOKEN }}
-  AWS_ACCESS_KEY_ID: ${{secrets.S3_DUCKDB_ORG_DEPLOY_ID}}
-  AWS_SECRET_ACCESS_KEY: ${{secrets.S3_DUCKDB_ORG_DEPLOY_KEY}}
+  AWS_ACCESS_KEY_ID: ${{secrets.S3_DUCKDB_NODE_ID}}
+  AWS_SECRET_ACCESS_KEY: ${{secrets.S3_DUCKDB_NODE_KEY}}
   AWS_DEFAULT_REGION: us-east-1
 
 jobs:
@@ -30,20 +30,6 @@ jobs:
         with:
           python-version: '3.11'
 
-      - name: Debug workflow
-        shell: bash
-        run:
-          echo "$AWS_ACCESS_KEY_ID" "$AWS_DEFAULT_REGION"
-          echo "$AWS_ACCESS_KEY_ID" > myfile.txt
-          LOCAL_BINARY=myfile.txt
-          REMOTE_BINARY=https://npm.duckdb.org/duckdb/myfile.txt
-          S3_ENDPOINT_BINARY="s3://duckdb-npm/"${REMOTE_BINARY:23}
-          pip install awscli
-          echo "local binary at  $LOCAL_BINARY"
-          echo "remote binary at $REMOTE_BINARY"
-          echo "served from      $S3_ENDPOINT_BINARY"
-          aws s3 cp $LOCAL_BINARY $S3_ENDPOINT_BINARY --acl public-read
-
       - name: Setup NPM
         shell: bash
         run: ./scripts/node_version.sh upload
@@ -62,7 +48,7 @@ jobs:
     strategy:
       matrix:
         # node.js current support policy to be found at https://github.com/duckdb/duckdb-node/tree/main/#Supported-Node-versions
-        node: [ '16', '17', '18', '19', '20', '21']
+        node: [ '12', '14', '16', '17', '18', '19', '20', '21']
         target_arch: [ x64, arm64 ]
         isRelease:
           - ${{ startsWith(github.ref, 'refs/tags/v') || github.ref == 'refs/heads/main' }}
@@ -95,7 +81,7 @@ jobs:
       # Default Python (3.12) doesn't have support for distutils
       - uses: actions/setup-python@v4
         with:
-          python-version: '3.11'
+          python-version: '3.10'
 
       - name: Update apt
         shell: bash

package/package.json

@@ -2,7 +2,7 @@
   "name": "duckdb",
   "main": "./lib/duckdb.js",
   "types": "./lib/duckdb.d.ts",
-  "version": "0.10.1-dev13.0",
+  "version": "0.10.1-dev22.0",
   "description": "DuckDB node.js API",
   "gypfile": true,
   "dependencies": {

package/src/database.cpp

@@ -141,6 +141,7 @@ static void TaskCompleteCallback(napi_env e, napi_status status, void *data) {
 	duckdb::unique_ptr<TaskHolder> holder((TaskHolder *)data);
 	holder->db->TaskComplete(e);
 	holder->task->DoCallback();
+	napi_delete_async_work(e, holder->request);
 }
 
 void Database::TaskComplete(Napi::Env env) {

package/myfile.txt

@@ -1 +0,0 @@
-AKIA4HHCC5ZJWPMXCW75 us-east-1 echo AKIA4HHCC5ZJWPMXCW75 LOCAL_BINARY=myfile.txt REMOTE_BINARY=https://npm.duckdb.org/duckdb/myfile.txt S3_ENDPOINT_BINARY=s3://duckdb-npm/ pip install awscli echo local binary at   echo remote binary at  echo served from       aws s3 cp --acl public-read