dtable-utils 0.0.4-beta.1 → 4.2.0

package/README.md

@@ -55,3 +55,17 @@ $ yarn add dtable-utils
 ```js
 import { CellType } from 'dtable-utils';
 ```
+
+## 测试
+
+### 常规测试
+
+```bash
+npm test
+```
+
+### 测试覆盖率
+
+```bash
+npm run test-cov
+```

package/es/column/option.js

@@ -86,10 +86,9 @@ var createOption = function createOption(options, optionName) {
 
 /**
  * Generate cell option by name.
- * Return the option id if exist, otherwise generate a new option
  * @param {array} options e.g. [{ id, ... }, ...]
  * @param {string} optionName used as the option name
- * @returns option id and option, object
+ * @returns return the option id if exist, otherwise generate a new option, object
  */
 var generatorCellOption = function generatorCellOption(options, optionName) {
   var existOption = options.find(function (option) {
@@ -109,10 +108,9 @@ var generatorCellOption = function generatorCellOption(options, optionName) {
 
 /**
  * Generate cell options by names.
- * Return the options ids if exist, otherwise generate new options
  * @param {array} options e.g. [{ id, ... }, ...]
  * @param {array} optionNames used as the options names
- * @returns options ids and options, object
+ * @returns Return the options ids if exist, otherwise generate new options, object
  */
 var generatorCellOptions = function generatorCellOptions(options, optionNames) {
   var cellOptions = [];

package/es/filter/core.js

@@ -54,7 +54,7 @@ var otherDate = function otherDate(filterTermModifier, filterTerm) {
   var month = today.getMonth(); // use js month representation: 0 - 11
   var day = today.getDate();
 
-  //          0   1   2   3    4   5   6   7   8   9  10  11
+  //          0   1   2   3    4   5   6   7   8   9  10  11 days in every month
   var days = [31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31];
   days[1] = year % 4 === 0 && (year % 100 !== 0 || year % 400 === 0) ? 29 : 28; // is leap year
   switch (filterTermModifier) {

package/es/sort/sort-column/number.js

@@ -10,9 +10,15 @@ import { SORT_TYPE } from '../../constants/sort.js';
 var sortNumber = function sortNumber(leftNumber, rightNumber, sortType) {
   var emptyLeftNumber = !leftNumber && leftNumber !== 0;
   var emptyRightNumber = !rightNumber && rightNumber !== 0;
-  if (emptyLeftNumber && emptyRightNumber) return 0;
-  if (emptyLeftNumber) return 1;
-  if (emptyRightNumber) return -1;
+  if (emptyLeftNumber && emptyRightNumber) {
+    return 0;
+  }
+  if (emptyLeftNumber) {
+    return 1;
+  }
+  if (emptyRightNumber) {
+    return -1;
+  }
   if (leftNumber > rightNumber) {
     return sortType === SORT_TYPE.UP ? 1 : -1;
   }

package/es/sort/sort-column/single-select.js

@@ -15,9 +15,15 @@ var sortSingleSelect = function sortSingleSelect(leftOptionId, rightOptionId, _r
   var nextOptionIdIndex = option_id_index_map[rightOptionId];
   var emptyLeftOptionId = !currentOptionIdIndex && currentOptionIdIndex !== 0;
   var emptyRightOptionId = !nextOptionIdIndex && nextOptionIdIndex !== 0;
-  if (emptyLeftOptionId && emptyRightOptionId) return 0;
-  if (emptyLeftOptionId) return 1;
-  if (emptyRightOptionId) return -1;
+  if (emptyLeftOptionId && emptyRightOptionId) {
+    return 0;
+  }
+  if (emptyLeftOptionId) {
+    return 1;
+  }
+  if (emptyRightOptionId) {
+    return -1;
+  }
   if (currentOptionIdIndex > nextOptionIdIndex) {
     return sort_type === SORT_TYPE.UP ? 1 : -1;
   }

package/es/sort/sort-column/text.js

@@ -51,10 +51,18 @@ var compareString = function compareString(leftString, rightString) {
 var sortText = function sortText(leftText, rightText, sortType) {
   var emptyLeftText = !leftText;
   var emptyRightText = !rightText;
-  if (emptyLeftText && emptyRightText) return 0;
-  if (emptyLeftText) return 1;
-  if (emptyRightText) return -1;
-  if (rightText === leftText) return 0;
+  if (emptyLeftText && emptyRightText) {
+    return 0;
+  }
+  if (emptyLeftText) {
+    return 1;
+  }
+  if (emptyRightText) {
+    return -1;
+  }
+  if (rightText === leftText) {
+    return 0;
+  }
   return sortType === SORT_TYPE.UP ? compareString(leftText, rightText) : -1 * compareString(leftText, rightText);
 };
 

package/lib/column/option.js

@@ -90,10 +90,9 @@ var createOption = function createOption(options, optionName) {
 
 /**
  * Generate cell option by name.
- * Return the option id if exist, otherwise generate a new option
  * @param {array} options e.g. [{ id, ... }, ...]
  * @param {string} optionName used as the option name
- * @returns option id and option, object
+ * @returns return the option id if exist, otherwise generate a new option, object
  */
 var generatorCellOption = function generatorCellOption(options, optionName) {
   var existOption = options.find(function (option) {
@@ -113,10 +112,9 @@ var generatorCellOption = function generatorCellOption(options, optionName) {
 
 /**
  * Generate cell options by names.
- * Return the options ids if exist, otherwise generate new options
  * @param {array} options e.g. [{ id, ... }, ...]
  * @param {array} optionNames used as the options names
- * @returns options ids and options, object
+ * @returns Return the options ids if exist, otherwise generate new options, object
  */
 var generatorCellOptions = function generatorCellOptions(options, optionNames) {
   var cellOptions = [];

package/lib/filter/core.js

@@ -62,7 +62,7 @@ var otherDate = function otherDate(filterTermModifier, filterTerm) {
   var month = today.getMonth(); // use js month representation: 0 - 11
   var day = today.getDate();
 
-  //          0   1   2   3    4   5   6   7   8   9  10  11
+  //          0   1   2   3    4   5   6   7   8   9  10  11 days in every month
   var days = [31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31];
   days[1] = year % 4 === 0 && (year % 100 !== 0 || year % 400 === 0) ? 29 : 28; // is leap year
   switch (filterTermModifier) {

package/lib/sort/sort-column/number.js

@@ -14,9 +14,15 @@ var sort = require('../../constants/sort.js');
 var sortNumber = function sortNumber(leftNumber, rightNumber, sortType) {
   var emptyLeftNumber = !leftNumber && leftNumber !== 0;
   var emptyRightNumber = !rightNumber && rightNumber !== 0;
-  if (emptyLeftNumber && emptyRightNumber) return 0;
-  if (emptyLeftNumber) return 1;
-  if (emptyRightNumber) return -1;
+  if (emptyLeftNumber && emptyRightNumber) {
+    return 0;
+  }
+  if (emptyLeftNumber) {
+    return 1;
+  }
+  if (emptyRightNumber) {
+    return -1;
+  }
   if (leftNumber > rightNumber) {
     return sortType === sort.SORT_TYPE.UP ? 1 : -1;
   }

package/lib/sort/sort-column/single-select.js

@@ -19,9 +19,15 @@ var sortSingleSelect = function sortSingleSelect(leftOptionId, rightOptionId, _r
   var nextOptionIdIndex = option_id_index_map[rightOptionId];
   var emptyLeftOptionId = !currentOptionIdIndex && currentOptionIdIndex !== 0;
   var emptyRightOptionId = !nextOptionIdIndex && nextOptionIdIndex !== 0;
-  if (emptyLeftOptionId && emptyRightOptionId) return 0;
-  if (emptyLeftOptionId) return 1;
-  if (emptyRightOptionId) return -1;
+  if (emptyLeftOptionId && emptyRightOptionId) {
+    return 0;
+  }
+  if (emptyLeftOptionId) {
+    return 1;
+  }
+  if (emptyRightOptionId) {
+    return -1;
+  }
   if (currentOptionIdIndex > nextOptionIdIndex) {
     return sort_type === sort.SORT_TYPE.UP ? 1 : -1;
   }

package/lib/sort/sort-column/text.js

@@ -55,10 +55,18 @@ var compareString = function compareString(leftString, rightString) {
 var sortText = function sortText(leftText, rightText, sortType) {
   var emptyLeftText = !leftText;
   var emptyRightText = !rightText;
-  if (emptyLeftText && emptyRightText) return 0;
-  if (emptyLeftText) return 1;
-  if (emptyRightText) return -1;
-  if (rightText === leftText) return 0;
+  if (emptyLeftText && emptyRightText) {
+    return 0;
+  }
+  if (emptyLeftText) {
+    return 1;
+  }
+  if (emptyRightText) {
+    return -1;
+  }
+  if (rightText === leftText) {
+    return 0;
+  }
   return sortType === sort.SORT_TYPE.UP ? compareString(leftText, rightText) : -1 * compareString(leftText, rightText);
 };
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dtable-utils",
-  "version": "0.0.4-beta.1",
+  "version": "4.2.0",
   "description": "dtable common utils",
   "main": "./lib/index.js",
   "module": "./es/index.js",