dsh-workspace-explorer 1.1.0 → 1.1.2

package/src/client/main.js

@@ -1,25 +1,36 @@
 import { Explorer, ExplorerTitle } from '../ui/explorer.js';
 import { explorerCss } from '../ui/styles.js';
 import { scrollHorizontally } from '../ui/horizontal-wheel.js';
-import { underPath } from '../ui/navigation.js';
+import { parentOf, resourceAddress, sessionFilePath, underPath, windowsPath } from '../ui/navigation.js';
 import { renameFavorites } from '../ui/favorites.js';
+import { installSidebarMotion } from './sidebar-motion.js';
+import { changedFileButton, installConversationDrop } from './conversation-drop.js';
 
 const id = 'dsh-workspace-explorer';
 const inject = ['slots'];
 const h = react.createElement;
 const instancePrefix = 'dsh-resource://workspace-explorer/tab/';
-const occurrence = (sessionId, tabId) => JSON.stringify([sessionId, tabId]);
+const changesReviewPrefix = 'dsh-resource://changes-review/session/';
 
 function apply(ctx) {
   if (location.protocol !== 'dsh-app:' || location.hostname !== 'app') return;
   if (!navigator.platform.startsWith('Win')) return;
-  ctx.inject(['sidebarRightTabs', 'sidebarRight', 'remote', 'remote.session'], (scope) => {
+  ctx.inject(['sidebarRightTabs', 'sidebarRight', 'remote', 'remote.session', 'remote.workspaceFiles'], (scope) => {
     const sidebar = scope.sidebarRight;
-    const views = new Map();
+    const bindings = new Map();
     const folderTabs = new Map();
     const listeners = new Set();
     let viewList = [];
     let activeView;
+    let presentedSession;
+    let workspace;
+    let expanded;
+    let fileFocused = false;
+    let projecting = false;
+    let detached = false;
+    let captureQueued = false;
+    let handoffFrame;
+    let handoffAnimation;
 
     function subscribe(listener) {
       listeners.add(listener);
@@ -30,9 +41,171 @@ function apply(ctx) {
       for (const listener of listeners) listener();
     }
 
-    function updateViews() {
-      viewList = [...new Set(views.values())];
-      notify();
+    function filesIn(sessionId) {
+      return sidebar.openTabs.getSnapshot().filter(tab => tab.sessionId === sessionId && tab.kind === 'files');
+    }
+
+    function createView(initialPath) {
+      const host = document.createElement('div');
+      host.className = 'dwe-host';
+      const view = { host, address: instancePrefix + crypto.randomUUID(), path: initialPath ?? null, initialPath };
+      view.getTarget = () => view.target;
+      view.onPath = path => {
+        if (view.path === path) return;
+        view.path = path;
+        notify();
+      };
+      view.bindFileActions = actions => {
+        view.fileActions = actions;
+        if (view.pendingPreview) {
+          const preview = view.pendingPreview;
+          view.pendingPreview = undefined;
+          actions.reveal(...preview);
+        }
+        return () => { view.fileActions = undefined; };
+      };
+      return view;
+    }
+
+    function boundView(sessionId, tabId) {
+      return sessionId === presentedSession ? bindings.get(tabId) : undefined;
+    }
+
+    function rememberPresentation() {
+      if (projecting || detached || !presentedSession || sidebar.mounted.getSnapshot() !== presentedSession) return;
+      const tab = sidebar.active();
+      const view = tab && bindings.get(tab.id);
+      if (view) activeView = view;
+      fileFocused = Boolean(view);
+      expanded = sidebar.isExpanded();
+    }
+
+    function rememberOrder(sessionId) {
+      const selector = '[data-sidebar-right-session="' + CSS.escape(sessionId) + '"] [data-dockkit-tab]';
+      const ordered = new Set();
+      for (const chip of document.querySelectorAll(selector)) {
+        const view = bindings.get(chip.dataset.dockkitTab);
+        if (view) ordered.add(view);
+      }
+      const next = [...ordered, ...viewList.filter(view => !ordered.has(view))];
+      if (next.some((view, index) => view !== viewList[index])) {
+        viewList = next;
+        notify();
+      }
+    }
+
+    function capturePresentation(sessionId) {
+      if (captureQueued) return;
+      captureQueued = true;
+      queueMicrotask(() => {
+        captureQueued = false;
+        if (presentedSession !== sessionId || sidebar.mounted.getSnapshot() !== sessionId) return;
+        rememberPresentation();
+        rememberOrder(sessionId);
+      });
+    }
+
+    function syncTabs() {
+      if (projecting || detached || !presentedSession || sidebar.mounted.getSnapshot() !== presentedSession) return;
+      const tabs = filesIn(presentedSession);
+      const live = new Set(tabs.map(tab => tab.tabId));
+      const added = [];
+      const removed = new Set();
+      for (const [tabId, view] of bindings) {
+        if (live.has(tabId)) continue;
+        bindings.delete(tabId);
+        removed.add(view);
+      }
+      for (const tab of tabs) {
+        if (bindings.has(tab.tabId)) continue;
+        const view = createView(folderTabs.get(tab.contentId) ?? workspace);
+        bindings.set(tab.tabId, view);
+        added.push(view);
+      }
+      if (removed.size || added.length) {
+        viewList = [...viewList.filter(view => !removed.has(view)), ...added];
+        if (removed.has(activeView)) activeView = undefined;
+        notify();
+      }
+      rememberPresentation();
+    }
+
+    function closeDepartingTabs() {
+      const arriving = sidebar.mounted.getSnapshot();
+      if (!arriving || !presentedSession) return;
+      if (arriving === presentedSession) {
+        if (detached) queueMicrotask(() => {
+          if (detached && sidebar.mounted.getSnapshot() === arriving) present(arriving, workspace);
+        });
+        return;
+      }
+      if (detached) return;
+      rememberOrder(presentedSession);
+      detached = true;
+      if (expanded && viewList.length) beginHandoff();
+      // The old native store is still adopted before React commits the session change.
+      for (const tab of filesIn(presentedSession)) sidebar.closeIn?.(presentedSession, tab.tabId);
+    }
+
+    function beginHandoff() {
+      const frame = document.querySelector('[data-rightbar-col]')?.parentElement;
+      if (!frame) return;
+      if (handoffFrame !== frame) {
+        finishHandoff();
+        handoffFrame = frame;
+        frame.style.setProperty('--dwe-handoff-columns', getComputedStyle(frame).gridTemplateColumns);
+        frame.dataset.dweSidebarHandoff = '';
+      }
+      cancelAnimationFrame(handoffAnimation);
+      handoffAnimation = requestAnimationFrame(() => {
+        handoffAnimation = requestAnimationFrame(finishHandoff);
+      });
+    }
+
+    function finishHandoff() {
+      cancelAnimationFrame(handoffAnimation);
+      if (!handoffFrame) return;
+      delete handoffFrame.dataset.dweSidebarHandoff;
+      handoffFrame.style.removeProperty('--dwe-handoff-columns');
+      handoffFrame = undefined;
+    }
+
+    function placeView(view, options) {
+      sidebar.openResource(view.address, { kind: 'files', ...options });
+      const tab = sidebar.active();
+      if (tab?.kind === 'files' && tab.contentId === view.address) bindings.set(tab.id, view);
+    }
+
+    function present(sessionId, cwd) {
+      workspace = windowsPath(cwd);
+      if (sessionId !== presentedSession || detached) {
+        const first = !presentedSession;
+        presentedSession = sessionId;
+        detached = false;
+        bindings.clear();
+        if (first) {
+          syncTabs();
+        } else {
+          const nativeActive = sidebar.active();
+          const preserveExpansion = expanded;
+          projecting = true;
+          try {
+            for (const tab of filesIn(sessionId)) sidebar.close(tab.tabId);
+            const replaceTab = fileFocused && sidebar.active()?.kind === 'guide' ? sidebar.active()?.id : undefined;
+            viewList.forEach((view, index) => placeView(view, index === 0 ? { replaceTab } : undefined));
+            if (viewList.length) {
+              const restoreTab = !fileFocused && nativeActive?.kind !== 'files' ? nativeActive?.id
+                : [...bindings].find(([, view]) => view === activeView)?.[0];
+              if (restoreTab) sidebar.focus(restoreTab);
+              if (preserveExpansion !== undefined && sidebar.isExpanded() !== preserveExpansion) sidebar.toggleExpanded();
+            }
+          } finally {
+            projecting = false;
+          }
+          notify();
+          rememberPresentation();
+        }
+      }
     }
 
     const openLocal = async (path, action) => {
@@ -40,17 +213,143 @@ function apply(ctx) {
       if (!result.ok) throw result.error;
     };
 
+    function openDocument(address, options) {
+      sidebar.openResource(address, { ...options, kind: 'text' });
+    }
+
     function openFolderTab(path, paneId) {
       const address = instancePrefix + crypto.randomUUID();
       folderTabs.set(address, path);
       try {
         sidebar.openResource(address, { kind: 'files', paneId });
-      } catch (error) {
+        syncTabs();
+        const tab = sidebar.active();
+        return tab?.contentId === address ? bindings.get(tab.id) : undefined;
+      } finally {
         folderTabs.delete(address);
-        throw error;
       }
     }
 
+    async function statFile(sessionId, file, signal) {
+      try {
+        const result = await scope.remote.workspaceFiles.stat(sessionId, file, signal);
+        const absolute = windowsPath(result.ok && result.value.absolutePath);
+        if (absolute) return { absolute, name: absolute.split('\\').at(-1), size: result.value.bytes };
+      } catch { /* The built-in preview can report a failed session file lookup. */ }
+    }
+
+    function revealFile(view, file, line) {
+      const preview = [file.absolute, file.name, file.size, line];
+      if (view.fileActions) view.fileActions.reveal(...preview);
+      else view.pendingPreview = preview;
+    }
+
+    function fileRequest(address, options) {
+      const sessionId = sidebar.mounted.getSnapshot();
+      const file = workspace && sessionId === presentedSession && sessionFilePath(address, sessionId);
+      if (file) return { address, sessionId, file, params: options?.params };
+    }
+
+    function currentExplorer() {
+      return bindings.get(sidebar.active()?.id) ?? activeView ?? viewList[0];
+    }
+
+    async function openConversationFile(request, signal, { view, onUnavailable }) {
+      const { address, sessionId, file, params } = request;
+      const metadata = await statFile(sessionId, file, signal);
+      if (signal.aborted || sidebar.mounted.getSnapshot() !== sessionId) return;
+      if (!metadata) {
+        if (onUnavailable) onUnavailable();
+        else openDocument(address, { params });
+        return;
+      }
+      const existing = viewList.includes(view) ? view : currentExplorer();
+      const tabId = existing && [...bindings].find(([, item]) => item === existing)?.[0];
+      if (tabId) {
+        sidebar.focus(tabId);
+        if (!sidebar.isExpanded() && !existing.target?.isFloating) sidebar.toggleExpanded();
+      }
+      const target = tabId ? existing : openFolderTab(parentOf(metadata.absolute));
+      if (target) revealFile(target, metadata, params?.line);
+    }
+
+    function installFileOpener() {
+      const openResource = sidebar.openResource;
+      let fileClick;
+      let dragSource;
+      let openingReview = false;
+      function openFile(request, onUnavailable) {
+        fileClick?.abort();
+        fileClick = new AbortController();
+        void openConversationFile(request, fileClick.signal, { view: currentExplorer(), onUnavailable });
+      }
+      function open(address, options) {
+        const changed = dragSource?.changed;
+        if (changed && address.startsWith(changesReviewPrefix)) {
+          if (address.startsWith(changesReviewPrefix + encodeURIComponent(changed.sessionId) + '/')) {
+            dragSource.file = { ...changed, review: { address, params: options?.params } };
+          }
+          return;
+        }
+        const request = (!options || Object.keys(options).every(key => key === 'params')) && fileRequest(address, options);
+        if (!request) return openResource.call(this, address, options);
+        if (dragSource) {
+          dragSource.file = request;
+          return;
+        }
+        openFile(request);
+      }
+      function changedFileRequest(button) {
+        const card = button.closest('[data-changed-files]');
+        const description = document.getElementById(button.getAttribute('aria-describedby'));
+        const sessionId = card?.closest('[data-conversation-content]')?.dataset.conversationSession;
+        if (sessionId !== sidebar.mounted.getSnapshot() || !card?.contains(description)) return;
+        const absolute = windowsPath(description.textContent);
+        if (absolute) return fileRequest(resourceAddress(absolute, sessionId));
+      }
+      function clickChangedFile(event) {
+        // Shift-click retains the native change review for an individual file.
+        if (openingReview || dragSource?.changed || event.shiftKey || !(event.target instanceof Element)) return;
+        const button = event.target.closest(changedFileButton);
+        const request = button && changedFileRequest(button);
+        if (!request) return;
+        event.preventDefault();
+        event.stopPropagation();
+        openFile(request, () => {
+          if (!button.isConnected) return;
+          openingReview = true;
+          try { button.click(); }
+          finally { openingReview = false; }
+        });
+      }
+      function readDragSource(button) {
+        const isChanged = button.matches(changedFileButton);
+        const changed = isChanged ? changedFileRequest(button) : undefined;
+        if (isChanged && !changed) return;
+        // Capture Harness's file or review address without opening the tab until drop.
+        const capture = { changed };
+        dragSource = capture;
+        try { button.click(); }
+        finally { dragSource = undefined; }
+        return capture.file ?? changed;
+      }
+      sidebar.openResource = open;
+      const stopDrop = installConversationDrop(sidebar.mounted, readDragSource, ({ address, sessionId, params, review }, paneId) => {
+        if (sidebar.mounted.getSnapshot() !== sessionId) return;
+        if (review) sidebar.openResource(review.address, { paneId, params: review.params });
+        else openDocument(address, { paneId, params });
+      });
+      document.addEventListener('click', clickChangedFile, true);
+      const stop = sidebar.mounted.subscribe(() => fileClick?.abort());
+      return () => {
+        document.removeEventListener('click', clickChangedFile, true);
+        stopDrop();
+        stop();
+        fileClick?.abort();
+        if (sidebar.openResource === open) sidebar.openResource = openResource;
+      };
+    }
+
     function refreshDirectories(paths, moved = []) {
       const changed = new Set(paths.map(path => path.toLowerCase()));
       for (const view of viewList) {
@@ -67,101 +366,81 @@ function apply(ctx) {
     }
 
     function Anchor({ sessionId, useTabInfo }) {
-      const { tab } = useTabInfo();
+      const { tab, panel } = useTabInfo();
       const anchor = react.useRef(null);
-      const key = occurrence(sessionId, tab.id);
+      const view = react.useSyncExternalStore(subscribe, () => boundView(sessionId, tab.id));
+      const navigation = tab.navigation;
       react.useLayoutEffect(() => {
-        if (!tab.visible) return;
+        if (!tab.visible || !view) return;
         const element = anchor.current;
-        let view = views.get(key);
-        if (!view) {
-          const host = document.createElement('div');
-          host.className = 'dwe-host';
-          const initialPath = folderTabs.get(tab.contentId);
-          folderTabs.delete(tab.contentId);
-          view = { host, address: initialPath ? tab.contentId : instancePrefix + crypto.randomUUID(), path: null, initialPath };
-          view.getTarget = () => view.target;
-          view.onPath = path => {
-            if (view.path === path) return;
-            view.path = path;
-            notify();
-          };
-          view.bindFileActions = actions => {
-            view.fileActions = actions;
-            return () => { view.fileActions = undefined; };
-          };
-          views.set(key, view);
-          updateViews();
-        }
-        const target = { sessionId, actions: tab.actions };
+        const target = { sessionId, paneId: panel.id, isFloating: panel.isFloating };
         view.target = target;
         element.appendChild(view.host);
         notify();
+        capturePresentation(sessionId);
         const dispose = tab.actions.bindCommands?.({ refresh: () => view.fileActions?.refresh() });
         return () => {
           dispose?.();
           if (view.target !== target) return;
           view.target = undefined;
           if (view.host.parentNode === element) view.host.remove();
-          if (activeView === view && sidebar.mounted.getSnapshot() === sessionId
-              && (!sidebar.isExpanded() || sidebar.active()?.kind !== 'files')) {
-            activeView = undefined;
-          }
           notify();
+          capturePresentation(sessionId);
         };
-      }, [key, sessionId, tab.visible, tab.actions]);
-      react.useLayoutEffect(() => {
-        if (tab.visible && sidebar.active()?.id === tab.id) activeView = views.get(key);
-      });
+      }, [view, sessionId, tab.visible, tab.actions, panel.id, panel.isFloating]);
+      react.useEffect(() => {
+        if (!tab.visible || !view || view.handledNavigation === navigation) return;
+        const { address, params } = navigation;
+        const file = sessionFilePath(address, sessionId);
+        if (!file) return;
+
+        const controller = new AbortController();
+        const { signal } = controller;
+        const isCurrent = () => !signal.aborted && !tab.signal?.aborted
+          && sidebar.mounted.getSnapshot() === sessionId && boundView(sessionId, tab.id) === view;
+        async function reveal() {
+          const metadata = await statFile(sessionId, file, signal);
+          if (!isCurrent()) return;
+          view.handledNavigation = navigation;
+          if (metadata) {
+            view.revealedFile = true;
+            revealFile(view, metadata, params?.line);
+          } else {
+            openDocument(address, { paneId: panel.id, params, replaceTab: view.revealedFile ? undefined : tab.id });
+          }
+        }
+        void reveal();
+        return () => controller.abort();
+      }, [view, sessionId, tab.id, tab.visible, navigation, panel.id]);
       return h('div', { className: 'dwe-host', ref: anchor });
     }
 
     function Title({ sessionId, useTabInfo }) {
       const { tab } = useTabInfo();
-      const path = react.useSyncExternalStore(subscribe, () => views.get(occurrence(sessionId, tab.id))?.path ?? null);
+      const path = react.useSyncExternalStore(subscribe, () => boundView(sessionId, tab.id)?.path ?? null);
+      react.useLayoutEffect(() => {
+        if (tab.visible) capturePresentation(sessionId);
+      });
       return h(ExplorerTitle, { path });
     }
 
-    function View({ view, useSessions }) {
+    function View({ view, cwd }) {
       const target = react.useSyncExternalStore(subscribe, view.getTarget);
       const sessionId = target?.sessionId;
-      const cwd = useSessions(state => sessionId ? state.byId[sessionId]?.cwd : undefined);
       return reactDom.createPortal(h(Explorer, {
         sessionId, cwd, initialPath: view.initialPath, getTarget: view.getTarget, bindFileActions: view.bindFileActions,
-        onPath: view.onPath, openLocal, openFolderTab, refreshDirectories, updateRenamedPath,
+        onPath: view.onPath, openLocal, openDocument, openFolderTab, refreshDirectories, updateRenamedPath,
       }), view.host);
     }
 
     function Keeper({ useSessions }) {
       const sessionId = react.useSyncExternalStore(sidebar.mounted.subscribe, sidebar.mounted.getSnapshot);
       const currentViews = react.useSyncExternalStore(subscribe, () => viewList);
-      const previous = react.useRef();
+      const cwd = useSessions(state => sessionId ? state.byId[sessionId]?.cwd : undefined);
       react.useLayoutEffect(() => {
-        if (!sessionId || previous.current === sessionId) return;
-        const view = previous.current === undefined ? undefined : activeView;
-        previous.current = sessionId;
-        if (!view) return;
-        // Wait for the new conversation's dock store to be adopted.
-        queueMicrotask(() => {
-          if (sidebar.mounted.getSnapshot() !== sessionId) return;
-          const existing = sidebar.openTabs.getSnapshot().find(tab =>
-            tab.sessionId === sessionId && views.get(occurrence(sessionId, tab.tabId)) === view);
-          if (existing) {
-            if (!sidebar.isExpanded()) sidebar.toggleExpanded();
-            sidebar.focus(existing.tabId);
-            return;
-          }
-          sidebar.openResource(view.address, { kind: 'files' });
-          const tab = sidebar.active();
-          if (tab?.kind !== 'files') return;
-          const key = occurrence(sessionId, tab.id);
-          if (!views.has(key)) {
-            views.set(key, view);
-            updateViews();
-          }
-        });
-      }, [sessionId]);
-      return currentViews.map(view => h(View, { key: view.address, view, useSessions }));
+        if (sessionId && sidebar.mounted.getSnapshot() === sessionId) present(sessionId, cwd);
+      }, [sessionId, cwd]);
+      return currentViews.map(view => h(View, { key: view.address, view, cwd }));
     }
 
     scope.effect(() => {
@@ -179,26 +458,17 @@ function apply(ctx) {
         }
       }
       document.addEventListener('wheel', wheel, { passive: false, capture: true });
-      const dispose = sidebar.openTabs.subscribe(() => {
-        const inventory = sidebar.openTabs.getSnapshot();
-        const live = new Set(inventory.map(tab => occurrence(tab.sessionId, tab.tabId)));
-        const addresses = new Set(inventory.map(tab => tab.contentId));
-        for (const address of folderTabs.keys()) {
-          if (!addresses.has(address)) folderTabs.delete(address);
-        }
-        let removed = false;
-        for (const key of views.keys()) {
-          if (live.has(key)) continue;
-          views.delete(key);
-          removed = true;
-        }
-        if (removed) {
-          updateViews();
-          if (!viewList.includes(activeView)) activeView = undefined;
-        }
-      });
+      const disposeFileOpener = installFileOpener();
+      const disposeMotion = installSidebarMotion(sidebar);
+      const disposeTabs = sidebar.openTabs.subscribe(syncTabs);
+      const disposeSwitch = sidebar.mounted.subscribe(closeDepartingTabs);
       return () => {
-        dispose();
+        disposeFileOpener();
+        disposeMotion();
+        disposeTabs();
+        disposeSwitch();
+        detached = false;
+        finishHandoff();
         document.removeEventListener('wheel', wheel, true);
         style.remove();
       };
@@ -212,7 +482,7 @@ function apply(ctx) {
         scope.slots.register(key ? { name, key } : { name, id }, component)));
     }
     scope.effect(() => scope.sidebarRightTabs.register({
-      id, kind: 'files', priority: 'extension', title: () => '文件浏览', keepMounted: true, multiple: true,
+      id, kind: 'files', priority: 'extension', title: () => '文件浏览', multiple: true,
       guide: [{
         id: 'workspace', commandId: 'workspace.files', order: 10, title: () => '文件浏览',
         description: () => '浏览本机磁盘，在下方独立预览文件',

package/src/client/sidebar-motion.js

@@ -0,0 +1,69 @@
+const dockItems = ':is([data-dockkit-host="dock"], [data-dockkit-empty], [data-dockkit-divider])';
+const toggleButtons = 'button:is([data-sidebar-right-expand], [data-sidebar-right-toggle])';
+
+export function installSidebarMotion(sidebar) {
+  let allowed;
+  let collectFrame;
+  const instantFrames = new Map();
+
+  function stopMotion() {
+    cancelAnimationFrame(collectFrame);
+    if (!allowed) return;
+    for (const item of allowed.items) delete item.dataset.dweSidebarToggleMotion;
+    allowed = undefined;
+  }
+
+  function allowButtonMotion(event) {
+    const button = event.target instanceof Element && event.target.closest(toggleButtons);
+    if (!button || button.disabled) return;
+    const sessionId = sidebar.mounted.getSnapshot();
+    const panel = sessionId && document.querySelector(
+      '[data-sidebar-right-panel][data-sidebar-right-session="' + CSS.escape(sessionId) + '"]',
+    );
+    const frame = panel?.closest('[data-rightbar-col]')?.parentElement;
+    if (!frame) return;
+
+    // A tab selected during the slide must not inherit permission to animate.
+    stopMotion();
+    const items = [...panel.querySelectorAll(dockItems + ':not([hidden])')];
+    const motion = { frame, items };
+    allowed = motion;
+    for (const item of items) item.dataset.dweSidebarToggleMotion = '';
+    collectFrame = requestAnimationFrame(() => {
+      const transitions = [...frame.getAnimations(), ...items.flatMap(item => item.getAnimations())]
+        .filter(animation => ['transform', 'grid-template-columns'].includes(animation.transitionProperty));
+      Promise.allSettled(transitions.map(animation => animation.finished)).then(() => {
+        if (allowed === motion) stopMotion();
+      });
+    });
+  }
+
+  // The shell shares one grid transition between the left and right columns.
+  // Snap right-track changes outside the toggle controls so the left controls still animate.
+  const track = new MutationObserver(records => {
+    for (const frame of new Set(records.map(record => record.target))) {
+      if (allowed?.frame === frame || !frame.querySelector(':scope > [data-rightbar-col]')) continue;
+      cancelAnimationFrame(instantFrames.get(frame));
+      frame.dataset.dweSidebarTrackInstant = '';
+      instantFrames.set(frame, requestAnimationFrame(() => {
+        instantFrames.set(frame, requestAnimationFrame(() => {
+          delete frame.dataset.dweSidebarTrackInstant;
+          instantFrames.delete(frame);
+        }));
+      }));
+    }
+  });
+  track.observe(document.documentElement, { subtree: true, attributeFilter: ['data-rightbar-collapsed'] });
+  document.addEventListener('click', allowButtonMotion, true);
+  const disposeSwitch = sidebar.mounted.subscribe(stopMotion);
+  return () => {
+    stopMotion();
+    disposeSwitch();
+    track.disconnect();
+    for (const [frame, request] of instantFrames) {
+      cancelAnimationFrame(request);
+      delete frame.dataset.dweSidebarTrackInstant;
+    }
+    document.removeEventListener('click', allowButtonMotion, true);
+  };
+}

package/src/document-types.js

@@ -1,2 +1,2 @@
-export const officeExtensions = new Set(['doc', 'docx', 'xls', 'xlsx', 'ppt', 'pptx']);
-export const pdfAssetsPath = '/api/dsh.workspaceExplorer/pdf';
+export const officeExtensions = new Set(['doc', 'docx', 'xls', 'xlsx', 'ppt', 'pptx']);
+export const pdfAssetsPath = '/api/dsh.workspaceExplorer/pdf';