dsh-workbuddy-xdpool 1.7.3 → 1.7.4

package/CHANGELOG.md

@@ -4,6 +4,51 @@
 
 版本号遵循 [语义化版本](https://semver.org/lang/zh-CN/)。
 
+## 1.7.4 — 装在中文文件夹里的 WorkBuddy，终于找得到了
+
+> 「腾讯」两个字，让插件整整看不见一个装好、登录着、正在运行的 WorkBuddy。
+
+**你会看到**：插件卡片报「找不到 WorkBuddy 桌面端，无法取得密钥」，可你明明：程序装着、还开着、凭据文件就在那儿躺着。中文 Windows 上，只要**安装路径里带中文**（比如 `D:\ruanjian\anzhuang\腾讯\WorkBuddy\`）就会中招——国内用户把软件装进中文目录太常见了。
+
+**为什么**：插件去注册表里问「WorkBuddy 装哪儿了」，用的是 `reg.exe`，而 `reg.exe` 按**系统控制台代码页**输出——中文系统就是 GBK（936）。我们这边却当成 UTF-8 去读。于是：
+
+```
+实际路径：D:\ruanjian\anzhuang\腾讯\WorkBuddy\WorkBuddy.exe
+读出来：  D:\ruanjian\anzhuang\��Ѷ\WorkBuddy\WorkBuddy.exe   ← 存的什么鬼
+```
+
+`腾讯` 变成 `��Ѷ`，这个路径当然**不存在**。所有候选路径全部落空，插件就得出「没装」的结论。可笑的是它其实**探到了**注册表记录，只是**读成了乱码**。
+
+这个坑和之前那个「装到非系统盘」是两回事——那个是找不到记录，这个是找到了但读不对。
+
+**怎么修的**：
+
+- **改走 PowerShell 读注册表**（主路径）。`Get-ItemProperty` 直接调注册表 API，**根本不过控制台代码页那一关**，中文路径原样拿到；
+- **保留 `reg.exe` 作后备**（万一机器上 PowerShell 不可用），但**不再假定 UTF-8**：按字节读进来，逐个尝试各种编码，并且**用「这个路径是否真的存在」来判定哪个解码是对的**——这是唯一能区分「正确字节」和「看着像那么回事的乱码」的办法。
+
+**顺带修了报告里提到的两点**：
+
+- `DisplayIcon` 和 `InstallLocation` **两个字段都读**（不少安装包的 `InstallLocation` 是空的，只有 `DisplayIcon` 有值），并且清理 `",0` 后缀的逻辑保持不变；
+- `doctor` **现在会把探测到的每一条路径原样列出来**，前面标 `✓`/`·` 表示存不存在。以前它压根不显示这些路径——而这恰恰是排查「装了却找不到」最该看的东西。**乱码路径现在一眼就能看见**，不用再靠猜。
+
+### 验证
+
+- 类型检查全绿，测试 **278 项全绿**（+2）。
+- 新增 `tests/windows-registry-encoding.test.ts`：在本机**真实创建**一个含中文的目录（`D:\...\腾讯\WorkBuddy\WorkBuddy.exe`）并写进真实注册表，然后跑插件的真实探测逻辑，断言**拿到的路径与真实路径完全一致、且文件确实存在**。
+- **反向验证**：把修复撤掉、退回「`reg.exe` + UTF-8」，含中文的路径**读不出来**（0 条），测试变红——确认这个测试真的能抓住这个 bug。
+- 实测 `doctor` 输出：`✓ D:\DSH\_doc_check\腾讯\WorkBuddy\WorkBuddy.exe`，中文完整、存在性正确。
+
+### 给中招的人（在你升级之前，或者万一还有别的编码）
+
+临时指路，设完**完全退出 DSH 再启动**：
+
+```powershell
+[Environment]::SetEnvironmentVariable("WORKBUDDY_APP_EXECUTABLE",
+  "D:\ruanjian\anzhuang\腾讯\WorkBuddy\WorkBuddy.exe", "User")
+```
+
+写进 `$DSH_HOME/.env` 也一样有效（不用注销，更省事）。
+
 ## 1.7.3 — 模型不会因为一次网络抖动就消失
 
 > 开机那一秒网络还没起来，插件就把模型列表「降级」了，然后一整天都不再试第二次。

package/lib/bin.js

@@ -1,9 +1,9 @@
 import { createDecipheriv, createHash, randomUUID } from "node:crypto";
+import { existsSync, readFileSync, readdirSync } from "node:fs";
 import { copyFile, mkdir, readFile, readdir, rename, writeFile, writeFile as writeFile$1 } from "node:fs/promises";
 import { homedir, platform } from "node:os";
 import { basename, dirname, join, resolve } from "node:path";
 import { execFile, execFileSync } from "node:child_process";
-import { existsSync, readFileSync, readdirSync } from "node:fs";
 import z from "@deepseek-ai/schemastery";
 import "@earendil-works/pi-ai";
 import "@earendil-works/pi-ai/api/openai-completions.lazy";
@@ -1890,42 +1890,155 @@ function macosBundleExecutable(bundle) {
 	return join(bundle, "Contents", "MacOS", name);
 }
 /**
+* Encodings a Windows console child process may emit in, most likely first.
+*
+* `reg.exe` writes with the ACTIVE CODE PAGE, never UTF-8: a Chinese Windows
+* (code page 936) returns a path containing 「腾讯」 as GBK bytes. Decoding
+* those as UTF-8 mangles them into `��Ѷ`, every `existsSync` then fails, and the
+* plugin concludes no desktop app is installed while one is running fine.
+*
+* The list is ordered and each entry is TRIED rather than guessed: the first
+* decoding that yields usable text wins, and the decision is validated against
+* the filesystem rather than by sniffing bytes.
+*/
+const WINDOWS_CONSOLE_ENCODINGS = [
+	"utf-8",
+	"gbk",
+	"big5",
+	"shift_jis",
+	"euc-kr",
+	"windows-1252"
+];
+/**
+* Decode bytes from a Windows console child process.
+*
+* `accept` decides whether a decoding is usable — the callers pass "this text
+* contains a path that actually exists". Bytes that are already UTF-8 pass on
+* the first attempt, so the healthy case pays nothing.
+*/
+function decodeWindowsConsole(buf, accept) {
+	for (const label of WINDOWS_CONSOLE_ENCODINGS) {
+		let text;
+		try {
+			text = new TextDecoder(label, { fatal: false }).decode(buf);
+		} catch {
+			continue;
+		}
+		if (accept(text)) return text;
+	}
+	return new TextDecoder("utf-8", { fatal: false }).decode(buf);
+}
+/** Strip the `"<path>",<index>` decoration DisplayIcon carries. */
+function cleanIconPath(raw) {
+	return raw.replace(/^"/u, "").replace(/",-?\d+$/u, "").replace(/,-?\d+$/u, "").trim();
+}
+/** Registry locations the installer records its own product under. */
+const UNINSTALL_KEY_ROOTS = [
+	"HKLM\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall",
+	"HKLM\\SOFTWARE\\WOW6432Node\\Microsoft\\Windows\\CurrentVersion\\Uninstall",
+	"HKCU\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall"
+];
+/**
 * Windows install locations recorded by the app's own uninstaller.
 *
 * The registry is the authoritative answer: it survives a non-default drive, a
 * renamed folder and a differently-named executable, none of which any fixed
 * path list can predict. Real machines put the app at `D:\workbuddy\WorkBuddy.exe`
-* and `D:\workbuddyai\WorkBuddyAI.exe` — exactly the layouts a
-* `%ProgramFiles%\WorkBuddy\WorkBuddy.exe` probe cannot see, which is why the
-* plugin reported "the desktop app could not provide the key" for an app that was
-* installed and running.
+* and `D:\ruanjian\anzhuang\腾讯\WorkBuddy\WorkBuddy.exe` — layouts a
+* `%ProgramFiles%\WorkBuddy\WorkBuddy.exe` probe cannot see.
 *
 * `DisplayIcon` is the field that actually carries the path (observed as
 * `D:\workbuddy\WorkBuddy.exe,0`); `InstallLocation` is usually empty for these
 * installers, so both are read and either may contribute.
 *
+* Two readers, because neither alone is enough:
+*
+*  - **PowerShell first.** `Get-ItemProperty` talks to the registry API, so no
+*    console code page is involved and non-ASCII paths come back intact. This
+*    is the encoding-proof path.
+*  - **`reg.exe` as a fallback**, for a machine where PowerShell is unavailable
+*    (locked-down or stripped images). Its raw bytes are decoded through
+*    {@link decodeWindowsConsole}, which is what the original code got wrong.
+*
 * Returns [] on any failure — a missing registry key is the normal case on
 * non-Windows, not an error.
 */
 function windowsRegistryAppPaths() {
 	if (process.platform !== "win32") return [];
-	const roots = [
-		["HKLM\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall", "/**"],
-		["HKLM\\SOFTWARE\\WOW6432Node\\Microsoft\\Windows\\CurrentVersion\\Uninstall", "/**"],
-		["HKCU\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall", "/**"]
-	];
+	const viaPowerShell = windowsRegistryAppPathsViaPowerShell();
+	if (viaPowerShell.length > 0) return viaPowerShell;
+	return windowsRegistryAppPathsViaReg();
+}
+/**
+* Registry read through PowerShell, immune to the console code page.
+*
+* `[Console]::OutputEncoding` is set to UTF-8 so the bytes Node receives are
+* UTF-8 regardless of the machine's code page. Values are printed one per line
+* and matched by the caller, so a Chinese path survives the round trip.
+*
+* Best-effort: any failure (no PowerShell, no keys, a policy restriction)
+* returns [], and the `reg.exe` reader takes over.
+*/
+function windowsRegistryAppPathsViaPowerShell() {
+	const script = [
+		"$ErrorActionPreference='SilentlyContinue'",
+		"try { [Console]::OutputEncoding=[System.Text.Encoding]::UTF8 } catch {}",
+		"$roots=@('HKLM:\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\*','HKLM:\\SOFTWARE\\WOW6432Node\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\*','HKCU:\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\*')",
+		"foreach($r in $roots){",
+		"  Get-ItemProperty -Path $r | ForEach-Object {",
+		"    $dn=[string]$_.DisplayName; $di=[string]$_.DisplayIcon; $il=[string]$_.InstallLocation",
+		"    if($dn -match 'WorkBuddy|CodeBuddy' -or $di -match 'WorkBuddy|CodeBuddy'){",
+		"      if($di -ne ''){ Write-Output $di }",
+		"      if($il -ne ''){ Write-Output $il }",
+		"    }",
+		"  }",
+		"}"
+	].join("\n");
+	let stdout;
+	try {
+		stdout = execFileSync("powershell", [
+			"-NoProfile",
+			"-NonInteractive",
+			"-ExecutionPolicy",
+			"Bypass",
+			"-Command",
+			script
+		], {
+			encoding: "utf8",
+			timeout: 2e4,
+			windowsHide: true,
+			maxBuffer: 8388608
+		});
+	} catch {
+		return [];
+	}
 	const out = [];
-	for (const [root] of roots) {
-		let listing;
+	for (const line of stdout.split(/\r?\n/u)) {
+		const cleaned = cleanIconPath(line.trim());
+		if (cleaned !== "") out.push(cleaned);
+	}
+	return out;
+}
+/**
+* Registry read through `reg.exe`, with console-code-page detection.
+*
+* Kept as the fallback for machines without PowerShell. The decode step is the
+* fix: the output is captured as BYTES and decoded with whichever encoding
+* yields a path that exists, instead of assuming UTF-8 and quietly producing
+* mojibake that no existence check can ever match.
+*/
+function windowsRegistryAppPathsViaReg() {
+	const out = [];
+	for (const root of UNINSTALL_KEY_ROOTS) {
+		let listingBuf;
 		try {
-			listing = execFileSync("reg", [
+			listingBuf = execFileSync("reg", [
 				"query",
 				root,
 				"/s",
 				"/v",
 				"DisplayName"
 			], {
-				encoding: "utf8",
 				timeout: 1e4,
 				windowsHide: true,
 				maxBuffer: 8388608
@@ -1933,26 +2046,35 @@ function windowsRegistryAppPaths() {
 		} catch {
 			continue;
 		}
-		const keys = listing.split(/\r?\n(?=HKEY_)/u).filter((block) => /WorkBuddy|CodeBuddy/iu.test(block));
+		const keys = decodeWindowsConsole(listingBuf, (text) => /WorkBuddy|CodeBuddy/iu.test(text)).split(/\r?\n(?=HKEY_)/u).filter((block) => /WorkBuddy|CodeBuddy/iu.test(block));
 		for (const key of keys) {
 			const keyPath = /^(HKEY_[^\r\n]+)/u.exec(key)?.[1]?.trim();
 			if (keyPath === void 0) continue;
-			for (const name of ["DisplayIcon", "InstallLocation"]) try {
-				const value = execFileSync("reg", [
-					"query",
-					keyPath,
-					"/v",
-					name
-				], {
-					encoding: "utf8",
-					timeout: 5e3,
-					windowsHide: true
+			for (const name of ["DisplayIcon", "InstallLocation"]) {
+				let valueBuf;
+				try {
+					valueBuf = execFileSync("reg", [
+						"query",
+						keyPath,
+						"/v",
+						name
+					], {
+						timeout: 5e3,
+						windowsHide: true
+					});
+				} catch {
+					continue;
+				}
+				const value = decodeWindowsConsole(valueBuf, (text) => {
+					const candidate = /REG_(?:SZ|EXPAND_SZ)\s+(.+)$/mu.exec(text)?.[1]?.trim();
+					if (candidate === void 0) return false;
+					const path = cleanIconPath(candidate);
+					return path !== "" && existsSync(path);
 				});
 				const raw = /REG_(?:SZ|EXPAND_SZ)\s+(.+)$/mu.exec(value)?.[1]?.trim();
 				if (raw === void 0 || raw === "") continue;
-				const cleaned = raw.replace(/^"/u, "").replace(/",-?\d+$/u, "").replace(/,-?\d+$/u, "").trim();
-				out.push(cleaned);
-			} catch {}
+				out.push(cleanIconPath(raw));
+			}
 		}
 	}
 	return out;
@@ -2221,7 +2343,7 @@ const ENCRYPTED_CREDENTIAL_CODE = "ENCRYPTED_CREDENTIAL";
 var WorkBuddyEncryptedCredentialError = class extends Error {
 	code = ENCRYPTED_CREDENTIAL_CODE;
 	constructor(sourcePath) {
-		super(`workbuddy: ${sourcePath} holds encrypted credentials, but no WorkBuddy desktop app could be located to provide the key. If the app IS installed, it is simply outside the paths this plugin probes — set WORKBUDDY_APP_EXECUTABLE to its full .exe path (then restart DSH) and the credential will open. Signing in again will not help: the credential itself is intact. Run \`dsh-workbuddy-xdpool doctor\` to see which paths were probed.`);
+		super(`workbuddy: ${sourcePath} holds encrypted credentials, but no WorkBuddy desktop app could be located to provide the key. If the app IS installed, it is simply outside the paths this plugin probes — set WORKBUDDY_APP_EXECUTABLE to its full .exe path (then restart DSH) and the credential will open. Signing in again will not help: the credential itself is intact. Run \`dsh-workbuddy-xdpool doctor\` to see which paths were probed — if one of them looks like mojibake (e.g. "??" where a Chinese folder name should be), the registry value could not be decoded on this machine; report that line and use the override above in the meantime.`);
 		this.name = "WorkBuddyEncryptedCredentialError";
 	}
 };
@@ -5111,6 +5233,31 @@ async function commandDoctor() {
 		imported = (await readdir2(accountDir())).filter((name) => name.endsWith(".json"));
 	} catch {}
 	lines.push(imported.length === 0 ? "  (none)" : imported.map((name) => `  ✓ ${name}`).join("\n"));
+	lines.push("");
+	lines.push("WorkBuddy desktop app:");
+	const override = process.env[WORKBUDDY_APP_EXECUTABLE_ENV]?.trim();
+	if (override !== void 0 && override !== "") lines.push(`  env ${WORKBUDDY_APP_EXECUTABLE_ENV} = ${override}`);
+	let candidates = [];
+	try {
+		candidates = workbuddyAppExecutableCandidates();
+	} catch (error) {
+		lines.push(`  ✗ candidate probe threw: ${error instanceof Error ? error.message : String(error)}`);
+	}
+	let firstExisting;
+	for (const candidate of candidates) {
+		const exists = existsSync(candidate);
+		if (exists && firstExisting === void 0) firstExisting = candidate;
+		lines.push(`  ${exists ? "✓" : "·"} ${candidate}`);
+	}
+	lines.push(`  probed ${candidates.length} candidate path(s)`);
+	if (firstExisting === void 0) {
+		healthy = false;
+		lines.push("  ✗ no WorkBuddy desktop executable found at any probed path.");
+		lines.push("    If the app IS installed, set WORKBUDDY_APP_EXECUTABLE to its full .exe path");
+		lines.push("    (or put that line in $DSH_HOME/.env) and restart DSH. A path shown above that");
+		lines.push("    looks like mojibake (e.g. \"???\" for a Chinese folder) indicates the registry");
+		lines.push("    value could not be decoded on this machine — please report it with the line.");
+	} else lines.push(`  ✓ using ${firstExisting}`);
 	console.log(lines.join("\n"));
 	return healthy ? 0 : 1;
 }

package/lib/index.js

@@ -1997,42 +1997,155 @@ function macosBundleExecutable(bundle) {
 	return join(bundle, "Contents", "MacOS", name);
 }
 /**
+* Encodings a Windows console child process may emit in, most likely first.
+*
+* `reg.exe` writes with the ACTIVE CODE PAGE, never UTF-8: a Chinese Windows
+* (code page 936) returns a path containing 「腾讯」 as GBK bytes. Decoding
+* those as UTF-8 mangles them into `��Ѷ`, every `existsSync` then fails, and the
+* plugin concludes no desktop app is installed while one is running fine.
+*
+* The list is ordered and each entry is TRIED rather than guessed: the first
+* decoding that yields usable text wins, and the decision is validated against
+* the filesystem rather than by sniffing bytes.
+*/
+const WINDOWS_CONSOLE_ENCODINGS = [
+	"utf-8",
+	"gbk",
+	"big5",
+	"shift_jis",
+	"euc-kr",
+	"windows-1252"
+];
+/**
+* Decode bytes from a Windows console child process.
+*
+* `accept` decides whether a decoding is usable — the callers pass "this text
+* contains a path that actually exists". Bytes that are already UTF-8 pass on
+* the first attempt, so the healthy case pays nothing.
+*/
+function decodeWindowsConsole(buf, accept) {
+	for (const label of WINDOWS_CONSOLE_ENCODINGS) {
+		let text;
+		try {
+			text = new TextDecoder(label, { fatal: false }).decode(buf);
+		} catch {
+			continue;
+		}
+		if (accept(text)) return text;
+	}
+	return new TextDecoder("utf-8", { fatal: false }).decode(buf);
+}
+/** Strip the `"<path>",<index>` decoration DisplayIcon carries. */
+function cleanIconPath(raw) {
+	return raw.replace(/^"/u, "").replace(/",-?\d+$/u, "").replace(/,-?\d+$/u, "").trim();
+}
+/** Registry locations the installer records its own product under. */
+const UNINSTALL_KEY_ROOTS = [
+	"HKLM\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall",
+	"HKLM\\SOFTWARE\\WOW6432Node\\Microsoft\\Windows\\CurrentVersion\\Uninstall",
+	"HKCU\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall"
+];
+/**
 * Windows install locations recorded by the app's own uninstaller.
 *
 * The registry is the authoritative answer: it survives a non-default drive, a
 * renamed folder and a differently-named executable, none of which any fixed
 * path list can predict. Real machines put the app at `D:\workbuddy\WorkBuddy.exe`
-* and `D:\workbuddyai\WorkBuddyAI.exe` — exactly the layouts a
-* `%ProgramFiles%\WorkBuddy\WorkBuddy.exe` probe cannot see, which is why the
-* plugin reported "the desktop app could not provide the key" for an app that was
-* installed and running.
+* and `D:\ruanjian\anzhuang\腾讯\WorkBuddy\WorkBuddy.exe` — layouts a
+* `%ProgramFiles%\WorkBuddy\WorkBuddy.exe` probe cannot see.
 *
 * `DisplayIcon` is the field that actually carries the path (observed as
 * `D:\workbuddy\WorkBuddy.exe,0`); `InstallLocation` is usually empty for these
 * installers, so both are read and either may contribute.
 *
+* Two readers, because neither alone is enough:
+*
+*  - **PowerShell first.** `Get-ItemProperty` talks to the registry API, so no
+*    console code page is involved and non-ASCII paths come back intact. This
+*    is the encoding-proof path.
+*  - **`reg.exe` as a fallback**, for a machine where PowerShell is unavailable
+*    (locked-down or stripped images). Its raw bytes are decoded through
+*    {@link decodeWindowsConsole}, which is what the original code got wrong.
+*
 * Returns [] on any failure — a missing registry key is the normal case on
 * non-Windows, not an error.
 */
 function windowsRegistryAppPaths() {
 	if (process.platform !== "win32") return [];
-	const roots = [
-		["HKLM\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall", "/**"],
-		["HKLM\\SOFTWARE\\WOW6432Node\\Microsoft\\Windows\\CurrentVersion\\Uninstall", "/**"],
-		["HKCU\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall", "/**"]
-	];
+	const viaPowerShell = windowsRegistryAppPathsViaPowerShell();
+	if (viaPowerShell.length > 0) return viaPowerShell;
+	return windowsRegistryAppPathsViaReg();
+}
+/**
+* Registry read through PowerShell, immune to the console code page.
+*
+* `[Console]::OutputEncoding` is set to UTF-8 so the bytes Node receives are
+* UTF-8 regardless of the machine's code page. Values are printed one per line
+* and matched by the caller, so a Chinese path survives the round trip.
+*
+* Best-effort: any failure (no PowerShell, no keys, a policy restriction)
+* returns [], and the `reg.exe` reader takes over.
+*/
+function windowsRegistryAppPathsViaPowerShell() {
+	const script = [
+		"$ErrorActionPreference='SilentlyContinue'",
+		"try { [Console]::OutputEncoding=[System.Text.Encoding]::UTF8 } catch {}",
+		"$roots=@('HKLM:\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\*','HKLM:\\SOFTWARE\\WOW6432Node\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\*','HKCU:\\SOFTWARE\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\*')",
+		"foreach($r in $roots){",
+		"  Get-ItemProperty -Path $r | ForEach-Object {",
+		"    $dn=[string]$_.DisplayName; $di=[string]$_.DisplayIcon; $il=[string]$_.InstallLocation",
+		"    if($dn -match 'WorkBuddy|CodeBuddy' -or $di -match 'WorkBuddy|CodeBuddy'){",
+		"      if($di -ne ''){ Write-Output $di }",
+		"      if($il -ne ''){ Write-Output $il }",
+		"    }",
+		"  }",
+		"}"
+	].join("\n");
+	let stdout;
+	try {
+		stdout = execFileSync("powershell", [
+			"-NoProfile",
+			"-NonInteractive",
+			"-ExecutionPolicy",
+			"Bypass",
+			"-Command",
+			script
+		], {
+			encoding: "utf8",
+			timeout: 2e4,
+			windowsHide: true,
+			maxBuffer: 8388608
+		});
+	} catch {
+		return [];
+	}
 	const out = [];
-	for (const [root] of roots) {
-		let listing;
+	for (const line of stdout.split(/\r?\n/u)) {
+		const cleaned = cleanIconPath(line.trim());
+		if (cleaned !== "") out.push(cleaned);
+	}
+	return out;
+}
+/**
+* Registry read through `reg.exe`, with console-code-page detection.
+*
+* Kept as the fallback for machines without PowerShell. The decode step is the
+* fix: the output is captured as BYTES and decoded with whichever encoding
+* yields a path that exists, instead of assuming UTF-8 and quietly producing
+* mojibake that no existence check can ever match.
+*/
+function windowsRegistryAppPathsViaReg() {
+	const out = [];
+	for (const root of UNINSTALL_KEY_ROOTS) {
+		let listingBuf;
 		try {
-			listing = execFileSync("reg", [
+			listingBuf = execFileSync("reg", [
 				"query",
 				root,
 				"/s",
 				"/v",
 				"DisplayName"
 			], {
-				encoding: "utf8",
 				timeout: 1e4,
 				windowsHide: true,
 				maxBuffer: 8388608
@@ -2040,26 +2153,35 @@ function windowsRegistryAppPaths() {
 		} catch {
 			continue;
 		}
-		const keys = listing.split(/\r?\n(?=HKEY_)/u).filter((block) => /WorkBuddy|CodeBuddy/iu.test(block));
+		const keys = decodeWindowsConsole(listingBuf, (text) => /WorkBuddy|CodeBuddy/iu.test(text)).split(/\r?\n(?=HKEY_)/u).filter((block) => /WorkBuddy|CodeBuddy/iu.test(block));
 		for (const key of keys) {
 			const keyPath = /^(HKEY_[^\r\n]+)/u.exec(key)?.[1]?.trim();
 			if (keyPath === void 0) continue;
-			for (const name of ["DisplayIcon", "InstallLocation"]) try {
-				const value = execFileSync("reg", [
-					"query",
-					keyPath,
-					"/v",
-					name
-				], {
-					encoding: "utf8",
-					timeout: 5e3,
-					windowsHide: true
+			for (const name of ["DisplayIcon", "InstallLocation"]) {
+				let valueBuf;
+				try {
+					valueBuf = execFileSync("reg", [
+						"query",
+						keyPath,
+						"/v",
+						name
+					], {
+						timeout: 5e3,
+						windowsHide: true
+					});
+				} catch {
+					continue;
+				}
+				const value = decodeWindowsConsole(valueBuf, (text) => {
+					const candidate = /REG_(?:SZ|EXPAND_SZ)\s+(.+)$/mu.exec(text)?.[1]?.trim();
+					if (candidate === void 0) return false;
+					const path = cleanIconPath(candidate);
+					return path !== "" && existsSync(path);
 				});
 				const raw = /REG_(?:SZ|EXPAND_SZ)\s+(.+)$/mu.exec(value)?.[1]?.trim();
 				if (raw === void 0 || raw === "") continue;
-				const cleaned = raw.replace(/^"/u, "").replace(/",-?\d+$/u, "").replace(/,-?\d+$/u, "").trim();
-				out.push(cleaned);
-			} catch {}
+				out.push(cleanIconPath(raw));
+			}
 		}
 	}
 	return out;
@@ -2328,7 +2450,7 @@ const ENCRYPTED_CREDENTIAL_CODE = "ENCRYPTED_CREDENTIAL";
 var WorkBuddyEncryptedCredentialError = class extends Error {
 	code = ENCRYPTED_CREDENTIAL_CODE;
 	constructor(sourcePath) {
-		super(`workbuddy: ${sourcePath} holds encrypted credentials, but no WorkBuddy desktop app could be located to provide the key. If the app IS installed, it is simply outside the paths this plugin probes — set WORKBUDDY_APP_EXECUTABLE to its full .exe path (then restart DSH) and the credential will open. Signing in again will not help: the credential itself is intact. Run \`dsh-workbuddy-xdpool doctor\` to see which paths were probed.`);
+		super(`workbuddy: ${sourcePath} holds encrypted credentials, but no WorkBuddy desktop app could be located to provide the key. If the app IS installed, it is simply outside the paths this plugin probes — set WORKBUDDY_APP_EXECUTABLE to its full .exe path (then restart DSH) and the credential will open. Signing in again will not help: the credential itself is intact. Run \`dsh-workbuddy-xdpool doctor\` to see which paths were probed — if one of them looks like mojibake (e.g. "??" where a Chinese folder name should be), the registry value could not be decoded on this machine; report that line and use the override above in the meantime.`);
 		this.name = "WorkBuddyEncryptedCredentialError";
 	}
 };

package/package.json

@@ -2,7 +2,7 @@
   "name": "dsh-workbuddy-xdpool",
   "displayName": "DSH WorkBuddy XD Pool",
   "description": "Merge every locally signed-in WorkBuddy account into DeepSeek Harness as one auto-failing-over model pool (multi-account rotation, live credits, daily check-in and model catalog).",
-  "version": "1.7.3",
+  "version": "1.7.4",
   "license": "MIT",
   "author": "XDTrees",
   "homepage": "https://github.com/XDTrees/dsh-workbuddy-xdpool#readme",