dsh-unlag 1.9.99 → 1.9.101

package/index.js

@@ -830,12 +830,19 @@ function buttonAllowed(req) {
       return false
     }
     const origin = typeof req?.headers?.origin === 'string' ? req.headers.origin.trim().toLowerCase() : ''
-    if (origin === 'null') return false
+    // An opaque origin belongs to a document this machine did not open, and an origin that cannot
+    // be read is one this check cannot judge. Both are refused, and both say so: a refusal nobody
+    // can find afterwards is the kind of silence that makes a wrong answer look like a right one.
+    if (origin === 'null') {
+      log('refused a press from an opaque origin')
+      return false
+    }
     if (origin !== '') {
       let originSite = ''
       try {
         originSite = new URL(origin).host.toLowerCase() // ui-copy-ignore
       } catch {
+        log(`refused a press from an origin that is not an address: ${oneLine(origin, 200)}`)
         return false
       }
       if (originSite !== site) {
@@ -1936,8 +1943,10 @@ function serveButton(ctx, controller, config) {
            * A page on any site can post to a local address without asking first, and a log is
            * evidence: a made-up outcome must not get in. The header the page's own script sends
            * makes the request one a browser has to ask about first, and this app never agrees.
+           * The same address check the press uses applies here too: the log is the record a press
+           * leaves behind, so a page that may not press may not write into it either.
            */
-          if (typeof req?.headers?.[BUTTON_HEADER] !== 'string') return sendJson(res, 403, { status: 'forbidden' })
+          if (buttonAllowed(req) === false) return sendJson(res, 403, { status: 'forbidden' })
           let query = ''
           try {
             query = new URL(String(req?.url ?? ''), 'http://x').searchParams.toString()
@@ -2042,14 +2051,23 @@ export function apply(ctx, config) {
      * root is installed and no saved file applies anything by itself.
      */
     const syncWatching = () => {
-      if (settingsOf(config ?? {}).autoReload !== true) return
-      if (controller.available() === false) {
+      // Automatic reloading is an extra, and the press is the feature: anything that goes wrong
+      // while setting a watch up is said in one line and left off, never turned into a plugin that
+      // did not load.
+      try {
+        if (settingsOf(config ?? {}).autoReload !== true) return
+        if (controller.available() === false) {
+          closeAll(globalThis[WATCHER_KEY])
+          globalThis[WATCHER_KEY] = null
+          return
+        }
+        if (globalThis[WATCHER_KEY] !== null) return
+        globalThis[WATCHER_KEY] = controller.startWatching()
+      } catch (error) {
         closeAll(globalThis[WATCHER_KEY])
         globalThis[WATCHER_KEY] = null
-        return
+        log(`cannot watch for saved plugin changes: ${error?.message ?? error}; a press still works`)
       }
-      if (globalThis[WATCHER_KEY] !== null) return
-      globalThis[WATCHER_KEY] = controller.startWatching()
     }
     // Printed on every start so a reader of the log knows which action applies a change: a person
     // pressing the button, never this plugin, and never a restart of the app.
@@ -2064,8 +2082,14 @@ export function apply(ctx, config) {
     }
     if (typeof ctx.on === 'function') {
       ctx.on('internal/service', (service) => {
-        if (service === 'hmr') syncWatching()
-        if (service === 'clientModules') syncBundles()
+        // A service event is dispatched by the app itself; an exception here would travel back into
+        // whatever asked, so each answer is kept to its own line.
+        try {
+          if (service === 'hmr') syncWatching()
+          if (service === 'clientModules') syncBundles()
+        } catch (error) {
+          log(`cannot follow the ${oneLine(service, 40)} service: ${error?.message ?? error}`)
+        }
       })
     }
     globalThis[ROUTES_KEY] = serveButton(ctx, controller, config ?? {})

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dsh-unlag",
-  "version": "1.9.99",
+  "version": "1.9.101",
   "type": "module",
   "description": "A press applies plugin edits right away and brings a laggy interface back; automatic reloading stays off unless you turn it on, so the press is the only trigger, and nothing restarts.",
   "license": "MIT",