dsh-unlag 1.9.56 → 1.9.58

package/index.js

@@ -64,7 +64,6 @@ const CODE_STAMP = (() => {
     return 'unknown'
   }
 })()
-let logWrites = 0
 /** Tests point this at a scratch file, so a test run leaves the live log readable. */
 const logTarget = () => process.env.DSH_UNLAG_LOG ?? LOG_PATH
 /** Survives a module replacement, so a reload cannot leave a second watcher behind. */
@@ -200,15 +199,34 @@ export const Config = {
   },
 }
 
+/** Switches already reported, so a settings form read repeatedly writes one line, not many. */
+const STRANGE_SWITCHES = new Set()
+/**
+ * One switch. Absent means the default; a boolean means itself; anything else — a hand-edited
+ * string, a number, a list — is not a yes and is read as off, with one line saying so. A row that
+ * says "off" must not swap plugin code because the value happened to be the word "no".
+ */
+function booleanSwitch(config, key, fallback) {
+  const value = config?.[key]
+  if (value === undefined || value === null) return fallback
+  if (typeof value === 'boolean') return value
+  const seen = `${key}=${oneLine(value, 40)}`
+  if (!STRANGE_SWITCHES.has(seen) && STRANGE_SWITCHES.size < 32) {
+    STRANGE_SWITCHES.add(seen)
+    log(`a switch that is not a boolean was read as off: ${seen}`)
+  }
+  return false
+}
+
 /**
  * The three switches from any config shape. The press switches default on; automatic reloading
  * defaults off, and the undocumented `plugins: 'off'` from older configs keeps meaning off.
  */
 function settingsOf(config) {
   return {
-    reloadPlugins: config?.reloadPlugins !== false,
-    reloadInterface: config?.reloadInterface !== false,
-    autoReload: config?.plugins === 'off' ? false : config?.autoReload === true,
+    reloadPlugins: booleanSwitch(config, 'reloadPlugins', true),
+    reloadInterface: booleanSwitch(config, 'reloadInterface', true),
+    autoReload: config?.plugins === 'off' ? false : booleanSwitch(config, 'autoReload', false),
   }
 }
 
@@ -242,17 +260,17 @@ function ensureLogDir(target) {
 function log(line) {
   try {
     const target = logTarget()
-    // A file that only grows eventually costs the app its own memory budget: every 200 lines the
-    // size is checked once, and a log past the cap starts over instead of growing without end.
-    logWrites += 1
-    if (logWrites % 200 === 1) {
-      try {
-        if (statSync(target).size > LOG_MAX_BYTES) writeFileSync(target, '')
-      } catch {
-        /* a missing or unreadable log is created by the append below */
-      }
-    }
     const text = `${new Date().toISOString()} ${oneLine(line)}\n`
+    /**
+     * A file that only grows eventually costs the app its own memory budget, and a burst of lines
+     * can land between two periodic checks: the size is read before every write and the whole
+     * line has to fit, so the file never passes the cap even for one event.
+     */
+    try {
+      if (statSync(target).size + Buffer.byteLength(text) > LOG_MAX_BYTES) writeFileSync(target, '')
+    } catch {
+      /* a missing or unreadable log is created by the append below */
+    }
     try {
       appendFileSync(target, text)
     } catch {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dsh-unlag",
-  "version": "1.9.56",
+  "version": "1.9.58",
   "type": "module",
   "description": "A press applies plugin edits right away and brings a laggy interface back; automatic reloading stays off unless you turn it on, so the press is the only trigger, and nothing restarts.",
   "license": "MIT",