dsh-unlag 1.9.47 → 1.9.49

package/index.js

@@ -1672,9 +1672,13 @@ function serveButton(ctx, controller, config) {
   const handlers = [
     [
       `${BASE_PATH}/state`,
-      (_req, res) => {
+      (req, res) => {
         // A disposed context answers with a status instead of a throw the server has to guess at.
         try {
+          // These two are reads. Any other method is told so, the way the app's own bundle route
+          // answers a method it does not serve.
+          const method = String(req?.method ?? 'GET').toUpperCase()
+          if (method !== 'GET' && method !== 'HEAD') return sendJson(res, 405, { status: 'method' })
           sendJson(res, 200, { version: VERSION, code: CODE_STAMP, plugins: settings.reloadPlugins, page: settings.reloadInterface, shim: bundleShimStatus(ctx) })
         } catch (error) {
           log(`cannot describe this copy of the plugin: ${error?.message ?? error}`)
@@ -1684,10 +1688,12 @@ function serveButton(ctx, controller, config) {
     ],
     [
       `${BASE_PATH}/graph`,
-      (_req, res) => {
+      (req, res) => {
         // The page reads this before a rebuild; an answer that throws would leave the press with
         // no verdict at all, so the whole body is bounded and answers either way.
         try {
+          const method = String(req?.method ?? 'GET').toUpperCase()
+          if (method !== 'GET' && method !== 'HEAD') return sendJson(res, 405, { status: 'method' })
           ensureBundleShim(ctx)
           sendJson(res, 200, { graph: liveBootGraph(ctx) })
         } catch (error) {
@@ -1785,8 +1791,14 @@ function serveButton(ctx, controller, config) {
           if (!settings.reloadPlugins) return sendJson(res, 200, { status: 'off' })
           const limit = Number(process.env.DSH_UNLAG_ANSWER_MS ?? '') || RELOAD_ANSWER_MS
           let timer = null
+          let timedOut = false
           const stillApplying = new Promise((resolve) => {
-            timer = setTimeout(() => resolve({ status: 'applying', warnings: [], pending: [], restartReason: null, failedEntries: [] }), limit)
+            timer = setTimeout(() => {
+              // Only the timer's own answer means the update outlasted the page: an update that
+              // says "applying" itself is a press that arrived during another one, not a slow one.
+              timedOut = true
+              resolve({ status: 'applying', warnings: [], pending: [], restartReason: null, failedEntries: [] })
+            }, limit)
           })
           let answeredEarly = false
           try {
@@ -1807,7 +1819,8 @@ function serveButton(ctx, controller, config) {
             const outcome = await Promise.race([work, stillApplying])
             if (outcome?.status === 'applying') {
               answeredEarly = true
-              log('the update outlasted the answer the page waits for: the press is told it is still applying')
+              if (timedOut) log('the update outlasted the answer the page waits for: the press is told it is still applying')
+              else log('a press arrived while an update is already applying: the press is told it is still applying')
             }
             sendJson(res, 200, outcome)
           } finally {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dsh-unlag",
-  "version": "1.9.47",
+  "version": "1.9.49",
   "type": "module",
   "description": "A press applies plugin edits right away and brings a laggy interface back; automatic reloading stays off unless you turn it on, so the press is the only trigger, and nothing restarts.",
   "license": "MIT",