dsh-tower 2.4.2 → 2.6.0

package/scripts/surface-baseline.mjs

@@ -8,8 +8,9 @@
 //   tools         every tool the Host entry registers, including the
 //                 tower_mode/tower_control pair that index.js registers
 //                 directly rather than through define() (#118)
-//   components    user-visible rows in cordis.patch.yml (#120), so the 2.3.0
-//                 4 -> 1 contraction and any future move need a written decision
+//   components    user-visible rows in every shipped cordis.patch.yml (#120,
+//                 #134), so the 2.3.0 4 -> 1 contraction and any future move
+//                 need a written decision
 //
 // `scripts/surface-baseline.json` freezes those counts. A PR that grows a count
 // fails here until the baseline carries a decision with either an ADR under
@@ -24,7 +25,7 @@ import fs from 'node:fs'
 import path from 'node:path'
 import { fileURLToPath } from 'node:url'
 import { configSurface } from '../domain/config/schema.js'
-import { parseCordisPatch } from '../domain/components.js'
+import { COMPONENT_PATCH_FILES, mergeCordisPatches, parseCordisPatch } from '../domain/components.js'
 import { SURFACE_CLASSIFICATION_FILE, SURFACE_BASELINE_FILE, surfaceLine } from '../domain/surface.js'
 import { loadShippedToolSurface } from './lib/tool-surface.mjs'
 import { checkSurfaceBudget } from './lib/surface.mjs'
@@ -42,7 +43,8 @@ with a decision that names an existing docs/adr/ ADR, deletions that are no
 longer in the live surface, or a measurement-correction record with a reason and
 date. The classification table in
 ${SURFACE_CLASSIFICATION_FILE} must cover every key and tool exactly once, and
-the component count comes from the visible rows in cordis.patch.yml.`
+the component count comes from the visible rows in every shipped
+cordis.patch.yml.`
 
 /**
  * The live tool names: apply the shipped Host entry so every registration path
@@ -65,7 +67,15 @@ function liveToolNames() {
 export function liveSurface(root = PACKAGE_ROOT) {
   const config = configSurface()
   const tools = liveToolNames()
-  const patch = parseCordisPatch(fs.readFileSync(path.join(root, 'cordis.patch.yml'), 'utf8'))
+  // #134: the counted component surface is every shipped patch, not only the
+  // root one; `ui-bundle/cordis.patch.yml` ships the tower-ui row.
+  const patches = {}
+  for (const file of COMPONENT_PATCH_FILES) {
+    const patchFile = path.join(root, file)
+    if (!fs.existsSync(patchFile)) continue
+    patches[file] = parseCordisPatch(fs.readFileSync(patchFile, 'utf8'))
+  }
+  const patch = mergeCordisPatches(patches)
   return {
     configKeys: config.count,
     sections: config.sections.length,

package/scripts/types-coverage.mjs

@@ -14,6 +14,9 @@
 // changing the tsconfig is enough and this gate follows.
 //
 // Excluded tiers are data with a reason, not silent gaps:
+//   - `client.js` is the core Web Client half (#M40): a browser artifact checked
+//     by tests/plugin-config-client.test.mjs and the client rules, not by the
+//     Node tsc program;
 //   - `ui-bundle/**` is the optional Web client: a browser artifact with DOM
 //     types and no Node runtime, checked by tests/ui-bundle.test.mjs and the
 //     architecture client rules instead of the Node tsc program;
@@ -30,6 +33,10 @@ const WALK_SKIP = new Set(['node_modules', '.git', '.dsh-tower-worktrees', 'cove
 
 /** Shipped `.js` tiers that are deliberately outside the Node tsc program. */
 export const NOT_CHECKED_TIERS = [
+  {
+    pattern: 'client.js',
+    reason: 'core Web client: browser artifact, checked by tests/plugin-config-client.test.mjs',
+  },
   {
     pattern: 'ui-bundle/**',
     reason: 'optional Web client: browser artifact, checked by tests/ui-bundle.test.mjs and the client architecture rules',

package/skills.js

@@ -66,5 +66,8 @@ export function apply(ctx) {
   // lets tower_status/tower_doctor report "disabled by component tower-skills"
   // when the row is off instead of leaving the missing catalog unexplained.
   holdComponent(ctx, 'tower-skills')
-  ctx.skills.registerProvider(() => provider)
+  // #139: the provider must be unregistered with the plugin, so the catalog stops
+  // serving after unload/reload instead of keeping a dead provider alive. Host
+  // registries may or may not return a disposer; `ctx.effect` accepts both.
+  ctx.effect(() => ctx.skills.registerProvider(() => provider))
 }

package/tools/complete.js

@@ -31,7 +31,9 @@ export function registerCompleteTool(ctx, deps) {
       const context = await tower.missionContext(args.missionId)
       const checks = [...(Array.isArray(args.checks) ? args.checks : [])]
       const testsConfig = /** @type {any} */ (tower.config.tests ?? {})
-      if (testsConfig.enabled !== false && isCompleteAdmission(testsConfig.admission)) {
+      // #136: the `tower-tests` component row is the only switch; admission
+      // decides when discovery runs, not whether it may run.
+      if (isCompleteAdmission(testsConfig.admission)) {
         const discovery = await runMissionDiscovery(tower, { id: args.missionId, worktree: context.mission.worktree })
         if (discovery.configured && discovery.receipt.ok !== true) {
           throw new TowerToolError('tests-failed', `test discovery failed for ${args.missionId}: ${discovery.receipt.error}`)

package/tools/preflight.js

@@ -12,7 +12,7 @@ export function registerPreflightTool(ctx, deps) {
   define(ctx, {
     name: 'tower_preflight',
     description:
-      'Read-only merge gate for one mission: returns ok plus stable blocker codes (branch-missing, deps-unmerged, read-only-survey, stale-base, out-of-scope, base-dirty, branch-owned-by-closed-missions, and mission/worker guards). Review blockers (no-review, review-hold, not-clean, review-not-approved, tip-moved, review-mission-mismatch) apply only when review.requireReview is on. Never changes anything.',
+      'Read-only merge gate for one mission: returns ok plus stable blocker codes (branch-missing, deps-unmerged, read-only-survey, stale-base, out-of-scope, base-dirty, branch-owned-by-closed-missions, and mission/worker guards). Review blockers (no-review, review-hold, not-clean, review-not-approved, tip-moved, review-mission-mismatch) apply only when review.mode is required; review.mode off and optional skip them. Never changes anything.',
     parameters: PreflightInput,
     aliases: {"missionId":["id"]},
     requiresMissionId: true,

package/tools/review.js

@@ -13,7 +13,7 @@ export function registerReviewTool(ctx, deps) {
   define(ctx, {
     name: 'tower_review',
     description:
-      'Submit an independent review verdict bound to the current branch tip: a completed mission starts a review round, and while the mission is active a later route may still record a verdict for that same reviewed tip, appending to the same round without changing the status (a moved tip is rejected with an explanation). status is "clean", "p1-Nitems", or "p2-Nitems"; merge is "merge", "fix-then-merge", or "hold" (only clean + merge is later approval). Non-clean returns the mission to active. Reviewers are capped at 5 rounds per branch; a tower-submitted review is break-glass and requires breakGlassReason.',
+      'Submit an independent review verdict bound to the current branch tip: a completed mission starts a review round, and while the mission is active a later route may still record a verdict for that same reviewed tip, appending to the same round without changing the status (a moved tip is rejected with an explanation). status is "clean", "p1-Nitems", or "p2-Nitems"; merge is "merge", "fix-then-merge", or "hold" (only clean + merge is later approval). Non-clean returns the mission to active. Reviewers are capped at 5 rounds per branch; a tower-submitted review is break-glass and requires breakGlassReason. The tool is not registered when review.mode is off.',
     parameters: ReviewInput,
     aliases: {"missionId":["id"]},
     requiresMissionId: true,

package/tools/spawn.js

@@ -24,8 +24,8 @@ import { buildAgentOptions, buildSpawnBriefing, waitForSpawnResult } from '../ap
  *   recordSpawnThrottle: any,
  *   recordSpawnSuccess: any,
  *   runMissionDiscovery: any,
- *   textOf: any,
- *   inspectLeases: any,
+ *   textOf: any, inspectLeases: any,
+ *   leaseComponent?: () => { enabled: boolean, reason: string },
  * }} deps
  */
 export function registerSpawnTool(ctx, deps) {
@@ -37,7 +37,7 @@ export function registerSpawnTool(ctx, deps) {
   define(ctx, {
     name: 'tower_spawn',
     description:
-      'Spawn a worker or reviewer for a mission. Workers use the tower-worker preset; reviewers require a completed mission and use the read-only tower-reviewer preset. Provisions (or reuses) the mission git worktree and branch, generates a self-contained briefing, and starts a background subagent in that worktree. The child final report is delivered back to this session; tower_roster shows authoritative activity. Records the agent in the roster; reviewer spawns record the branch tip so a reviewer that modifies the branch cannot submit a review. Returns immediately unless wait=true.',
+      'Spawn a worker or reviewer for a mission. Workers use the tower-worker preset; reviewers require a completed mission and use the read-only tower-reviewer preset, and the reviewer role is refused when review.mode is off. Provisions (or reuses) the mission git worktree and branch, generates a self-contained briefing, and starts a background subagent in that worktree. The child final report is delivered back to this session; tower_roster shows authoritative activity. Records the agent in the roster; reviewer spawns record the branch tip so a reviewer that modifies the branch cannot submit a review. Returns immediately unless wait=true.',
     parameters: SpawnInput,
     aliases: {"missionId":["id"],"waitMs":["wait_ms"]},
     requiresMissionId: true,
@@ -54,7 +54,7 @@ export function registerSpawnTool(ctx, deps) {
       const preset = isReviewerRole(role) ? config.spawn.reviewerPreset : config.spawn.workerPreset
       const model = isReviewerRole(role) ? config.spawn.reviewerModel : config.spawn.workerModel
       const context = await tower.missionContext(args.missionId)
-      assertSpawnableMission({ role, context })
+      assertSpawnableMission({ role, context, config })
       const spawned = await enqueueSpawn(tower.root, async () => {
         const observed = await observeActivity(ctx, tower)
         await tower.reconcileObservedInactive(observed.activity)
@@ -71,6 +71,8 @@ export function registerSpawnTool(ctx, deps) {
         })
         const { subagents, provider } = await precheckSpawnServices({
           tower, ctx, config, preset, actor, exec, inspectLeases: deps.inspectLeases,
+          // #131: the app layer only needs the row fact; the root owns the registry.
+          leaseComponent: deps.leaseComponent,
         })
 
         const provisioned = await tower.provision({
@@ -134,9 +136,7 @@ export function registerSpawnTool(ctx, deps) {
           if (classifyError(error).retryable === true) {
             recordSpawnThrottle(tower.root, config.spawn.maxLiveWorkers)
           }
-          // The child may already be running even when recordSpawn failed: stop
-          // it and mark the reserved entry failed so it cannot keep writing
-          // unobserved.
+          // The child may already be running: stop it and fail the reserved entry.
           if (agentId) {
             try {
               await Promise.resolve(subagents.interrupt(agentId, { kind: 'ancestor', agent: exec.agent }))

package/tools/status.js

@@ -4,6 +4,7 @@ import { classifyError } from '../domain/errors.js'
 import { StatusInput } from '../domain/contracts/tool-inputs/index.js'
 import { ROSTER_INACTIVE_STATES, isMarkdownFormat, isReservedState, isWorkerRole } from '../domain/vocabulary.js'
 import { archiveView } from '../app/archive.js'
+import { reviewPolicyView } from '../domain/integration/review.js'
 
 /**
  * @param {any} ctx
@@ -21,7 +22,7 @@ export function registerStatusTool(ctx, deps) {
   define(ctx, {
     name: 'tower_status',
     description:
-      'Read the Tower dashboard for a repository: state path, base branch, revision, mission status counts, paged mission summaries (scope/deps/tasks/worktree/owner), roster size, findings, archive count, config path and the activity tail. Also reports the repo-scoped git lock holder (`gitLock: {held,pid,phase,heldMs}`) so a merge holding the mutex is visible. Pass missionId for one full mission (tasks, notes, reviews, findings, completion report; archived missions are loaded from their year file); offset/limit page the mission list (default 20, max 100); includeGate adds preflight gate digests for the page; includeArchived appends compact archived summaries after the active page; format:"markdown" returns the human-readable mission board (active missions plus an archived count). Read-only.',
+      'Read the Tower dashboard for a repository: state path, base branch, revision, mission status counts, paged mission summaries (scope/deps/tasks/worktree/owner), roster size, findings, archive count, config path and the activity tail. Also reports the repo-scoped git lock holder (`gitLock: {held,pid,phase,heldMs}`) so a merge holding the mutex is visible, and the resolved review policy (`review: {mode, available, required, detail}`; mode off means review is intentionally unavailable). Pass missionId for one full mission (tasks, notes, reviews, findings, completion report; archived missions are loaded from their year file); offset/limit page the mission list (default 20, max 100); includeGate adds preflight gate digests for the page; includeArchived appends compact archived summaries after the active page; format:"markdown" returns the human-readable mission board (active missions plus an archived count). Read-only.',
     parameters: StatusInput,
     aliases: { mission_id: ['missionId'], include_gate: ['includeGate'], include_archived: ['includeArchived'] },
     output: output(SCHEMAS.status),
@@ -38,6 +39,10 @@ export function registerStatusTool(ctx, deps) {
         (entry) => isWorkerRole(entry.role) && !ROSTER_INACTIVE_STATES.includes(entry.state) && !isReservedState(entry.state),
       ).length
       const spawn = spawnBackoffView(tower.root, tower.config.spawn?.maxLiveWorkers, inflight)
+      // #M39: the resolved review policy (`{mode, available, required, detail}`)
+      // is a first-class dashboard fact. In `off` the detail says review is
+      // intentionally unavailable rather than leaving it as a silent absence.
+      const review = reviewPolicyView(tower.config)
       if (args.missionId) {
         const [status, detail] = await Promise.all([
           tower.status({ missionIds: [args.missionId] }),
@@ -51,6 +56,7 @@ export function registerStatusTool(ctx, deps) {
           boardPath,
           mode,
           spawn,
+          review,
           components,
         }
       }
@@ -96,6 +102,7 @@ export function registerStatusTool(ctx, deps) {
         boardPath,
         mode,
         spawn,
+        review,
         components,
       }
       if (isMarkdownFormat(args.format)) {

package/tools/test.js

@@ -37,13 +37,13 @@ export function registerTestTool(ctx, deps) {
       await tower.assertWorktree(context.mission.worktree)
       const discovery = await runMissionDiscovery(tower, context.mission)
       if (!discovery.configured) {
-        return {
-          ok: false,
-          configured: false,
-          error: discovery.error ?? 'tower.testDiscovery is not configured in the worktree package.json',
-          tests: [],
-          commands: [],
-        }
+        // #136: the `tower-tests` row is the switch. When the row is off, say so
+        // and say how to turn it back on; never report the repository as
+        // "not configured" for a component cause.
+        const error = discovery.disabledBy
+          ? `test discovery is unavailable: ${discovery.reason ?? `disabled by component ${discovery.disabledBy}`}; enable the ${discovery.disabledBy} component in the plugin page and restart DSH`
+          : discovery.error ?? 'tower.testDiscovery is not configured in the worktree package.json'
+        return { ok: false, configured: false, error, tests: [], commands: [] }
       }
       const receipt = discovery.receipt
       return {

package/types/index.d.ts

@@ -57,6 +57,7 @@ export type ErrorCode =
   | 'provider-cooldown'
   | 'preset-missing'
   | 'reviewer-prerequisite'
+  | 'review-disabled'
   | 'not-authorized'
   | 'workspace-busy'
   | 'worker-limit'
@@ -73,6 +74,15 @@ export type ErrorCode =
   | 'tool-internal'
 // generated:vocabulary:end
 
+/**
+ * Review policy mode (#M39): `off` (review intentionally unavailable),
+ * `optional` (available, never required; default) or `required` (a clean review
+ * bound to the branch tip is a merge blocker). The deprecated
+ * `review.requireReview` boolean normalizes to this: true -> required,
+ * false -> optional.
+ */
+export type ReviewMode = 'off' | 'optional' | 'required'
+
 /** One machine-readable gate/completion blocker: a stable code plus a detail. */
 export interface Blocker {
   code: string

package/ui-bundle/locale/en.json

@@ -1,6 +1,6 @@
 {
   "meta": {
     "title": "Tower UI",
-    "description": "Shows Tower tool cards, a composer-dock tower summary, and a transient Tower status strip."
+    "description": "Adds Tower cards for tool results, a compact status summary above the message box, and a short status strip, in the web client. When off: The web interface piece is not loaded: no Tower cards, status summary or status strip. The Tower host, missions, state and the board keep working."
   }
 }

package/ui-bundle/locale/zh.json

@@ -1,6 +1,6 @@
 {
   "meta": {
     "title": "Tower 界面",
-    "description": "显示 Tower 工具卡片、输入框区域的 Tower 状态摘要，以及短暂的 Tower 状态提示条。"
+    "description": "在 Web 客户端中显示 Tower 工具结果卡片、输入框上方的简要状态摘要，以及简短的状态提示条。关闭后：界面插件不再加载，不再有 Tower 卡片、状态摘要或提示条。Tower 核心、任务线、状态与看板继续工作。"
   }
 }