dsh-tower 2.4.1 → 2.5.0

package/scripts/check-pack.mjs

@@ -10,7 +10,7 @@ import { execFileSync } from 'node:child_process'
 import fs from 'node:fs'
 import path from 'node:path'
 import { fileURLToPath } from 'node:url'
-import { capabilityLocalePaths } from './generate-capability-locale.mjs'
+import { capabilityLocalePaths, presetLocalePaths } from './generate-capability-locale.mjs'
 
 const ROOT = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..')
 const REQUIRED_FILES = [
@@ -18,9 +18,13 @@ const REQUIRED_FILES = [
   'index.js',
   'locale/en.json',
   'locale/zh.json',
-  // #121: every optional capability row explains itself on the Plugins page
-  // through a subpath locale resource, so those generated files are required.
+  // #121: every optional capability row and both preset-declaring rows explain
+  // themselves on the Plugins page through a subpath locale resource, so those
+  // generated files are required.
   ...capabilityLocalePaths(),
+  ...presetLocalePaths(),
+  'host/preset-worker.js',
+  'host/preset-reviewer.js',
   'ui-bundle/index.js',
   'ui-bundle/package.json',
   'ui-bundle/cordis.patch.yml',

package/scripts/component-surface.json

@@ -19,7 +19,16 @@
       "id": "tower-host",
       "scope": "internal",
       "kind": "row",
-      "fallback": "The Host plugin itself, nested under the mandatory tower anchor. A mandatory dependency, never its own switch."
+      "fallback": "The Host plugin itself, nested under the mandatory tower anchor. A mandatory dependency, never its own switch.",
+      "allowedOverrides": [
+        "mode.allowAgentControl",
+        "mode.workspaceLock",
+        "mode.workspaceLockScope",
+        "mode.planModePolicy",
+        "init.autoGitInit",
+        "send.interruptDefault",
+        "spawn.staleMs"
+      ]
     },
     {
       "id": "tower-skills",
@@ -43,7 +52,7 @@
       "id": "tower-leases",
       "scope": "visible",
       "kind": "row",
-      "fallback": "tower_resource is not registered; advisory leases are coordination only, so nothing else depends on them."
+      "fallback": "tower_resource is not registered; advisory leases are coordination only, but spawn.requireLease still needs the tool to acquire one, so a config that sets spawn.requireLease is rejected at runtime preconditions instead of failing every spawn at lease-busy."
     },
     {
       "id": "tower-tests",
@@ -51,26 +60,48 @@
       "kind": "row",
       "fallback": "tower_test is not registered and no test receipt can be recorded. With gates.requireTests:true planning/mode entry is rejected with an explanation, and the merge gate still reports tests-missing."
     },
+    {
+      "id": "tower-board",
+      "scope": "visible",
+      "kind": "row",
+      "fallback": "MISSIONS.md is not written or refreshed, so an existing board goes stale. Mission state tools, gates and every other capability keep working; docs.boardLocation still chooses where a board would be written."
+    },
+    {
+      "id": "tower-archive",
+      "scope": "visible",
+      "kind": "row",
+      "fallback": "Terminal missions are not moved out of state.json, so the hot state keeps growing and status/doctor keep loading their full history. Merges, gates and every other capability keep working; nothing is deleted. afterDays/maxMissions keep their tuning meaning."
+    },
     {
       "id": "tower-hmr",
       "scope": "visible",
       "kind": "row",
-      "fallback": "tower_reload and /tower reload are unavailable; a profile without HMR behaves exactly as before. Shipped disabled: enable the row for a linked dev profile."
+      "fallback": "Development-only tooling: tower_reload and /tower reload are unavailable, so a linked-profile reload has to be triggered outside Tower. A normal profile behaves exactly as before; the row ships disabled on purpose."
     },
     {
       "id": "preset-tower-worker",
       "scope": "internal",
       "kind": "row",
-      "fallback": "tower_spawn fails without the worker preset. A mandatory dependency, never a switch."
+      "fallback": "Declared by dsh-tower/preset-worker: tower_spawn fails without the worker preset. A mandatory dependency, never a switch."
     },
     {
       "id": "preset-tower-reviewer",
       "scope": "visible",
       "kind": "row",
-      "fallback": "The reviewer cannot be dispatched. Supported while review.requireReview is false (merge is unaffected); with the gate on planning/mode entry is locked with an explanatory error."
+      "fallback": "Declared by dsh-tower/preset-reviewer: the reviewer cannot be dispatched. Supported while review.requireReview is false (merge is unaffected); with the gate on planning/mode entry is locked with an explanatory error."
+    },
+    {
+      "id": "tower-ui",
+      "scope": "visible",
+      "kind": "row",
+      "fallback": "The Tower web UI plugin does not load in this profile: no Tower tool cards, composer-dock summary or status strip. Host tools, missions, state and the MISSIONS.md board are unaffected."
     }
   ],
   "gateableTools": {},
+  "behaviorKnobs": [
+    "spawn.requireLease",
+    "tests.admission"
+  ],
   "keys": [
     {
       "name": "section",
@@ -85,17 +116,35 @@
     {
       "name": "init.autoGitInit",
       "class": "optional-config",
-      "note": "Bootstrap convenience; off only means tower_init will not run git init."
+      "note": "Bootstrap convenience; off only means tower_init will not run git init.",
+      "exemption": {
+        "date": "2026-11-03",
+        "ref": "docs/adr/0005-component-surface.md",
+        "issue": "#138",
+        "reason": "Tuning, not capability: tower_init stays the component and the switch only decides whether it runs git init."
+      }
     },
     {
       "name": "init.snapshotDirty",
       "class": "optional-config",
-      "note": "Dirty-work baseline convenience; no capability is removed."
+      "note": "Dirty-work baseline convenience; no capability is removed.",
+      "exemption": {
+        "date": "2026-11-03",
+        "ref": "docs/adr/0005-component-surface.md",
+        "issue": "#138",
+        "reason": "Tuning, not capability: the init component remains available with or without a dirty-work snapshot baseline."
+      }
     },
     {
       "name": "init.autoExclude",
       "class": "optional-config",
-      "note": "Keeps Tower artifacts out of .git/info/exclude; safe either way."
+      "note": "Keeps Tower artifacts out of .git/info/exclude; safe either way.",
+      "exemption": {
+        "date": "2026-11-03",
+        "ref": "docs/adr/0005-component-surface.md",
+        "issue": "#138",
+        "reason": "Tuning, not capability: both values keep the init component and only change which artifacts the exclude file names."
+      }
     },
     {
       "name": "mode.promptSection",
@@ -250,7 +299,13 @@
     {
       "name": "spawn.requireLease",
       "class": "optional-config",
-      "note": "Advisory-lease gate before a worker starts."
+      "note": "Advisory-lease gate before a worker starts.",
+      "exemption": {
+        "date": "2026-11-03",
+        "ref": "docs/adr/0005-component-surface.md",
+        "issue": "#138",
+        "reason": "Tuning the safety level inside the optional tower-leases row; with leases off the Host refuses requireLease instead of removing the spawn capability."
+      }
     },
     {
       "name": "send.maxPerMinute",
@@ -260,17 +315,24 @@
     {
       "name": "send.interruptDefault",
       "class": "optional-config",
-      "note": "Default for the interrupt-before-deliver flag."
-    },
-    {
-      "name": "tests.enabled",
-      "class": "optional-component",
-      "note": "Tuning inside the optional tower-tests component: it decides whether discovery runs when the row is on. Off with gates.requireTests:true is rejected at config resolution."
+      "note": "Default for the interrupt-before-deliver flag.",
+      "exemption": {
+        "date": "2026-11-03",
+        "ref": "docs/adr/0005-component-surface.md",
+        "issue": "#138",
+        "reason": "Tuning, not capability: the send component always exists and the switch only picks a delivery default."
+      }
     },
     {
       "name": "tests.admission",
       "class": "optional-config",
-      "note": "Chooses when discovery runs inside the optional tests capability."
+      "note": "Chooses when discovery runs inside the optional tests capability.",
+      "exemption": {
+        "date": "2026-11-03",
+        "ref": "docs/adr/0005-component-surface.md",
+        "issue": "#138",
+        "reason": "Tuning when the admission check runs inside the optional tower-tests row, which still owns whether test tooling exists."
+      }
     },
     {
       "name": "tests.timeoutMs",
@@ -285,7 +347,13 @@
     {
       "name": "tests.autoChecks",
       "class": "optional-config",
-      "note": "Attaches a tests check to completion when discovery runs."
+      "note": "Attaches a tests check to completion when discovery runs.",
+      "exemption": {
+        "date": "2026-11-03",
+        "ref": "docs/adr/0005-component-surface.md",
+        "issue": "#138",
+        "reason": "Tuning the default receipt policy inside the optional tower-tests row, which still owns whether any test tooling exists."
+      }
     },
     {
       "name": "tests.allowPackageDiscovery",
@@ -312,25 +380,15 @@
       "class": "forbidden-to-disable",
       "note": "The report cap is part of the completion contract; the refusal itself is never configurable away."
     },
-    {
-      "name": "docs.board",
-      "class": "optional-config",
-      "note": "Writes the human-readable board; no capability is removed."
-    },
     {
       "name": "docs.boardLocation",
       "class": "optional-config",
-      "note": "Chooses the board location."
-    },
-    {
-      "name": "archive.enabled",
-      "class": "optional-config",
-      "note": "Archival is maintenance, not a tool capability; off only leaves terminal missions hot."
+      "note": "Chooses where the board is written; whether it is written is the tower-board component row (#133)."
     },
     {
       "name": "archive.afterDays",
       "class": "optional-config",
-      "note": "Archive age threshold."
+      "note": "Archive age threshold inside the optional tower-archive component (#135)."
     },
     {
       "name": "archive.maxMissions",

package/scripts/generate-capability-locale.mjs

@@ -1,6 +1,6 @@
-// Generate the per-capability row locale files (#121).
+// Generate the per-row locale files (#121).
 //
-// The DSH Plugins page renders an optional row as
+// The DSH Plugins page renders a row as
 // `row.meta.title ?? row.moduleName` plus `row.meta.description`, and the Host
 // fills `row.meta` by resolving `<specifier>/locale/en.json` and then every
 // sibling `<lang>.json` in that directory. A subpath row without such a resource
@@ -10,9 +10,11 @@
 // Those files are generated, not hand-written: the single source of truth is the
 // `components` block of `locale/<lang>.json` that `npm run docs:check:components`
 // already audits. `meta.title` is the component `title`; `meta.description`
-// composes that component's `summary` (what the capability enables) with its
-// `disables` text (what turning it off removes), so the row explains the switch
-// in both directions.
+// composes that component's `summary` (what the row provides) with either its
+// `disables` text (what turning it off removes) or, for the mandatory worker
+// preset, an explicit "mandatory dependency, not a switch" label. The same
+// generator covers capability rows and the two preset-declaring rows, so their
+// labels cannot drift apart.
 //
 // Usage:
 //   node scripts/generate-capability-locale.mjs [--root <dir>] [--check]
@@ -28,6 +30,11 @@ const LANGUAGES = Object.keys(LANGUAGE_FILES)
 // `disables` prose, so the check can prove every description names what the
 // switch removes without depending on one English or Chinese phrasing.
 const OFF_EFFECT_LABEL = { en: 'When off:', zh: '关闭后：' }
+export { OFF_EFFECT_LABEL }
+// The worker preset has no off state; it is a mandatory dependency of the Tower
+// host. Its description says so with an explicit marker instead of a "When off"
+// label that would make the row read like a switch.
+const DEPENDENCY_LABEL = { en: 'Mandatory dependency, not a switch:', zh: '强制依赖，不是开关：' }
 
 /**
  * The optional capability rows that need their own subpath locale resource, in
@@ -40,9 +47,27 @@ export const CAPABILITY_LOCALES = [
   { specifier: 'import', component: 'tower-import' },
   { specifier: 'leases', component: 'tower-leases' },
   { specifier: 'tests', component: 'tower-tests' },
+  { specifier: 'board', component: 'tower-board' },
+  { specifier: 'archive', component: 'tower-archive' },
   { specifier: 'hmr', component: 'tower-hmr' },
 ]
 
+/**
+ * The two preset-declaring rows. They used to mount the shared
+ * `@deepseek-ai/dsh-agent-preset`, so DSH resolved one locale resource for both
+ * and rendered the same title twice. Each now owns a Tower declaration module
+ * (`host/preset-*.js`) and therefore its own `<specifier>/locale/*.json` label.
+ * `mandatory` is the worker dependency; it is asserted against the component
+ * surface scope by the gate/tests so the flag cannot drift from the policy.
+ */
+export const PRESET_LOCALES = [
+  { specifier: 'preset-worker', component: 'preset-tower-worker', mandatory: true },
+  { specifier: 'preset-reviewer', component: 'preset-tower-reviewer', mandatory: false },
+]
+
+/** Every row that ships a generated subpath locale resource. */
+export const ROW_LOCALES = [...CAPABILITY_LOCALES, ...PRESET_LOCALES]
+
 export const CAPABILITY_LOCALE_LANGUAGES = LANGUAGES
 
 /** Repo-relative paths of every generated capability locale file. */
@@ -52,7 +77,19 @@ export function capabilityLocalePaths() {
   )
 }
 
-/** The `package.json` exports entry that exposes one capability's locale files. */
+/** Repo-relative paths of every generated preset row locale file. */
+export function presetLocalePaths() {
+  return PRESET_LOCALES.flatMap(({ specifier }) =>
+    LANGUAGES.map((lang) => `locale/${specifier}/${lang}.json`),
+  )
+}
+
+/** Repo-relative paths of every generated row locale file (capability + preset). */
+export function rowLocalePaths() {
+  return [...capabilityLocalePaths(), ...presetLocalePaths()]
+}
+
+/** The `package.json` exports entry that exposes one row's locale files. */
 export function capabilityLocaleExport(specifier) {
   return { key: `./${specifier}/locale/*.json`, target: `./locale/${specifier}/*.json` }
 }
@@ -63,15 +100,22 @@ function requireText(value, label) {
   return text
 }
 
+/** Normalize the three locale prose fields a generated row label needs. */
+function rowText(entry, lang) {
+  return {
+    title: requireText(entry?.title, `${lang} row title`),
+    summary: requireText(entry?.summary, `${lang} row summary`).replace(/\s+/g, ' '),
+    disables: requireText(entry?.disables, `${lang} row disables`).replace(/\s+/g, ' '),
+  }
+}
+
 /**
  * Compose the display metadata for one capability row in one language.
  * @param {{ title: string, summary: string, disables: string }} entry
  * @param {'en' | 'zh'} lang
  */
 export function renderCapabilityMeta(entry, lang) {
-  const title = requireText(entry?.title, `${lang} capability title`)
-  const summary = requireText(entry?.summary, `${lang} capability summary`).replace(/\s+/g, ' ')
-  const disables = requireText(entry?.disables, `${lang} capability disables`).replace(/\s+/g, ' ')
+  const { title, summary, disables } = rowText(entry, lang)
   // Chinese prose does not space CJK punctuation, so the label joins directly.
   const space = lang === 'zh' ? '' : ' '
   return {
@@ -80,23 +124,57 @@ export function renderCapabilityMeta(entry, lang) {
 }
 
 /**
- * Render every generated file for one repository root.
- * @param {string} root
- * @returns {Map<string, string>} repo-relative path -> file text
+ * Compose the display metadata for one preset-declaring row in one language.
+ * The mandatory worker dependency is labelled as a dependency, never as a
+ * switch; the conditional reviewer keeps the ordinary off-effect label.
+ * @param {{ title: string, summary: string, disables: string }} entry
+ * @param {'en' | 'zh'} lang
+ * @param {boolean} mandatory
  */
-export function renderCapabilityLocaleFiles(root) {
+export function renderPresetMeta(entry, lang, mandatory) {
+  const { title, summary, disables } = rowText(entry, lang)
+  const space = lang === 'zh' ? '' : ' '
+  const label = mandatory ? DEPENDENCY_LABEL[lang] : OFF_EFFECT_LABEL[lang]
+  return {
+    meta: { title, description: `${summary}${space}${label}${space}${disables}` },
+  }
+}
+
+function readLocales(root) {
   const locales = {}
   for (const lang of LANGUAGES) {
     const file = path.join(root, LANGUAGE_FILES[lang])
     if (!fs.existsSync(file)) throw new Error(`${LANGUAGE_FILES[lang]} is missing under ${root}`)
     locales[lang] = JSON.parse(fs.readFileSync(file, 'utf8'))
   }
+  return locales
+}
+
+/** Pull one row's components entry out of both locales, or throw a named error. */
+function componentEntry(locales, lang, component) {
+  const entry = locales[lang]?.components?.[component]
+  if (!entry) throw new Error(`${LANGUAGE_FILES[lang]} has no components.${component} entry`)
+  return entry
+}
+
+/**
+ * Render every generated file for one repository root.
+ * @param {string} root
+ * @returns {Map<string, string>} repo-relative path -> file text
+ */
+export function renderRowLocaleFiles(root) {
+  const locales = readLocales(root)
   const files = new Map()
   for (const { specifier, component } of CAPABILITY_LOCALES) {
     for (const lang of LANGUAGES) {
-      const entry = locales[lang]?.components?.[component]
-      if (!entry) throw new Error(`${LANGUAGE_FILES[lang]} has no components.${component} entry`)
-      files.set(`locale/${specifier}/${lang}.json`, `${JSON.stringify(renderCapabilityMeta(entry, lang), null, 2)}\n`)
+      const rendered = renderCapabilityMeta(componentEntry(locales, lang, component), lang)
+      files.set(`locale/${specifier}/${lang}.json`, `${JSON.stringify(rendered, null, 2)}\n`)
+    }
+  }
+  for (const { specifier, component, mandatory } of PRESET_LOCALES) {
+    for (const lang of LANGUAGES) {
+      const rendered = renderPresetMeta(componentEntry(locales, lang, component), lang, mandatory)
+      files.set(`locale/${specifier}/${lang}.json`, `${JSON.stringify(rendered, null, 2)}\n`)
     }
   }
   return files
@@ -116,11 +194,12 @@ function main(argv) {
   --help   print this text
 
 The files are generated from the components block of locale/en.json and
-locale/zh.json; do not edit locale/<capability>/<lang>.json by hand.`)
+locale/zh.json; do not edit locale/<row>/<lang>.json by hand. Capability and
+preset-declaring rows share this generator so their labels cannot drift.`)
     return 0
   }
   const root = path.resolve(options.root)
-  const files = renderCapabilityLocaleFiles(root)
+  const files = renderRowLocaleFiles(root)
   if (options.check) {
     const stale = []
     for (const [relative, expected] of files) {
@@ -129,11 +208,11 @@ locale/zh.json; do not edit locale/<capability>/<lang>.json by hand.`)
       if (actual !== expected) stale.push(relative)
     }
     if (stale.length > 0) {
-      console.error('capability locale files are stale; run npm run docs:generate:locale')
+      console.error('row locale files are stale; run npm run docs:generate:locale')
       for (const relative of stale) console.error(`  ${relative}`)
       return 1
     }
-    console.log(`capability row locales: ${files.size} files in sync (${CAPABILITY_LOCALES.length} specifiers, en/zh)`)
+    console.log(`row locales: ${files.size} files in sync (${ROW_LOCALES.length} specifiers, en/zh)`)
     return 0
   }
   for (const [relative, text] of files) {
@@ -141,7 +220,7 @@ locale/zh.json; do not edit locale/<capability>/<lang>.json by hand.`)
     fs.mkdirSync(path.dirname(target), { recursive: true })
     fs.writeFileSync(target, text)
   }
-  console.log(`wrote ${files.size} capability row locale files (${CAPABILITY_LOCALES.length} specifiers, en/zh)`)
+  console.log(`wrote ${files.size} row locale files (${ROW_LOCALES.length} specifiers, en/zh)`)
   return 0
 }
 

package/scripts/mount-smoke/probe.mjs

@@ -11,6 +11,7 @@
 import fs from 'node:fs'
 import path from 'node:path'
 import { pathToFileURL } from 'node:url'
+import { PRESET_SPECIFIERS } from './surface.mjs'
 
 function parseArgs(argv) {
   const options = {}
@@ -45,7 +46,7 @@ for (const file of [profileBoot, appBoot]) {
 }
 
 const { runProfile } = await import(pathToFileURL(profileBoot).href)
-const { loadLayeredEnv } = await import(pathToFileURL(appBoot).href)
+const { loadLayeredEnv, readPluginMeta } = await import(pathToFileURL(appBoot).href)
 if (typeof runProfile !== 'function') throw new Error(`probe: host ${hostVersion} does not export runProfile`)
 
 /** Run one surface read, keeping a missing service a reportable value. */
@@ -64,7 +65,7 @@ const { ctx, shutdown } = await runProfile({
   args: [],
 })
 
-const surface = { host: { version: hostVersion }, profile: {}, tools: null, skills: null, presets: null, commands: null, tree: null }
+const surface = { host: { version: hostVersion }, profile: {}, tools: null, skills: null, presets: null, labels: null, commands: null, tree: null }
 try {
   const profileContext = ctx.get('profileContext')
   surface.profile = {
@@ -88,9 +89,38 @@ try {
 
   const presets = ctx.get('agentPresets')
   surface.presets = presets
-    ? await read(async () => (await presets.list()).map((preset) => preset.id))
+    ? await read(async () => {
+        // Both preset rows declare themselves through Tower-owned modules
+        // (`dsh-tower/preset-*`). Keep the display metadata and the activation
+        // diagnostic so the smoke can prove each row still mounts, not only
+        // that two ids exist (#121).
+        const list = await presets.list()
+        return {
+          ids: list.map((preset) => preset.id),
+          entries: list.map(({ id, name, description, order, broken }) => ({
+            id,
+            ...name === undefined ? {} : { name },
+            ...description === undefined ? {} : { description },
+            ...order === undefined ? {} : { order },
+            ...broken === undefined ? {} : { broken },
+          })),
+        }
+      })
     : { error: 'the agentPresets service is not mounted (profile has no preset registry)' }
 
+  // The Plugins page labels a row through this exact call. Resolve both preset
+  // row specifiers from the installed profile so the smoke proves the two rows
+  // render distinct titles/descriptions instead of one shared label (#121).
+  surface.labels =
+    typeof readPluginMeta === 'function' && typeof profileContext?.dir === 'string'
+      ? await read(() => {
+          const base = pathToFileURL(path.join(profileContext.dir, 'cordis.yml')).href
+          return Object.fromEntries(
+            PRESET_SPECIFIERS.map((specifier) => [specifier, readPluginMeta(specifier, base) ?? null]),
+          )
+        })
+      : { error: 'the host exports no readPluginMeta, so preset row labels cannot be read' }
+
   const commands = ctx.get('commands')
   surface.commands = commands
     ? await read(() => commands.list(undefined).map((command) => command.name))