npm - dsh-taskboard - Versions diffs - 0.4.3 → 0.4.4 - Mend

dsh-taskboard 0.4.3 → 0.4.4

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (6) hide show

package/README.md CHANGED Viewed

@@ -213,6 +213,13 @@ node scripts/screenshot.mjs     # 重新生成 img/ 截图（需本机 Edge）
 ## 升级日志
+### 0.4.4
+- **修复看板偶尔突然掉样式的问题（[ #3](https://github.com/cloader/dsh-taskboard/issues/3)）**。排查结论：浏览器里其他插件在后台热更新时，会按"样式归属"做清理，而看板自己的样式表没有归属标记，被误当成别的插件的样式连带删掉了。本次修复后：
+  - 看板的样式表明确打上了自己的归属标记，其他插件更新时不会再误删它
+  - 看板每 2 秒自动检查一次样式是否完好，即便被误删也会立刻自动恢复——以后遇到掉样式，最多闪一下就自动修好，不用再刷新页面
+- 新增回归测试：样式归属标记生效、误删后 2 秒内自动恢复、样式不会重复注入
 ### 0.4.3
 - **修复折叠侧边栏时入口不收成纯图标（用户反馈）**：收起侧边栏后，shell 把侧栏收成 36×36 图标轨道（layout frame 出现 `data-sidebar-collapsed` 属性、侧栏根节点切换 CSS-Module `*_collapsed` 哈希类），而看板入口仍保持全宽——图标、「任务看板」文字、右侧计数角标挤在窄轨里。修复：折叠信号下入口镜像原生轨道几何（36×36、居中、与原生 newSession 折叠态同款间距），隐藏文字与角标，图标 14→16px 保证可读；双信号选择器（`[data-sidebar-collapsed]` 与 `[class*="_collapsed"]`）沿用 0.4.2 双选择器原则，新旧 shell 通吃；展开态完全不受影响，`aria-label` 保留无障碍提示

package/lib/client.js CHANGED Viewed

@@ -1586,15 +1586,46 @@ window.__ModuleLoader__.load({
 		.dsh-atb-imp-result { font-size: 12px; color: var(--dsw-alias-state-success-primary, #30a46c); margin-top: 10px; }
 		.dsh-atb-badge[data-kind="checklist"] { color: var(--dsw-alias-label-secondary, inherit); }
 		`;
-		let injected = false;
-		/** Inject the stylesheet once (idempotent). */
+		/** Style element id (stable since 0.1.x: hook for tests and debugging). */
+		const STYLE_ID = "dsh-taskboard-styles";
+		/**
+		* Ownership tag for the shell's client-module bookkeeping. The web shell
+		* claims every UNTAGGED `<style>` for whichever plugin module materializes
+		* next (claimStyles in dsh-client-modules), and the client HMR driver
+		* deletes `<style>` tags by this attribute on every rebuilt entry
+		* (removeOwnedStyles in dsh-client-hmr).
+		*/
+		const PLUGIN_ID = "dsh-taskboard";
+		/** Per-stylesheet identity, mirroring the shell's own data-plugin-css. */
+		const CSS_TAG = "dsh-taskboard/styles";
+		/**
+		* Ensure the stylesheet lives in <head>: create when absent, re-attach when
+		* removed, always carry the ownership tags.
+		*
+		* 0.4.4 fix (field report: CSS randomly dropped, board renders as unstyled
+		* HTML until refresh): injection runs from cordis apply(), which resolves
+		* AFTER this module's materialization, so the old untagged <style> could be
+		* claimed by ANY sibling plugin module that materialized later (observed
+		* with lazily-materializing profile bundles). That sibling's next HMR
+		* rebuild then deleted OUR stylesheet, and the old module-level `injected`
+		* flag blocked re-injection until a full page refresh. Pre-tagging pins
+		* ownership to this plugin: sibling claims skip tagged styles, and only
+		* THIS plugin's rebuild removes it — the fresh apply re-injects. Idempotency
+		* is DOM-based for the same reason: a module flag cannot see removals,
+		* getElementById can. A found element is re-tagged too, so a leftover
+		* pre-0.4.4 element adopted across a hot swap heals its ownership.
+		*/
 		function injectStyles() {
-			if (injected || typeof document === "undefined") return;
-			const style = document.createElement("style");
-			style.id = "dsh-taskboard-styles";
-			style.textContent = STYLES;
-			document.head.append(style);
-			injected = true;
+			if (typeof document === "undefined") return;
+			let style = document.getElementById(STYLE_ID);
+			if (style === null) {
+				style = document.createElement("style");
+				style.id = STYLE_ID;
+				style.textContent = STYLES;
+				document.head.append(style);
+			}
+			style.dataset.plugin = PLUGIN_ID;
+			style.dataset.pluginCss = CSS_TAG;
 		}
 		//#endregion
@@ -1834,7 +1865,7 @@ window.__ModuleLoader__.load({
 		* @module dsh-taskboard/shared/version
 		*/
 		/** The package version (must equal package.json "version"). */
-		const PLUGIN_VERSION = "0.4.3";
+		const PLUGIN_VERSION = "0.4.4";
 		//#endregion
 		//#region src/client/board/TaskCard.tsx
@@ -4700,6 +4731,9 @@ window.__ModuleLoader__.load({
 		function apply(ctx) {
 			try {
 				injectStyles();
+				const styleWatch = setInterval(() => {
+					injectStyles();
+				}, 2e3);
 				const controller = new BoardController(createClient());
 				const connection = ctx.get?.("connection");
 				if (connection !== void 0) {
@@ -4743,6 +4777,7 @@ window.__ModuleLoader__.load({
 					console.error("[dsh-taskboard] mount failed:", error);
 				}
 				ctx.effect?.(() => () => {
+					clearInterval(styleWatch);
 					for (const d of disposers.splice(0)) d();
 					controller.dispose();
 				}, "dsh-taskboard: client mount");

package/package.json CHANGED Viewed

@@ -1,7 +1,7 @@
 {
   "name": "dsh-taskboard",
   "description": "Agent-first task board for the DSH web GUI: host-authoritative task ledger with taskboard_* agent tools, project (= workspace) claim boundaries, per-task model execution in fresh sessions, optional per-task git-worktree isolation (dedicated task branches, commit evidence, one-click merge), host-side cron scheduling, and a live SSE kanban view. Mounts via the official dsh plugin system — no DSH source changes.",
-  "version": "0.4.3",
+  "version": "0.4.4",
   "type": "module",
   "main": "lib/index.js",
   "exports": {

package/src/client/index.ts CHANGED Viewed

@@ -49,6 +49,11 @@ interface ClientContextFace {
 export function apply(ctx: ClientContextFace): void {
   try {
     injectStyles()
+    // Stylesheet watchdog (0.4.4): re-assert the stylesheet if anything
+    // removed it mid-session — defense-in-depth on top of the ownership
+    // tag (see styles.ts for the claim/reload mechanism it guards against).
+    // One getElementById per 2s tick; cleared with the plugin teardown.
+    const styleWatch = setInterval(() => { injectStyles() }, 2_000)
     const client = createClient()
     const controller = new BoardController(client)
@@ -104,7 +109,12 @@ export function apply(ctx: ClientContextFace): void {
     // cordis effect semantics: the callback runs immediately and its RETURN
     // VALUE is the disposer (family-plugin precedent: () => () => {...}).
     // A single-layer arrow here executes the teardown immediately.
+    // The stylesheet itself is NOT removed here: the HMR driver owns removal
+    // of tagged styles on this plugin's rebuild (and a self-removal could
+    // race a same-lifetime re-apply); its rules are dsh-atb-* scoped, so a
+    // leftover tag after a full disable is inert.
     ctx.effect?.(() => () => {
+      clearInterval(styleWatch)
       for (const d of disposers.splice(0)) d()
       controller.dispose()
     }, 'dsh-taskboard: client mount')

package/src/client/styles.ts CHANGED Viewed

@@ -691,14 +691,47 @@ html[data-dsh-atb-active] .dsh-atb-view { display: flex; flex-direction: column;
 .dsh-atb-badge[data-kind="checklist"] { color: var(--dsw-alias-label-secondary, inherit); }
 `
-let injected = false
+/** Style element id (stable since 0.1.x: hook for tests and debugging). */
+const STYLE_ID = 'dsh-taskboard-styles'
-/** Inject the stylesheet once (idempotent). */
+/**
+ * Ownership tag for the shell's client-module bookkeeping. The web shell
+ * claims every UNTAGGED `<style>` for whichever plugin module materializes
+ * next (claimStyles in dsh-client-modules), and the client HMR driver
+ * deletes `<style>` tags by this attribute on every rebuilt entry
+ * (removeOwnedStyles in dsh-client-hmr).
+ */
+const PLUGIN_ID = 'dsh-taskboard'
+/** Per-stylesheet identity, mirroring the shell's own data-plugin-css. */
+const CSS_TAG = 'dsh-taskboard/styles'
+/**
+ * Ensure the stylesheet lives in <head>: create when absent, re-attach when
+ * removed, always carry the ownership tags.
+ *
+ * 0.4.4 fix (field report: CSS randomly dropped, board renders as unstyled
+ * HTML until refresh): injection runs from cordis apply(), which resolves
+ * AFTER this module's materialization, so the old untagged <style> could be
+ * claimed by ANY sibling plugin module that materialized later (observed
+ * with lazily-materializing profile bundles). That sibling's next HMR
+ * rebuild then deleted OUR stylesheet, and the old module-level `injected`
+ * flag blocked re-injection until a full page refresh. Pre-tagging pins
+ * ownership to this plugin: sibling claims skip tagged styles, and only
+ * THIS plugin's rebuild removes it — the fresh apply re-injects. Idempotency
+ * is DOM-based for the same reason: a module flag cannot see removals,
+ * getElementById can. A found element is re-tagged too, so a leftover
+ * pre-0.4.4 element adopted across a hot swap heals its ownership.
+ */
 export function injectStyles(): void {
-  if (injected || typeof document === 'undefined') return
-  const style = document.createElement('style')
-  style.id = 'dsh-taskboard-styles'
-  style.textContent = STYLES
-  document.head.append(style)
-  injected = true
+  if (typeof document === 'undefined') return
+  let style = document.getElementById(STYLE_ID)
+  if (style === null) {
+    style = document.createElement('style')
+    style.id = STYLE_ID
+    style.textContent = STYLES
+    document.head.append(style)
+  }
+  style.dataset.plugin = PLUGIN_ID
+  style.dataset.pluginCss = CSS_TAG
 }

package/src/shared/version.ts CHANGED Viewed

@@ -6,4 +6,4 @@
  */
 /** The package version (must equal package.json "version"). */
-export const PLUGIN_VERSION = '0.4.3'
+export const PLUGIN_VERSION = '0.4.4'