dsh-taskboard 0.4.0 → 0.4.1

package/README.md

@@ -60,6 +60,11 @@ node scripts/screenshot.mjs     # 重新生成 img/ 截图（需本机 Edge）
 
 ## 升级日志
 
+### 0.4.1
+
+- **修复侧栏入口点击竞态（用户反馈）**：部分 shell 的 DOM 里，任务看板侧栏入口被插在 class 含 `newSession` 的容器内部——点击入口时，看板的全局捕获监听器（「点侧栏会话/新会话让位」语义）先 `closeBoard`，入口自身的 `toggleBoard` 再翻回来，表现为**看板一开就闪关、或入口按钮关不掉**。修复：捕获监听器先按 `closest('[data-dsh-atb-entry]')` 整体豁免入口子树（比给选择器加 `:not()` 更稳——`:not()` 只排除元素自身匹配，挡不住入口嵌在带类祖先容器内的形态）；真会话行/新会话按钮的让位语义不变。顺带加固 `newSessionButton()` 锚点扫描排除自身入口，杜绝自愈重插时锚点自引用
+- 回归测试：构造「入口位于 newSession 容器内」的竞态形态 DOM——点击入口开/关 toggle 正常；点真新会话按钮仍让位
+
 ### 0.4.0
 
 **验收效率包——把「人验收」环节在看板内闭环：**

package/lib/client.js

@@ -1576,6 +1576,8 @@ window.__ModuleLoader__.load({
 
 		//#endregion
 		//#region src/client/sidebar-entry.ts
+		/** Stable data attribute identifying this entry row. */
+		const ENTRY_SELECTOR = "[data-dsh-atb-entry]";
 		/** Inline icon (16px nav-icon look). */
 		const ICON = "<svg viewBox=\"0 0 16 16\" width=\"14\" height=\"14\" fill=\"none\" stroke=\"currentColor\" stroke-width=\"1.3\" stroke-linecap=\"round\" stroke-linejoin=\"round\" aria-hidden=\"true\"><rect x=\"2\" y=\"2.5\" width=\"12\" height=\"11\" rx=\"1.5\"/><path d=\"M2 6.5h12M6.5 6.5v7\"/></svg>";
 		/**
@@ -1590,15 +1592,18 @@ window.__ModuleLoader__.load({
 		/**
 		* The New Session button: nested in the logo row on current shells, a direct
 		* child BUTTON on the real shell (the family plugins' fallback), with
-		* aria-label/text fallbacks for other shells.
+		* aria-label/text fallbacks for other shells. The direct-child scan skips
+		* our own entry (0.4.1): on shells where the insertion anchor lands inside a
+		* class-carrying container, a self-referential anchor would pin the entry
+		* against that container's own geometry instead of the family block.
 		*/
 		function newSessionButton(root) {
 			const nested = root.querySelector("button[class*=\"newSession\"]");
 			if (nested !== null) return nested;
-			for (const child of root.children) if (child instanceof HTMLButtonElement) return child;
+			for (const child of root.children) if (child instanceof HTMLButtonElement && !child.matches("[data-dsh-atb-entry]")) return child;
 			const byAria = root.querySelector("button[aria-label=\"新建会话\"], button[aria-label=\"New Session\"], button[aria-label*=\"新会话\"], button[aria-label*=\"new session\" i]");
 			if (byAria !== null) return byAria;
-			return Array.from(root.querySelectorAll("button")).find((button) => /新会话|新建会话|new session/i.test(button.textContent ?? ""));
+			return Array.from(root.querySelectorAll("button")).find((button) => !button.matches("[data-dsh-atb-entry]") && /新会话|新建会话|new session/i.test(button.textContent ?? ""));
 		}
 		/** Build the entry row (a detached button; insert once the shell is up). */
 		function createEntry(controller) {
@@ -1806,7 +1811,7 @@ window.__ModuleLoader__.load({
 		* @module dsh-taskboard/shared/version
 		*/
 		/** The package version (must equal package.json "version"). */
-		const PLUGIN_VERSION = "0.4.0";
+		const PLUGIN_VERSION = "0.4.1";
 
 		//#endregion
 		//#region src/client/board/TaskCard.tsx
@@ -4589,6 +4594,7 @@ window.__ModuleLoader__.load({
 				if (!controller.getSnapshot().boardOpen) return;
 				const target = event.target;
 				if (target === null) return;
+				if (target.closest("[data-dsh-atb-entry]") !== null) return;
 				if (target.closest(SIDEBAR_ROW_SELECTOR) !== null) controller.closeBoard();
 			};
 			document.addEventListener("click", onClickSidebarRow, true);

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "dsh-taskboard",
   "description": "Agent-first task board for the DSH web GUI: host-authoritative task ledger with taskboard_* agent tools, project (= workspace) claim boundaries, per-task model execution in fresh sessions, optional per-task git-worktree isolation (dedicated task branches, commit evidence, one-click merge), host-side cron scheduling, and a live SSE kanban view. Mounts via the official dsh plugin system — no DSH source changes.",
-  "version": "0.4.0",
+  "version": "0.4.1",
   "type": "module",
   "main": "lib/index.js",
   "exports": {

package/src/client/board-mount.tsx

@@ -10,6 +10,7 @@
 import { createRoot, type Root } from 'react-dom/client'
 import type { BoardController } from './controller.ts'
 import { TaskBoard } from './board/TaskBoard.tsx'
+import { ENTRY_SELECTOR } from './sidebar-entry.ts'
 
 /** The injected board container. */
 export const BOARD_VIEW_SELECTOR = '[data-dsh-atb-view]'
@@ -72,6 +73,13 @@ export function mountBoard(controller: BoardController): () => void {
     if (!controller.getSnapshot().boardOpen) return
     const target = event.target as HTMLElement | null
     if (target === null) return
+    // 0.4.1 竞态修复：任务看板自己的侧栏入口先整体豁免——在部分 shell
+    // 的 DOM 里，插入点落在 class 含 newSession 的容器内部，此时入口点击
+    // 会被本捕获监听器先 closeBoard，再被入口自身的 toggleBoard 翻回来
+    // （症状：看板闪关或入口按钮关不掉）。豁免必须按「入口子树」判定
+    // （closest 而非元素自身匹配）：入口可能嵌在带 newSession 类的祖先
+    // 容器里，仅对选择器加 :not() 排除元素自身挡不住那种嵌套形态。
+    if (target.closest(ENTRY_SELECTOR) !== null) return
     if (target.closest(SIDEBAR_ROW_SELECTOR) !== null) controller.closeBoard()
   }
   document.addEventListener('click', onClickSidebarRow, true)

package/src/client/sidebar-entry.ts

@@ -36,20 +36,23 @@ function sidebarRoot(): HTMLElement | undefined {
 /**
  * The New Session button: nested in the logo row on current shells, a direct
  * child BUTTON on the real shell (the family plugins' fallback), with
- * aria-label/text fallbacks for other shells.
+ * aria-label/text fallbacks for other shells. The direct-child scan skips
+ * our own entry (0.4.1): on shells where the insertion anchor lands inside a
+ * class-carrying container, a self-referential anchor would pin the entry
+ * against that container's own geometry instead of the family block.
  */
 function newSessionButton(root: HTMLElement): HTMLButtonElement | undefined {
   const nested = root.querySelector<HTMLButtonElement>('button[class*="newSession"]')
   if (nested !== null) return nested
   for (const child of root.children) {
-    if (child instanceof HTMLButtonElement) return child
+    if (child instanceof HTMLButtonElement && !child.matches(ENTRY_SELECTOR)) return child
   }
   const byAria = root.querySelector<HTMLButtonElement>(
     'button[aria-label="新建会话"], button[aria-label="New Session"], button[aria-label*="新会话"], button[aria-label*="new session" i]',
   )
   if (byAria !== null) return byAria
   const buttons = Array.from(root.querySelectorAll<HTMLButtonElement>('button'))
-  return buttons.find(button => /新会话|新建会话|new session/i.test(button.textContent ?? ''))
+  return buttons.find(button => !button.matches(ENTRY_SELECTOR) && /新会话|新建会话|new session/i.test(button.textContent ?? ''))
 }
 
 /** Build the entry row (a detached button; insert once the shell is up). */

package/src/shared/version.ts

@@ -6,4 +6,4 @@
  */
 
 /** The package version (must equal package.json "version"). */
-export const PLUGIN_VERSION = '0.4.0'
+export const PLUGIN_VERSION = '0.4.1'