dsh-side-chat-plus 0.3.3 → 0.4.0-alpha.1

package/src/context-types.ts

@@ -43,11 +43,14 @@ export interface SideSessionEvent {
   sourceEventSeqs?: number[]
 }
 
-/** The live session face the host reads (header + append-only event log). */
+/**
+ * The live session face the host reads. Event reads go through
+ * `sessionQuery.readSession` instead: DSH 0.1.6 deprecated the Session's
+ * synchronous event getters (`events` before 0.1.5, `snapshotEvents` after).
+ */
 export interface SideSession {
   id: string
   header: SideSessionHeader
-  events?: readonly SideSessionEvent[]
   requestHeader?: () => { config?: { provider?: string; model?: string; reasoningEffort?: string; maxTokens?: number } } | undefined
 }
 
@@ -206,14 +209,6 @@ export interface SideSessionQuery {
   readSession(sessionId: string): Promise<SideSessionLogSnapshot>
 }
 
-/** Sandbox mode vocabulary (read from the session override). */
-export type SideSandboxMode = 'read-only' | 'workspace-write' | 'danger-full-access'
-
-/** The sandbox policy face. */
-export interface SideSandboxPolicy {
-  overrideOf(session: SideSession): SideSandboxMode | undefined
-}
-
 /** One permission preset option. */
 export interface SidePresetOption {
   value: string
@@ -221,11 +216,16 @@ export interface SidePresetOption {
   description?: string
 }
 
-/** The permission presets face. */
+/** The permission presets face (`current` reads the SESSION, not event rows). */
 export interface SidePermissionPresets {
-  current(events: readonly SideSessionEvent[]): string
+  current(session: SideSession): string
   set(session: SideSession, name: string): void
-  selectFor(state: unknown): { options: SidePresetOption[]; currentValue: string }
+  /** 0.1.6+: process-level catalog of selectable presets. */
+  catalog?(): { options: SidePresetOption[] }
+  /** 0.1.6+: the preset selected as the default for future sessions. */
+  defaultPreset?: string
+  /** 0.1.5 and earlier: combined catalog plus current value. Removed in 0.1.6. */
+  selectFor?(state: unknown): { options: SidePresetOption[]; currentValue: string }
 }
 
 /** The agent presets face (composeFrom joins a child to the parent's composition). */
@@ -304,10 +304,35 @@ export interface SideSettingsService {
 
 /** The client slots service face (settings.section registration). */
 export interface SideSlotsService {
-  inject(name: string, factory: () => () => void): void
+  inject(name: string, factory: () => () => void): () => void
   register(options: Record<string, unknown>, component: unknown): () => void
 }
 
+/** One right-sidebar tab type definition (dsh-client-ui-sidebar-right contract, mirror). */
+export interface SideTabDefinition {
+  /** Stable unique key; the body seat entry registers under the same key. */
+  id: string
+  /** Discriminator used by `openTab(kind)` and the pane dispatch. */
+  kind: string
+  /** Registry band ('builtin' | 'extension' | 'fallback'); defaults to the extension band. */
+  priority?: string
+  /** Fresh title for the tab chip captured at open time. */
+  title(address: string): string
+}
+
+/** The right-sidebar tab-type registry face (`ctx.sidebarRight.tabs`). */
+export interface SideSidebarRightTabs {
+  /** Register a tab type; returns a disposer (hold it in the caller's ctx.effect). */
+  register(definition: SideTabDefinition): () => void
+}
+
+/** The cross-plugin right-sidebar face (`ctx.sidebarRight`, ui-sidebar-right). */
+export interface SideSidebarRight {
+  tabs: SideSidebarRightTabs
+  /** Open a page type by kind in the mounted session; reveals the column. */
+  openTab(kind: string, options?: { paneId?: string; replaceTab?: boolean; revealIfOpened?: boolean }): void
+}
+
 /** One durable image reference (mirror of ImageAttachmentRef). */
 export interface SideImageAttachmentRef {
   attachmentId: string
@@ -325,6 +350,8 @@ export interface SideAttachmentStore {
     maxImagesPerMessage: number
     maxMessageImageBytes: number
     maxImagePixels: number
+    /** 0.1.6+ per-image intrinsic width/height ceiling; absent on earlier lines. */
+    maxImageDimension?: number
     mediaTypes: readonly string[]
   }
   validateImage(input: { data: Uint8Array; mediaType: string; name?: string }): Promise<void>
@@ -335,7 +362,7 @@ export interface SideAttachmentStore {
 /** The host command registry face (`ctx.commands`). */
 export interface SideCommandsService {
   list(agent: SideAgent): Array<{ name: string; description: string }>
-  execute(agent: SideAgent, line: string, signal: AbortSignal): Promise<unknown>
+  execute(agent: SideAgent, line: string, submittedAttachments: readonly unknown[], signal: AbortSignal): Promise<unknown>
 }
 
 /** The per-session composer input face this plugin writes to (draft-only). */
@@ -363,7 +390,6 @@ declare module 'cordis' {
     agents: SideAgentsService
     workspaceRegistry: SideWorkspaceRegistry
     sessionQuery: SideSessionQuery
-    sandboxPolicy: SideSandboxPolicy
     permissionPresets: SidePermissionPresets
     agentPresets: SideAgentPresets
     llm: SideLlm

package/src/index.ts

@@ -23,6 +23,7 @@ import type {
   SideImageAttachmentRef,
   SideInstallModelSelection,
   SideModelSelectionRef,
+  SidePresetOption,
   SideSession,
   SideSessionEvent,
 } from './context-types.ts'
@@ -40,7 +41,6 @@ export const inject = [
   'agents',
   'workspaceRegistry',
   'sessionQuery',
-  'sandboxPolicy',
   'permissionPresets',
   'agentPresets',
   'llm',
@@ -187,6 +187,7 @@ const PrefsSchema: z<SubchatPrefs> = z.object({
   sendImmediately: z.boolean().default(SUBCHAT_PREFS_DEFAULTS.sendImmediately),
   defaultPrompt: z.string().default(SUBCHAT_PREFS_DEFAULTS.defaultPrompt),
   bringMode: z.union(['draft', 'context']).default(SUBCHAT_PREFS_DEFAULTS.bringMode),
+  panelHome: z.union(['floating', 'sidebar-right']).default(SUBCHAT_PREFS_DEFAULTS.panelHome),
 })
 
 /** Live settings face (bound when the settings service is mounted). */
@@ -311,15 +312,24 @@ function buildApi(ctx: Context, sideChats: Map<string, SidechatRecord>, getSetti
     const childId = requireString(payload, 'childId')
     const line = requireString(payload, 'line')
     const child = childOf(childId)
-    const result = await ctx.commands.execute(child, line, new AbortController().signal)
+    const result = await ctx.commands.execute(child, line, [], new AbortController().signal)
     return { executed: result !== undefined }
   }
 
+  /**
+   * Read a side chat's event log through the session-query service. DSH 0.1.6
+   * deprecated the Session's synchronous event getters (`snapshotEvents`,
+   * `eventAt`, `ownEvents`); `readSession` is the live-preferred asynchronous
+   * read that supersedes them, and the transcript routes already use it.
+   */
+  const sessionEvents = async (sessionId: string): Promise<readonly SideSessionEvent[]> =>
+    (await ctx.sessionQuery.readSession(sessionId)).events
+
   /** Fold one side-chat agent's plan/goal state for its composer chrome. */
-  const state = (payload: unknown): { plan: { active: boolean; pending: boolean }; goal: { id: string; objective: string } | null } => {
+  const state = async (payload: unknown): Promise<{ plan: { active: boolean; pending: boolean }; goal: { id: string; objective: string } | null }> => {
     const childId = requireString(payload, 'childId')
-    const child = childOf(childId)
-    const events = child.session.events ?? []
+    childOf(childId)
+    const events = await sessionEvents(childId)
     // Plan fold mirrors dsh-plan-mode's `plan` projection.
     let planActive = false
     let planWanted: boolean | null = null
@@ -431,7 +441,7 @@ function buildApi(ctx: Context, sideChats: Map<string, SidechatRecord>, getSetti
       // Client-supplied preset wins; otherwise inherit the launching
       // conversation's permission preset (skip custom).
       const explicitPreset = typeof record.preset === 'string' && record.preset !== '' ? record.preset : undefined
-      const parentPreset = ctx.permissionPresets.current(parent.session.events ?? [])
+      const parentPreset = ctx.permissionPresets.current(parent.session)
       const preset = explicitPreset ?? parentPreset
       if (preset !== 'custom') {
         ctx.permissionPresets.set(handle.agent.session, preset)
@@ -467,7 +477,7 @@ function buildApi(ctx: Context, sideChats: Map<string, SidechatRecord>, getSetti
   }
 
   /** List the side chats launched by one parent conversation. */
-  const list = (payload: unknown): { items: Array<{ childId: string; running: boolean; runningSince?: number }> } => {
+  const list = async (payload: unknown): Promise<{ items: Array<{ childId: string; running: boolean; runningSince?: number }> }> => {
     const parentSessionId = requireString(payload, 'parentSessionId')
     const items: Array<{ childId: string; running: boolean; runningSince?: number }> = []
     for (const record of sideChats.values()) {
@@ -482,7 +492,8 @@ function buildApi(ctx: Context, sideChats: Map<string, SidechatRecord>, getSetti
       // back to the open-turn event scan.
       const status = (agent as { status?: string }).status
       const statusRunning = status === 'running'
-      const eventRunningSince = openTurnStart(agent.session.events ?? [])
+      // Only the status-less fallback pays for a log read.
+      const eventRunningSince = status === undefined ? openTurnStart(await sessionEvents(record.childId)) : undefined
       const running = statusRunning || (status === undefined && eventRunningSince !== undefined)
       const runningSince = running ? (eventRunningSince ?? Date.now()) : undefined
       items.push({
@@ -510,7 +521,7 @@ function buildApi(ctx: Context, sideChats: Map<string, SidechatRecord>, getSetti
   }
 
   /** The deployment-resolved image policy (for client-side fast-path checks). */
-  const limits = (): { mediaTypes: string[]; maxImageBytes: number; maxImagesPerMessage: number; maxMessageImageBytes: number; maxImagePixels: number } => {
+  const limits = (): { mediaTypes: string[]; maxImageBytes: number; maxImagesPerMessage: number; maxMessageImageBytes: number; maxImagePixels: number; maxImageDimension?: number } => {
     const l = ctx.attachments.imageLimits
     return {
       mediaTypes: [...l.mediaTypes],
@@ -518,6 +529,8 @@ function buildApi(ctx: Context, sideChats: Map<string, SidechatRecord>, getSetti
       maxImagesPerMessage: l.maxImagesPerMessage,
       maxMessageImageBytes: l.maxMessageImageBytes,
       maxImagePixels: l.maxImagePixels,
+      // Added in 0.1.6; earlier lines leave it absent so the client skips the check.
+      ...(l.maxImageDimension === undefined ? {} : { maxImageDimension: l.maxImageDimension }),
     }
   }
 
@@ -706,11 +719,31 @@ function buildApi(ctx: Context, sideChats: Map<string, SidechatRecord>, getSetti
 
   /** Permission-preset options for the side-chat selector. */
   const permissions = (): { options: Array<{ value: string; name: string; description?: string }>; current: string } => {
-    const select = ctx.permissionPresets.selectFor({})
-    return {
-      options: select.options.map((o) => ({ value: o.value, name: o.name, ...(o.description === undefined ? {} : { description: o.description }) })),
-      current: select.currentValue,
+    const presets = ctx.permissionPresets
+    const toOption = (o: SidePresetOption): { value: string; name: string; description?: string } => ({
+      value: o.value,
+      name: o.name,
+      ...(o.description === undefined ? {} : { description: o.description }),
+    })
+    // 0.1.6 split the combined `selectFor(knobState)` into a process-level
+    // `catalog()` plus a separate current value. Prefer the new face and fall
+    // back to the old one so both release lines serve this route.
+    const catalog = presets.catalog
+    if (typeof catalog === 'function') {
+      return {
+        options: catalog.call(presets).options.map(toOption),
+        current: presets.defaultPreset ?? 'custom',
+      }
+    }
+    const selectFor = presets.selectFor
+    if (typeof selectFor === 'function') {
+      const select = selectFor.call(presets, {})
+      return {
+        options: select.options.map(toOption),
+        current: select.currentValue,
+      }
     }
+    throw new SidechatError('permissions-unavailable', 'the permission-presets service exposes neither catalog() nor selectFor()', 503)
   }
 
   return {
@@ -814,6 +847,23 @@ export function apply(ctx: Context): void {
     }
   }, 'dsh-side-chat: dispose side chats')
 
+  // DSH 0.1.6 lists archived sessions in Settings and lets the user restore
+  // one. A side chat is archived precisely so it stays out of the session
+  // list, so at activation re-archive every recorded side chat that a restore
+  // (or an older run) left visible again. Best-effort: records whose session
+  // no longer exists are simply skipped.
+  ctx.effect(() => {
+    void (async () => {
+      for (const record of await readRecords()) {
+        try {
+          await ctx.workspaceRegistry.archiveSession(record.childId)
+        } catch {
+          // Unknown/expired ids are expected as the record list ages out.
+        }
+      }
+    })()
+  }, 'dsh-side-chat: re-archive recorded side chats')
+
   ctx.effect(() => ctx.webServer.register({
     kind: 'prefix',
     path: '/sidechat/api',

package/src/settings-shared.ts

@@ -12,6 +12,9 @@ export const SUBCHAT_PREFS_NS = 'dsh-side-chat'
 /** How a brought-back reply lands in the main conversation. */
 export type BringMode = 'draft' | 'context'
 
+/** Where the side-chat panel lives when a side chat is open. */
+export type PanelHome = 'floating' | 'sidebar-right'
+
 /** User-facing side-chat preferences. */
 export interface SubchatPrefs {
   /** Whether the "look up workspace / parent when needed" switch defaults on. */
@@ -22,6 +25,8 @@ export interface SubchatPrefs {
   defaultPrompt: string
   /** How brought-back content lands: into the composer draft, or as a collapsed context row. */
   bringMode: BringMode
+  /** Which container hosts the panel: the classic floating right-edge panel, or the new built-in right sidebar. */
+  panelHome: PanelHome
 }
 
 /** Fallback prefs used whenever the settings document is unreachable or malformed. */
@@ -30,4 +35,5 @@ export const SUBCHAT_PREFS_DEFAULTS: SubchatPrefs = {
   sendImmediately: true,
   defaultPrompt: '',
   bringMode: 'draft',
+  panelHome: 'sidebar-right',
 }