dsh-server-connector 0.1.0 → 0.2.0

package/lib/audit.js

@@ -61,9 +61,20 @@ const APPEND_QUEUES = new Map()
  * Non-execution events the spec names (doc §3.4, §4.2.4, §9.6). `rule-disabled`
  * is the event that must be written when a rule id leaves a server's
  * `disabledRules` — i.e. when the rule is switched off (doc §4.2.4).
- * @typedef {'hostkey-disabled'|'server-deleted'|'rule-disabled'} AuditEvent
+ * `server-enabled` / `server-disabled` record the enable switch, which applies
+ * immediately rather than through the pending queue (enable-switch spec).
+ * @typedef {'hostkey-disabled'|'server-deleted'|'rule-disabled'|'server-enabled'|'server-disabled'} AuditEvent
  */
 
+/** Every accepted event name, in one place so the validator and the type agree. */
+const AUDIT_EVENTS = Object.freeze([
+  'hostkey-disabled',
+  'server-deleted',
+  'rule-disabled',
+  'server-enabled',
+  'server-disabled',
+])
+
 /**
  * What `append()` accepts. Every key except `ts` is optional; `ts` is stamped
  * by the log so callers cannot backdate an entry.
@@ -168,10 +179,10 @@ function buildRecord(entry, now) {
   if (!isPlainObject(entry)) throw new AuditError('INVALID_AUDIT', 'audit entry must be an object.')
   const isEvent = entry.event !== undefined
   if (isEvent) {
-    if (entry.event !== 'hostkey-disabled' && entry.event !== 'server-deleted' && entry.event !== 'rule-disabled') {
+    if (!AUDIT_EVENTS.includes(/** @type {any} */ (entry.event))) {
       throw new AuditError(
         'INVALID_AUDIT',
-        'event must be one of hostkey-disabled, server-deleted, rule-disabled.',
+        `event must be one of ${AUDIT_EVENTS.join(', ')}.`,
       )
     }
     if (entry.decision !== undefined) {