dsh-root-planner-preset 1.4.0 → 1.4.1

package/build-patch.mjs

@@ -177,7 +177,12 @@ const patch = `# Generated by build-patch.mjs from persona.txt. Do not hand-edit
                 config:
                   provider: fork
                   toolName: subagent_fork
-                  agentPreset: root-planner-worker
+                  # No agentPreset, on purpose. The fork provider declares
+                  # inheritsParentContext true and agentPreset false, and configuring a
+                  # preset for it makes the row throw at activation — which is exactly how
+                  # the first attempt at this migration made the whole preset fail to load.
+                  # A forked child inherits its parent's preset: from a worker that is
+                  # still the worker preset, from the root it is the root preset.
               - id: tool-subagent-codex
                 name: '@deepseek-ai/dsh-tool-subagent'
                 disabled: true
@@ -319,7 +324,7 @@ const patch = `# Generated by build-patch.mjs from persona.txt. Do not hand-edit
                 config:
                   provider: fork
                   toolName: subagent_fork
-                  agentPreset: root-planner-worker
+                  # Inherits its parent's preset; see the note on the root preset's fork row.
           - id: tool-ask-user
             name: '@deepseek-ai/dsh-tool-ask-user'
           - id: tool-todo

package/cordis.patch.yml

@@ -194,7 +194,12 @@
                 config:
                   provider: fork
                   toolName: subagent_fork
-                  agentPreset: root-planner-worker
+                  # No agentPreset, on purpose. The fork provider declares
+                  # inheritsParentContext true and agentPreset false, and configuring a
+                  # preset for it makes the row throw at activation — which is exactly how
+                  # the first attempt at this migration made the whole preset fail to load.
+                  # A forked child inherits its parent's preset: from a worker that is
+                  # still the worker preset, from the root it is the root preset.
               - id: tool-subagent-codex
                 name: '@deepseek-ai/dsh-tool-subagent'
                 disabled: true
@@ -407,7 +412,7 @@
                 config:
                   provider: fork
                   toolName: subagent_fork
-                  agentPreset: root-planner-worker
+                  # Inherits its parent's preset; see the note on the root preset's fork row.
           - id: tool-ask-user
             name: '@deepseek-ai/dsh-tool-ask-user'
           - id: tool-todo

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dsh-root-planner-preset",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "type": "module",
   "description": "DSH agent preset: the root agent plans and decides, subagent workers read, write and run commands inside their own _agents/ workspace, and nothing outlives its task.",
   "license": "MIT",

package/verify-depth-override.mjs

@@ -74,6 +74,19 @@ check(depthPatch?.insert === undefined, 'override is not an insert patch');
 // whenever the profile re-composes — so its content is the evidence that the
 // edit was picked up rather than merely written.
 const composed = yaml.load(readFileSync(COMPOSED, 'utf8'), { schema: loaderSchema });
+// `cordis.yml` is a runtime cache, not a source: its own header calls it "an empty entry
+// list" and says the tree is composed from patches at startup. An empty file therefore
+// means the harness has not rewritten the composition yet on this machine, not that the
+// override is missing. Treating it as failure produced four red checks after a
+// `--dump-config` reset the file — a red that said nothing about the preset.
+if (!Array.isArray(composed) || composed.length === 0) {
+  process.stdout.write(
+    'SKIP the composed-profile checks: cordis.yml still holds the empty template that the\n' +
+      'harness rewrites at startup. Start dsh once, then re-run this script.\n',
+  );
+  process.stdout.write(failures.length === 0 ? '\nALL CHECKS PASSED\n' : `\n${failures.length} CHECK(S) FAILED\n`);
+  process.exit(failures.length === 0 ? 0 : 1);
+}
 const subagentRows = composed.filter((row) => row.id === 'subagent');
 check(subagentRows.length === 1, `exactly one subagent row in the composition (found ${subagentRows.length})`);
 check(subagentRows[0]?.name === '@deepseek-ai/dsh-subagent', 'the composition row matches the asserted name');

package/verify-patch.mjs

@@ -161,26 +161,46 @@ check(
 const workerDelegation = workerPlugins.find((row) => row.id === 'delegation');
 const workerDelegationRows = workerDelegation?.config ?? [];
 
-// Loader row id -> the model-facing tool name that row publishes.
+// Loader row id -> the model-facing tool name that row publishes, plus the provider whose
+// capability decides whether a preset may be selected for it.
 const childTools = [
-  { id: 'tool-subagent', toolName: 'subagent' },
-  { id: 'tool-subagent-fork', toolName: 'subagent_fork' },
-].map(({ id, toolName }) => {
+  { id: 'tool-subagent', toolName: 'subagent', provider: 'spawn' },
+  { id: 'tool-subagent-fork', toolName: 'subagent_fork', provider: 'fork' },
+].map(({ id, toolName, provider }) => {
   const row = delegationRows.find((entry) => entry.id === id);
   check(row !== undefined, `delegation declares ${id}`);
   check(row?.config?.toolName === toolName, `${id} publishes the tool name ${toolName}`);
-  check(row?.config?.agentPreset === 'root-planner-worker', `${id} spawns into the worker preset`);
+  check(row?.config?.provider === provider, `${id} uses the ${provider} provider`);
   check(
     row?.config?.toolFilter === undefined,
     `${id} carries no toolFilter (DSH 0.2.1 removed it and strips it silently)`,
   );
-  // A grandchild must land in the worker preset too, or the tree degrades at depth 2:
-  // the platform default persona and the full tool list come back one level down.
-  const nested = workerDelegationRows.find((entry) => entry.id === id);
-  check(nested?.config?.agentPreset === 'root-planner-worker', `worker ${id} spawns into the worker preset too`);
-  return { id, toolName };
+  // Only the spawn provider supports independent preset selection. A grandchild spawned
+  // through it must land in the worker preset too, or the tree degrades at depth 2: the
+  // platform default persona and the full tool list come back one level down.
+  if (provider === 'spawn') {
+    check(row?.config?.agentPreset === 'root-planner-worker', `${id} spawns into the worker preset`);
+    const nested = workerDelegationRows.find((entry) => entry.id === id);
+    check(nested?.config?.agentPreset === 'root-planner-worker', `worker ${id} spawns into the worker preset too`);
+  }
+  return { id, toolName, provider };
 });
 
+// The fork provider declares `agentPreset: false` together with
+// `inheritsParentContext: true`, and its row throws at activation when a preset is
+// configured for it — which is what made the whole preset fail to load on DSH 0.2.1.
+// Assert the absence in both presets so a later edit cannot reintroduce it.
+for (const [label, rows] of [
+  ['the root preset', delegationRows],
+  ['the worker preset', workerDelegationRows],
+]) {
+  const fork = rows.find((entry) => entry.id === 'tool-subagent-fork');
+  check(
+    fork?.config?.agentPreset === undefined,
+    `${label} sets no agentPreset on the fork row (the fork provider rejects one)`,
+  );
+}
+
 // A subagent is a worker: the curated set keeps the write and shell tools.
 for (const worker of ['read', 'write', 'edit', 'ops_replace', 'pwsh']) {
   check(CHILD_TOOLS.includes(worker), `the curated set keeps ${worker} (a subagent must be able to work)`);