dsh-pve-vm 0.1.0 → 0.1.1

package/CHANGELOG.md

@@ -3,6 +3,43 @@
 All notable changes to this plugin are documented here. The format follows
 [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), versions follow [SemVer](https://semver.org/).
 
+## [0.1.1] — 2026-10-13
+
+Linux guest support. Everything below was found by running the plugin against a real RedOS 8
+guest with a MATE desktop, not by reading the code.
+
+### Fixed
+
+* **Guest OS detection rejected almost every Linux distribution.** The guest agent reports `id`
+  from `/etc/os-release`, and only IDs containing `linux` were accepted — RedOS reports `redos`,
+  Debian `debian`, Ubuntu `ubuntu`. All of them landed in `other` and every `vm_*` tool answered
+  *running a shell command is not supported for guest OS «other»*, so the whole guest-agent half
+  was dead on Linux. Windows was unaffected (`mswindows`), which is why it went unnoticed.
+  Windows is now matched first, Linux by `id`/`name`/`pretty-name`, and a non-Windows guest that
+  answered `get-osinfo` with a non-empty `kernel-release` counts as Linux.
+* **`vm_type_text` typed nothing on a GDM desktop.** The built-in typing script used
+  `$home/.Xauthority`, which does not exist when GDM owns the session — RedOS and RHEL keep the
+  file at `/run/user/<uid>/gdm/Xauthority`. `xdotool` then talked to the X server with no
+  authorization at all, failed with *No protocol specified*, and the text never appeared. The
+  script now tries `~/.Xauthority`, then the GDM path, then any `/run/user/<uid>/*/Xauthority`.
+* **`vm_type_text` could not submit text.** `text=$(… | base64 -d)` — command substitution strips
+  trailing newlines, so text ending in `"\n"` was typed without pressing Enter and the shell
+  prompt never came back.
+* **Console errors hid the actual cause.** When the node's `sshd` does not accept `AcceptEnv`,
+  `LC_PVE_TICKET` never arrives and `qm vncproxy` exits with a precise
+  *LC_PVE_TICKET not set, VNC proxy without password is forbidden* — but the RFB reader saw EOF
+  before ssh had finished exiting, so only *the VNC stream was closed by the node* surfaced. The
+  ssh stderr is now reported (after a short grace period), both during the handshake and when a
+  live session dies mid-way.
+
+### Known limitations
+
+* Proxmox applies a **default 5-second timeout to QMP commands** (`PVE/QMPClient.pm`), and
+  `guest-exec` waits for the guest agent to acknowledge. While a previous long command is still
+  running inside the guest that acknowledgement arrives too late and the call fails with
+  *qmp command 'guest-exec' failed - got timeout*. On an idle guest 10 out of 10 calls complete
+  in about a second. `vm_exec` is currently synchronous and does not retry.
+
 ## [0.1.0] — 2026-10-13
 
 Initial public release.

package/lib/config.js

@@ -12,7 +12,11 @@ import z from '@deepseek-ai/schemastery';
 /** Text input script inside a Linux guest (used by `vm_type_text`). */
 export const DEFAULT_GUEST_TYPE_COMMAND = [
   'set -e',
-  'text=$(printf %s "$1" | base64 -d)',
+  // `$(...)` strips trailing newlines, and without them the text cannot be
+  // "submitted" with Enter: `vm_type_text` with a trailing \"\\n\" silently typed
+  // the line and left the prompt waiting.
+  'text=$(printf %s "$1" | base64 -d; printf X)',
+  'text=${text%X}',
   'uid=""; home=""; disp=""; xauth=""',
   'for s in $(loginctl list-sessions --no-legend 2>/dev/null | awk \'{print $1}\'); do',
   '  [ "$(loginctl show-session "$s" -p Active --value 2>/dev/null)" = "yes" ] || continue',
@@ -22,7 +26,15 @@ export const DEFAULT_GUEST_TYPE_COMMAND = [
   '  [ -n "$disp" ] && break',
   'done',
   '[ -n "$disp" ] || disp=":0"',
-  '[ -n "$home" ] && [ -f "$home/.Xauthority" ] && xauth="$home/.Xauthority"',
+  '[ -n "$uid" ] || uid=$(id -u)',
+  // XAUTHORITY. GDM (RedOS 8, RHEL) keeps it in /run/user/<uid>/gdm/Xauthority,
+  // and ~/.Xauthority may not exist at all — xdotool then talked to X with no
+  // authorization whatsoever, got "No protocol specified" and typed nothing
+  // (found during acceptance on 2026-10-13, RedOS 8 + MATE + GDM).
+  'if [ -n "$home" ] && [ -f "$home/.Xauthority" ]; then xauth="$home/.Xauthority"',
+  'elif [ -f "/run/user/$uid/gdm/Xauthority" ]; then xauth="/run/user/$uid/gdm/Xauthority"',
+  'else xauth=$(ls -1 /run/user/$uid/*/Xauthority /run/user/$uid/xauth* 2>/dev/null | head -1)',
+  'fi',
   'run() { if [ -n "$xauth" ]; then XAUTHORITY="$xauth" DISPLAY="$disp" "$@"; else DISPLAY="$disp" "$@"; fi; }',
   'if command -v xdotool >/dev/null 2>&1; then run xdotool type --delay 12 --clearmodifiers -- "$text"; exit 0; fi',
   'if command -v wtype >/dev/null 2>&1; then',

package/lib/session.js

@@ -252,6 +252,19 @@ export class VmController {
     } catch (error) {
       session.alive = false;
       this.#drop(vmid);
+      // RFB sees EOF before ssh has finished exiting, and the most valuable
+      // explanation — the node's stderr — is lost. Give ssh a short grace
+      // period: without it "the VNC stream was closed by the node" cannot tell
+      // an sshd without AcceptEnv (`LC_PVE_TICKET not set, VNC proxy without
+      // password is forbidden`) from a powered-off VM or a busy QMP socket.
+      // Verified by a negative test on 2026-10-13 (sshd on :2222, no AcceptEnv).
+      const detail = await Promise.race([
+        handle.done.then(() => stderr.trim()).catch(() => ''),
+        new Promise((resolve) => setTimeout(() => resolve(''), 1500)),
+      ]);
+      if (detail.length > 0 && error?.code === 'EOF') {
+        throw new VmError(`failed to open the console of VM ${vmid}: ${detail}`, 'CONSOLE_FAILED');
+      }
       throw error;
     }
     this.sessions.set(vmid, session);
@@ -281,6 +294,12 @@ export class VmController {
         if (error?.code === 'EOF' || error?.code === 'TIMEOUT') {
           session.alive = false;
           this.#drop(id);
+          // A stream that died mid-way is explained by ssh's stderr: for
+          // instance `qm vncproxy` exiting on its own 15-minute idle timeout.
+          const detail = session.stderrText?.() ?? '';
+          if (detail.length > 0) {
+            throw new VmError(`${error.message}; ssh: ${detail}`, error.code);
+          }
         }
         throw error;
       }

package/lib/ssh.js

@@ -72,13 +72,30 @@ export function guestPingCommand(vmid) {
 
 /**
  * Detect the guest OS from the agent's response.
+ *
+ * The guest agent reports `id` from `/etc/os-release` (`ID=`), and every distro
+ * uses its own name there: `redos`, `debian`, `ubuntu`, `altlinux`, `astra-linux`…
+ * So "id == linux" is not a usable Linux test — it filtered out almost every real
+ * distribution (found during acceptance on 2026-10-13: RedOS 8 reports `redos`,
+ * Debian reports `debian`; both landed in `other` and every `vm_*` tool refused
+ * to work). Windows must be checked first: its agent also reports
+ * `kernel-release` (the NT build number), so "has kernel-release => Linux" is
+ * wrong on its own — the order of the checks matters.
+ *
  * @param {unknown} osinfo the parsed `get-osinfo` JSON.
  * @returns {'windows'|'linux'|'other'}
  */
 export function guestOsFamily(osinfo) {
   const id = String(osinfo?.id ?? '').toLowerCase();
-  if (id.includes('windows') || id === 'mswindows') return 'windows';
-  if (id === 'linux' || id.includes('linux')) return 'linux';
+  const name = String(osinfo?.name ?? '').toLowerCase();
+  const pretty = String(osinfo?.['pretty-name'] ?? '').toLowerCase();
+  if (id === 'mswindows' || id.includes('windows') || name.includes('windows')) return 'windows';
+  if (id.includes('linux') || name.includes('linux') || pretty.includes('linux')) return 'linux';
+  // Whatever is left is a non-Windows guest that answered get-osinfo. Only
+  // Windows and Linux are supported, so it is Linux; `kernel-release` is a
+  // sanity check on the reply (an empty agent response never reaches here).
+  const kernel = String(osinfo?.['kernel-release'] ?? '');
+  if (kernel.length > 0) return 'linux';
   return 'other';
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dsh-pve-vm",
-  "version": "0.1.0",
+  "version": "0.1.1",
   "description": "Proxmox VE VM control for DeepSeek Harness: see the screen and click in a VM console over VNC, plus commands, files and typed text through the QEMU guest agent.",
   "type": "module",
   "license": "MIT",