dsh-pr-release-workspace 0.1.0 → 0.1.1

package/lib/client.js

@@ -77,6 +77,7 @@ window.__ModuleLoader__.load({
         'detail.noDiff': 'No changed files were returned.',
         'detail.binary': 'Binary file — no text diff.',
         'detail.diffCapped': 'This pull request is larger than one diff; files were read individually.',
+        'detail.diffIncomplete': 'This pull request changes more files than this panel will page through; the list below is incomplete.',
         'detail.diffFailed': 'The diff could not be loaded.',
         'detail.noComments': 'No review comments yet.',
         'detail.reviewComment': 'on line {line}',
@@ -186,6 +187,7 @@ window.__ModuleLoader__.load({
         'detail.noDiff': '没有返回变更文件。',
         'detail.binary': '二进制文件，无文本差异。',
         'detail.diffCapped': '这个 PR 的改动超过单份 diff 的限额，已按文件逐个读取。',
+        'detail.diffIncomplete': '这个 PR 的改动文件数超过本面板的分页上限，下面的列表并不完整。',
         'detail.diffFailed': 'diff 加载失败。',
         'detail.noComments': '还没有评审评论。',
         'detail.reviewComment': '第 {line} 行',
@@ -1859,7 +1861,14 @@ window.__ModuleLoader__.load({
         'div',
         { style: { display: 'flex', flexDirection: 'column', gap: '2px' } },
         value.truncated === true
-          ? h('p', { className: 'prw-note', style: { margin: '0 0 8px' } }, t('detail.diffCapped'))
+          ? h(
+              'p',
+              { className: 'prw-note', style: { margin: '0 0 8px' } },
+              // `truncated` says GitHub would not render one diff; `complete`
+              // says whether the per-file read reached the end. They are
+              // different claims and a partial list must not look whole.
+              value.complete === false ? t('detail.diffIncomplete') : t('detail.diffCapped'),
+            )
           : null,
         value.files.map(function (file, index) {
           return h(FileRow, {

package/lib/host/exec.js

@@ -67,6 +67,19 @@ export function classifyGhFailure(error, stderr) {
   const rate = matchRateLimit(text)
   if (rate !== null) return rate
 
+  // `gh pr diff` refuses any PR over 300 changed files with
+  // `HTTP 406: … the diff exceeded the maximum number of files (300)` plus
+  // `PullRequest.diff too_large`. This has its own code because the caller can
+  // recover from it — the per-file endpoint still answers — and because the
+  // generic `unknown` message would erase the only thing that identifies it.
+  if (/too_large|exceeded the maximum number of files|diff exceeded the maximum/i.test(text)) {
+    return {
+      code: 'diff-too-large',
+      message: 'This pull request changes more files than GitHub will return as a single diff.',
+      retryAfterSeconds: null,
+    }
+  }
+
   if (/Resource not accessible by integration|must have .* access|insufficient.*scope/i.test(text)) {
     return {
       code: 'forbidden',

package/lib/host/pull.js

@@ -452,13 +452,18 @@ export async function readPullDiff(target, options = {}) {
     // hunks. Falling back keeps a big PR readable instead of turning the detail
     // view into an error page.
     if (!isDiffTooLarge(error)) throw error
-    const files = await readFilePatches(target, options)
+    const { files, complete } = await readFilePatches(target, options)
     return {
       files,
+      // `truncated` means "GitHub would not render this as one diff", which is
+      // exactly the condition that got us here.
       truncated: true,
+      complete,
       bytes: 0,
       source: 'rest-file-patches',
-      note: 'This pull request has more changed files than GitHub will render as one diff; it was reassembled from per-file patches.',
+      note: complete
+        ? 'This pull request has more changed files than GitHub will render as one diff; it was reassembled from per-file patches.'
+        : 'This pull request has more changed files than GitHub will render as one diff, and more than this panel will page through; the list below is incomplete.',
     }
   }
 }
@@ -466,10 +471,17 @@ export async function readPullDiff(target, options = {}) {
 /**
  * Was this failure the "too many files" refusal rather than a real error?
  *
+ * `runGh` classifies a failure and hands back a content-free message, so the
+ * original stderr — the only place `HTTP 406` and `too_large` appear — is gone
+ * by the time we get here. The classifier therefore assigns its own code, and
+ * this checks that code. The message pattern stays as a second line of defence
+ * for errors that did not come from `runGh`.
+ *
  * @param {unknown} error
  * @returns {boolean}
  */
 function isDiffTooLarge(error) {
+  if (error?.code === 'diff-too-large') return true
   const message = String(error?.message ?? '')
   return /406|too_large|exceeded the maximum number of files|too large/i.test(message)
 }
@@ -485,19 +497,26 @@ function isDiffTooLarge(error) {
  *
  * @param {{ owner: string, repo: string, number: number }} target
  * @param {{ signal?: AbortSignal }} [options]
- * @returns {Promise<{ path: string, oldText: string | null, newText: string | null }[]>}
+ * @returns {Promise<{ files: { path: string, oldText: string | null, newText: string | null }[], complete: boolean }>}
  */
 async function readFilePatches(target, options) {
   /** @type {{ path: string, oldText: string | null, newText: string | null }[]} */
   const out = []
   // `per_page` is capped at 100 by the API regardless of what is asked for.
-  const maxPages = 8
+  // Twenty pages is 2000 files: past that the read is not a diff any more, and
+  // the caller is told the list is incomplete rather than being handed a slice
+  // that looks whole.
+  const maxPages = 20
+  let complete = false
   for (let page = 1; page <= maxPages; page += 1) {
     const items = await ghApiJson(
       `/repos/${encodeURIComponent(target.owner)}/${encodeURIComponent(target.repo)}/pulls/${target.number}/files`,
       { query: { per_page: '100', page: String(page) }, signal: options.signal, timeoutMs: 30_000 },
     )
-    if (!Array.isArray(items) || items.length === 0) break
+    if (!Array.isArray(items) || items.length === 0) {
+      complete = true
+      break
+    }
     for (const item of items) {
       if (typeof item?.filename !== 'string') continue
       const status = typeof item?.status === 'string' ? item.status : 'modified'
@@ -513,9 +532,12 @@ async function readFilePatches(target, options) {
         newText: status === 'removed' ? null : newText,
       })
     }
-    if (items.length < 100) break
+    if (items.length < 100) {
+      complete = true
+      break
+    }
   }
-  return out
+  return { files: out, complete }
 }
 
 /**

package/locale/en.json

@@ -19,6 +19,7 @@
   "detail.conflicts": "Conflicts",
   "detail.diffCapped": "This pull request is larger than one diff; files were read individually.",
   "detail.diffFailed": "The diff could not be loaded.",
+  "detail.diffIncomplete": "This pull request changes more files than this panel will page through; the list below is incomplete.",
   "detail.drafts": "My notes",
   "detail.files": "Files",
   "detail.head": "from",

package/locale/zh.json

@@ -19,6 +19,7 @@
   "detail.conflicts": "有冲突",
   "detail.diffCapped": "这个 PR 的改动超过单份 diff 的限额，已按文件逐个读取。",
   "detail.diffFailed": "diff 加载失败。",
+  "detail.diffIncomplete": "这个 PR 的改动文件数超过本面板的分页上限，下面的列表并不完整。",
   "detail.drafts": "我的批注",
   "detail.files": "文件",
   "detail.head": "来自",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dsh-pr-release-workspace",
-  "version": "0.1.0",
+  "version": "0.1.1",
   "description": "PR and release workspace for DSH: grouped pull requests, file diffs, review comments, CI checks, and an evidence-backed release chain from merged PR to the live market index.",
   "type": "module",
   "main": "lib/index.js",