dsh-plugin-toolkit 0.9.5 → 0.9.6

package/CHANGELOG.md

@@ -1,3 +1,20 @@
+## 0.9.6
+
+- **The host half now survives a context it does not own.** `apply()` ended with
+  an unguarded `installRoutes(ctx)`, and cordis does not return `undefined` for
+  an undeclared service — it throws `cannot get property "webServer" without
+  inject`. So the whole `apply` failed, no route was registered, and the plugin
+  manager showed one red dot with no text: the exact symptom the 0.9.5 report
+  channel was built to explain, caused by the code next to it.
+- `verify` now calls the host face's `apply` with a context that throws on every
+  undeclared property, the way cordis does. A plain `{}` hid this: reading
+  `ctx.webServer` off it is just `undefined`. Message:
+  `apply() throws when a service it never declared is read, which fails the row: …`
+- The scaffold was never affected — its host half registers nothing.
+- Regression tests: `test/host.test.mjs` (activation, deferred web server,
+  method guard) and a `verify` case that builds a plugin whose `apply` reads
+  `ctx.webServer` unguarded.
+
 ## 0.9.5
 
 - The panel reports its own failures. When a row fails to activate the app shows

package/index.js

@@ -143,11 +143,19 @@ export function apply(ctx) {
   let installed = false;
   const installRoutes = (serviceCtx) => {
     if (installed) return;
-    const server = serviceCtx !== null && serviceCtx !== undefined ? serviceCtx.webServer : undefined;
-    if (server === null || server === undefined || typeof server.register !== 'function') return;
-    server.register({ kind: 'exact', path: '/toolkit/check', handler: checkHandler });
-    server.register({ kind: 'exact', path: '/toolkit/report', handler: reportHandler });
-    installed = true;
+    // Reading `ctx.webServer` on a context that does not declare `inject` does
+    // not yield undefined: cordis throws "cannot get property ... without
+    // inject". An unguarded read here fails the whole apply, which is exactly
+    // the red dot with no message this panel exists to explain.
+    try {
+      const server = serviceCtx !== null && serviceCtx !== undefined ? serviceCtx.webServer : undefined;
+      if (server === null || server === undefined || typeof server.register !== 'function') return;
+      server.register({ kind: 'exact', path: '/toolkit/check', handler: checkHandler });
+      server.register({ kind: 'exact', path: '/toolkit/report', handler: reportHandler });
+      installed = true;
+    } catch {
+      // No web server on this context: the guard still runs, the panel does not.
+    }
   };
 
   const defer = (deps, callback) => {

package/lib/verify.mjs

@@ -35,6 +35,21 @@ function packTarball(dir, destination) {
   return path.join(destination, document.filename);
 }
 
+/**
+ * What cordis hands a plugin that declares no `inject`: every undeclared
+ * property read throws. A plain `{}` hides the bug this is looking for.
+ */
+function undeclaredContext() {
+  const base = { inject: undefined };
+  return new Proxy(base, {
+    get(target, key) {
+      if (key in target) return target[key];
+      if (typeof key === 'symbol') return undefined;
+      throw new Error(`cannot get property "${String(key)}" without inject`);
+    },
+  });
+}
+
 export async function verify({ dir, mount = true }) {
   const failures = [];
   const report = doctor(dir);
@@ -113,6 +128,7 @@ export async function verify({ dir, mount = true }) {
   // 0.8.0 shipped a package whose root export was the CLI, installed cleanly,
   // and mounted nothing.
   const rootFile = rootEntry(report.manifest);
+  let hostFace = null;
   if (rootFile !== null) {
     const absolute = path.join(installed, rootFile);
     if (fs.existsSync(absolute) === false) {
@@ -126,6 +142,7 @@ export async function verify({ dir, mount = true }) {
     try {
       const { pathToFileURL } = await import('node:url');
       const loaded = await import(pathToFileURL(absolute).href);
+      hostFace = loaded;
       if (typeof loaded.apply !== 'function') {
         return {
           ok: false,
@@ -144,6 +161,26 @@ export async function verify({ dir, mount = true }) {
     }
   }
 
+  // A host face that reads a service it never declared does not get undefined
+  // back: cordis throws "cannot get property ... without inject", the row fails,
+  // and the plugin manager shows one red dot. This cost a real user several
+  // restarts, so the activation itself is checked, not just the import.
+  if (hostFace !== null) {
+    try {
+      hostFace.apply(undeclaredContext());
+    } catch (error) {
+      return {
+        ok: false,
+        stage: 'install',
+        failures: [{
+          check: 'host apply',
+          message: `apply() throws when a service it never declared is read, which fails the row: ${error.message}`,
+        }],
+        files: packed.files,
+      };
+    }
+  }
+
   // `--no-mount` skips the DOM, not the install: the host half is the half
   // that silently fails, and importing it needs nothing but Node.
   if (mount === false) return { ok: true, stage: 'pack', failures: [], files: packed.files, size: packed.size };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dsh-plugin-toolkit",
-  "version": "0.9.5",
+  "version": "0.9.6",
   "description": "Preflight, release and test DeepSeek Harness plugins: checks what the host needs, waits for npm to actually serve the version, and keeps the market index honest.",
   "type": "module",
   "bin": {