dsh-plugin-toolkit 0.9.3 → 0.9.4

package/CHANGELOG.md

@@ -1,3 +1,15 @@
+## 0.9.4
+
+- The client module now declares `inject: ['slots', 'locale']` and guards every
+  service it reads. Without the list the loader calls `apply()` before those
+  services exist; the throw fails the **whole web boot**, and the app then reports
+  that third-party plugins are unsupported and starts with them disabled. That is
+  what one unguarded `ctx.locale.register` did to a real profile.
+- `verify` now calls the client module's `apply()` with a bare context and refuses
+  a face without an `inject` list, so this class of failure is caught before
+  install instead of at boot.
+- `init` scaffolds the same guards, for the same reason.
+
 ## 0.9.3
 
 - The panel needed one more thing than `dsh.client`: the host resolves the bundle

package/client.js

@@ -137,25 +137,43 @@ window.__ModuleLoader__.load({
     }
 
     function apply(ctx) {
-      injectStyles(document);
-      ctx.locale.register(NS, COPY);
-      ctx.inject(['sidebarRightTabs', 'sidebarRight'], (tabCtx) => {
-        if (tabCtx.slots === undefined || tabCtx.sidebarRightTabs === undefined) return;
-        tabCtx.effect(() => tabCtx.slots.inject('sidebar.right.pane.tab', () => tabCtx.slots.register({
-          name: 'sidebar.right.pane.tab',
-          key: NS,
-          locale: NS,
-        }, Panel)));
-        tabCtx.effect(() => tabCtx.sidebarRightTabs.register({
-          id: NS,
-          kind: KIND,
-          priority: 'extension',
-          title: () => 'Plugin doctor',
-        }));
-      });
+      // A panel that cannot find its services must degrade, not fail the boot:
+      // an exception here fails the whole web boot and takes every other plugin
+      // down with it. Every service below is optional for that reason.
+      try {
+        injectStyles(typeof document === 'undefined' ? undefined : document);
+      } catch {
+        // No document: the styles are cosmetic.
+      }
+      try {
+        if (ctx.locale !== undefined && typeof ctx.locale.register === 'function') ctx.locale.register(NS, COPY);
+      } catch {
+        // The panel keeps its English strings.
+      }
+      try {
+        if (typeof ctx.inject !== 'function') return;
+        ctx.inject(['sidebarRightTabs', 'sidebarRight'], (tabCtx) => {
+          if (tabCtx === undefined || tabCtx.slots === undefined || tabCtx.sidebarRightTabs === undefined) return;
+          tabCtx.effect(() => tabCtx.slots.inject('sidebar.right.pane.tab', () => tabCtx.slots.register({
+            name: 'sidebar.right.pane.tab',
+            key: NS,
+            locale: NS,
+          }, Panel)));
+          tabCtx.effect(() => tabCtx.sidebarRightTabs.register({
+            id: NS,
+            kind: KIND,
+            priority: 'extension',
+            title: () => 'Plugin doctor',
+          }));
+        });
+      } catch {
+        // No sidebar: the plugin still loads, it just has no place to show.
+      }
     }
 
-    module.exports = { apply, name: 'dsh-plugin-toolkit' };
+    // The services the tab body reads. Declaring them lets the loader wait for
+    // them instead of calling apply() before they exist.
+    module.exports = { inject: ['slots', 'locale'], apply, name: 'dsh-plugin-toolkit' };
     return module.exports;
   },
 });

package/lib/init.mjs

@@ -86,10 +86,18 @@ function client({ name, title }) {
     }
 
     return {
+      // The services this panel reads. Declaring them makes the loader wait,
+      // and guarding them keeps a missing service from failing the whole boot.
+      inject: ['slots', 'locale'],
       apply(ctx) {
-        ctx.locale.register(NS, COPY);
+        try {
+          if (ctx.locale !== undefined && typeof ctx.locale.register === 'function') ctx.locale.register(NS, COPY);
+        } catch {
+          // keep the English strings
+        }
+        if (typeof ctx.inject !== 'function') return undefined;
         const dispose = ctx.inject(['sidebarRightTabs', 'sidebarRight'], (tabCtx) => {
-          if (tabCtx.slots === undefined) return;
+          if (tabCtx === undefined || tabCtx.slots === undefined) return;
           const tr = tabCtx.locale.bind(NS);
           const offType = tabCtx.sidebarRightTabs.register({
             id: NS,

package/lib/verify.mjs

@@ -165,7 +165,30 @@ export async function verify({ dir, mount = true }) {
       // running out of npx's cache, whose dependencies are not the panel's.
       const panel = await mountClient({ file: entryFile, resolveFrom: dir });
       const text = panel.text();
+      // The web boot calls the module's apply() before every service exists. An
+      // exception there fails the whole boot and takes the other plugins down
+      // with it, so check the face and the bare-context call here.
+      const { loadBundle } = await import('./testkit/index.mjs');
+      const face = loadBundle(entryFile);
+      const faceProblems = [];
+      if (Array.isArray(face.inject) === false) {
+        faceProblems.push('the client module declares no inject list, so the loader calls apply() before its services exist');
+      }
+      try {
+        face.apply({});
+      } catch (error) {
+        faceProblems.push(`apply() throws when the services are absent, which fails the web boot: ${error.message}`);
+      }
       await panel.unmount();
+      if (faceProblems.length > 0) {
+        return {
+          ok: false,
+          stage: 'mount',
+          failures: faceProblems.map((message) => ({ check: 'boot', message })),
+          files: packed.files,
+          installed,
+        };
+      }
       return { ok: true, stage: 'mount', failures: [], files: packed.files, size: packed.size, installed, text };
     } catch (error) {
       return {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dsh-plugin-toolkit",
-  "version": "0.9.3",
+  "version": "0.9.4",
   "description": "Preflight, release and test DeepSeek Harness plugins: checks what the host needs, waits for npm to actually serve the version, and keeps the market index honest.",
   "type": "module",
   "bin": {