dsh-plugin-toolkit 0.8.1 → 0.8.2

package/CHANGELOG.md

@@ -1,3 +1,14 @@
+## 0.8.2
+
+`doctor` now refuses the failure that shipped in 0.8.0.
+
+- New check `root export`: when a package declares `dsh.bundle`, its root module
+  has to be the plugin. A root that is also a `bin` target — a CLI wearing a
+  plugin's clothes — is reported, and so is a root module with no `apply`.
+  pnpm reports success either way; the row just mounts nothing.
+- `test/doctor.test.mjs` covers both shapes, and a bundle with no root module
+  (a subpath plugin) stays legal.
+
 ## 0.8.1
 
 `0.8.0` installed and then did nothing: the loader starts a plugin by importing

package/lib/doctor.mjs

@@ -138,6 +138,34 @@ export function checkFilesList(manifest) {
   return null;
 }
 
+/**
+ * The loader starts a plugin by importing the bare package name. A package that
+ * ships both a CLI and a panel is one `exports` edit away from having its root
+ * point at the CLI — the row then mounts nothing, and pnpm reports success.
+ */
+export function checkRootExport(dir, manifest) {
+  if (manifest.dsh === undefined || manifest.dsh === null) return null;
+  const root = typeof manifest.exports === 'object' && manifest.exports !== null ? manifest.exports['.'] : undefined;
+  const entry = typeof root === 'string' ? root : manifest.main;
+  // A bundle that inserts a subpath plugin needs no root module at all.
+  if (typeof entry !== 'string') return null;
+
+  const target = entry.replace(/^\.\//, '');
+  const bins = Object.values(manifest.bin ?? {}).filter((value) => typeof value === 'string');
+  if (bins.some((bin) => bin.replace(/^\.\//, '') === target) === true) {
+    return `exports["."] points at the CLI (${entry}), so the loader's row has no plugin to apply; point it at the module that exports apply`;
+  }
+
+  const file = path.resolve(dir, target);
+  if (fs.existsSync(file) === false) return null;
+  const source = fs.readFileSync(file, 'utf8');
+  const exported = /export\s+(?:async\s+)?function\s+apply\b|export\s+(?:const|let|var)\s+apply\b|export\s*\{[^}]*\bapply\b|\bapply\s*[:=]\s*(?:async\s*)?(?:function|\()/.test(source);
+  if (exported === false) {
+    return `the root export ${entry} does not export apply, so the loader imports the package and mounts nothing`;
+  }
+  return null;
+}
+
 /** Runs every check and returns `{ failures, notes }`. */
 export function doctor(dir) {
   const { manifest } = readManifest(dir);
@@ -149,6 +177,7 @@ export function doctor(dir) {
     ['patch file', checkPatchFile(dir, manifest)],
     ['client entry', checkClientEntry(dir, manifest)],
     ['files list', checkFilesList(manifest)],
+    ['root export', checkRootExport(dir, manifest)],
   ];
   const failures = checks.filter(([, result]) => result !== null && typeof result === 'string');
   return {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dsh-plugin-toolkit",
-  "version": "0.8.1",
+  "version": "0.8.2",
   "description": "Preflight, release and test DeepSeek Harness plugins: checks what the host needs, waits for npm to actually serve the version, and keeps the market index honest.",
   "type": "module",
   "bin": {