dsh-plugin-infj-pet 1.0.3 → 1.0.5

package/CHANGELOG.md

@@ -3,6 +3,72 @@
 All notable changes to this plugin are documented here. This project follows
 [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 1.0.5
+
+**The character and its speech bubble line up**
+
+- The box that carries the character was not the size of the character: it
+  reserved a ground gap as height while the sprite pushed itself up by the same
+  amount as a bottom margin. The visible pixels therefore sat above the box's
+  bottom edge, so the sage looked off-centre while the bubble, anchored to the
+  box, sat opposite it. The box is now exactly the artwork, and the ground
+  clearance is padding on the container — the drawing and the box agree, so the
+  speech is centred on the character at every size.
+- The five pixels of horizontal margin that widened the box have gone for the
+  same reason.
+
+**The bubble is sized to the character**
+
+- The bubble was a fixed 250 px at every scale, which crowded a large sage and
+  wasted space on a small one. It is now two and a half times the character's own
+  width: about 292 px small, 585 px medium, 878 px large, still clamped to the
+  viewport so it cannot overflow a narrow window.
+
+**Citations name the book**
+
+- Quotations are attributed by title only — 《务虚笔记》, 《我与地坛》,
+  《病隙碎笔》, 《命若琴弦》 — because the title is what a reader needs in order
+  to find the passage. The author's name no longer appears in the interface; it
+  remains in the licence notice, where attribution belongs.
+- The reading line supplied by the project owner is now attributed to
+  《务虚笔记》, which resolves the source that 1.0.2 had recorded as unidentified.
+  The edition is still unpinned and the README says so rather than implying more
+  certainty than exists.
+
+## 1.0.4
+
+**Fix: the plugin never activated**
+
+`1.0.3` shipped a Host half that could not start. In Cordis an `inject` entry
+names a service the plugin waits for, and the entry stays pending until that name
+is provided — an object form does not mean "optional". The Host half declared
+`{ optional: ['agents'] }`, which asks for a service literally called `optional`.
+Nothing provides it, so the entry stayed pending forever and the whole plugin,
+browser half included, never loaded. DSH reported it as:
+
+```
+1 entry did not activate infj-pet (dsh-plugin-infj-pet):
+pending (waiting for service: optional)
+```
+
+The `inject` declaration is gone. The optional agents registry is read with
+`ctx.get('agents')` instead, which returns `undefined` when it is absent and
+costs only the coarse `isSubagent` hint on a recorded boundary.
+
+Guards added so this cannot come back:
+
+- a test asserts `inject` is `undefined`, with the reason in the failure path
+- a test asserts the Host half still activates and records a boundary when no
+  agents registry is present
+- the fake Cordis context no longer needs `agents`, because the plugin must not
+  ask for it
+
+**A note on why this was missed.** Forty-six of the forty-seven tests exercised
+the browser half, which was never the part failing. The Host half was tested
+against a fake context — and a fake context does not enforce the `inject` gate,
+because that gate is framework behaviour. A complete stub hid a framework-level
+failure; the new assertions target exactly that blind spot.
+
 ## 1.0.3
 
 **The sage no longer paces about**

package/README.md

@@ -55,23 +55,26 @@ Around that core:
 
 This is an **in-window** companion, not an operating-system desktop overlay.
 
-### Words borrowed from 史铁生 (Shi Tiesheng)
+### Quoted lines
 
-Several of the reading lines are his, and the sage is careful to say so: a
-quoted line renders its attribution directly under the text, in a smaller line,
-never as if the sage had written it.
+Several reading lines are short quotations, attributed in the interface under the
+line they belong to — the speech bubble cites the book, and this page records the
+full source. They are brief, individually attributed, and used in a
+non-commercial companion; the project claims no rights in them.
 
 | Line | Source |
 |---|---|
-| 如果我进来，走进你独处的时间……我只是来给你的窗上装好玻璃，冬天的风就要来了。 | 史铁生 — supplied by the project owner; publication not yet identified |
-| 死是一件不必急于求成的事。 | 史铁生《我与地坛》 |
-| 太阳，他每时每刻都是夕阳也都是旭日。 | 史铁生《我与地坛》 |
-| 我常觉得这中间有着宿命的味道。 | 史铁生《我与地坛》 |
-
-Where a line could not be verified against a published source, this project says
-so rather than presenting a guess as a quotation — the first row above is
-recorded as unverified for exactly that reason. Titles are referenced for the
-remaining states; no passage is reproduced beyond the short lines listed here.
+| 如果我进来，走进你独处的时间……我只是来给你的窗上装好玻璃，冬天的风就要来了。 | 《务虚笔记》 — named by the project owner; edition not yet pinned |
+| 死是一件不必急于求成的事。 | 《我与地坛》 |
+| 太阳，他每时每刻都是夕阳也都是旭日。 | 《我与地坛》 |
+| 我常觉得这中间有着宿命的味道。 | 《我与地坛》 |
+
+The sage cites the book, not the author's name: the title is what a reader needs
+to find the passage, and it keeps the attribution to a fact rather than a
+byline. Where a line could not be checked against a published edition, this
+project says so — the first row above is recorded that way rather than being
+presented as confirmed. Titles are referenced for the remaining states; no
+passage is reproduced beyond the short lines listed here.
 
 ---
 
@@ -167,8 +170,12 @@ contract:
 - injected shares: `slots`, `sessions`, `connection`, `locale`
 - only `react` and `react-dom/client` are required from the platform module table
 
-The Host half declares no required service and registers one optional listener,
-so a Host-side change degrades the companion rather than failing the plugin.
+The Host half declares **no `inject`**, on purpose. A Cordis `inject` entry names a
+service the plugin waits for, and the entry stays pending until that service is
+provided — so an `inject` that never resolves stops the whole plugin, browser half
+included, from ever activating. The optional agents registry is read with
+`ctx.get('agents')` instead, which returns `undefined` when it is missing and
+costs only the coarse `isSubagent` hint.
 
 DSH is evolving quickly. If a future release changes the slot or store contract,
 the sage is written to fail quietly: it falls back to a non-reactive pose rather

package/lib/client.js

@@ -127,12 +127,12 @@ window.__ModuleLoader__.load({
         {
           zh: '死是一件不必急于求成的事。',
           en: 'Dying is a thing that need not be hurried.',
-          source: { zh: '史铁生《我与地坛》', en: 'Shi Tiesheng, "The Ditan and I"' }
+          source: { zh: '《我与地坛》', en: '"The Ditan and I"' }
         },
         {
           zh: '太阳，他每时每刻都是夕阳也都是旭日。',
           en: 'The sun is, at every moment, both the setting sun and the rising one.',
-          source: { zh: '史铁生《我与地坛》', en: 'Shi Tiesheng, "The Ditan and I"' }
+          source: { zh: '《我与地坛》', en: '"The Ditan and I"' }
         },
         { zh: '我在，不急。', en: 'I am here. No rush.' }
       ],
@@ -142,7 +142,7 @@ window.__ModuleLoader__.load({
         {
           zh: '病隙里也有碎笔。',
           en: 'Fragments get written in the gaps between being ill.',
-          source: { zh: '史铁生《病隙碎笔》', en: 'Shi Tiesheng, "Notes Written in the Gaps"' }
+          source: { zh: '《病隙碎笔》', en: '"Notes Written in the Gaps"' }
         }
       ],
       waiting: [
@@ -154,24 +154,24 @@ window.__ModuleLoader__.load({
         {
           zh: '命若琴弦，先别急着弹断它。',
           en: 'Life is like a string on the qin — do not rush to play it through.',
-          source: { zh: '史铁生《命若琴弦》', en: 'Shi Tiesheng, "Life Is Like a String"' }
+          source: { zh: '《命若琴弦》', en: '"Life Is Like a String"' }
         }
       ],
       reading: [
         {
           zh: '如果我进来，走进你独处的时间，你只管你的沉思默想，不不，你不要慌忙起来，对，你想怎样待着就怎样待着，我只是来给你的窗上装好玻璃，冬天的风就要来了。',
           en: 'If I come in, into your private hour — go on with your thinking, no, do not get up in a hurry, yes, stay however you like. I have only come to fit the glass in your window. The winter wind is on its way.',
-          source: { zh: '史铁生', en: 'Shi Tiesheng' }
+          source: { zh: '《务虚笔记》', en: '"Notes on a Fiction"' }
         },
         {
           zh: '太阳，他每时每刻都是夕阳也都是旭日。',
           en: 'The sun is, at every moment, both the setting sun and the rising one.',
-          source: { zh: '史铁生《我与地坛》', en: 'Shi Tiesheng, "The Ditan and I"' }
+          source: { zh: '《我与地坛》', en: '"The Ditan and I"' }
         },
         {
           zh: '死是一件不必急于求成的事。',
           en: 'Dying is a thing that need not be hurried.',
-          source: { zh: '史铁生《我与地坛》', en: 'Shi Tiesheng, "The Ditan and I"' }
+          source: { zh: '《我与地坛》', en: '"The Ditan and I"' }
         }
       ],
       sleeping: [
@@ -185,7 +185,7 @@ window.__ModuleLoader__.load({
         {
           zh: '我常觉得这中间有着宿命的味道。',
           en: 'I have often felt there was something of fate in all of it.',
-          source: { zh: '史铁生《我与地坛》', en: 'Shi Tiesheng, "The Ditan and I"' }
+          source: { zh: '《我与地坛》', en: '"The Ditan and I"' }
         }
       ]
     };
@@ -454,18 +454,20 @@ window.__ModuleLoader__.load({
 
       var scale = opts.scale || 1;
       var art = SP.stage.art;
-      var marginX = 12;
-      var marginY = 8;
-      // The box frames the artwork rather than the whole cell, so the sage is not
-      // surrounded by the sheet's empty margin. Everything is an integer multiple
-      // of the source pixels so nothing is resampled.
+      // The box is exactly the artwork, with no slop: any margin here would sit
+      // between the visible pixels and the box edge, and the bubble is anchored to
+      // the box, so the character would look offset from its own speech. The sheet's
+      // empty cell margin is already trimmed by using the measured art box, and
+      // everything stays an integer multiple of the source pixels so nothing is
+      // resampled. The little clearance under the feet is CSS padding on the
+      // container, which keeps the layout and the drawing in agreement.
       return {
-        width: (art.width + marginX) * scale,
-        height: (art.height + marginY) * scale,
+        width: art.width * scale,
+        height: art.height * scale,
         backgroundSize: SP.sheet.width * scale + 'px ' + SP.sheet.height * scale + 'px',
         backgroundPosition: -Math.round(cell[0] * scale) + 'px ' + -Math.round(cell[1] * scale) + 'px',
-        // How far the artwork's ground line sits above the box's bottom edge.
-        bottomInset: (SP.stage.ground - (art.y + art.height) + marginY) * scale
+        // The ground line is the artwork's last row, so nothing hangs below it.
+        groundGap: (SP.stage.ground - (art.y + art.height)) * scale
       };
     }
 
@@ -712,7 +714,11 @@ window.__ModuleLoader__.load({
       '.infj-sprite{image-rendering:pixelated;image-rendering:crisp-edges;background-repeat:no-repeat;',
       'transform-origin:bottom center;transition:transform .16s ease-out}',
       '.infj-pet.is-poked .infj-sprite{transform:scale(1.06)}',
-      '.infj-bubble{position:absolute;bottom:calc(100% + 6px);left:50%;transform:translateX(-50%);max-width:250px;',
+      // The bubble is anchored to the box, so its width is derived from the box
+      // rather than fixed: a larger sage gets a proportionally larger bubble, and
+      // the wrap stays comfortable at every size.
+      '.infj-bubble{position:absolute;bottom:calc(100% + 6px);left:50%;transform:translateX(-50%);',
+      'box-sizing:border-box;width:calc(var(--s-bubble) * 2.5);max-width:min(88vw,var(--s-bubble) * 2.5);',
       'min-width:72px;padding:8px 12px;border-radius:14px;background:var(--s-panel);color:var(--s-ink);',
       'font-size:12.5px;font-weight:500;box-shadow:0 6px 22px rgba(16,34,16,0.18),0 1px 0 rgba(255,255,255,0.5) inset;',
       'border:1px solid var(--s-chip);pointer-events:none;animation:infj-bubble-in .22s ease-out;text-align:center;',
@@ -1002,8 +1008,11 @@ window.__ModuleLoader__.load({
         }) || SIZES[1];
         var scale = size.scale;
         var art = SP.stage.art;
-        var boxWidth = (art.width + 12) * scale;
-        var boxHeight = (art.height + 8) * scale;
+        // The box is the artwork itself; the sheet's own ground gap becomes padding
+        // below it so the character is centred both ways inside its own box.
+        var groundGap = (SP.stage.ground - (art.y + art.height)) * scale;
+        var boxWidth = art.width * scale;
+        var boxHeight = art.height * scale + groundGap;
 
         var rootRef = React.useRef(null);
         var dragRef = React.useRef(null);
@@ -1284,6 +1293,11 @@ window.__ModuleLoader__.load({
         var style = {
           width: boxWidth + 'px',
           height: boxHeight + 'px',
+          // The bubble derives its width from the character's own size, so a
+          // larger sage gets a proportionally larger bubble instead of the same
+          // cramped box at every scale.
+          '--s-bubble': boxWidth + 'px',
+          paddingBottom: groundGap + 'px',
           left: position.x == null ? undefined : position.x + 'px',
           top: position.y == null ? undefined : position.y + 'px',
           right: position.x == null ? '24px' : undefined,
@@ -1344,8 +1358,7 @@ window.__ModuleLoader__.load({
               backgroundSize: spec.backgroundSize,
               backgroundPosition: spec.backgroundPosition,
               width: spec.width + 'px',
-              height: spec.height + 'px',
-              marginBottom: spec.bottomInset + 'px'
+              height: spec.height + 'px'
             }
           })
         );

package/lib/index.js

@@ -15,8 +15,19 @@
 /** Cordis plugin name; also the service key. */
 export const name = 'infjPet';
 
-/** The agents registry is optional, so a missing one degrades instead of blocking. */
-export const inject = { optional: ['agents'] };
+/**
+ * Deliberately no `inject`.
+ *
+ * A Cordis `inject` entry names a service the plugin waits for, and the plugin
+ * stays pending until that name is provided. An object form does not mean
+ * "optional": `{ optional: ['agents'] }` asks for a service literally called
+ * `optional`, which never arrives, so the whole entry never activates.
+ *
+ * The agents registry is read with `ctx.get('agents')` in `apply` instead. That
+ * returns `undefined` when the service is absent, which is exactly the
+ * degradation wanted here: boundaries are still recorded, only the coarse
+ * `isSubagent` hint is left off.
+ */
 
 /** Bounded ring of remembered boundaries. */
 export const HISTORY_LIMIT = 256;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dsh-plugin-infj-pet",
-  "version": "1.0.3",
+  "version": "1.0.5",
   "description": "INFJ Sage — a pixel-art Advocate/Counselor companion that lives in your DSH window and reflects what your agents are doing.",
   "keywords": [
     "dsh",