dsh-plugin-infj-pet 1.0.3 → 1.0.4

package/CHANGELOG.md

@@ -3,6 +3,40 @@
 All notable changes to this plugin are documented here. This project follows
 [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 1.0.4
+
+**Fix: the plugin never activated**
+
+`1.0.3` shipped a Host half that could not start. In Cordis an `inject` entry
+names a service the plugin waits for, and the entry stays pending until that name
+is provided — an object form does not mean "optional". The Host half declared
+`{ optional: ['agents'] }`, which asks for a service literally called `optional`.
+Nothing provides it, so the entry stayed pending forever and the whole plugin,
+browser half included, never loaded. DSH reported it as:
+
+```
+1 entry did not activate infj-pet (dsh-plugin-infj-pet):
+pending (waiting for service: optional)
+```
+
+The `inject` declaration is gone. The optional agents registry is read with
+`ctx.get('agents')` instead, which returns `undefined` when it is absent and
+costs only the coarse `isSubagent` hint on a recorded boundary.
+
+Guards added so this cannot come back:
+
+- a test asserts `inject` is `undefined`, with the reason in the failure path
+- a test asserts the Host half still activates and records a boundary when no
+  agents registry is present
+- the fake Cordis context no longer needs `agents`, because the plugin must not
+  ask for it
+
+**A note on why this was missed.** Forty-six of the forty-seven tests exercised
+the browser half, which was never the part failing. The Host half was tested
+against a fake context — and a fake context does not enforce the `inject` gate,
+because that gate is framework behaviour. A complete stub hid a framework-level
+failure; the new assertions target exactly that blind spot.
+
 ## 1.0.3
 
 **The sage no longer paces about**

package/README.md

@@ -167,8 +167,12 @@ contract:
 - injected shares: `slots`, `sessions`, `connection`, `locale`
 - only `react` and `react-dom/client` are required from the platform module table
 
-The Host half declares no required service and registers one optional listener,
-so a Host-side change degrades the companion rather than failing the plugin.
+The Host half declares **no `inject`**, on purpose. A Cordis `inject` entry names a
+service the plugin waits for, and the entry stays pending until that service is
+provided — so an `inject` that never resolves stops the whole plugin, browser half
+included, from ever activating. The optional agents registry is read with
+`ctx.get('agents')` instead, which returns `undefined` when it is missing and
+costs only the coarse `isSubagent` hint.
 
 DSH is evolving quickly. If a future release changes the slot or store contract,
 the sage is written to fail quietly: it falls back to a non-reactive pose rather

package/lib/index.js

@@ -15,8 +15,19 @@
 /** Cordis plugin name; also the service key. */
 export const name = 'infjPet';
 
-/** The agents registry is optional, so a missing one degrades instead of blocking. */
-export const inject = { optional: ['agents'] };
+/**
+ * Deliberately no `inject`.
+ *
+ * A Cordis `inject` entry names a service the plugin waits for, and the plugin
+ * stays pending until that name is provided. An object form does not mean
+ * "optional": `{ optional: ['agents'] }` asks for a service literally called
+ * `optional`, which never arrives, so the whole entry never activates.
+ *
+ * The agents registry is read with `ctx.get('agents')` in `apply` instead. That
+ * returns `undefined` when the service is absent, which is exactly the
+ * degradation wanted here: boundaries are still recorded, only the coarse
+ * `isSubagent` hint is left off.
+ */
 
 /** Bounded ring of remembered boundaries. */
 export const HISTORY_LIMIT = 256;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dsh-plugin-infj-pet",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "description": "INFJ Sage — a pixel-art Advocate/Counselor companion that lives in your DSH window and reflects what your agents are doing.",
   "keywords": [
     "dsh",