dsh-pause-resume 0.4.0 → 0.4.1

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## 0.4.1
+
+A stop that could not finish no longer traps the button, and the dot stops lying after a resume.
+
+* An unfinished stop now always offers the resume that releases it. The button used to prefer
+  `pause` whenever live work remained, so a partial stop re-ran the same stop on the same
+  uncancellable turn: the icon never changed, the attention dot stayed, and pressing it did
+  nothing a person could see.
+* Work that starts while a plan waits no longer flips the button back to pause. The plan owns the
+  action until it is consumed.
 ## 0.4.0
 
 The crash path is now a first-class restore path, and a dead button after a restart is fixed.

package/index.js

@@ -7,7 +7,7 @@ import { createHeartbeat } from './lib/heartbeat.js'
 import { createProbe, listRunning } from './lib/probe.js'
 
 export const name = 'dsh-pause-resume'
-export const VERSION = '0.4.0'
+export const VERSION = '0.4.1'
 
 const BASE_PATH = '/dsh-pause-resume'
 const BUTTON_HEADER = 'x-dsh-pause-resume'

package/lib/engine.js

@@ -139,10 +139,14 @@ export function createEngine({ store, probe, heartbeat = null, bootId = 'boot',
     const work = workOf(current)
     const busy = TRANSIENT.has(phase)
     const workCount = liveWorkCount(work)
+    // A plan is an unfinished stop: the only way forward is to resume it, even when the stop left
+    // work behind. Preferring `pause` there used to trap a partial stop forever: every press
+    // re-ran the same stop, the residue could never be cancelled, and the button never offered the
+    // resume that would have released the plan.
     let action = 'none'
     if (busy) action = 'busy'
-    else if (current.readable === true && workCount > 0) action = 'pause'
     else if (plan !== null) action = 'resume'
+    else if (current.readable === true && workCount > 0) action = 'pause'
     const attentionRows = plan !== null ? plan.attention : result?.attention
     const attention = Array.isArray(attentionRows) ? attentionRows.length : 0
     const first = attention > 0 ? attentionRows[0] : null

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dsh-pause-resume",
-  "version": "0.4.0",
+  "version": "0.4.1",
   "type": "module",
   "description": "One header button stops running turns, goals and jobs, writes a plan to disk, and restores that work after a restart or crash; the button shape is the only status.",
   "license": "MIT",