dsh-model-everything 0.3.0 → 0.4.0

package/lib/types/presentation.d.ts

@@ -15,7 +15,7 @@
  * Both are pure and replayable: they read the persisted value, never the filesystem.
  */
 import type { ContentBlock } from '@deepseek-ai/dsh-llm';
-import type { ToolResultView } from '@deepseek-ai/dsh-tools';
+import type { ToolCallView, ToolResultView } from '@deepseek-ai/dsh-tools';
 /** One finding, as a card needs it: a code to name it and a sentence to read. */
 export interface CardFinding {
     code: string;
@@ -39,6 +39,53 @@ export interface ReportCard {
         owns: string;
         instead: string;
     };
+    /** `model_edit`: the changes this call applied, as the report lists them. */
+    changes?: Array<{
+        kind: string;
+        what: string;
+        detail?: string;
+    }>;
+    /** `model_edit` and `report_diff`: how the findings moved, when either report could compare. */
+    delta?: {
+        added: number;
+        removed: number;
+        changed: number;
+        addedErrors: number;
+    };
+    /** `report_diff`: the first finding the change adds, so a card can lead with it. */
+    firstAdded?: CardFinding;
+    /** `report_diff`: the current report's own verdict, which differs from the delta's when a clean change lands on a failing report. */
+    currentVerdict?: string;
+    /** The artifact a translation or a rendering produced, as the first lines of it. */
+    source?: {
+        label: string;
+        lines: string[];
+        total: number;
+    };
+    /** `uml_structure_verify`: the graph's own counts, which are measurements rather than findings. */
+    graph?: {
+        nodes: number;
+        edges: number;
+        cycles: number;
+        isolated: number;
+        dangling: number;
+    };
+    /** `model_design_review`: three levels, because a signal is not a violation and a fact is neither. */
+    levels?: {
+        violations: number;
+        signals: number;
+        facts: number;
+        skipped: number;
+    };
+    /** `model_interleaving_scan`: how many claims were found, and in which families. */
+    claims?: {
+        absolute: number;
+        keywords: number;
+        families: Array<{
+            family: string;
+            count: number;
+        }>;
+    };
 }
 /**
  * Project a report into the card payload.
@@ -50,10 +97,68 @@ export declare function reportCard(value: unknown, family: string): ReportCard;
 /** The card body: four lines, in the order a reader asks the questions. */
 export declare function cardBlocks(card: ReportCard): ContentBlock[];
 /**
- * `presentResult` for a report tool: render the card from the persisted payload, and fall back to the
- * raw content by returning undefined when there is none.
+ * The pending card for a report tool: a title naming the artifact, and the file to follow.
+ *
+ * From the arguments only, because a UI calls this during streaming and again on replay; the file has not
+ * been opened at that point and must not be.
+ */
+/**
+ * The card payload with the artifact previewed.
+ *
+ * A translation and a rendering both produce text a reader wants to see the shape of, and neither should
+ * paste the whole file into a card: the preview is bounded, and it says how much it left out. The report
+ * keeps the artifact in full for whoever needs it.
  */
+export declare function cardWithSource(value: unknown, family: string, text: string | undefined, label: string, limit?: number): ReportCard;
+export declare function reportCallView(family: string): (args: unknown) => ToolCallView | undefined;
+/**
+ * The card for `model_edit`: what changed, and what the change did to the findings.
+ *
+ * Both lists are already in the report, so this is a rendering of the same value rather than a second
+ * computation - the rule every card here follows.
+ */
+export declare function editCardBlocks(card: ReportCard): ContentBlock[];
+/**
+ * The card for `report_diff`: does this change add anything, read as counts and the first added error.
+ *
+ * A diff's `verdict` is about the delta, so the card leads with the delta and never with the current
+ * report's own verdict - the two differ exactly when a clean change lands on an already-failing report.
+ */
+export declare function diffCardBlocks(card: ReportCard): ContentBlock[];
+/** `presentResult` for `model_edit`, falling back to the generic card when the payload has no changes. */
+export declare function editResultView(family: string): (_args: unknown, result: {
+    content: ContentBlock[];
+    meta?: unknown;
+}) => ToolResultView | undefined;
 export declare function reportResultView(family: string): (_args: unknown, result: {
     content: ContentBlock[];
     meta?: unknown;
 }) => ToolResultView | undefined;
+/** The card for `uml_structure_verify`: the graph's shape first, then the first finding. */
+export declare function structureCardBlocks(card: ReportCard): ContentBlock[];
+/** The card for `model_design_review`: violations, then signals, then facts - never one number. */
+export declare function designCardBlocks(card: ReportCard): ContentBlock[];
+/** The card for `model_interleaving_scan`: claims by family, and the reminder that nothing was proven. */
+export declare function scanCardBlocks(card: ReportCard): ContentBlock[];
+/** One `presentResult` per card body, since the shapes differ but the fallback does not. */
+export declare function familyResultView(family: string, body: (card: ReportCard) => ContentBlock[]): (_args: unknown, result: {
+    content: ContentBlock[];
+    meta?: unknown;
+}) => ToolResultView | undefined;
+export declare const structureResultView: (_args: unknown, result: {
+    content: ContentBlock[];
+    meta?: unknown;
+}) => ToolResultView | undefined;
+export declare const designResultView: (_args: unknown, result: {
+    content: ContentBlock[];
+    meta?: unknown;
+}) => ToolResultView | undefined;
+export declare const scanResultView: (_args: unknown, result: {
+    content: ContentBlock[];
+    meta?: unknown;
+}) => ToolResultView | undefined;
+/** `presentResult` for `report_diff`: the delta leads, never the current report's own verdict. */
+export declare function diffResultView(family: string): (_args: unknown, result: {
+    content: ContentBlock[];
+    meta?: unknown;
+}) => ToolResultView | undefined;

package/lib/uml-tool.js

@@ -3,7 +3,7 @@ import { createHash } from 'node:crypto';
 import { REPORT_SCHEMAS, DEFAULT_HASH_SPEC, valueHash, refusalVerdict, verdictOf, verdictOfFindings } from './engine.js';
 import { renderUml, parseUml, parseFindings, reviewUml, explainLabels, checkUmlIntent, UmlError, UML_DIAGRAMS, } from './uml.js';
 import { renderReportText } from './report-view.js';
-import { reportCard, reportResultView } from './presentation.js';
+import { cardWithSource, reportCallView, reportCard, reportResultView } from './presentation.js';
 /**
  * The UML front end as four tools, one per job.
  *
@@ -51,7 +51,8 @@ const reportOutput = (family) => ({
     // The card a UI shows, separated from the text the model reads. The family is the tool's own name, so
     // one shared output does not have to guess which tool is calling it.
     presentationMeta(_args, value) {
-        return reportCard(value, family);
+        const report = value;
+        return cardWithSource(value, family, typeof report.diagram === 'string' ? report.diagram : undefined, 'diagram source');
     },
 });
 /** Draw a model as diagram source. */
@@ -67,6 +68,7 @@ export const umlRenderTool = defineTool({
         reportView: reportViewParameter,
     },
     output: reportOutput(UML_RENDER_TOOL_NAME),
+    presentCall: reportCallView(UML_RENDER_TOOL_NAME),
     presentResult: reportResultView(UML_RENDER_TOOL_NAME),
     timeoutMs: 10_000,
     isConcurrencySafe: () => true,
@@ -105,6 +107,7 @@ export const umlParseTool = defineTool({
         reportView: reportViewParameter,
     },
     output: reportOutput(UML_PARSE_TOOL_NAME),
+    presentCall: reportCallView(UML_PARSE_TOOL_NAME),
     presentResult: reportResultView(UML_PARSE_TOOL_NAME),
     timeoutMs: 10_000,
     isConcurrencySafe: () => true,
@@ -157,6 +160,7 @@ export const umlReviewTool = defineTool({
         reportView: reportViewParameter,
     },
     output: reportOutput(UML_REVIEW_TOOL_NAME),
+    presentCall: reportCallView(UML_REVIEW_TOOL_NAME),
     presentResult: reportResultView(UML_REVIEW_TOOL_NAME),
     timeoutMs: 10_000,
     isConcurrencySafe: () => true,
@@ -189,6 +193,7 @@ export const umlExplainLabelsTool = defineTool({
         reportView: reportViewParameter,
     },
     output: reportOutput(UML_LABELS_TOOL_NAME),
+    presentCall: reportCallView(UML_LABELS_TOOL_NAME),
     presentResult: reportResultView(UML_LABELS_TOOL_NAME),
     timeoutMs: 10_000,
     isConcurrencySafe: () => true,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dsh-model-everything",
-  "version": "0.3.0",
+  "version": "0.4.0",
   "description": "Modeling abstraction and automated review for designs and code, including a refactoring harness: UML diagrams, executable verification of machines and protocols with before/after regression, data-model and migration checks, concurrency claim routing, export to external checkers, dependency-graph review, and report diffing. Native plugin for DeepSeek Harness (dsh).",
   "type": "module",
   "main": "lib/index.js",
@@ -64,6 +64,8 @@
     "typecheck": "tsc -p tsconfig.json --noEmit",
     "lint:md": "markdownlint --dot --ignore \"**/node_modules/**\" .",
     "bump": "node scripts/bump-version.mjs",
+    "test:cards": "node tests/presentation/run.mjs && node tests/automaton/run.mjs && node tests/routing/run.mjs",
+    "coverage": "c8 --reporter=text --exclude-after-remap=false npm run test:engine",
     "test:engine": "npm run build && node tests/engine/run.mjs && node tests/design-engine/run.mjs && node tests/catalog/run.mjs && node tests/data-engine/run.mjs && node tests/concurrency/run.mjs && node tests/uml/run.mjs && node tests/apply-smoke.mjs && node tests/memory/run.mjs && node tests/skills/run.mjs && node tests/gate/run.mjs && node tests/skill-routing/run.mjs && node tests/toolset/run.mjs && node tests/principles/run.mjs && node tests/feature-checklist/run.mjs && node tests/usage/run.mjs && node tests/translation/run.mjs && node tests/documentation/run.mjs && node tests/contributing/run.mjs && node tests/routing-map/run.mjs && node tests/report-reading/run.mjs && node tests/structure/run.mjs && node tests/automaton/run.mjs && node tests/presentation/run.mjs && node tests/routing/run.mjs && node tests/tool-routing/run.mjs && node tests/tools/run.mjs && node tests/baseline/run.mjs && node tests/granularity/run.mjs && node tests/exporters/run.mjs && node tests/report-view/run.mjs && node tests/contracts/run.mjs && node tests/tool-boundary/run.mjs && node tests/negatives/run.mjs && node tests/external/run.mjs",
     "test:full": "npm run build && node tests/full-suite.mjs",
     "check": "npm run lint:md && npm run test:engine"

package/src/automaton-tool.ts

@@ -11,7 +11,7 @@ import { verifyAutomaton, type AutomatonRelation } from './automaton.js'
 import type { JsonValue } from './json-value.js'
 import { optionRefusal } from './option-shape.js'
 import { renderReportText } from './report-view.js'
-import { reportCard, reportResultView } from './presentation.js'
+import { reportCallView, reportCard, reportResultView } from './presentation.js'
 
 export const MODEL_AUTOMATON_TOOL_NAME = 'model_automaton_verify'
 
@@ -53,10 +53,11 @@ export const modelAutomatonTool = defineTool({
     },
     // The card a UI shows, separated from the text the model reads: a verdict and the first thing wrong,
     // never the whole report.
-    presentationMeta(_args, value) {
+    presentationMeta(args, value) {
       return reportCard(value, MODEL_AUTOMATON_TOOL_NAME) as unknown as JsonValue
     },
   },
+  presentCall: reportCallView(MODEL_AUTOMATON_TOOL_NAME),
   presentResult: reportResultView(MODEL_AUTOMATON_TOOL_NAME),
   timeoutMs: 10_000,
   isConcurrencySafe: () => true,

package/src/automaton.ts

@@ -261,6 +261,7 @@ function isDeterministic(automaton: Automaton): boolean {
   return true
 }
 
+
 export function verifyAutomaton(input: unknown, options: { other?: unknown; relation?: AutomatonRelation } = {}): AutomatonReport {
   const parsed = validateAutomaton(input)
   if (!parsed.ok) {
@@ -281,9 +282,6 @@ export function verifyAutomaton(input: unknown, options: { other?: unknown; rela
   // accepts nothing: the first is a modelling smell, the second is usually a defect in the intended language.
   for (const [index, label] of dfa.labels.entries()) {
     if (label.length === 0) continue
-    if (label.length === 1 && !reach[index]) {
-      findings.push({ code: 'AUT001_UNREACHABLE_STATE', severity: 'warning', message: `state "${label[0]}" cannot be reached from init` })
-    }
     if (!dfa.accept[index] && reach[index] && !canAccept[index]) {
       findings.push({ code: 'AUT002_TRAP_STATE', severity: 'warning', message: `state "${label[0]}" is reachable but can never reach an accepting state` })
     }
@@ -321,10 +319,12 @@ export function verifyAutomaton(input: unknown, options: { other?: unknown; rela
         findings.push({ code: 'AUT009_UNDECIDED', severity: 'warning', message: 'the product search stopped at its state cap before deciding the relation, so equality is neither proven nor refuted', detail: 'the product of two automata can be exponential; reduce one of them, or decide the relation with a tool that searches symbolically' })
       } else
       if (relation === 'equivalent') {
-        if (missing !== undefined || extra !== undefined) {
-          const word = missing ?? extra
-          witness = { word: word ?? [], reason: missing !== undefined ? 'accepted by the first automaton, rejected by the second' : 'accepted by the second automaton, rejected by the first' }
-          findings.push({ code: 'AUT006_NOT_EQUIVALENT', severity: 'error', message: 'the two automata accept different languages', detail: `shortest witness: ${word === undefined || word.length === 0 ? 'the empty word' : word.join(' ')}; ${witness.reason}` })
+        if (missing !== undefined) {
+          witness = { word: missing, reason: 'accepted by the first automaton, rejected by the second' }
+          findings.push({ code: 'AUT006_NOT_EQUIVALENT', severity: 'error', message: 'the two automata accept different languages', detail: `shortest witness: ${missing.length === 0 ? 'the empty word' : missing.join(' ')}; ${witness.reason}` })
+        } else if (extra !== undefined) {
+          witness = { word: extra, reason: 'accepted by the second automaton, rejected by the first' }
+          findings.push({ code: 'AUT006_NOT_EQUIVALENT', severity: 'error', message: 'the two automata accept different languages', detail: `shortest witness: ${extra.length === 0 ? 'the empty word' : extra.join(' ')}; ${witness.reason}` })
         }
       } else if (relation === 'subset') {
         if (missing !== undefined) {
@@ -338,11 +338,12 @@ export function verifyAutomaton(input: unknown, options: { other?: unknown; rela
     }
   }
 
-  const errors = findings.filter((finding) => finding.severity === 'error').length
+  const errorFindings = findings.filter((finding) => finding.severity === 'error')
+  const errors = errorFindings.length
   const warnings = findings.filter((finding) => finding.severity === 'warning').length
   const verdict = errors > 0 ? 'fail' : warnings > 0 ? 'pass_with_findings' : 'pass'
   const reason = errors > 0
-    ? `${String(errors)} error finding(s) (first: ${findings.find((finding) => finding.severity === 'error')?.code ?? 'unknown'})`
+    ? `${String(errors)} error finding(s) (first: ${errorFindings[0].code})`
     : warnings > 0
       ? `no error findings; ${String(warnings)} warning finding(s)`
       : 'every check passed'

package/src/compose-tool.ts

@@ -1,7 +1,7 @@
 import { defineTool } from '@deepseek-ai/dsh-tools'
 import type { JsonValue } from './json-value.js'
 import { runCompositionVerification } from './engine.js'
-import { reportCard, reportResultView } from './presentation.js'
+import { reportCallView, reportCard, reportResultView } from './presentation.js'
 import type { SharedAccess, SharedLocation } from './engine.js'
 import { OptionShapeError, optionRefusal, requireArrayOption } from './option-shape.js'
 import { renderReportText } from './report-view.js'
@@ -61,7 +61,9 @@ export const modelComposeTool = defineTool({
     presentationMeta(_args, value) {
       return reportCard(value, COMPOSE_TOOL_NAME) as unknown as JsonValue
     },
-  },  presentResult: reportResultView(COMPOSE_TOOL_NAME),
+  },
+  presentCall: reportCallView(COMPOSE_TOOL_NAME),
+  presentResult: reportResultView(COMPOSE_TOOL_NAME),
 
   timeoutMs: 10_000,
   isConcurrencySafe: () => true,

package/src/concurrency-tool.ts

@@ -2,7 +2,7 @@ import { defineTool } from '@deepseek-ai/dsh-tools'
 import type { JsonValue } from './json-value.js'
 import { runConcurrencyScan } from './concurrency.js'
 import { renderReportText } from './report-view.js'
-import { reportCard, reportResultView } from './presentation.js'
+import { reportCallView, reportCard, scanResultView } from './presentation.js'
 
 export const INTERLEAVING_SCAN_TOOL_NAME = 'model_interleaving_scan'
 
@@ -40,7 +40,9 @@ export const modelConcurrencyScanTool = defineTool({
     presentationMeta(_args, value) {
       return reportCard(value, INTERLEAVING_SCAN_TOOL_NAME) as unknown as JsonValue
     },
-  },  presentResult: reportResultView(INTERLEAVING_SCAN_TOOL_NAME),
+  },
+  presentCall: reportCallView(INTERLEAVING_SCAN_TOOL_NAME),
+  presentResult: scanResultView,
 
   timeoutMs: 10_000,
   isConcurrencySafe: () => true,

package/src/data-tool.ts

@@ -4,7 +4,7 @@ import { runDataVerification, DATA_ENGINE_SCHEMA_VERSION } from './data-engine.j
 import { oneOf } from './model-file.js'
 import { optionRefusal, requireArrayOption, requireObjectOption } from './option-shape.js'
 import { renderReportText } from './report-view.js'
-import { reportCard, reportResultView } from './presentation.js'
+import { reportCallView, reportCard, reportResultView } from './presentation.js'
 
 export const DATAMODEL_VERIFY_TOOL_NAME = 'model_datamodel_verify'
 
@@ -69,7 +69,9 @@ export const modelDataModelVerifyTool = defineTool({
     presentationMeta(_args, value) {
       return reportCard(value, DATAMODEL_VERIFY_TOOL_NAME) as unknown as JsonValue
     },
-  },  presentResult: reportResultView(DATAMODEL_VERIFY_TOOL_NAME),
+  },
+  presentCall: reportCallView(DATAMODEL_VERIFY_TOOL_NAME),
+  presentResult: reportResultView(DATAMODEL_VERIFY_TOOL_NAME),
 
   timeoutMs: 10_000,
   isConcurrencySafe: () => true,

package/src/design-tool.ts

@@ -1,7 +1,7 @@
 import { defineTool } from '@deepseek-ai/dsh-tools'
 import type { JsonValue } from './json-value.js'
 import { REPORT_SCHEMAS } from './engine.js'
-import { reportCard, reportResultView } from './presentation.js'
+import { designResultView, reportCallView, reportCard } from './presentation.js'
 import { oneOf } from './model-file.js'
 import { runDesignReview } from './design-engine.js'
 import { renderReportText } from './report-view.js'
@@ -53,7 +53,9 @@ export const designTool = defineTool({
     presentationMeta(_args, value) {
       return reportCard(value, DESIGN_TOOL_NAME) as unknown as JsonValue
     },
-  },  presentResult: reportResultView(DESIGN_TOOL_NAME),
+  },
+  presentCall: reportCallView(DESIGN_TOOL_NAME),
+  presentResult: designResultView,
 
   timeoutMs: 10_000,
   isConcurrencySafe: () => true,

package/src/edit-tool.ts

@@ -14,7 +14,7 @@ import { defineTool } from '@deepseek-ai/dsh-tools'
 import { diffReports } from './baseline.js'
 import { applyEdits, readModelFile } from './editor.js'
 import { REPORT_SCHEMAS, runVerification } from './engine.js'
-import { reportCard, reportResultView } from './presentation.js'
+import { editResultView, reportCallView, reportCard } from './presentation.js'
 import type { JsonValue } from './json-value.js'
 import { optionRefusal } from './option-shape.js'
 import { renderReportText } from './report-view.js'
@@ -66,7 +66,9 @@ export const modelEditTool = defineTool({
     presentationMeta(_args, value) {
       return reportCard(value, MODEL_EDIT_TOOL_NAME) as unknown as JsonValue
     },
-  },  presentResult: reportResultView(MODEL_EDIT_TOOL_NAME),
+  },
+  presentCall: reportCallView(MODEL_EDIT_TOOL_NAME),
+  presentResult: editResultView(MODEL_EDIT_TOOL_NAME),
 
   timeoutMs: 20_000,
   isConcurrencySafe: () => false,

package/src/export-tool.ts

@@ -1,7 +1,7 @@
 import { defineTool } from '@deepseek-ai/dsh-tools'
 import type { JsonValue } from './json-value.js'
 import { REPORT_SCHEMAS, DEFAULT_HASH_SPEC, modelHash, refusalVerdict, validateModel, verdictOf } from './engine.js'
-import { reportCard, reportResultView } from './presentation.js'
+import { cardWithSource, reportCallView, reportCard, reportResultView } from './presentation.js'
 import { ExportError, exportModel, type ExportFormat } from './exporters.js'
 import { renderReportText } from './report-view.js'
 
@@ -52,9 +52,12 @@ export const modelExportTool = defineTool({
     },
     // The card a UI shows, separated from the text the model reads.
     presentationMeta(_args, value) {
-      return reportCard(value, EXPORT_TOOL_NAME) as unknown as JsonValue
+      const report = value as Record<string, unknown>
+      return cardWithSource(value, EXPORT_TOOL_NAME, typeof report.primary === 'string' ? report.primary : undefined, typeof report.format === 'string' ? 'artifact: ' + report.format : 'artifact') as unknown as JsonValue
     },
-  },  presentResult: reportResultView(EXPORT_TOOL_NAME),
+  },
+  presentCall: reportCallView(EXPORT_TOOL_NAME),
+  presentResult: reportResultView(EXPORT_TOOL_NAME),
 
   timeoutMs: 10_000,
   isConcurrencySafe: () => true,