dsh-mobilecode 0.7.0 → 0.7.1

package/README.md

@@ -202,7 +202,9 @@ classified adb boundary (argv-based, quoted, replay-safe):
 - `device_backtrace` — a thread/crash dump without a debugger: sends SIGQUIT
   (`kill -3`), waits for ART to write the trace, reads the newest `/data/anr`
   entry, and falls back to the logcat crash buffer when `/data/anr` is unreadable
-  (`engine: "anr-trace" | "logcat-crash"`). Pass `package_name` or `pid`.
+  (`engine: "anr-trace" | "logcat-crash"`). SIGQUIT refusal (system-uid or
+  non-debuggable process) degrades to the crash buffer with an explanatory note
+  instead of failing. Pass `package_name` or `pid`.
 
 **Conversation surface (v0.7.0)** — the transcript integration ported from
 dsh-android's UI/UX:

package/lib/index.js

@@ -531,6 +531,10 @@ function makeRoutes(engine, config, stream) {
         const argv = DEVICE_ACTIONS[action]
         if (argv === undefined) { writeJson(res, 400, { code: 'unknown_action', error: `unknown device action "${action}"` }); return }
         if (!StreamAccess.SERIAL_PATTERN.test(serial)) { writeJson(res, 400, { code: 'bad_request', error: 'device must be an adb device serial' }); return }
+        if (serial !== stream.host.streamedSerial) {
+          const online = await stream.host.listDevices()
+          if (!online.some((device) => device.serial === serial)) { writeJson(res, 409, { code: 'device_not_found', error: `device ${serial} is not online` }); return }
+        }
         try {
           await DeviceBuild.adbRun(serial, ['shell', ...argv])
           writeJson(res, 200, { ok: true, action, device: serial })
@@ -1647,7 +1651,8 @@ function deviceBacktraceTool() {
     name: 'device_backtrace',
     description: 'Capture a native/ANR thread backtrace or crash log for an app on the device. Sends SIGQUIT (kill -3) to the process, ' +
       'waits for the ART runtime to write the thread dump, then reads the newest /data/anr entry. When /data/anr is unrunnable it falls ' +
-      'back to the logcat crash buffer and says so (engine field: "anr-trace" | "logcat-crash"). Pass package_name or pid.',
+      'back to the logcat crash buffer and says so (engine field: "anr-trace" | "logcat-crash"). SIGQUIT refusal (system-uid or ' +
+      'non-debuggable process) degrades to the crash buffer with an explanatory note instead of failing. Pass package_name or pid.',
     parameters: {
       serial: { type: 'string', description: 'Android device serial. Omit to use the first attached device.' },
       package_name: { type: 'string', description: 'Package of the process to trace (e.g. com.simspoof.app).' },
@@ -1695,22 +1700,32 @@ function deviceBacktraceTool() {
       if (pid === undefined) {
         throw new Error(`device_backtrace could not resolve a running process for ${packageName ? `"${packageName}"` : 'the request'} on ${serial} — pass a package_name of a running app, or an explicit pid.`)
       }
-      // SIGQUIT: the ART runtime writes the thread dump to /data/anr/.
-      await DeviceBuild.adbRun(serial, ['shell', 'kill', '-3', String(pid)])
-      await new Promise((resolve) => setTimeout(resolve, 1200))
-      const listing = await DeviceBuild.adbRun(serial, ['shell', 'ls', '-t', '/data/anr']).catch(() => undefined)
-      const newest = (listing ?? '').split(/\r?\n/).map((line) => line.trim()).filter((line) => line !== '' && !line.includes(' '))[0]
-      if (newest !== undefined) {
-        const content = await DeviceBuild.adbRun(serial, ['shell', 'cat', DeviceBuild.shQuoteDevice(`/data/anr/${newest}`)], { timeoutMs: 30_000 }).catch(() => undefined)
-        if (content !== undefined && content.trim() !== '') {
-          return DeviceBuild.jsonSafe({
-            serial,
-            engine: 'anr-trace',
-            ...(packageName ? { package_name: packageName } : {}),
-            pid,
-            trace_path: `/data/anr/${newest}`,
-            lines: content.split(/\r?\n/).slice(-250),
-          })
+      // SIGQUIT: the ART runtime writes the thread dump to /data/anr/. The adb
+      // shell user cannot signal system-uid / non-debuggable processes on
+      // enforcing builds (EPERM) — degrade honestly instead of throwing.
+      let sigquit = true
+      try {
+        await DeviceBuild.adbRun(serial, ['shell', 'kill', '-3', String(pid)])
+      } catch {
+        sigquit = false
+      }
+      let newest
+      if (sigquit) {
+        await new Promise((resolve) => setTimeout(resolve, 1200))
+        const listing = await DeviceBuild.adbRun(serial, ['shell', 'ls', '-t', '/data/anr']).catch(() => undefined)
+        newest = (listing ?? '').split(/\r?\n/).map((line) => line.trim()).filter((line) => line !== '' && !line.includes(' '))[0]
+        if (newest !== undefined) {
+          const content = await DeviceBuild.adbRun(serial, ['shell', 'cat', DeviceBuild.shQuoteDevice(`/data/anr/${newest}`)], { timeoutMs: 30_000 }).catch(() => undefined)
+          if (content !== undefined && content.trim() !== '') {
+            return DeviceBuild.jsonSafe({
+              serial,
+              engine: 'anr-trace',
+              ...(packageName ? { package_name: packageName } : {}),
+              pid,
+              trace_path: `/data/anr/${newest}`,
+              lines: content.split(/\r?\n/).slice(-250),
+            })
+          }
         }
       }
       // Fallback: the logcat crash buffer (FATAL/AndroidRuntime lines), filtered by package when known.
@@ -1724,7 +1739,9 @@ function deviceBacktraceTool() {
           engine: 'logcat-crash',
           ...(packageName ? { package_name: packageName } : {}),
           pid,
-          note: `SIGQUIT sent to pid ${pid}; /data/anr was ${newest === undefined ? 'empty/unreadable' : `read but produced no content for ${newest}`}; the logcat crash buffer has no matching FATAL lines now. The app may not have crashed — check device_log for the main buffer.`,
+          note: sigquit
+            ? `SIGQUIT sent to pid ${pid}; /data/anr was ${newest === undefined ? 'empty/unreadable' : `read but produced no content for ${newest}`}; the logcat crash buffer has no matching FATAL lines now. The app may not have crashed — check device_log for the main buffer.`
+            : `SIGQUIT refused for pid ${pid} — the adb shell user cannot signal this process (system uid or non-debuggable app on an enforcing build), so no fresh thread dump exists; the logcat crash buffer has no matching FATAL lines either. Target a debuggable app for a live dump, or use an adb-rooted device.`,
           lines: [],
         })
       }

package/lib/list-rows.js

@@ -140,6 +140,10 @@ export function parseCounters(label) {
     const rawKey = match[3].trim()
     if (rawKey === "") continue
     const key = normalizeCountKey(rawKey)
+    // A counter key must contain a letter: serial-ish strings like
+    // "sdk_gphone64_x86_64" backtrack to punctuation-only keys ("_") that are
+    // never real counters.
+    if (!/\p{L}/u.test(key)) continue
     if (seen.has(key)) continue
     seen.add(key)
     counters.push({ key, value: number * multiplier, raw: match[0].trim() })

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "dsh-mobilecode",
-  "description": "MobileCode for the dsh web GUI: detect iOS/Android projects, run preview servers, and drive the simulator/emulator from the session — 24 agent tools (device_run, device_screen, device_ui_tree, device_tap_element, device_wait_for, device_scroll_to, device_input, device_intent, device_connect, device_pair_qr, device_perf, device_app_info, device_install, device_uninstall, device_reboot, device_log, live screen stream, multimodal screenshots) with one classified adb boundary and a Wi-Fi connect/pair QR flow in the Connection settings tab. Hot-pluggable — mounted via the profile bundle list + cordis.patch.yml, no dsh source changes.",
-  "version": "0.7.0",
+  "description": "MobileCode for the dsh web GUI: detect iOS/Android projects, run preview servers, and drive the simulator/emulator from the session — 28 agent tools (device_run, device_screen, device_ui_tree, device_ui_rows, device_tap_row, device_tap_element, device_wait_for, device_scroll_to, device_input, device_intent, device_connect, device_pair_qr, device_perf, device_meminfo, device_backtrace, device_app_info, device_install, device_uninstall, device_reboot, device_log, live screen stream, multimodal screenshots) with one classified adb boundary and a Wi-Fi connect/pair QR flow in the Connection settings tab. Hot-pluggable — mounted via the profile bundle list + cordis.patch.yml, no dsh source changes.",
+  "version": "0.7.1",
   "type": "module",
   "packageManager": "pnpm@11.22.0",
   "engines": {