dsh-mnemon 0.5.8 → 0.5.10

package/lib/index.js

@@ -20,6 +20,11 @@ import { spawn } from "node:child_process";
 import { StringDecoder } from "node:string_decoder";
 import { z as z$1 } from "zod";
 import { Remote, TypertRemoteService } from "@deepseek-ai/dsh-typert-protocol";
+//#region src/host/view-protocol.ts
+const MNEMON_VIEW_CHANNEL = "/dsh-mnemon-view";
+const MNEMON_VIEW_WRITE_CHANNEL = "/dsh-mnemon-view-settings";
+const MNEMON_VIEW_SETTINGS_NAMESPACE = "mnemon-view";
+//#endregion
 //#region src/host/display-mode.ts
 /** Keep the historical misspelling at input boundaries, never in UI or runtime state. */
 function normalizeDisplayMode(value) {
@@ -28,11 +33,6 @@ function normalizeDisplayMode(value) {
 	throw new Error("dsh-mnemon: displayMode must be sidebar or builtin (legacy buildin is accepted)");
 }
 //#endregion
-//#region src/host/view-protocol.ts
-const MNEMON_VIEW_CHANNEL = "/dsh-mnemon-view";
-const MNEMON_VIEW_WRITE_CHANNEL = "/dsh-mnemon-view-settings";
-const MNEMON_VIEW_SETTINGS_NAMESPACE = "mnemon-view";
-//#endregion
 //#region src/host/protocol.ts
 /** Starter Entry ids remain reserved when DSH nests them under an include. */
 function isDefaultSourceInstance(instanceKey, sourceTypeId) {
@@ -48,6 +48,15 @@ const MNEMON_SETTINGS_NAMESPACE = "mnemon";
 function isWorkspaceStorageScope(scope) {
 	return scope === "workspace" || scope === "workspaces";
 }
+const DEFAULT_IDLE_REVIEW = {
+	enabled: true,
+	provider: "spawn",
+	fallback: "spawn",
+	minIntervalMs: 3e5,
+	maxPerSession: 20,
+	maxContextChars: 24e3,
+	maxTokens: 4096
+};
 const CATEGORIES = [
 	"preference",
 	"decision",
@@ -151,6 +160,15 @@ const RuntimeMemorySchema = z.object({
 	userLimitBytes: z.number().step(1).min(1).max(MAX_RUNTIME_MEMORY_LIMIT_BYTES).default(DEFAULT_RUNTIME_USER_LIMIT_BYTES),
 	maintenanceMaxTokens: z.number().step(1).min(1).max(MAX_RUNTIME_MAINTENANCE_MAX_TOKENS).default(DEFAULT_RUNTIME_MAINTENANCE_MAX_TOKENS)
 });
+const IdleReviewSchema = z.object({
+	enabled: z.boolean().default(DEFAULT_IDLE_REVIEW.enabled),
+	provider: z.union(["spawn", "fork"]).default(DEFAULT_IDLE_REVIEW.provider),
+	fallback: z.union(["spawn", "skip"]).default(DEFAULT_IDLE_REVIEW.fallback),
+	minIntervalMs: z.number().step(1).min(5e3).max(864e5).default(DEFAULT_IDLE_REVIEW.minIntervalMs),
+	maxPerSession: z.number().step(1).min(0).max(200).default(DEFAULT_IDLE_REVIEW.maxPerSession),
+	maxContextChars: z.number().step(1).min(1e3).max(1e6).default(DEFAULT_IDLE_REVIEW.maxContextChars),
+	maxTokens: z.number().step(1).min(128).max(131072).default(DEFAULT_IDLE_REVIEW.maxTokens)
+});
 const MemoryParticipationModeSchema = z.union([
 	"off",
 	"manual",
@@ -224,6 +242,7 @@ const Config = z.object({
 	recallMode: z.union(["guided", "off"]).default("guided"),
 	writebackMode: z.union(["guided", "off"]).default("guided"),
 	idleReviewMs: z.number().step(1).min(5e3).max(6e5).default(DEFAULT_IDLE_REVIEW_MS),
+	idleReview: IdleReviewSchema.default(DEFAULT_IDLE_REVIEW),
 	conversationInteraction: z.object({
 		toolviews: z.boolean().default(false),
 		turnBar: z.boolean().default(true),
@@ -394,6 +413,7 @@ function resolveConfig(config = {}) {
 		recallMode: config.recallMode ?? "guided",
 		writebackMode: config.writebackMode ?? "guided",
 		idleReviewMs: config.idleReviewMs ?? 3e4,
+		idleReview: IdleReviewSchema(config.idleReview ?? {}),
 		conversationInteraction: {
 			toolviews: config.conversationInteraction?.toolviews ?? false,
 			turnBar: config.conversationInteraction?.turnBar ?? true,
@@ -424,7 +444,7 @@ const COMPONENT_ORDER = [
 ];
 const BODY_ID = /^[a-zA-Z0-9][a-zA-Z0-9_-]*$/;
 const SQLITE_HEADER = Buffer.from("SQLite format 3\0", "binary");
-function record$2(value) {
+function record$3(value) {
 	return typeof value === "object" && value !== null && !Array.isArray(value) ? value : void 0;
 }
 function utf8(bytes, label) {
@@ -467,7 +487,7 @@ function componentsForScope(scope) {
 	return [scope];
 }
 function parseManifest(value) {
-	const manifest = record$2(value);
+	const manifest = record$3(value);
 	if (manifest?.format !== "mnemonpack" || manifest.version !== 1) throw new Error("unsupported Mnemon Pack format or version");
 	if (manifest.scope !== "full" && !COMPONENT_ORDER.includes(manifest.scope)) throw new Error("Mnemon Pack scope is invalid");
 	if (typeof manifest.exportedAt !== "string") throw new Error("Mnemon Pack exportedAt is invalid");
@@ -476,11 +496,11 @@ function parseManifest(value) {
 	if (components.length === 0 || new Set(components).size !== components.length || components.some((component) => !COMPONENT_ORDER.includes(component))) throw new Error("Mnemon Pack components are invalid");
 	const expected = componentsForScope(manifest.scope);
 	if (components.length !== expected.length || expected.some((component) => !components.includes(component))) throw new Error("Mnemon Pack scope does not match its components");
-	const source = record$2(manifest.source);
+	const source = record$3(manifest.source);
 	if (source?.plugin !== "dsh-mnemon" || typeof source.pluginVersion !== "string") throw new Error("Mnemon Pack source is invalid");
 	if (!Array.isArray(manifest.summary)) throw new Error("Mnemon Pack summary is invalid");
 	const summary = manifest.summary.map((entry) => {
-		const item = record$2(entry);
+		const item = record$3(entry);
 		const component = item?.component;
 		if (!COMPONENT_ORDER.includes(component) || !Number.isSafeInteger(item?.files) || !Number.isSafeInteger(item?.bytes) || !Number.isSafeInteger(item?.items) || Number(item?.files) < 0 || Number(item?.bytes) < 0 || Number(item?.items) < 0) throw new Error("Mnemon Pack summary entry is invalid");
 		return {
@@ -530,8 +550,8 @@ function parseArchive(base64, runtimeLimits = RUNTIME_MEMORY_LIMITS) {
 		if (path !== "manifest.json" && path !== "checksums.json" && !allowedPayloadPath(path)) throw new Error(`unsupported Mnemon Pack entry: ${path}`);
 	}
 	const manifest = parseManifest(json$1(files["manifest.json"], "manifest.json"));
-	const checksumValue = record$2(json$1(files["checksums.json"], "checksums.json"));
-	const checksumFiles = record$2(checksumValue?.files);
+	const checksumValue = record$3(json$1(files["checksums.json"], "checksums.json"));
+	const checksumFiles = record$3(checksumValue?.files);
 	if (checksumValue?.algorithm !== "sha256" || checksumFiles === void 0) throw new Error("Mnemon Pack checksums are invalid");
 	const payloadNames = names.filter((path) => path.startsWith("payload/")).sort();
 	if (Object.keys(checksumFiles).length !== payloadNames.length) throw new Error("Mnemon Pack checksum inventory does not match the payload");
@@ -554,10 +574,10 @@ function parseArchive(base64, runtimeLimits = RUNTIME_MEMORY_LIMITS) {
 	};
 }
 function parseRuntime(value, limits = RUNTIME_MEMORY_LIMITS) {
-	const source = record$2(value);
+	const source = record$3(value);
 	if (source?.version !== RUNTIME_MEMORY_VERSION || !Array.isArray(source.entries)) throw new Error("runtime memories.json is invalid");
 	const entries = source.entries.map((raw) => {
-		const entry = record$2(raw);
+		const entry = record$3(raw);
 		if (typeof entry?.content !== "string" || entry.target !== "memory" && entry.target !== "user" || ![
 			"critical",
 			"normal",
@@ -588,13 +608,13 @@ function runtimeProjection(entries, target) {
 	return content === "" ? "" : `${content}\n`;
 }
 function parseDocumentIndex(value) {
-	const index = record$2(value);
+	const index = record$3(value);
 	if (index?.version !== DOCUMENTS_VERSION || !Array.isArray(index.documents)) throw new Error("Documents index.json is invalid");
 	const ids = /* @__PURE__ */ new Set();
 	return {
 		version: 1,
 		documents: index.documents.map((raw) => {
-			const item = record$2(raw);
+			const item = record$3(raw);
 			if (typeof item?.id !== "string" || item.id.trim() === "" || ids.has(item.id)) throw new Error("Documents index contains an invalid or duplicate id");
 			if (typeof item.title !== "string" || typeof item.description !== "string" || item.status !== "active" && item.status !== "archived") throw new Error("Documents index contains an invalid record");
 			if (typeof item.filename !== "string" || basename(item.filename) !== item.filename || !/^[a-zA-Z0-9._-]+\.md$/u.test(item.filename)) throw new Error("Documents index contains an unsafe filename");
@@ -624,13 +644,13 @@ function parseDocumentIndex(value) {
 	};
 }
 function parseRegistry(value) {
-	const registry = record$2(value);
+	const registry = record$3(value);
 	if (registry?.version !== 1 || !Array.isArray(registry.bodies)) throw new Error("Memory Space registry is invalid");
 	const ids = /* @__PURE__ */ new Set();
 	return {
 		version: 1,
 		bodies: registry.bodies.map((raw) => {
-			const body = record$2(raw);
+			const body = record$3(raw);
 			if (typeof body?.id !== "string" || !BODY_ID.test(body.id) || ids.has(body.id)) throw new Error("Memory Space registry contains an invalid or duplicate id");
 			if (typeof body.name !== "string" || body.name.trim() === "" || body.name.length > 100 || typeof body.description !== "string" || body.description.length > 1e3) throw new Error("Memory Space registry contains invalid metadata");
 			if (typeof body.createdAt !== "string" || typeof body.updatedAt !== "string") throw new Error("Memory Space registry contains invalid timestamps");
@@ -1263,7 +1283,7 @@ function safeBytes(path) {
 function readJson(path) {
 	return JSON.parse(readFileSync(path, "utf8"));
 }
-function record$1(value) {
+function record$2(value) {
 	return typeof value === "object" && value !== null && !Array.isArray(value) ? value : void 0;
 }
 function missing(kind, path) {
@@ -1281,9 +1301,9 @@ function runtimeArea(root) {
 	const source = join(path, "memories.json");
 	if (!existsSync(source)) return missing("runtime", path);
 	try {
-		const file = record$1(readJson(source));
+		const file = record$2(readJson(source));
 		if (file === void 0 || !Array.isArray(file.entries)) throw new Error("memories.json is not a valid runtime-memory source");
-		const entries = file.entries.map(record$1).filter((entry) => entry !== void 0);
+		const entries = file.entries.map(record$2).filter((entry) => entry !== void 0);
 		const userEntries = entries.filter((entry) => entry.target === "user").length;
 		const memoryEntries = entries.filter((entry) => entry.target === "memory").length;
 		const projectionsHealthy = existsSync(join(path, "USER.md")) && existsSync(join(path, "MEMORY.md"));
@@ -1318,8 +1338,8 @@ function memorySpacesArea(root) {
 	if (!existsSync(path)) return missing("memory-bodies", path);
 	try {
 		const registryPath = join(path, ".dsh-memory-bodies.json");
-		const registry = existsSync(registryPath) ? record$1(readJson(registryPath)) : void 0;
-		const bodies = Array.isArray(registry?.bodies) ? registry.bodies.map(record$1).filter((body) => body !== void 0) : [];
+		const registry = existsSync(registryPath) ? record$2(readJson(registryPath)) : void 0;
+		const bodies = Array.isArray(registry?.bodies) ? registry.bodies.map(record$2).filter((body) => body !== void 0) : [];
 		const databaseCount = readdirSync(path, { withFileTypes: true }).filter((entry) => entry.isDirectory() && existsSync(join(path, entry.name, "mnemon.db"))).length;
 		const activeCount = bodies.filter((body) => body.active === true).length;
 		const invalidRegistry = existsSync(registryPath) && (registry?.version !== 1 || !Array.isArray(registry.bodies));
@@ -1354,9 +1374,9 @@ function documentsArea(root) {
 	const indexPath = join(path, "index.json");
 	if (!existsSync(indexPath)) return missing("documents", path);
 	try {
-		const index = record$1(readJson(indexPath));
+		const index = record$2(readJson(indexPath));
 		if (index === void 0 || !Array.isArray(index.documents)) throw new Error("index.json is not a valid Documents index");
-		const documents = index.documents.map(record$1).filter((document) => document !== void 0);
+		const documents = index.documents.map(record$2).filter((document) => document !== void 0);
 		const active = documents.filter((document) => document.status === "active").length;
 		const archived = documents.filter((document) => document.status === "archived").length;
 		return {
@@ -1392,9 +1412,9 @@ function stateArea(root) {
 		let providerConnections = 0;
 		let providerServices = 0;
 		if (existsSync(providerRegistry)) try {
-			const registry = record$1(readJson(providerRegistry));
+			const registry = record$2(readJson(providerRegistry));
 			providerConnections = Array.isArray(registry?.bodies) ? registry.bodies.length : 0;
-			providerServices = record$1(registry?.services) === void 0 ? 0 : Object.keys(record$1(registry?.services)).length;
+			providerServices = record$2(registry?.services) === void 0 ? 0 : Object.keys(record$2(registry?.services)).length;
 		} catch {}
 		return {
 			kind: "state",
@@ -2615,12 +2635,21 @@ function hostSessionEventAt(session, seq) {
 //#region src/host/review-tools.ts
 const startingReview = new AsyncLocalStorage();
 /**
+* The published Agent Teams alpha.2 tool suite installs its policy before a
+* provider publishes a child descriptor. Both rc.2 in-process providers then
+* lose membership on step two. Inspect public services/capabilities only and
+* skip before creating a child; do not remove another plugin's policy.
+*/
+function idleReviewBlockReason(parent) {
+	return parent.ctx?.get?.("agentTeams") !== void 0 && parent.ctx.tools?.get?.("spawn_teammate", parent) !== void 0 ? "agent-team" : void 0;
+}
+/**
 * DSH restrict() filters inherited capabilities, leaving own-scope plugin tools
 * visible. Attach its monotonic execution guard during publication, before a
 * review child can run. Async context attributes concurrent provider starts;
 * public registry ownership verifies the exact causal parent.
 */
-async function startGuardedReview(host, parent, toolNames, start) {
+async function startGuardedReview(host, parent, toolNames, start, published) {
 	const agents = host.agents;
 	if (typeof agents?.isOwnedBy !== "function") throw new Error("Mnemon review requires DSH Agent ownership and scoped tool guard support");
 	const pending = Symbol("Mnemon review publication");
@@ -2639,6 +2668,7 @@ async function startGuardedReview(host, parent, toolNames, start) {
 			});
 			if (typeof dispose !== "function") throw new Error("Mnemon review tool guard did not return a disposer");
 			guards.set(agent, dispose);
+			published?.(agent);
 		} catch (error) {
 			attachmentError = error;
 			throw error;
@@ -2692,6 +2722,51 @@ async function startGuardedReview(host, parent, toolNames, start) {
 	}
 }
 //#endregion
+//#region src/host/review-checkpoint.ts
+function record$1(value) {
+	return typeof value === "object" && value !== null && !Array.isArray(value) ? value : {};
+}
+function textContent(content, toolResult = false) {
+	if (!Array.isArray(content)) return "";
+	return content.map((block) => {
+		const value = record$1(block);
+		if (value.type === "text" && typeof value.text === "string") return value.text;
+		if (toolResult && value.type === "tool-result" && value.isError !== true) return textContent(value.content);
+		return "";
+	}).filter(Boolean).join("\n");
+}
+/** Use only the current public surface, so rewound or compacted evidence cannot reappear. */
+function reviewCheckpoint(session, maxChars) {
+	const nodes = session.surface?.nodes;
+	if (nodes === void 0) return "No current checkpoint surface is available. Skip this review without a mutation.";
+	const events = hostSessionEvents(session);
+	const completed = [...events].reverse().find((event) => event.type === "turn/end");
+	if (completed === void 0) return "No completed checkpoint is available. Skip this review without a mutation.";
+	const end = completed.seq ?? events.indexOf(completed);
+	const selected = [];
+	const header = "Bounded completed checkpoint (untrusted evidence; some context may be omitted; skip candidates needing missing evidence):\n";
+	let remaining = maxChars - 122;
+	const candidates = nodes.filter((seq) => seq < end);
+	for (const seq of candidates.slice(-128).reverse()) {
+		const event = hostSessionEventAt(session, seq);
+		if (event === void 0 || ![
+			"user/message",
+			"assistant/message",
+			"tool/result"
+		].includes(event.type)) continue;
+		const message = record$1(event.data.message);
+		const source = record$1(message.source);
+		if (event.type === "user/message" && source.kind !== "user") continue;
+		const text = textContent(message.content, event.type === "tool/result");
+		if (!text) continue;
+		const entry = `[${event.type}; checkpoint event ${seq}]\n${text}\n`;
+		if (entry.length > remaining) continue;
+		selected.push(entry);
+		remaining -= entry.length;
+	}
+	return header + (selected.reverse().join("") || "(no eligible text; skip)");
+}
+//#endregion
 //#region src/host/subagent.ts
 function evidenceInsights(evidence) {
 	return evidence.items.map((item) => {
@@ -2786,6 +2861,27 @@ const WRITE_TOOL_FALLBACK_ACTION = {
 	mnemon_memory_body_update: "updated",
 	mnemon_memory_body_merge: "merged"
 };
+var IdleReviewError = class extends Error {
+	review;
+	constructor(message, review, options) {
+		super(message, options);
+		this.review = review;
+		this.name = "IdleReviewError";
+	}
+};
+function reviewReceipt(receipt) {
+	if (!mutationResultCommitted(receipt.value)) return void 0;
+	const value = object$4(receipt.value);
+	const args = optionalObject(receipt.arguments);
+	const document = optionalObject(value.document);
+	return {
+		tool: receipt.name,
+		action: typeof value.action === "string" ? value.action : "committed",
+		...typeof document?.id === "string" ? { documentId: document.id } : {},
+		...typeof args?.target === "string" ? { target: args.target } : {},
+		...typeof value.revision === "string" ? { revision: value.revision } : {}
+	};
+}
 const WRITE_SCHEMA = {
 	type: "object",
 	properties: {
@@ -3727,7 +3823,11 @@ var MnemonSubagentCoordinator = class {
 		return {
 			source,
 			cleanup,
-			memoryBodyIds: new Set(strings(object$4(grant.value).memoryBodyIds))
+			memoryBodyIds: new Set(strings(object$4(grant.value).memoryBodyIds)),
+			writeScope: {
+				viewId: view.id,
+				grant
+			}
 		};
 	}
 	runtimeModel(scope, parent, signal, operation, label, prompt, schema, persona) {
@@ -3781,7 +3881,28 @@ ${naturalRequest(request)}`;
 		};
 	}
 	async review(parent, signal) {
-		const { provider, runId, result } = await this.delegate(parent, "review", "Mnemon idle checkpoint review", "Review the inherited completed checkpoint now.", REVIEW_TOOLS, WRITE_SCHEMA, signal, "fork", REVIEW_PERSONA);
+		if (idleReviewBlockReason(parent) !== void 0) return {
+			delegated: false,
+			action: "skipped",
+			summary: "Idle review is paused while Agent Teams tools are active because the published child policy is incompatible.",
+			documentIds: []
+		};
+		const config = this.runtimeSource.config.idleReview;
+		let preferred = config.provider;
+		if (preferred === "fork") try {
+			this.provider("fork");
+		} catch (error) {
+			if (config.fallback === "skip") return {
+				delegated: false,
+				action: "skipped",
+				summary: "Fork provider unavailable; idle review skipped.",
+				documentIds: []
+			};
+			preferred = "spawn";
+		}
+		const prompt = preferred === "fork" ? "Review the inherited completed checkpoint now." : reviewCheckpoint(parent.session, config.maxContextChars);
+		const persona = preferred === "fork" ? REVIEW_PERSONA : REVIEW_PERSONA.replaceAll("inherited", "supplied bounded");
+		const { provider, runId, result } = await this.delegate(parent, "review", "Mnemon idle checkpoint review", prompt, REVIEW_TOOLS, WRITE_SCHEMA, signal, preferred, persona, { terminalTools: ["mnemon_runtime_memory", "mnemon_document_create"] });
 		const value = object$4(result.structured);
 		return {
 			delegated: true,
@@ -3973,13 +4094,27 @@ ${naturalRequest(request)}`;
 		if (request.target === "user") return this.compactUserAndCommit(context, request, plan, signal);
 		const archive = await context.memorySpaces();
 		const memoryService = archive.source;
-		const writable = (body) => body.active && body.providerEnabled !== false && body.provider.capabilities.remember === true && (archive.memoryBodyIds === void 0 || archive.memoryBodyIds.has(body.id));
+		let allowed = archive.memoryBodyIds;
+		const readDirectory = async () => {
+			const catalog = await memoryService.read("body-directory", archive.writeScope === void 0 ? null : { writeScope: archive.writeScope }, signal);
+			allowed = archive.memoryBodyIds;
+			if (catalog.writeScope !== void 0) {
+				const scope = catalog.writeScope;
+				if (archive.writeScope === void 0 || scope === null || scope.viewId !== archive.writeScope.viewId || scope.sourceInstanceKey !== archive.writeScope.grant.sourceInstanceKey || !Array.isArray(scope.memoryBodyIds) || scope.memoryBodyIds.length > 1e4 || scope.memoryBodyIds.some((id) => typeof id !== "string" || id.trim() === "" || id !== id.trim())) throw new Error("Runtime archival received an invalid Memory Spaces write scope; pending write was not committed; retry the same request in a new turn");
+				allowed = new Set(scope.memoryBodyIds);
+			}
+			return catalog;
+		};
+		const catalog = await readDirectory();
+		const writable = (body) => body.active && body.providerEnabled !== false && body.provider.capabilities.remember === true && (allowed === void 0 || allowed.has(body.id));
 		const eligible = (body) => writable(body) && body.provider.capabilities.writeMode === "exact" && body.provider.capabilities.forget === true;
-		const catalog = await memoryService.read("body-directory", null, signal);
 		const eligibleBodies = catalog.items.filter(eligible);
 		if (eligibleBodies.length === 0) {
-			const unsupported = catalog.items.filter(writable).map((body) => `${body.id} (provider=${body.provider.id}, writeMode=${body.provider.capabilities.writeMode}, forget=${body.provider.capabilities.forget})`).join(", ");
-			throw new Error(`runtime memory archival requires an existing active writable Memory Space with exact writes and safe forget; activate a supported Memory Space or increase runtimeMemory.memoryLimitBytes${unsupported === "" ? "" : `; unsupported destinations: ${unsupported}`}`);
+			const writableBodies = catalog.items.filter(writable);
+			const unsupported = writableBodies.map((body) => `${body.id} (provider=${body.provider.id}, writeMode=${body.provider.capabilities.writeMode}, forget=${body.provider.capabilities.forget})`).join(", ");
+			const reason = catalog.items.length === 0 ? "Memory Space body-directory is empty" : allowed?.size === 0 ? "current View write scope is empty" : allowed !== void 0 && catalog.items.some((body) => body.active && body.providerEnabled !== false && body.provider.capabilities.remember && !allowed?.has(body.id)) && writableBodies.length === 0 ? "current View write scope excludes the active writable Memory Spaces" : writableBodies.length === 0 ? "no active writable Memory Space in the authorized scope" : "authorized destinations lack exact writes or safe forget";
+			const scope = archive.writeScope === void 0 ? "management" : `${archive.writeScope.grant.sourceInstanceKey}/${catalog.writeScope === void 0 ? "pinned-read" : "source-write"}`;
+			throw new Error(`runtime memory archival requires an existing active writable Memory Space with exact writes and safe forget; ${reason}; scope=${scope}, catalog=${catalog.items.length}, authorized=${allowed?.size ?? "management"}, writable=${writableBodies.length}; pending write was not committed and existing runtime entries are unchanged; retry the same request in a new turn after activating a supported authorized Memory Space, or increase runtimeMemory.memoryLimitBytes${unsupported === "" ? "" : `; unsupported destinations: ${unsupported}`}`);
 		}
 		const eligibleById = new Map(eligibleBodies.map((body) => [body.id, body]));
 		const budget = compactedBudget(plan);
@@ -4043,7 +4178,7 @@ ${chunk.context}
 			...branches === void 0 ? {} : { branches }
 		}));
 		if ((await runtimeMemory.read("maintenance-plan", request, signal)).revision !== plan.revision) throw new Error("runtime memory changed while archival was running; no archive writes were attempted");
-		const destinations = await memoryService.read("body-directory", null, signal);
+		const destinations = await readDirectory();
 		for (const memoryBodyId of new Set(routed.values())) if (!destinations.items.some((body) => body.id === memoryBodyId && eligible(body))) throw new Error(`runtime archive Memory Space ${memoryBodyId} is no longer eligible; no archive writes were attempted`);
 		signal.throwIfAborted();
 		context.assertWritable?.();
@@ -4067,6 +4202,7 @@ ${chunk.context}
 			for (const memoryBodyId of new Set(routed.values())) {
 				signal.throwIfAborted();
 				context.assertWritable?.();
+				if (archive.writeScope !== void 0 && !(await readDirectory()).items.some((body) => body.id === memoryBodyId && eligible(body))) throw new Error(`runtime archive Memory Space ${memoryBodyId} is no longer authorized or eligible; pending write was not committed`);
 				const batch = sources.filter((source) => routed.get(source.index) === memoryBodyId);
 				const written = await memoryService.mutate("remember-many", { requests: batch.map((source) => requests[source.index - 1]) }, signal);
 				for (const [offset, result] of written.entries()) {
@@ -4252,8 +4388,11 @@ ${runtimeSnapshotContext("user", plan.entries)}`;
 		const staged = /* @__PURE__ */ new WeakMap();
 		const recoverableTools = new Set(recovery?.terminalTools ?? []);
 		const committedReceipts = [];
+		const reviewReceipts = [];
+		let reviewChildId;
 		const stagedReceipts = /* @__PURE__ */ new Map();
 		let run;
+		let completed;
 		let failure;
 		let disposeResultObserver;
 		let releaseWorkflow;
@@ -4265,7 +4404,14 @@ ${runtimeSnapshotContext("user", plan.entries)}`;
 			}
 			if (this.disposed) throw new Error("dsh-mnemon subagent coordinator is disposed");
 			const observer = this.resultRuntime.on("tools/result", ((execution, result) => {
-				if (signal.aborted || !this.resultRequests.has(requestId)) return;
+				if (!this.resultRequests.has(requestId)) return;
+				if (operation === "review" && execution.agent?.id === reviewChildId && execution.name !== void 0 && recoverableTools.has(execution.name) && result.isError !== true && Object.hasOwn(result, "value")) reviewReceipts.push({
+					agentId: execution.agent.id,
+					name: execution.name,
+					arguments: execution.arguments,
+					value: result.value
+				});
+				if (signal.aborted) return;
 				if (execution.token !== void 0) {
 					const entries = stagedReceipts.get(execution.token);
 					if (entries !== void 0) {
@@ -4330,7 +4476,7 @@ ${runtimeSnapshotContext("user", plan.entries)}`;
 Completion protocol: call \`${resultToolName}\` exactly once with requestId \`${requestId}\` and result matching this JSON schema:
 ${JSON.stringify(outputSchema)}
 This is the only completion channel for this run. Do not finish with a plain-text answer. The requestId expires when this run finishes or is cancelled.`;
-			const perOpMaxTokens = operation === "migration" || operation === "compaction" ? this.runtimeMaintenanceMaxTokensResolver?.() ?? 8192 : operation === "document-archive" ? 8192 : operation === "metadata-maintenance" ? 4096 : void 0;
+			const perOpMaxTokens = operation === "migration" || operation === "compaction" ? this.runtimeMaintenanceMaxTokensResolver?.() ?? 8192 : operation === "document-archive" ? 8192 : operation === "metadata-maintenance" ? 4096 : operation === "review" ? this.runtimeSource.config.idleReview.maxTokens : void 0;
 			const fixed = this.taskAgentModelResolver?.();
 			const baseAgentOptions = perOpMaxTokens === void 0 ? void 0 : { maxTokens: perOpMaxTokens };
 			const resolvedAgentOptions = fixed === void 0 ? baseAgentOptions : {
@@ -4351,7 +4497,9 @@ This is the only completion channel for this run. Do not finish with a plain-tex
 				toolFilter: { allow: [...tools, resultToolName] },
 				persona: completionPersona
 			});
-			run = operation === "review" ? await startGuardedReview(this.resultRuntime, parent, [...tools, resultToolName], start) : await start();
+			run = operation === "review" ? await startGuardedReview(this.resultRuntime, parent, [...tools, resultToolName], start, (child) => {
+				reviewChildId = child.id;
+			}) : await start();
 			const activeRun = run;
 			const result = await activeRun.result;
 			if (captured !== void 0 && captured.agentId !== activeRun.id) throw new Error("Mnemon subagent result was recorded by a different child");
@@ -4363,11 +4511,12 @@ This is the only completion channel for this run. Do not finish with a plain-tex
 				throw new Error(`memory subagent stopped with ${result.stopReason}${detail === void 0 ? "" : `: ${detail}`}`);
 			}
 			if (structured === void 0) throw new Error("memory subagent completed without recording its result");
-			this.counters[operation === "write" ? "writes" : operation === "review" ? "reviews" : operation === "placement" ? "placements" : operation === "migration" ? "migrations" : operation === "compaction" ? "compactions" : operation === "document-archive" ? "documentArchives" : operation === "metadata-maintenance" ? "metadataMaintenances" : "answers"] += 1;
-			this.counters.lastRunId = activeRun.id;
-			if (operation !== "answer") this.counters.lastOperation = operation;
-			this.counters.lastAt = (/* @__PURE__ */ new Date()).toISOString();
-			return {
+			if (operation === "review" && [
+				"failed",
+				"partial",
+				"unknown"
+			].includes(String(object$4(structured).action))) throw new Error(`memory review reported ${object$4(structured).action}`);
+			completed = {
 				provider,
 				runId: activeRun.id,
 				result: {
@@ -4378,8 +4527,14 @@ This is the only completion channel for this run. Do not finish with a plain-tex
 			};
 		} catch (error) {
 			this.counters.failures += 1;
-			failure = error;
-			throw error;
+			const receipts = reviewReceipts.map(reviewReceipt).filter((receipt) => receipt !== void 0);
+			failure = operation === "review" ? new IdleReviewError(error instanceof Error ? error.message : String(error), {
+				status: receipts.length > 0 ? "partial" : "failed",
+				provider,
+				...reviewChildId === void 0 ? {} : { runId: reviewChildId },
+				receipts
+			}, { cause: error }) : error;
+			throw failure;
 		} finally {
 			this.resultRequests.delete(requestId);
 			let cleanupFailure;
@@ -4394,8 +4549,24 @@ This is the only completion channel for this run. Do not finish with a plain-tex
 				if (failure === void 0 && cleanupFailure === void 0) cleanupFailure = error;
 			}
 			releaseWorkflow?.();
-			if (cleanupFailure !== void 0) throw cleanupFailure;
+			if (cleanupFailure !== void 0) {
+				this.counters.failures += 1;
+				if (operation !== "review") throw cleanupFailure;
+				const receipts = reviewReceipts.map(reviewReceipt).filter((receipt) => receipt !== void 0);
+				throw new IdleReviewError(cleanupFailure instanceof Error ? cleanupFailure.message : String(cleanupFailure), {
+					status: receipts.length > 0 ? "partial" : "failed",
+					provider,
+					...reviewChildId === void 0 ? {} : { runId: reviewChildId },
+					receipts
+				}, { cause: cleanupFailure });
+			}
 		}
+		if (completed === void 0) throw new Error("memory subagent did not complete");
+		this.counters[operation === "write" ? "writes" : operation === "review" ? "reviews" : operation === "placement" ? "placements" : operation === "migration" ? "migrations" : operation === "compaction" ? "compactions" : operation === "document-archive" ? "documentArchives" : operation === "metadata-maintenance" ? "metadataMaintenances" : "answers"] += 1;
+		this.counters.lastRunId = completed.runId;
+		if (operation !== "answer") this.counters.lastOperation = operation;
+		this.counters.lastAt = (/* @__PURE__ */ new Date()).toISOString();
+		return completed;
 	}
 	provider(preferred) {
 		const names = this.subagents.list();
@@ -5098,6 +5269,9 @@ var MnemonAgentLifecycle = class {
 	lastReviewAction;
 	lastReviewScore;
 	lastReviewDocumentIds;
+	idleReviewAttempts = 0;
+	lastReviewAttemptAt;
+	lastReviewFailure;
 	lastPhase = "idle";
 	lastAt;
 	lastError;
@@ -5147,6 +5321,10 @@ var MnemonAgentLifecycle = class {
 			idleReviewPending: this.idleReviewTimer !== void 0,
 			reviewRunning: this.reviewRunning,
 			reviewActivity: this.reviewActivity(),
+			idleReviewAttempts: this.idleReviewAttempts,
+			...idleReviewBlockReason(this.agent) === void 0 ? {} : { idleReviewBlocked: "agent-team" },
+			...this.lastReviewAttemptAt === void 0 ? {} : { nextReviewAt: new Date(this.lastReviewAttemptAt + this.config.idleReview.minIntervalMs).toISOString() },
+			...this.lastReviewFailure === void 0 ? {} : { lastReviewFailure: this.lastReviewFailure },
 			lastPhase: this.lastPhase,
 			...this.lastReviewAt === void 0 ? {} : { lastReviewAt: this.lastReviewAt },
 			...this.lastReviewAction === void 0 ? {} : { lastReviewAction: this.lastReviewAction },
@@ -5272,9 +5450,9 @@ var MnemonAgentLifecycle = class {
 		this.releaseView(turn);
 	}
 	scheduleIdleReview(turn) {
-		if (!this.config.lifecycleEnabled || !this.config.writeEnabled || this.config.writebackMode !== "guided") return;
-		if (this.config.memoryTopology.strategyId !== "default-three-tier") return;
 		this.cancelIdleReview(true);
+		if (!this.idleReviewAllowed()) return;
+		if (this.config.memoryTopology.strategyId !== "default-three-tier") return;
 		const activity = this.ensureTurnActivity(turn);
 		const tools = completedToolActivity(hostSessionEvents(this.agent.session), turn);
 		activity.toolCallCount = tools.count;
@@ -5282,15 +5460,24 @@ var MnemonAgentLifecycle = class {
 		if (!this.reviewActivity().eligible || !this.reviewAdmitted(turn)) return;
 		this.idleReviewTimer = setTimeout(() => {
 			this.idleReviewTimer = void 0;
-			if (this.config.memoryTopology.strategyId !== "default-three-tier") return;
+			if (!this.idleReviewAllowed() || this.reviewRunning) return;
+			if (this.lastReviewAttemptAt !== void 0 && Date.now() < this.lastReviewAttemptAt + this.config.idleReview.minIntervalMs) {
+				this.scheduleIdleReview(turn);
+				return;
+			}
 			if (this.agent.status !== "idle") return;
 			if (!hostSessionEvents(this.agent.session).some((event) => event.type === "turn/end" && eventTurn(event) === turn) || !this.reviewActivity().eligible || !this.reviewAdmitted(turn)) return;
 			this.runIdleReview();
-		}, this.config.idleReviewMs);
+		}, Math.max(this.config.idleReviewMs, (this.lastReviewAttemptAt ?? -Infinity) + this.config.idleReview.minIntervalMs - Date.now()));
+	}
+	idleReviewAllowed() {
+		return this.config.lifecycleEnabled && this.config.writeEnabled && this.config.writebackMode === "guided" && this.config.idleReview.enabled && this.idleReviewAttempts < this.config.idleReview.maxPerSession && idleReviewBlockReason(this.agent) === void 0 && this.config.memoryTopology.strategyId === "default-three-tier";
 	}
 	async runIdleReview() {
 		const controller = new AbortController();
 		const triggeredScore = this.reviewActivity().score;
+		this.idleReviewAttempts += 1;
+		this.lastReviewAttemptAt = Date.now();
 		this.reviewRunning = true;
 		this.reviewController = controller;
 		this.mark("review");
@@ -5301,11 +5488,13 @@ var MnemonAgentLifecycle = class {
 			this.lastReviewAction = result.action;
 			this.lastReviewScore = triggeredScore;
 			this.lastReviewDocumentIds = result.documentIds;
+			this.lastReviewFailure = void 0;
 			this.turnActivity.clear();
 			this.lastError = void 0;
 			this.mark("review");
 		} catch (error) {
-			if (!controller.signal.aborted) this.fail(error);
+			if (error instanceof IdleReviewError) this.lastReviewFailure = error.review;
+			if (!controller.signal.aborted || error instanceof IdleReviewError && error.review.status === "partial") this.fail(error);
 		} finally {
 			if (this.reviewController === controller) {
 				this.reviewRunning = false;
@@ -7099,6 +7288,7 @@ const MUTABLE_FIELDS = [
 	"recallMode",
 	"writebackMode",
 	"idleReviewMs",
+	"idleReview",
 	"displayMode",
 	"tabEnabled",
 	"writeEnabled",
@@ -7655,7 +7845,7 @@ function registerTools(ctx, runtimeSource, coordinator) {
 				},
 				old_text: {
 					type: "string",
-					description: "Unique substring of the existing entry. Required for replace and remove."
+					description: "Full content of the existing entry, or a unique substring. A unique full-content match takes precedence within the selected target. Required for replace and remove."
 				},
 				importance: {
 					type: "string",
@@ -7705,7 +7895,7 @@ function registerTools(ctx, runtimeSource, coordinator) {
 	}));
 	ctx.tools.register(definition({
 		name: "mnemon_remember",
-		description: "Archive one durable insight in a selected provider-backed Memory Space. Ordinary new hot memory belongs in mnemon_runtime_memory; use direct archival only for explicit long-term persistence or runtime capacity migration. Choose the narrowest existing space, search it first, verify capabilities.remember=true, and wait for the provider receipt. OpenViking writes are asynchronous semantic extraction and may truthfully return skipped. Do not dump transcripts, temporary progress, routine observations, or repository-obvious facts.",
+		description: "Archive one durable insight in a selected provider-backed Memory Space. Ordinary new hot memory belongs in mnemon_runtime_memory; use direct archival only for explicit long-term persistence or runtime capacity migration. Choose the narrowest existing space, search it first, verify capabilities.remember=true, and wait for the provider receipt. Exact writes require confirmed persistence; providers using semantic extraction may truthfully return skipped. Do not dump transcripts, temporary progress, routine observations, or repository-obvious facts.",
 		parameters: {
 			type: "object",
 			properties: {