dsh-loci 3.1.0 → 3.2.0

package/CHANGELOG.md

@@ -4,6 +4,41 @@ All notable changes to this project are documented here. The format follows
 [Keep a Changelog](https://keepachangelog.com/en/1.1.0/); the project follows
 [Semantic Versioning](https://semver.org/spec/v2.0.0.html) from 1.0.0.
 
+## [3.2.0] — 2026-11-15
+
+The sidebar was sending people to an empty room. Found in the live store, not in a test.
+
+### Fixed
+
+- **"N item(s) waiting for you in Review" counted rows Review hides.** The card read
+  `stats.pendingCandidates`, which counted every candidate and disputed row in scope; the
+  Review tab lists only the kinds that can reach the prompt (`rule`, `semantic`,
+  `procedural`). Episodic session summaries are candidates *by design* — they are history,
+  not claims — so on a normal day the entire count was composed of rows Review deliberately
+  excludes.
+
+  Live evidence, after one afternoon of use: **3 pending rows, all `episodic`**, and the
+  sidebar offering to review them somewhere it would not. The count is now `0` and Review
+  shows `0`.
+
+  `REVIEWABLE_KINDS` is one exported list. `countPending`, `stats.pendingCandidates`,
+  `stats.disputed` and the panel's request all use it, so the badge and the list cannot drift
+  apart again. `byStatus` stays complete — that is a data view, not a to-do.
+
+- **`stats.pendingCandidates` ignored `valid_to`** while `countPending` honoured it, so a
+  candidate closed by maintenance stayed in the badge. Both now exclude expired rows.
+
+### Why this matters beyond the cosmetic
+
+The card was telling the user to do something that could not be done, which reads as "the
+tool is broken" rather than "there is nothing to do". A number with a door is a promise.
+
+### Not fixed, recorded
+
+Episodic summaries still accumulate as candidates and are only removed by the 30-day
+candidate TTL. They are visible in the Feed tab, which is where history belongs, but nothing
+says so. That is part of R24 (the panel explains almost nothing about itself).
+
 ## [3.1.0] — 2026-11-15
 
 Four things from looking at the live sidebar and panel.

package/client.js

@@ -955,6 +955,7 @@ window.__ModuleLoader__.load({
       // Only the kinds that could actually reach the prompt are reviewable. An
       // episodic session summary is history: it is never injected, so parking it
       // here forever is how the queue became a wall nobody reads.
+      // The same three kinds the store counts as pending, so the badge and the list agree.
       const reviewable = 'kinds=rule,semantic,procedural';
       const candidates = useJson(`/list?status=candidate&limit=50&${reviewable}`);
       const disputed = useJson(`/list?status=disputed&limit=50&${reviewable}`);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dsh-loci",
-  "version": "3.1.0",
+  "version": "3.2.0",
   "description": "Layered long-term memory for DeepSeek Harness: the prompt sees only a stable index, full text is one lookup away. Bi-temporal facts, strict scope isolation, verified-only injection.",
   "type": "module",
   "license": "MIT",

package/src/host/index.js

@@ -23,7 +23,7 @@ import { registerCommands } from './commands.js';
 import { runDoctor } from './doctor.js';
 
 /** Version stamped into the database and diagnostics. */
-export const VERSION = '3.1.0';
+export const VERSION = '3.2.0';
 
 /** Optional collaborators; without them the plugin still serves tools. */
 export const inject = ['systemPrompt', 'tools'];

package/src/host/store/store.js

@@ -118,6 +118,13 @@ function tierOf(kind, pinned) {
 /** Statuses that may be injected or returned by default. */
 export const INJECTABLE_STATUSES = Object.freeze(['verified']);
 
+/**
+ * The kinds a person can review. Everything else — episodic summaries, working notes — is
+ * either history or scratch, and Review hides it. One list, used by the counter and the UI,
+ * so the number and the list cannot drift apart again.
+ */
+export const REVIEWABLE_KINDS = Object.freeze(['rule', 'semantic', 'procedural']);
+
 /** The phrase a caller must echo before the whole store is forgotten. */
 export const CONFIRM_ALL = 'forget everything';
 
@@ -877,18 +884,25 @@ export class Store {
    * @param scopeKeys - explicit scope keys (never a wildcard).
    * @returns the count of candidate and disputed entries.
    */
-  countPending(scopeKeys, now = this.now()) {
+  countPending(scopeKeys, options = {}) {
     if (scopeKeys.length === 0) return 0;
+    const now = options.now ?? this.now();
+    // Only rows a person can actually act on. Episodic summaries are candidates by design —
+    // they are history, not claims, and Review hides them — so counting them made the
+    // sidebar announce work with nowhere to do it.
+    const kinds = Array.isArray(options.kinds) && options.kinds.length > 0 ? options.kinds : REVIEWABLE_KINDS;
     const marks = scopeKeys.map(() => '?').join(', ');
+    const kindMarks = kinds.map(() => '?').join(', ');
     return Number(
       this.db
         .prepare(
           `SELECT COUNT(*) AS n FROM memory m
            WHERE m.status IN ('candidate', 'disputed') AND m.deleted_at IS NULL
              AND (m.valid_to IS NULL OR m.valid_to > ?)
+             AND m.kind IN (${kindMarks})
              AND m.scope_key IN (${marks})`,
         )
-        .get(now, ...scopeKeys)?.n ?? 0,
+        .get(now, ...kinds, ...scopeKeys)?.n ?? 0,
     );
   }
 
@@ -1095,18 +1109,28 @@ export class Store {
       .all(...keys)) {
       byScope[row.scope] = Number(row.n);
     }
+    // "Pending" and "disputed" are questions for a person, so they count only the kinds a
+    // person can act on. Episodic summaries are candidates by design and Review hides them;
+    // counting them here made the sidebar announce work with nowhere to do it. The byStatus
+    // view below stays complete, because that is data rather than a to-do.
+    const kindMarks = REVIEWABLE_KINDS.map(() => '?').join(', ');
     const pending = Number(
       this.db
         .prepare(
           `SELECT COUNT(*) AS n FROM memory m JOIN memory_head h ON h.ord = m.ord
-           WHERE h.status = 'candidate' AND m.deleted_at IS NULL${marks}`,
+           WHERE h.status = 'candidate' AND m.deleted_at IS NULL AND m.kind IN (${kindMarks})
+             AND (m.valid_to IS NULL OR m.valid_to > ?)${marks}`,
         )
-        .get(...keys)?.n ?? 0,
+        .get(...REVIEWABLE_KINDS, this.now(), ...keys)?.n ?? 0,
     );
     const disputed = Number(
       this.db
-        .prepare(`SELECT COUNT(*) AS n FROM memory m JOIN memory_head h ON h.ord = m.ord WHERE h.status = 'disputed'${marks}`)
-        .get(...keys)?.n ?? 0,
+        .prepare(
+          `SELECT COUNT(*) AS n FROM memory m JOIN memory_head h ON h.ord = m.ord
+           WHERE h.status = 'disputed' AND m.kind IN (${kindMarks})
+             AND (m.valid_to IS NULL OR m.valid_to > ?)${marks}`,
+        )
+        .get(...REVIEWABLE_KINDS, this.now(), ...keys)?.n ?? 0,
     );
     const lastInjection = this.db
       .prepare('SELECT ts, session_id, scope_key, section_bytes, entries_listed, entries_hidden, source FROM request_stat ORDER BY id DESC LIMIT 1')

package/src/mcp/store-facade.js

@@ -36,7 +36,7 @@ export function openFacadeStore(options = {}) {
     memoryRoot: root,
     paths,
     config,
-    pluginVersion: '3.1.0',
+    pluginVersion: '3.2.0',
     readOnly: options.readOnly === true,
   });
   return { store, paths };