dsh-linked-workspace 0.8.1 → 0.8.3

package/CHANGELOG.md

@@ -1,5 +1,40 @@
 # Changelog
 
+## 0.8.3 — 2026-11-11
+
+Second review round: follow-ups to the 0.8.2 paging and preview work.
+
+- **Preview overlay (medium)**: the sanitizer now strips inline `style` attributes as well. A document containing `<div style="position:fixed;inset:0;z-index:99999;background:#fff">` used to cover the whole DSH window and could impersonate a login page (click-jacking / phishing without any script).
+- **Paging survives refresh (medium)**: the local tree refreshes every 4 seconds; it now re-requests only the number of entries already loaded instead of resetting to the first page, so “Load more” results no longer disappear after up to 4 s.
+- **Paging offset with hidden files (medium)**: “Load more” uses the raw server offset, so with hidden files toggled off entries are neither duplicated (200 duplicates before) nor skipped; the remaining count follows the same offset.
+- **Directory listing cache (medium)**: `fs.list` caches a listing for 5 seconds, so paging a huge directory reads it once instead of re-running a full `listDir` (20,000 entries: ~10.4 s per call). Writes, mkdir, rename, move, delete, copy and transfers invalidate the cache, and `limit` is clamped server-side to 1..5000.
+- **Partial copy cleanup (low)**: if a directory copy fails midway (for example on a >64 MB file), the partial target is removed and the error is `FS_INCOMPLETE`; `FS_TOO_LARGE` now only means an actual size cap.
+- **Connection reuse (low)**: `HostPool` keys in-flight connects by host *and* authority, so an address change cannot attach an old connection to a new request; a connection replaced while connecting is disposed instead of leaked, and `setHosts` clears stale pending entries.
+- **Right-sidebar requests (low)**: the linked-workspace tree source de-duplicates in-flight loads instead of sending the same request twice.
+- **Large pickers and PDF export (low)**: the local/remote directory pickers render at most 500 entries plus a “type the path directly” note; markdown-to-PDF export stops after 999 name suffixes with an explicit error instead of looping forever.
+- **Tests**: fixed two self-inconsistent assertions in `test/host-api.mjs` (a folder left behind made a later create return 409, and an already-existing folder was expected to answer 400); the suite now passes all 28 steps.
+
+## 0.8.2 — 2026-11-11
+
+Three-day review round: security, data-integrity and large-directory fixes.
+
+- **Document preview XSS (high)**: the preview sanitizer now normalizes control characters, whitespace and zero-width characters before checking a URL scheme, so `jav\tascript:` links (and `vbscript:`, `file:`, `blob:`, `data:text/html`) can no longer run in the GUI. Only `http(s)`, `mailto`, `tel`, relative URLs and bitmap `data:image/*` sources are kept; SVG data URLs stay blocked.
+- **Mirror containment on Windows**: `realpathSync.native` is used for the containment check, so a directory junction can no longer make `.remote` (or a mirrored file) point outside the workspace. Linked `.local`/`.remote` entries that are themselves links are removed as links, never followed.
+- **No silent truncation when copying**: copying a remote file larger than 64 MB, or reading one incompletely, now fails with an explicit error instead of writing a truncated copy. The `linked_workspace` read tool no longer mirrors a truncated payload into `.remote`.
+- **Large local files**: `local.read` reads only the requested head of the file instead of loading the whole thing into memory, so peeking at multi-gigabyte files no longer allocates them (or fails with `ERR_FS_FILE_TOO_LARGE`).
+- **Non-empty directory delete from the tool**: `linked_workspace` `delete` now removes directories recursively, matching the UI, instead of failing on SFTP `rmdir`.
+- **Paged directory listings**: `fs.list` and `local.list` return `limit`/`offset` with `total` and `hasMore` (default 500, max 5000); both trees render a “Load more (N left)” row. A 20,000-entry folder no longer freezes the UI (it used to render all 20,012 rows).
+- **Deep sync trees**: the mirror sync marks a job truncated when it stops at the depth limit, instead of reporting success with missing files.
+- **Accessibility**: visible `:focus-visible` rings for tree rows, inputs, buttons and tabs; `role="treeitem"`/`aria-level`/`aria-selected`/`aria-expanded` on tree rows with ←/→ collapse/expand; the add-workspace dialog focuses its first field, traps Tab, and closes on Escape.
+- **Excel preview honesty**: `read_xlsx` reports `totalRow`/`totalCol`/`truncated`, and the grid notes when it shows only the first 200 rows × 40 columns or the first 20 worksheets.
+- **Build and host fixes**: the client build fails loudly when a `src/parts/*` file is missing; the dead branch in `linked.update` is gone; `HostPool` reuses one in-flight connection per host instead of leaking a duplicate on concurrent first connects.
+
+Earlier unreleased work included in this version:
+
+- Fixed linked-directory context-menu creation on both the remote and local trees: New folder and New file are direct menu actions, so the scrollable menu no longer clips the creation submenu.
+- CSV, HTML, SVG and other preview formats now create ordinary empty files; only Markdown, PDF, DOCX, XLSX and PPTX use document templates.
+- Creation keeps the name dialog open on failure, displays the error and prevents repeated submissions while pending. New files and folders reject existing names with HTTP 409 instead of replacing or silently reusing them, on both remote and local trees.
+
 ## 0.8.1 — 2026-11-09
 
 - **Image zoom**: the image preview gains zoom-out/zoom-in buttons, a percentage readout, “Fit to window” and “1:1” controls, plus `Ctrl/Cmd + wheel` zoom.

package/README.en.md

@@ -119,6 +119,35 @@ Old “Remote directories” tabs are restored after refresh through hidden lega
 
 See [CHANGELOG.md](CHANGELOG.md) for the full version history.
 
+### 0.8.3
+
+Follow-up fixes to the 0.8.2 paging and preview work (second review round):
+
+- Document previews now also drop inline `style` attributes, so a `position:fixed` overlay can no longer cover the whole app and impersonate a login page (click-jacking/phishing surface).
+- Tree refreshes (the local tree every 4 s) re-request only the entries already loaded, so “Load more” results are no longer reset to the first page.
+- With hidden files toggled, “Load more” uses the true server offset: entries are neither duplicated nor skipped, and the “N left” label is computed from that offset.
+- `fs.list` gained a 5-second listing cache: paging reads the directory once, and any write, mkdir, rename, move, delete, copy or transfer invalidates it.
+- A directory copy that fails midway removes the partial copy and reports `FS_INCOMPLETE`; `FS_TOO_LARGE` is now reserved for real size limits.
+- Concurrent first connects are keyed by host *and* address, so an address change cannot hand the old connection to the new request, and replaced connections are released.
+- The right-sidebar tree source de-duplicates in-flight loads instead of issuing the same request twice.
+- Directory pickers render at most 500 entries and suggest typing the path; PDF export stops after 999 name suffixes with an explicit error instead of looping forever.
+- Tests: two self-inconsistent assertions in `test/host-api.mjs` were fixed (a leftover folder made a later create return 409, and an existing name was expected to return 400); all 28 steps now pass.
+
+### 0.8.2
+
+Security, data-integrity and large-directory fixes from the three-day review round:
+
+- The document-preview sanitizer normalizes control characters, whitespace and zero-width characters before checking a URL scheme, so `jav\tascript:`, `vbscript:`, `file:` and `data:text/html` links no longer run in the GUI; only `http(s)`, `mailto`, `tel`, relative URLs and bitmap `data:image` sources are kept.
+- Windows junctions can no longer escape the `.remote` containment check (`realpathSync.native`); linked `.local`/`.remote` entries are removed as links, never followed.
+- Copying a remote file over 64 MB, or reading one incompletely, now fails loudly instead of writing a truncated copy; the read tool no longer mirrors truncated payloads.
+- `local.read` reads only the requested head instead of loading the whole file into memory.
+- The `linked_workspace` `delete` action removes non-empty directories recursively.
+- Directory listings are paged (500 by default, 5000 max, with `total`/`hasMore`) and both trees render a “Load more” row, so a 20,000-entry folder no longer freezes the UI.
+- Mirror sync marks a job truncated at the depth limit instead of reporting success with files missing.
+- Accessibility: `:focus-visible` rings, `treeitem`/`aria-level`/`aria-expanded` semantics, `←`/`→` collapse and expand, and an add-workspace dialog that focuses its first field, traps Tab and closes on Escape.
+- Excel previews report `totalRow`/`totalCol`/`truncated` and note when the grid shows only the first 200 rows × 40 columns or the first 20 worksheets.
+- The client build fails when a `src/parts/*` file is missing; the dead `linked.update` branch is gone; `HostPool` reuses one in-flight connection per host.
+
 ### 0.7.0
 
 Single-click tree navigation with preview tabs and double-click pinning, remote/local terminal buttons with `cd`, VSCode-like shortcuts, unsaved-close prompts, and an auto-save switch under Settings → Connections.

package/README.md

@@ -114,6 +114,35 @@ dsh plugin --profile "$DSH_PROFILE" add "file:$PWD/dsh-linked-workspace"
 
 已打开的旧右侧栏「远程目录」标签页会在刷新后自动恢复（插件保留了两个隐藏的旧 tab 类型别名），标签标题也会自动改成「联动工作区目录」，新开的标签使用新的 `dsh-linked-workspace` 类型。
 
+### 0.8.3 变化
+
+针对 0.8.2 分页与预览的后续修复（第二轮评审）：
+
+- 文档预览同时删除内联 `style`，`position:fixed` 全屏覆盖层不再能把整页伪装成登录页（点击劫持/钓鱼面）。
+- 目录树刷新（本地树每 4 秒）只重取已加载的条目数，不再把「加载更多」的结果打回第一页。
+- 含隐藏文件时「加载更多」用服务端真实偏移，条目不再重复或遗漏；「剩余 N 项」按真实偏移计算。
+- `fs.list` 增加 5 秒列表缓存：翻页只读一次目录；写、建、改名、移动、删除、复制、传输后立即失效。
+- 目录复制中途失败会清理已复制的半成品并返回 `FS_INCOMPLETE`（原 `FS_TOO_LARGE` 只用于真实超限）。
+- 并发首次连接按「主机 + 地址」复用，主地址变化时不再把旧连接交给新地址请求，被替换的连接会释放。
+- 右侧栏树的数据源增加请求去重，重复加载不再重复发请求。
+- 目录选择器最多渲染 500 项并提示可直接输入路径；导出 PDF 的同名后缀最多尝试 999 次，超限报错而不是无限循环。
+- 测试：修复 `test/host-api.mjs` 自身两处断言缺陷（重复创建文件夹残留、把已存在当 400），全套 28 步通过。
+
+### 0.8.2 变化
+
+安全、数据完整性与大目录体验修复（三日评审轮）：
+
+- 文档预览净化器先归一控制字符/空白/零宽字符再判 scheme，`jav\tascript:`、`vbscript:`、`file:`、`data:text/html` 不再可执行；只保留 http(s)/mailto/tel、相对链接与位图 `data:image`。
+- Windows junction 不再能绕过 `.remote` 包含性校验（改用 `realpathSync.native`）；链接目录只删链接本身。
+- 远端复制 >64 MB 或读取不完整时直接报错，不再静默写入截断副本；工具读文件只在未截断时同步到 `.remote`。
+- `local.read` 只读取所需头部，不再把超大文件整体读入内存。
+- 工具 `delete` 可递归删除非空远端目录。
+- 目录列表分页（默认 500、最大 5000，返回 `total`/`hasMore`），树底「加载更多」；2 万项目录不再卡死。
+- 同步深度超限会标记为截断，不再把漏文件当成功。
+- 可访问性：`:focus-visible` 焦点环、树行 `treeitem`/`aria-level`/`aria-expanded`、`←`/`→` 折叠展开、添加工作区弹窗聚焦首字段 + Tab 循环 + Esc 关闭。
+- Excel 预览返回 `totalRow`/`totalCol`/`truncated`，并提示「仅显示前 200 行 × 40 列」「仅显示前 20 个工作表」。
+- 客户端构建缺 `src/parts/*` 文件时直接失败；移除 `linked.update` 死分支；`HostPool` 并发首连复用同一连接。
+
 ### 0.5.11 变化
 
 远程目录的只读文件现在能看到代码内容；设置里「打开工作区」会跳转并关闭设置，远程目录「打开」会打开对应远程标签。

package/docs/API.md

@@ -58,12 +58,12 @@ relative to the scope root, or absolute inside it.
 | `workspaces.remove` | `{ id }` | `{}` |
 | `workspaces.rename` | `{ id, name }` | `{ workspace }` |
 | `workspaces.test` | `{ id }` | `{ ok, latencyMs?, resolvedPath?, error? }` |
-| `fs.list` | `{ workspaceId?/linkedId?, path }` | `{ path, entries: RemoteEntry[] }` |
+| `fs.list` | `{ workspaceId?/linkedId?, path, limit?, offset? }` | `{ path, entries: RemoteEntry[], total, offset, limit, hasMore }` (default 500, max 5000). Listings are cached for 5 s for `offset > 0`; writes, mkdir, rename, move, delete, copy and transfers invalidate the cache. |
 | `fs.read` | `{ workspaceId?/linkedId?, path, maxBytes? }` | `FileRead` |
 | `media.read` | `{ workspaceId?/linkedId?, path }` | `{ path, size, mtime, mime, base64 }` (PNG/JPG/GIF/WebP/BMP/ICO/AVIF/SVG, max 24 MB) |
-| `fs.write` | `{ workspaceId?/linkedId?, path, content, expectedMtime? }` | `{ path, size, mtime }` |
+| `fs.write` | `{ workspaceId?/linkedId?, path, content, expectedMtime?, createOnly? }` | `{ path, size, mtime }` (`createOnly: true`: existing target → 409) |
 | `fs.stat` | `{ workspaceId?/linkedId?, path }` | `{ path, relative, type, size, mtime, mode }` |
-| `fs.mkdir` | `{ workspaceId?/linkedId?, path }` | `{}` |
+| `fs.mkdir` | `{ workspaceId?/linkedId?, path, createOnly? }` | `{}` (`createOnly: true`: existing target → 409) |
 | `fs.rename` | `{ workspaceId?/linkedId?, from, to }` | `{}` |
 | `fs.move` | `{ workspaceId?/linkedId?, path, targetDir? }` | `{ path }` (same remote tree; collision → 409) |
 | `fs.delete` | `{ workspaceId?/linkedId?, path }` | `{}` |
@@ -71,7 +71,7 @@ relative to the scope root, or absolute inside it.
 | `settings.get` | `{}` | `{ editorTheme, editorThemeFamily, editorThemeMode, fileOpenMode, autoSave }` |
 | `settings.update` | `{ editorTheme?, editorThemeFamily?, editorThemeMode?, fileOpenMode?, autoSave? }` | `{ editorTheme, editorThemeFamily, editorThemeMode, fileOpenMode, autoSave }` |
 | `local.browse` | `{ path? }` | `{ path, parent, home, entries: [{ name, path }] }` |
-| `local.mkdir` | `{ path, name }` | `{ path }` |
+| `local.mkdir` | `{ path, name }` | `{ path }` (existing target → 409) |
 | `linked.list` | `{}` | `{ links: LinkInfo[] }` (each link carries `running`) |
 | `linked.create` | `{ hostId, remotePath, localPath, name?, mirror? }` | `{ link, workspaceId: string|null }` |
 | `linked.update` | `{ id, name?, mirror? }` | `{ link }` |
@@ -79,7 +79,7 @@ relative to the scope root, or absolute inside it.
 | `linked.sync` | `{ id, maxFiles?, maxBytes? }` | `{ job: SyncJob }` (starts a background job) |
 | `linked.syncStatus` | `{ id }` | `{ job: SyncJob | null }` |
 | `linked.syncCancel` | `{ id }` | `{ cancelled: boolean }` |
-| `local.list` | `{ path }` | `{ path, entries: [{ name, path, type, size, mtime }] }` |
+| `local.list` | `{ path, limit?, offset? }` | `{ path, entries: [{ name, path, type, size, mtime }], total, offset, limit, hasMore }` |
 | `local.openExternal` | `{ path }` | `{ opened, path }` |
 | `terminal.open` | `{ workspaceId?/linkedId?, side: 'remote'\|'local' }` | `{ opened, side, path, host? }` |
 | `fs.openExternal` | `{ workspaceId?/linkedId?, path }` | `{ opened, localPath, size }` |
@@ -102,7 +102,7 @@ relative to the scope root, or absolute inside it.
 | `local.move` | `{ path, targetDir?, root? }` | `{ path, type }` (same local tree; collision → 409) |
 | `local.delete` | `{ path, root? }` | `{}` (recursive) |
 | `local.copy` | `{ path, targetDir? }` | `{ path, type }` |
-| `local.newFile` | `{ path }` | `{ path }` |
+| `local.newFile` | `{ path }` | `{ path }` (existing target → 409) |
 | `local.chmod` | `{ path, mode }` | `{ path, mode }` |
 | `local.edit` | `{ path, app? }` | `{ path }` (opens Notepad) |
 

package/docs/VERIFY.md

@@ -89,6 +89,8 @@ Host code (lib/) reloads live with `plugin_manager set_plugin include:linked-wor
 19. 编辑器：内部内容面板不显示路径/保存头部（Ctrl+S 保存）；修改未保存时文件标签名前出现灰色圆点；行号、语法高亮（字符串/注释/关键字有颜色）、主题配色、
    远端并发修改 → 冲突提示（重新加载/强制保存）、二进制/大文件只读；底部状态栏完整可见（不再被视口裁切）。
 
+20. **右键新建回归**：远端目录和本地目录的文件夹均右击后，菜单中直接出现「新建文件夹」「新建文件」（不依赖向右展开的子菜单）；分别在根目录和嵌套目录创建文件夹、`.txt`、`.csv`、`.html`、`.svg`、`.png`，应创建空普通文件。`.md`、`.pdf`、`.docx`、`.xlsx`、`.pptx` 仍创建对应模板并打开；重复名称应留在命名对话框并显示错误，不得覆盖已有文件。
+
 ## 联动会话（模型工具）
 
 1. 在联动工作区里新建会话，问模型「这个联动工作区的远端根目录是什么」→ 它应调用 `linked_workspace` 的 `list`/`info`。
@@ -132,3 +134,25 @@ Host code (lib/) reloads live with `plugin_manager set_plugin include:linked-wor
 4. 本地与远端各打开一个 `.html`/`.htm`：内容面板以 iframe 渲染页面，状态栏显示 HTML、大小和「网页脚本已禁用」。
 5. HTML 内联样式与静态标签正常显示；页面内脚本不执行，链接不会跳出 DSH 主界面。
 6. 读取失败的 HTML（权限/过大/二进制）显示错误提示和重试按钮。
+
+## 安全、分页与可访问性（0.8.2）
+
+1. **预览链接净化**：在本地或远端放一个 Markdown 文件，内容含 `<a href="jav&#9;ascript:document.title='X'">click</a>` 与 `[example](https://example.com)`；预览后点第一个链接：页面不应跳转、标题不变、DSH 界面不被替换；第二个链接仍指向 `https://example.com`。`vbscript:`、`file:`、`data:text/html`、`data:image/svg+xml` 链接同样应被移除。
+2. **大目录分页**：造一个 20 000 项的目录（`1..20000 | % { New-Item -ItemType File "f$_.txt" }`），在目录树展开它：应只出现 500 行和「加载更多（剩余 19500 项）」，页面不卡顿、可滚动、可点其他文件；点「加载更多」追加 500 行并更新剩余计数，滚到底部后可继续加载。
+3. **键盘操作**：Tab 到目录树行应看到明显焦点环；聚焦树行时 `←` 收起、`→` 展开目录；读屏应能听到 treeitem 层级与展开状态。
+4. **添加工作区弹窗**：打开后焦点直接在第一个输入框；连按 Tab 焦点在弹窗内循环，不会跑到背景页面；`Esc` 关闭弹窗。
+5. **大文件窥视**：打开一个 >2 GB 的本地文件（只读预览）：应显示「文件过大，仅显示前 512 KB」而不是报错或长时间卡住；内存不随文件大小增长。
+6. **复制上限**：在远端复制一个 >64 MB 的文本/二进制文件：应提示「超过 64 MB，无法复制」，目标目录不得出现被截断的副本。
+7. **非空目录删除（工具）**：让 agent 用 `linked_workspace` 的 `delete` 删除一个含文件的远端目录：应递归删除成功，不再报 SFTP `Failure`。
+8. **Excel 截断提示**：打开一个 >200 行或 >40 列的 xlsx：表格上方应出现「仅显示前 200 行 × 40 列」；工作表超过 20 个时出现「仅显示前 20 个工作表」。
+
+## 分页续修与预览覆盖（0.8.3）
+
+1. **预览覆盖层**：放一个 Markdown 文件，内容为 `<div style="position:fixed;inset:0;z-index:99999;background:#fff;padding:24px">FAKE-LOGIN-PAGE</div>` 加一行普通文字；预览后不应出现全屏白底覆盖层，`div` 上不应残留 `style` 属性，页面其余部分照常可点。
+2. **加载更多不被刷新清空**：在本地树展开一个 >500 项的目录，点「加载更多」后**静置 10 秒**（跨过两次 4 秒刷新）：行数与剩余计数应保持不变，不回退到 500 行。
+3. **隐藏文件下的分页**：目录中同时放 300 个 `.hidden*.txt` 与 600 个 `visible*.txt`；先关闭「显示隐藏的文件」再展开该目录，点「加载更多」：可见条目不应重复、不应遗漏，最终数量为 600，剩余计数归零。
+4. **目录选择器上限**：进入一个含 600+ 子目录的父目录：列表面板最多显示 500 项，并提示「目录项过多，仅显示前 500 项；可直接在输入框中输入路径」；在输入框直接键入子路径仍可选择。
+5. **翻页性能**：对 20 000 项的远端目录连续点两次「加载更多」：第二次起应明显快于首次（5 秒内命中列表缓存），且界面不卡顿。
+6. **复制失败清理（开发核验）**：复制一个内含 >64 MB 文件的目录：应报错且目标目录不留半成品（可用 `git status` 之外的目录列表确认）。
+7. **导出 PDF 上限（开发核验）**：同目录放 999 个同名 `<name>.pdf` 后再次导出同名的 Markdown：应提示「同名 PDF 过多，请先清理目录中的旧导出」，不进入无限循环。
+8. **host-api 套件**：在有 SSH 主机与 DSH 运行时 Node 的机器上跑 `node test/host-api.mjs`（本机系统 Node 24.13 删除中日韩字符目录会崩溃，用 DSH 自带 Electron Node 执行）：应为 28 步全部通过。