dsh-interconnect 0.11.17 → 0.11.18

package/lib/tool-interconnect/index.js

@@ -951,6 +951,8 @@ var InterconnectService = class extends Service {
   peerOf = /* @__PURE__ */ new WeakMap();
   /** Configured peer an outbound dial owns a socket for; absent on inbound sockets. */
   dialedPeerOf = /* @__PURE__ */ new WeakMap();
+  /** Dialed sockets already reported as announcing an id other than their configured key. */
+  mismatchWarned = /* @__PURE__ */ new WeakSet();
   /** Sender each local session last received a send from, keyed by local session id. */
   senders = /* @__PURE__ */ new Map();
   /** In-flight frames sent over a peer link, keyed by `reqId`, awaiting a correlated result. */
@@ -1217,12 +1219,12 @@ var InterconnectService = class extends Service {
    * dialed link plus the peer's inbound one), so one event must leave over one
    * of them. Which one is decided by local ownership, not by the peer: a dialed
    * socket is a configured peer's link and always sends. An inbound socket is
-   * skipped only when an open dialed link covers the id that socket itself
-   * announced — either because `Config.peers` lists that peer under the id, or
-   * because the peer announced the id over that dialed link — so an
-   * announcement can suppress nothing but a duplicate the controlled link
-   * already carries. An impostor cannot drop an event for a peer, and without a
-   * dialed link every inbound socket receives it.
+   * skipped only when this instance has an open dialed link configured under
+   * the id that socket itself announced, so a self-reported announcement can
+   * never silence another peer's link; with no such dialed link every inbound
+   * socket receives the event. A peer listed under a key other than the id it
+   * announces is warned about once per link, because then its own inbound
+   * socket is not attributable and the peer receives each event twice.
    *
    * That holds once a peer's announcement has been seen. Between this
    * instance's dialed link opening and the peer's `hello` arriving on its
@@ -1241,10 +1243,7 @@ var InterconnectService = class extends Service {
         continue;
       }
       const dialedPeer = this.dialedPeerOf.get(socket);
-      if (dialedPeer === void 0) continue;
-      covered.add(dialedPeer);
-      const announced = this.peerOf.get(socket);
-      if (announced !== void 0) covered.add(announced);
+      if (dialedPeer !== void 0) covered.add(dialedPeer);
     }
     for (const socket of this.sockets) {
       if (this.dialedPeerOf.get(socket) === void 0) {
@@ -1577,6 +1576,13 @@ var InterconnectService = class extends Service {
     const frame = parsed;
     if (frame.type === "hello") {
       this.peerOf.set(socket, frame.sender);
+      const dialedPeer = this.dialedPeerOf.get(socket);
+      if (dialedPeer !== void 0 && dialedPeer !== frame.sender && !this.mismatchWarned.has(socket)) {
+        this.mismatchWarned.add(socket);
+        this.ctx.logger.warn(
+          `interconnect: peer configured as ${dialedPeer} announces ${frame.sender}; list a peer under the instanceId it announces, or the duplicate inbound link is not recognised`
+        );
+      }
       return;
     }
     if (frame.type === "event") {