dsh-interconnect 0.11.15 → 0.11.17

package/lib/tool-interconnect/index.js

@@ -838,8 +838,10 @@ var PLUGIN_SOURCE = "dsh-interconnect";
 var MAX_LINK_FRAME_BYTES = 1024 * 1024;
 var LINK_HANDSHAKE_TIMEOUT_MS = 1e4;
 var LINK_CHANNEL = "/interconnect/link";
+var MAX_INSTANCE_ID_CHARS = 256;
 var MAX_REQUEST_ID_CHARS = 256;
 var MAX_LISTED_SESSIONS = 100;
+var frameFitsLink = (frame) => Buffer.byteLength(JSON.stringify(frame), "utf8") <= MAX_LINK_FRAME_BYTES;
 var rowBytes = (row) => Buffer.byteLength(JSON.stringify(row), "utf8") + 1;
 var notificationSchema = Schema.union([
   Schema.object({ kind: Schema.const("agent/created").required(), sessionId: Schema.string().required() }),
@@ -930,7 +932,7 @@ var linkFrameSchema = Schema.union([
 var InterconnectService = class extends Service {
   static inject = ["agents", "credentials"];
   static Config = Schema.object({
-    instanceId: Schema.string().default("dsh"),
+    instanceId: Schema.string().max(MAX_INSTANCE_ID_CHARS).default("dsh"),
     requestTimeoutMs: Schema.natural().max(6e4).default(1e4),
     peers: Schema.dict(Schema.string()).default({}),
     delivery: Schema.union([Schema.const("followup"), Schema.const("steer"), Schema.const("inject")]).default("followup"),
@@ -940,7 +942,6 @@ var InterconnectService = class extends Service {
   requestTimeoutMs;
   delivery;
   allowResume;
-  subscriptions = [];
   server = new WebSocketServer({ noServer: true, maxPayload: MAX_LINK_FRAME_BYTES });
   sockets = /* @__PURE__ */ new Set();
   /** Outbound peer links keyed by the peer's `instanceId`. */
@@ -997,28 +998,28 @@ var InterconnectService = class extends Service {
         socket.ping();
       }
     }, 3e4);
-    this.subscriptions.push(ctx.on("agent/status", ({ agent, status }) => {
+    ctx.on("agent/status", ({ agent, status }) => {
       this.fanout({ kind: "agent/status", sessionId: String(agent.session.id), status });
-    }));
-    this.subscriptions.push(ctx.on("agent/created", ({ agent }) => {
+    });
+    ctx.on("agent/created", ({ agent }) => {
       this.fanout({ kind: "agent/created", sessionId: String(agent.session.id) });
-    }));
-    this.subscriptions.push(ctx.on("agent/disposed", ({ agent }) => {
+    });
+    ctx.on("agent/disposed", ({ agent }) => {
       this.fanout({ kind: "agent/disposed", sessionId: String(agent.session.id) });
-    }));
-    this.subscriptions.push(ctx.on("session/created", (session) => {
+    });
+    ctx.on("session/created", (session) => {
       const parentSessionId = session.header.parentSession === void 0 ? void 0 : String(session.header.parentSession);
       this.fanout({
         kind: "session/created",
         sessionId: String(session.id),
         ...parentSessionId === void 0 ? {} : { parentSessionId }
       });
-    }));
-    this.subscriptions.push(ctx.on("session/disposed", (session) => {
+    });
+    ctx.on("session/disposed", (session) => {
       this.senders.delete(String(session.id));
       this.fanout({ kind: "session/disposed", sessionId: String(session.id) });
-    }));
-    this.subscriptions.push(ctx.on("subagent/end", (info) => {
+    });
+    ctx.on("subagent/end", (info) => {
       if (!info.local) return;
       this.fanout({
         kind: "subagent/end",
@@ -1026,10 +1027,7 @@ var InterconnectService = class extends Service {
         childSessionId: String(info.id),
         stopReason: info.stopReason
       });
-    }));
-    ctx.effect(() => () => {
-      for (const dispose of this.subscriptions.splice(0)) dispose();
-    }, "interconnect: event subscriptions");
+    });
     ctx.effect(() => () => {
       if (this.heartbeatTimer !== void 0) clearInterval(this.heartbeatTimer);
       for (const state of this.linkStates.values()) state.close();
@@ -1126,22 +1124,30 @@ var InterconnectService = class extends Service {
    * Send a `msg` frame over the live link to a peer and resolve with its
    * correlated `msg-result`. Undefined when the peer has no live link here
    * (not configured, or the link is down) — sends can only address configured+
-   * connected peers by design.
+   * connected peers by design — and a `message-too-large` result when the
+   * encoded frame would not fit the link.
    */
   async msgRequest(instanceId, kind, payload) {
     const state = this.linkStates.get(instanceId);
     if (state === void 0 || !state.writable()) return void 0;
     const reqId = `m${++this.reqIdCounter}-${randomUUID()}`;
-    const message = {
-      kind,
-      sessionId: payload.sessionId,
-      text: payload.text,
-      ...payload.sender === void 0 ? {} : { sender: payload.sender },
-      ...payload.delivery === void 0 ? {} : { delivery: payload.delivery },
-      ...payload.resume === void 0 ? {} : { resume: payload.resume }
+    const frame = {
+      type: "msg",
+      reqId,
+      message: {
+        kind,
+        sessionId: payload.sessionId,
+        text: payload.text,
+        ...payload.sender === void 0 ? {} : { sender: payload.sender },
+        ...payload.delivery === void 0 ? {} : { delivery: payload.delivery },
+        ...payload.resume === void 0 ? {} : { resume: payload.resume }
+      }
     };
+    if (!frameFitsLink(frame)) {
+      return { delivered: false, instance: instanceId, reason: "message-too-large" };
+    }
     return this.waitForResult(reqId, "msg", (failure) => {
-      const wrote = state.sendFrame({ type: "msg", reqId, message });
+      const wrote = state.sendFrame(frame);
       if (!wrote) failure(new Error(`interconnect: peer link to ${instanceId} closed while sending`));
     });
   }
@@ -1211,10 +1217,12 @@ var InterconnectService = class extends Service {
    * dialed link plus the peer's inbound one), so one event must leave over one
    * of them. Which one is decided by local ownership, not by the peer: a dialed
    * socket is a configured peer's link and always sends. An inbound socket is
-   * skipped only when a dialed link to the id that socket itself announced is
-   * open, so an announcement can suppress nothing but a duplicate the
-   * controlled link already carries — an impostor cannot drop an event for a
-   * peer, and without a dialed link every inbound socket receives it.
+   * skipped only when an open dialed link covers the id that socket itself
+   * announced — either because `Config.peers` lists that peer under the id, or
+   * because the peer announced the id over that dialed link — so an
+   * announcement can suppress nothing but a duplicate the controlled link
+   * already carries. An impostor cannot drop an event for a peer, and without a
+   * dialed link every inbound socket receives it.
    *
    * That holds once a peer's announcement has been seen. Between this
    * instance's dialed link opening and the peer's `hello` arriving on its
@@ -1233,7 +1241,10 @@ var InterconnectService = class extends Service {
         continue;
       }
       const dialedPeer = this.dialedPeerOf.get(socket);
-      if (dialedPeer !== void 0) covered.add(dialedPeer);
+      if (dialedPeer === void 0) continue;
+      covered.add(dialedPeer);
+      const announced = this.peerOf.get(socket);
+      if (announced !== void 0) covered.add(announced);
     }
     for (const socket of this.sockets) {
       if (this.dialedPeerOf.get(socket) === void 0) {
@@ -1265,12 +1276,7 @@ var InterconnectService = class extends Service {
     if (query.kind === "ping") {
       result = { pong: true, instance: this.instanceId };
     } else if (query.kind === "list") {
-      const rowBudget = this.listRowsBudgetBytes(reqId);
-      if (rowBudget < 0) {
-        this.ctx.logger.warn("interconnect: list answer cannot fit the link frame cap; not answering");
-        return;
-      }
-      result = this.listSessions(rowBudget);
+      result = this.listSessions(this.listRowsBudgetBytes(reqId));
     } else {
       const payload = {
         sender: this.peerOf.get(socket) ?? "unknown-peer",
@@ -1302,10 +1308,11 @@ var InterconnectService = class extends Service {
    * Bytes one `list` answer may spend on its `sessions` rows: the frame cap
    * minus the serialized envelope that answer will carry. The envelope holds
    * the peer-supplied `reqId` and this instance's own id, so it is measured per
-   * answer instead of reserved with a fixed constant.
+   * answer instead of reserved with a fixed constant. Both ids are bounded
+   * ({@link MAX_REQUEST_ID_CHARS} and {@link MAX_INSTANCE_ID_CHARS} characters),
+   * so the envelope always fits and the budget is always positive.
    * @param reqId - the request id the answer has to echo.
-   * @returns the byte budget for the rows, negative when even an empty answer
-   * exceeds the cap and so cannot be sent at all.
+   * @returns the byte budget for the rows.
    */
   listRowsBudgetBytes(reqId) {
     const envelope = {
@@ -1792,7 +1799,7 @@ function apply(ctx) {
       text: {
         type: "string",
         required: true,
-        description: "Message text delivered to the peer session."
+        description: 'Message text delivered to the peer session. At most 1 MiB once encoded: a larger message is refused with reason "message-too-large".'
       },
       delivery: {
         type: "string",
@@ -1823,6 +1830,8 @@ function apply(ctx) {
               return `not delivered: could not wake "${_args.sessionId}" on ${value.instance} (no persisted session under that id, or the wake itself failed)`;
             case "session-owned-by-subagent":
               return `not delivered: "${_args.sessionId}" is a subagent's session on ${value.instance} \u2014 its parent agent owns delivery, so reach it through that parent`;
+            case "message-too-large":
+              return "not delivered: the message is too large for the peer link (limit 1 MiB); shorten the text and try again";
             default:
               return `not delivered: no live session "${_args.sessionId}" on ${value.instance}` + (_args.resume === true ? " \u2014 use interconnect_list to see which sessions are live there" : " \u2014 use interconnect_list to see which sessions are live there, or set resume to wake this one");
           }
@@ -1973,6 +1982,9 @@ function apply(ctx) {
           if (value.reason === "no-sender-known") {
             return "not delivered: no sender identity is known to reply to";
           }
+          if (value.reason === "message-too-large") {
+            return "not delivered: the reply is too large for the peer link (limit 1 MiB); shorten the text and try again";
+          }
           if (value.reason === "session-owned-by-subagent") {
             return "not delivered: the recorded sender's session belongs to a subagent and its parent agent owns delivery";
           }