dsh-hashline-edit 0.2.2 → 0.3.0

package/src/edit-tool.ts

@@ -1,118 +0,0 @@
-/** SAFETY: EditTool — deep module owning the edit Use Case seam.
- *
- * Graded surface: one narrow interface `EditTool { execute, preview }`
- * hides pipeline delegation, warnings/drift stitching.
- * Frameworks (pi TUI) never cross this seam — that lives in TuiPresenter.
- * Clean Architecture: Use Cases depend inward only (mutation-engine),
- * never outward to Frameworks.
- *
- * Typed boundaries: validate once at admission (payload-contract via normReq/assertReq),
- * trust inside. Immutable state: never mutates caller-owned request.
- */
-
-import { constants } from "node:fs";
-import { sessionKeyFor } from "./served-session/session.js";
-import { normReq, assertReq, type NormalizedEditRequest } from "./payload-contract.js";
-import { execute as engineExecute, preview as enginePreview } from "./mutation-engine/engine.js";
-import { isMutationSuccess } from "./mutation-engine/types.js";
-import { attachEnvelope } from "./error-envelope.js";
-
-type EditToolContext = {
-  cwd: string;
-  sessionManager?: { getSessionId(): string };
-};
-
-export type PreviewContext = {
-  sessionManager?: { getSessionId(): string };
-};
-
-type PreviewResult = { diff: string } | { error: string };
-
-export interface EditTool {
-  /** SAFETY: Execute a validated edit; returns pi tool_result or throws on failure. Admission: params validated by normReq/assertReq. */
-  execute(
-    params: unknown,
-    signal: AbortSignal | undefined,
-    ctx: EditToolContext,
-  ): Promise<{
-    content: Array<{ type: "text"; text: string }>;
-    details: unknown;
-  }>;
-  /** SAFETY: Preview without persisting — mirrors pi's compPreview(request, cwd, ctx). The ctx must carry the session whose serves the anchors came from (#165). */
-  preview(request: unknown, cwd: string, ctx: PreviewContext): Promise<PreviewResult>;
-}
-
-export function createEditTool(): EditTool {
-  return {
-    async execute(params, signal, ctx) {
-      const canonical = normReq(params);
-      assertReq(canonical);
-      // SAFETY: ctx is untyped at pi boundary — cast validated by pi's runtime context shape (cwd + sessionManager)
-      const sessionKey = sessionKeyFor(
-        ctx as unknown as { sessionManager?: { getSessionId(): string } },
-      );
-      // SAFETY: canonical is validated NormalizedEditRequest after assertReq — trusted inside boundary
-      const result = await engineExecute(canonical as NormalizedEditRequest, ctx.cwd, {
-        accessMode: constants.R_OK | constants.W_OK,
-        // SAFETY: signal is AbortSignal | undefined at pi boundary — runtime check via engine's abortIf
-        ...(signal !== undefined ? { signal } : {}),
-        sessionKey,
-      });
-      if (isMutationSuccess(result)) {
-        // SAFETY: toolResult is validated by isMutationSuccess discriminated union guard
-        return result.toolResult as {
-          content: Array<{ type: "text"; text: string }>;
-          details: unknown;
-        };
-      }
-      // WHY: every range-family producer emits `details.cause` (user-facing diagnosis) —
-      // WHY: carry it on the thrown error so callers catching the message still see the cause.
-      // WHY: the whole failure envelope (code, diagnosis, rows, block) is stamped through the
-      // WHY: envelope assembler (src/error-envelope.ts) — this seam never hand-copies fields.
-      const failure = new Error(result.message);
-      attachEnvelope(failure, {
-        code: result.code,
-        ...(result.cause !== undefined ? { cause: result.cause } : {}),
-        // WHY: the raw payload message rides the envelope so the adapter can name the tool.
-        // WHY: The rendered message alone cannot say which call raised the refusal.
-        ...(result.payloadMessage !== undefined ? { payloadMessage: result.payloadMessage } : {}),
-        servedRows: result.servedRows ?? [],
-        servedBlock: result.servedBlock ?? "",
-      });
-      throw failure;
-    },
-    async preview(request, cwd, ctx) {
-      try {
-        const normalized = normReq(request);
-        assertReq(normalized);
-        // SAFETY: normalized is validated NormalizedEditRequest after assertReq
-        // WHY: (#165) preview verifies against the SAME session the anchors were served to —
-        // WHY: without a session, sessionKeyFor fails loud here instead of minting a key whose
-        // WHY: lease lookups all miss as a misleading E_UNKNOWN_ANCHOR.
-        const result = await enginePreview(normalized as NormalizedEditRequest, cwd, {
-          accessMode: constants.R_OK,
-          sessionKey: sessionKeyFor(ctx),
-        });
-        if (!isMutationSuccess(result)) {
-          return { error: result.message };
-        }
-        const file = result.raw;
-        // WHY: the call's own classification, not the primary file's bytes: a multi-file edit may
-        // WHY: change another file while the primary stands still, and that IS a change to preview.
-        if (result.metrics.classification === "noop") {
-          return {
-            error: `No changes made to ${file.path}. The edit produced identical content.`,
-          };
-        }
-        return {
-          // WHY: #174 single projection — the engine's `preview` seam already produced the
-          // WHY: `genDiff` text with the pane's context; this display path renders it and
-          // WHY: never re-projects.
-          diff: result.diff,
-        };
-      } catch (error: unknown) {
-        return { error: error instanceof Error ? error.message : String(error) };
-      }
-    },
-  };
-}

package/src/edit.ts

@@ -1,136 +0,0 @@
-/** SAFETY: Edit tool — thin adapter over deep EditTool + TuiPresenter.
- *
- * Clean Architecture: this module is the Interface Adapter seam.
- * It owns the pi ToolDefinition wiring only; Use Case lives in EditTool,
- * Framework (pi TUI) lives in TuiPresenter.
- */
-
-import type { ExtensionAPI, ToolDefinition } from "@earendil-works/pi-coding-agent";
-import type { TSchema } from "typebox";
-import {
-  prepareEditArguments,
-  EDIT_DESCRIPTION,
-  type NormalizedEditRequest,
-  type EditItem,
-  editToolSchema,
-  editItemSchema,
-  anchorFromSchema,
-  anchorToSchema,
-  editFileSchema,
-  editModeSchema,
-  assertReq,
-} from "./payload-contract.js";
-import { withPayloadSubject } from "./domain-errors.js";
-import { attributePayloadSubject } from "./error-envelope.js";
-import { createEditTool, type PreviewContext } from "./edit-tool.js";
-import { createTuiPresenter } from "./tui-presenter.js";
-import { loadP, loadGuide } from "./prompts.js";
-import type { EditDetails } from "./edit-response.js";
-import type { RPreview, RRState } from "./edit-render.js";
-
-void EDIT_DESCRIPTION;
-/** SAFETY: @deprecated Import from "./payload-contract.js" — single source per ADR-0007 */
-export { assertReq };
-/** SAFETY: @deprecated Import from "./payload-contract.js" — single source per ADR-0007. Re-exports retained for compatibility until next MAJOR. `replaceWithSchema` is REMOVED: the ticket-04 wire has no `replace_with` fold. */
-export {
-  editToolSchema,
-  editItemSchema,
-  anchorFromSchema,
-  anchorToSchema,
-  editFileSchema,
-  editModeSchema,
-};
-export { reuseText, reuseMarkdown } from "./tui-presenter.js";
-
-/** The wire item (ticket-04): exactly one payload — `text` or `text_ref` — plus optional `at`. */
-export type EditParams = EditItem;
-
-export type EditRequest = NormalizedEditRequest;
-
-export async function compPreview(
-  request: unknown,
-  cwd: string,
-  ctx: PreviewContext,
-): Promise<RPreview> {
-  const tool = createEditTool();
-  return tool.preview(request, cwd, ctx);
-}
-
-type ToolDef = ToolDefinition<TSchema, EditDetails, RRState> & {
-  renderShell?: "default" | "self";
-};
-
-export function buildToolDef(
-  getSessionManager?: () => { getSessionId(): string } | undefined,
-): ToolDef {
-  const E_DESC = loadP("../prompts/edit.md");
-  const E_SNIPPET = loadP("../prompts/edit-snippet.md");
-  const E_GUIDE = loadGuide("../prompts/edit-guidelines.md");
-  const parameters = editToolSchema;
-  const tool = createEditTool();
-  const presenter = createTuiPresenter(
-    // SAFETY: fire-time read is paired with the arm-time getSessionId below; DebouncedPreview
-    // SAFETY: drops the compute if the serving session changed between arming and firing.
-    (req, cwd) => {
-      // SAFETY: the fire-time read stays inside the call so the ctx names the session serving anchors now.
-      const sessionManager = getSessionManager?.();
-      return tool.preview(req, cwd, sessionManager === undefined ? {} : { sessionManager });
-    },
-    () => getSessionManager?.()?.getSessionId(),
-  );
-  return {
-    name: "edit",
-    label: "Edit",
-    description: E_DESC,
-    parameters,
-    promptSnippet: E_SNIPPET,
-    promptGuidelines: E_GUIDE,
-    // WHY: an admission refusal raised here carries no subject, so it must name the edit tool.
-    // WHY: Without the stamp the model reads the neutral wording — the analyzer names no caller.
-    prepareArguments: (args: unknown) => {
-      try {
-        return prepareEditArguments(args);
-      } catch (error) {
-        throw withPayloadSubject(error, "edit");
-      }
-    },
-    renderShell: "default",
-    // SAFETY: presenter owns TUI casts — asToolDef returns ToolDefinition-typed renders, edit.ts has zero direct TUI casts
-    ...presenter.asToolDef(),
-    async execute(_toolCallId, params, signal, _onUpdate, ctx) {
-      // SAFETY: pi execute boundary is untyped — ctx narrowed via sessionKeyFor, signal is AbortSignal validated by engine
-      try {
-        const res = await tool.execute(
-          params,
-          signal as AbortSignal | undefined,
-          // SAFETY: ctx is untyped at the pi boundary — cast validated by pi's runtime shape
-          ctx as unknown as {
-            cwd: string;
-            sessionManager?: { getSessionId(): string };
-          },
-        );
-        // SAFETY: res is validated tool result after tool.execute — cast to pi ToolDef return type for registration
-        return res as unknown as ReturnType<ToolDef["execute"]> extends Promise<infer R>
-          ? R
-          : never;
-      } catch (error) {
-        throw attributePayloadSubject(error, "edit");
-      }
-    },
-  };
-}
-
-export function regEdit(pi: ExtensionAPI): void {
-  // WHY: (#165) pi's ToolRenderContext carries no session, so the preview pane's session is
-  // WHY: captured from the session_start ctx — the same session reads serve anchors to.
-  // WHY: session_start fires for startup/reload/new/resume/fork, so the capture tracks switches.
-  // WHY: (#168-class) tracking a switch is only safe if the *pending* compute re-checks it:
-  // WHY: buildToolDef below exposes getSessionId so DebouncedPreview binds the serving session
-  // WHY: at arm time and drops (cancels) a compute whose session changed before the timer fires,
-  // WHY: instead of verifying anchors against a session that never served them.
-  let sessionManager: { getSessionId(): string } | undefined;
-  pi.on("session_start", (_event, ctx) => {
-    sessionManager = ctx.sessionManager;
-  });
-  pi.registerTool(buildToolDef(() => sessionManager));
-}