dsh-harbor-evolution 0.8.2 → 0.8.3

package/README.md

@@ -14,8 +14,8 @@ npx --yes dsh-harbor-evolution@latest setup --project-root "$PWD"
 
 The setup command installs both required runtimes:
 
-- `harbor-dsh-evolution==0.8.2` in a managed Python environment.
-- `dsh-harbor-evolution@0.8.2` in the selected DSH profile.
+- `harbor-dsh-evolution==0.8.3` in a managed Python environment.
+- `dsh-harbor-evolution@0.8.3` in the selected DSH profile.
 
 It then stores the absolute Harbor executable paths and a fallback `projectRoot` in the profile's `harbor-evolution` block and verifies the integration. Agent Tool calls always use the calling session's absolute working directory as their project root; the configured value remains the Web Workbench and non-Agent fallback. Existing unrelated profile entries are preserved, and rerunning setup updates the same block.
 

package/lib/evolution.js

@@ -154,6 +154,15 @@ async function cliJson(config, args, { allowedExitCodes = [0], input } = {}) {
   }
 }
 
+export function historicalDockerBlockers(value) {
+  const findings = Array.isArray(value?.findings) ? value.findings : []
+  return findings.filter(item => (
+    item?.level === 'error'
+    && typeof item.code === 'string'
+    && item.code.startsWith('DOCKER_')
+  ))
+}
+
 export async function inspectEvaluator(config, args = {}) {
   const stack = resolveWithin(config.projectRoot, args.stackPath ?? '.harbor/evaluation-stack.yml', 'stackPath')
   return cliJson(config, [
@@ -467,6 +476,16 @@ export async function runHistoricalEvaluation(config, args, modelRuntime) {
   ])
   const dataset = resolveWithin(projectRoot, materialized.dataset_path ?? output, 'historicalDataset')
   const stack = resolveWithin(projectRoot, materialized.stack_path, 'historicalStack')
+  // Fail fast on Docker runtime blockers (e.g. an unresolvable credential
+  // helper) before Harbor creates a Job whose Trials would all fail during
+  // environment setup and only report missing downstream artifacts.
+  const dockerCheck = await cliJson(config, ['docker-check'], { allowedExitCodes: [0, 2] })
+  const dockerBlockers = historicalDockerBlockers(dockerCheck)
+  if (dockerBlockers.length) {
+    throw new Error(
+      `HISTORICAL_DOCKER_PREFLIGHT_FAILED: Docker runtime preflight blocked the Historical Job:\n${dockerBlockers.map(item => `${item.code}: ${item.message}`).join('\n')}`,
+    )
+  }
   const batch = JSON.parse(await readFile(batchPath, 'utf8'))
   const jobs = resolveWithin(projectRoot, config.jobsDir, 'jobsDir')
   const jobName = args.jobName ?? makeHistoricalJobName(batch)

package/lib/process.js

@@ -1,10 +1,36 @@
 import { spawn } from 'node:child_process'
+import { existsSync } from 'node:fs'
+import path from 'node:path'
+
+const DOCKER_DESKTOP_BIN = '/Applications/Docker.app/Contents/Resources/bin'
+
+/**
+ * On macOS, Docker Desktop keeps `docker-credential-desktop` (and the other
+ * credential helpers) inside the app bundle, outside the default PATH that a
+ * GUI-launched Harness inherits. A missing helper makes `docker build`/`pull`
+ * fail with `exec: "docker-credential-desktop": executable file not found in
+ * $PATH` even though the CLI and daemon are reachable. Prepend that directory
+ * to PATH for every child process we spawn so Harbor inherits a resolvable
+ * helper. The change is macOS-only, existence-checked, and idempotent.
+ */
+export function dockerDesktopAwareEnv(env, {
+  platform = process.platform,
+  pathExists = existsSync,
+} = {}) {
+  const base = env ?? process.env
+  if (platform !== 'darwin') return base
+  if (!pathExists(DOCKER_DESKTOP_BIN)) return base
+  const current = String(base.PATH ?? '')
+  const segments = current.split(path.delimiter).filter(Boolean)
+  if (segments.includes(DOCKER_DESKTOP_BIN)) return base
+  return { ...base, PATH: [DOCKER_DESKTOP_BIN, ...segments].join(path.delimiter) }
+}
 
 export function runProcess(command, args, options = {}) {
   return new Promise((resolve, reject) => {
     const child = spawn(command, args, {
       cwd: options.cwd,
-      env: options.env ?? process.env,
+      env: dockerDesktopAwareEnv(options.env ?? process.env),
       shell: false,
       stdio: [options.input === undefined ? 'ignore' : 'pipe', 'pipe', 'pipe'],
     })

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dsh-harbor-evolution",
-  "version": "0.8.2",
+  "version": "0.8.3",
   "description": "DeepSeek Harness plugin and Skill for Harbor Candidate and Historical Session evaluation workflows.",
   "type": "module",
   "main": "index.js",