dsh-graft-plugin 0.2.0 → 0.2.1

package/README.md

@@ -135,6 +135,7 @@ All optional, all on the plugin's row in your profile's `cordis.patch.yml`:
 |---|---|
 | `0.1.2-rc.1` – `0.1.0-rc.7` | tested, full feature set — the `graft viz` tab via `dsh-better-sidebar` |
 | `0.1.5-rc.2` / `0.1.5` | tested — chip, tools, `/graft` and auto-rebuild all work; on `0.1.5` the `graft viz` button opens the graph in the built-in right sidebar |
+| `0.2.0-rc.2` | needs plugin `0.2.1`+ — earlier releases fail to activate (see Troubleshooting) |
 
 - Node 22+
 - the `graft` CLI on PATH (`npm install -g @nanonets/graft`)
@@ -168,6 +169,8 @@ registering "dsh-graft-plugin" via __ModuleLoader__.load
 
 **No chip appears and dsh started without errors.** The plugin is in the profile's `package.json` `dependencies` but not in `dsh.profile.bundles` — which happens under pnpm 10+ when the `add` ends non-zero on `ERR_PNPM_IGNORED_BUILDS`; dsh skips the bundle row in that case and starts up looking healthy. Fix: `pnpm approve-builds` in the profile directory (tick `dsh-graft-plugin`), then re-run `dsh plugin --profile web add dsh-graft-plugin`. If `pnpm approve-builds` reports nothing awaiting approval, check `pnpm-workspace.yaml` for an unanswered `dsh-graft-plugin` entry (pnpm's approval placeholder) and set its value to `true` first.
 
+**On dsh 0.2 the plugin fails to load with `strict codec has no create() factory`, and dsh offers to remove it.** dsh 0.2 requires every strict remote codec to carry a `create()` schema factory; plugin releases before `0.2.1` only had the 0.1 `schema` key. Update to `0.2.1` or later, which carries both and so loads on 0.1 and 0.2.
+
 **`/graft` says the graft CLI is not on PATH.** The postinstall was blocked or skipped (see Install): `npm install -g @nanonets/graft`.
 
 ## Licence

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dsh-graft-plugin",
-  "version": "0.2.0",
+  "version": "0.2.1",
   "description": "Shows which graft index a dsh session is serving and whether it still matches the code, and gives the model graft_ask, graft_grep, graft_callers, graft_skeleton and graft_map as native tools.",
   "type": "module",
   "main": "src/index.js",

package/scripts/test-harness.mjs

@@ -256,6 +256,42 @@ check('that dependency is soft too', clientSource.includes('ctx.inject(["sidebar
 check('the body reads the session from either host', clientSource.includes('props?.sessionId ?? props?.scope?.sessionId'))
 check('the browser tab survives only as the last resort', clientSource.includes('neither sidebar'))
 
+// The remote descriptors must survive dsh 0.2's typert codec validation, which
+// runs inside `ctx.remote.$mount`: a strict codec needs a typeSymbol and a
+// `create()` factory returning a schema with `parse`. The 0.1 shape (`schema`
+// only) threw "strict codec has no create() factory", rejected apply(), and
+// took the whole plugin down. The client may only use strict codecs for
+// parameters. The descriptor block is lifted out of client.js and evaluated,
+// so this tests the shipped objects, not a copy.
+console.log('\nremote descriptors (dsh 0.2 codec contract)')
+const descriptorBlock = /function identity\(value\) \{[\s\S]*?\r?\n    const CONTRIBUTION = \{[\s\S]*?\r?\n    \};/.exec(clientSource)?.[0]
+check('descriptor block found in client.js', descriptorBlock !== undefined)
+const CONTRIBUTION = descriptorBlock ? new Function(`${descriptorBlock}; return CONTRIBUTION;`)() : { descriptors: [] }
+function codecProblem(codec, { parameter }) {
+  if (!codec || typeof codec !== 'object') return 'missing codec'
+  if (codec.mode === 'src-json') return parameter ? 'client parameters must be strict' : undefined
+  if (codec.mode !== 'strict') return `unknown mode ${codec.mode}`
+  if (typeof codec.typeSymbol !== 'string' || codec.typeSymbol === '') return 'empty typeSymbol'
+  if (typeof codec.create !== 'function') return 'strict codec has no create() factory'
+  const schema = codec.create()
+  if (typeof schema?.parse !== 'function') return 'create() returned no parse()'
+  if (codec.create() !== schema) return 'create() is not memoized'
+  // dsh 0.1 read `schema` directly; keep it so older hosts still load.
+  if (typeof codec.schema?.parse !== 'function') return 'no 0.1 schema fallback'
+  return undefined
+}
+check('declares the status and viz descriptors', CONTRIBUTION.descriptors.map((d) => d.method).join() === 'status,viz')
+for (const d of CONTRIBUTION.descriptors) {
+  for (const p of d.parameters) {
+    const problem = codecProblem(p.codec, { parameter: true })
+    check(`${d.id} parameter ${p.name} codec is valid`, problem === undefined, problem)
+  }
+  const problem = codecProblem(d.result, { parameter: false })
+  check(`${d.id} result codec is valid`, problem === undefined, problem)
+  const sample = { ok: true, value: { root: '/r', nodeCount: 1 } }
+  check(`${d.id} result decodes as a pass-through`, d.result.create().parse(sample) === sample)
+}
+
 await rm(fixture, { recursive: true, force: true })
 
 console.log(failures === 0 ? '\nALL CHECKS PASSED' : `\n${failures} CHECK(S) FAILED`)

package/src/client.js

@@ -50,7 +50,21 @@ window.__ModuleLoader__.load({
     function identity(value) {
       return value;
     }
-    const CODEC = { mode: "strict", typeSymbol: "graft-status/json", schema: { parse: identity } };
+    /*
+     * Pass-through codec carrying both codec shapes: dsh 0.2's typert
+     * validator requires a strict codec to expose a `create()` factory
+     * returning the schema (it throws "strict codec has no create() factory"
+     * otherwise, failing `$mount` and with it the whole plugin), while dsh 0.1
+     * read `schema` directly. The host still runs assertJsonValue on every
+     * decoded value, so identity is safe.
+     */
+    const IDENTITY_SCHEMA = { parse: identity };
+    const CODEC = {
+      mode: "strict",
+      typeSymbol: "graft-status/json",
+      schema: IDENTITY_SCHEMA,
+      create: () => IDENTITY_SCHEMA,
+    };
     const descriptor = (method, names) => ({
       id: "graft-status#graftStatus/" + method,
       service: "graftStatus",
@@ -58,7 +72,7 @@ window.__ModuleLoader__.load({
       method,
       invocation: { kind: "direct" },
       parameters: names.map((name) => ({ name, wire: name, source: "json", codec: CODEC })),
-      result: { mode: "strict", typeSymbol: "graft-status/json", schema: { parse: identity } },
+      result: CODEC,
       sourceLocation: { file: "graft-status/client.js", line: 1, column: 1 },
     });
     const CONTRIBUTION = {