dsh-git-worktree 0.10.0 → 0.11.0

package/lib/session-checkout-module.js

@@ -1,3 +1,4 @@
+import { isValidCommitMessage } from './commit-message.js';
 import { hostMessages, hostPersistedCleanupMessage } from './i18n/host-messages.js';
 import { hostMessage } from './i18n/host.js';
 import { createHash } from 'node:crypto';
@@ -146,14 +147,11 @@ export function createSessionCheckoutModule(dependencies) {
         };
     }
     function projectPreviousReview(review) {
-        const suggestedCommitMessage = review.suggestedCommitMessage.length <= 500
-            ? review.suggestedCommitMessage
-            : review.suggestedCommitMessage.slice(0, 500).replace(/[\uD800-\uDBFF]$/u, '');
         return {
             reviewId: review.reviewId,
             iteration: review.iteration,
             summary: review.summary,
-            suggestedCommitMessage,
+            suggestedCommitMessage: review.suggestedCommitMessage,
             changedFiles: review.changedFiles.slice(0, 50),
         };
     }
@@ -1156,7 +1154,7 @@ export function createSessionCheckoutModule(dependencies) {
         }
         const summary = input.summary.trim();
         const suggestedCommitMessage = input.suggestedCommitMessage.trim();
-        if (!summary || !suggestedCommitMessage || input.tests.length > 20) {
+        if (!summary || !isValidCommitMessage(suggestedCommitMessage) || input.tests.length > 20) {
             throw new SessionCheckoutError('invalid_input', hostMessage('theReviewSummaryCommitMessageOrValidationItemsAre'));
         }
         const record = dependencies.registry.read().managedCheckouts[binding.target.checkoutId];
@@ -1220,8 +1218,7 @@ export function createSessionCheckoutModule(dependencies) {
             return operationError('not_owner', hostMessage('onlyTheOwnerIsolatedSessionCanSaveACheckpoint'));
         }
         const commitMessage = input.commitMessage.trim();
-        if (!commitMessage
-            || commitMessage.length > 500
+        if (!isValidCommitMessage(commitMessage)
             || !input.expectedReviewId.trim()
             || !/^[0-9a-f]{64}$/u.test(input.expectedGeneration)
             || !input.requestId.trim()
@@ -2461,6 +2458,9 @@ export function createSessionCheckoutModule(dependencies) {
         if (binding.ownerSessionId !== input.sessionId || binding.target.kind !== 'isolated') {
             return operationError('not_owner', hostMessage('onlyTheOwnerIsolatedSessionCanFinalizeTheAcceptance'));
         }
+        if (!isValidCommitMessage(input.commitMessage)) {
+            return operationError('invalid_input', hostMessage('theCommitMessageMustBeNonemptyAndContainNoNul'));
+        }
         const record = dependencies.registry.read().managedCheckouts[binding.target.checkoutId];
         if (!record)
             return operationError('checkout_missing', hostMessage('theIsolatedCheckoutRecordDoesNotExist'));
@@ -2620,6 +2620,9 @@ export function createSessionCheckoutModule(dependencies) {
         if (binding.target.kind !== 'isolated') {
             return operationError('operation_not_allowed', hostMessage('localCheckoutDoesNotSupportFinish'));
         }
+        if (!isValidCommitMessage(input.commitMessage)) {
+            return operationError('invalid_input', hostMessage('theCommitMessageMustBeNonemptyAndContainNoNul'));
+        }
         let record = dependencies.registry.read().managedCheckouts[binding.target.checkoutId];
         if (!record)
             return operationError('checkout_missing', hostMessage('theIsolatedCheckoutRecordDoesNotExist'));