dsh-diff-approval 0.20.1 → 0.22.0

package/lib/types/client/presentation-menu.d.ts

@@ -0,0 +1,45 @@
+/**
+ * The mode switch: where the panel shows — floating over the app, or docked as a
+ * tab in the app's right sidebar. (What the floating panel *covers* is the
+ * coverage control's business; see the panel's own header.)
+ *
+ * One implementation, two hosts. The floating panel draws it in its own header
+ * beside the gear. A *docked* panel draws no header at all — the tab is the
+ * frame, its chip already carries the title and a close button — so the chip
+ * (`sidebar.right.pane.tab.title`, which is this plugin's own component) hosts
+ * the same control instead: the seat's convention is a glyph *before* the title
+ * text, and the chip's tail is masked for the kit's own close button.
+ *
+ * @module dsh-diff-approval/client/presentation-menu
+ */
+import type { ReactNode } from 'react';
+import type { MenuEntry } from '@deepseek-ai/dsh-client-ui-primitives';
+import type { DiffApprovalPresentation } from './settings.ts';
+import type { Translator } from './locales.ts';
+/**
+ * The mode switch's mark: the state it currently shows, and the same glyph each
+ * menu row leads with. The dock mark is the icon the app's own right sidebar uses
+ * (`IconPanelLeftOutline16`, mirrored — see ui-sidebar-right's ExpandButton), so
+ * "dock" points at the same affordance the column does.
+ * @param props - the state, and the drawn size in px.
+ * @returns the glyph.
+ */
+export declare function PresentationIcon({ state, size }: {
+    state: DiffApprovalPresentation;
+    size: number;
+}): ReactNode;
+export interface PresentationMenuProps {
+    t: Translator;
+    /** Where the panel is now: the checked row, and the mark on the trigger. */
+    current: DiffApprovalPresentation;
+    onChoose: (next: DiffApprovalPresentation) => void;
+    /** Rows pinned below a hairline, for a host with no other way to reach them
+     *  (the chip carries this plugin's Settings; a docked panel has no gear). */
+    footer?: readonly MenuEntry[];
+    /** Called for a `footer` row's id, which is not a presentation. */
+    onFooter?: (id: string) => void;
+    /** The chip's variant: no room for the chevron, and a box the chip's 28px
+     *  height can hold. */
+    compact?: boolean;
+}
+export declare function PresentationMenu({ t, current, onChoose, footer, onFooter, compact }: PresentationMenuProps): ReactNode;

package/lib/types/client/settings.d.ts

@@ -1,4 +1,24 @@
 /** Client preferences for the review panel, persisted in localStorage. */
+/** Where the review panel shows: floating over the app, or docked as a tab in the
+ *  app's right sidebar. What the floating panel covers is a separate setting —
+ *  see {@link DiffApprovalCover}. */
+export type DiffApprovalPresentation = 'float' | 'dock';
+/**
+ * What the floating panel covers: the app's header above the conversation, its
+ * left sidebar, its right sidebar, and the composer below. All four on is the
+ * presentation the panel used to call "fullscreen" — the panel filling the
+ * window; both sidebars and the header only is the plain floating panel, which
+ * leaves the input usable.
+ */
+export interface DiffApprovalCover {
+    readonly top: boolean;
+    readonly left: boolean;
+    readonly right: boolean;
+    readonly composer: boolean;
+}
+/** The floating panel's default coverage: the header and both sidebars, not the
+ *  composer. */
+export declare const FLOAT_COVER_DEFAULT: DiffApprovalCover;
 /** Default lead rows above a jumped-to diff block (kept small and bounded). */
 export declare const NAV_LEAD_ROWS_DEFAULT = 2;
 export declare const NAV_LEAD_ROWS_MIN = 0;
@@ -61,6 +81,42 @@ export declare function setSearchCaseSensitive(value: boolean): void;
 export declare function searchWholeWord(): boolean;
 /** Persist the search whole-word preference. */
 export declare function setSearchWholeWord(value: boolean): void;
+/**
+ * Where the review panel shows, as the user last had it. Two states, both
+ * remembered so the footer entry can restore the one they were using:
+ *
+ * - `float` — the panel floating over the app, covering what
+ *   {@link panelCover} says (and the composer only when that says so);
+ * - `dock` — the panel docked in the app's right sidebar, as its own tab.
+ *
+ * A stored `fullscreen` — the third state before coverage became three switches —
+ * reads as `float`, with {@link panelCover} supplying the all-on coverage it
+ * meant.
+ * @returns the remembered presentation; `float` when unset or unrecognized.
+ */
+export declare function panelPresentation(): DiffApprovalPresentation;
+/** Persist the panel's presentation (see {@link panelPresentation}). */
+export declare function setPanelPresentation(value: DiffApprovalPresentation): void;
+/**
+ * What the floating panel covers (see {@link DiffApprovalCover}). Defaults to
+ * both sidebars and not the composer; a stored `fullscreen` presentation from
+ * before the switches means all three.
+ * @returns the remembered coverage.
+ */
+export declare function panelCover(): DiffApprovalCover;
+/** Window event: the floating panel's coverage changed (see {@link setPanelCover}). */
+export declare const COVER_CHANGED_EVENT = "diff-approval:cover";
+/** Persist what the floating panel covers. */
+export declare function setPanelCover(value: DiffApprovalCover): void;
+/**
+ * Whether the file list always folds into its floating card, whatever width the
+ * panel has. Defaults to off, where the width decides: the list sits beside the
+ * diff while there is room for both. Only an explicit `'1'` forces the fold.
+ * @returns whether the file list is always folded.
+ */
+export declare function fileListFloat(): boolean;
+/** Persist the always-fold preference for the file list. */
+export declare function setFileListFloat(value: boolean): void;
 /**
  * Whether lines wrap (auto-wrap) in the diff for one highlight language.
  * Defaults to off; only an explicit `'1'` enables it. Stored per language, so
@@ -171,7 +227,9 @@ export declare function quickSummonKey(): string;
 /** Persist the quick-summon chord. */
 export declare function setQuickSummonKey(value: string): void;
 /** Default chord for each configurable action (every supported key except the
- *  panel's own ESC-to-close, which is intentionally not remapped). */
+ *  panel's own ESC-to-close, which is intentionally not remapped). The coverage
+ *  switches are keyed like the edges they toggle, in the order the panel lists
+ *  them: left, top, right, bottom. */
 export declare const DEFAULT_KEYBINDINGS: Record<string, string>;
 /** The currently configured chord for one action; falls back to its default. */
 export declare function keybindingOf(action: string): string;

package/lib/types/client/slots.d.ts

@@ -1,6 +1,7 @@
 /** The panel's injected business face and its observable snapshot. */
 import type { HostObservable } from '@deepseek-ai/dsh-client-ui-slots';
 import type { SessionId } from '@deepseek-ai/dsh-client-connection/client';
+import type { DockSnapshot } from './dock.tsx';
 import type { DiffApprovalAddValue, DiffApprovalBlockRange, DiffApprovalBrowseValue, DiffApprovalOpenAction, DiffApprovalRefreshValue, PendingFileDiff, VcsImportValue } from '../types.ts';
 /** What the panel reads and drives: the pending list plus in-flight entries. */
 export interface PendingDiffSnapshot {
@@ -26,7 +27,23 @@ export interface PendingPanelFace {
     hooks: {
         /** Live pending-diff snapshot for the current page. */
         pending: HostObservable<PendingDiffSnapshot>;
+        /** The dock's state (whether our right-sidebar tab is showing), or absent
+         *  when this build has no right sidebar to dock into. */
+        dock?: HostObservable<DockSnapshot>;
     };
+    /** Reveal the panel in the app's right sidebar, opening its tab if needed.
+     *  Absent when this build has no right sidebar: the panel then opens floating
+     *  whatever the remembered presentation says. */
+    onOpenDock?: (() => void) | undefined;
+    /** The docked tab body's own visibility, so the footer entry can light up
+     *  while the panel lives in the sidebar. */
+    onDockShowing?: ((showing: boolean) => void) | undefined;
+    /** Close the docked panel: the docked tab's own close, published by its chip.
+     *  `undefined` while no dock tab exists. */
+    onDockClose?: ((close: (() => void) | undefined) => void) | undefined;
+    /** Close the docked tab now, when one exists (the quick-summon chord's job
+     *  while the panel lives in the sidebar). */
+    closeDock?: (() => void) | undefined;
     /** Read the pending list for the current session into the snapshot. */
     onRefresh: (sessionId: SessionId | undefined) => void;
     /** Keep one operation. `keepListed` leaves the resolved entry in the list. */
@@ -64,7 +81,7 @@ export interface PendingPanelFace {
     onRevertAll: (sessionId: SessionId) => Promise<void>;
     /** Acknowledge the redo-cleared notice so it is only surfaced once. */
     onAckRedoCleared: () => void;
-    /** Collapse the DSH sidebar (no-op when already collapsed) before the modal
-     * opens or fullscreens, so an expanded sidebar can't overlap the modal. */
+    /** Collapse the DSH sidebar (no-op when already collapsed) before the floating
+     *  modal opens on a narrow window, so the sidebar can't overlap it. */
     collapseSidebar: () => void;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dsh-diff-approval",
-  "version": "0.20.1",
+  "version": "0.22.0",
   "description": "DeepSeek Harness plugin: pending-edit review with whole-file diff and Keep/Revert",
   "packageManager": "pnpm@11.21.0",
   "author": "Wu Zhiwei",