dsh-data-quality 0.3.9 → 0.3.11

package/src/events.ts

@@ -15,6 +15,13 @@
  *   durable copy. On 0.1.2-alpha.3 the envelope field is retained for stored-log
  *   read compatibility only - its Session.append still cannot stamp the marker,
  *   so the gate behavior is unchanged.
+ * - On the 0.1.6-alpha.2 line `Session.append<T>(type, data, ...opts)` takes a
+ *   third argument only for surface-eligible event types, and that argument is
+ *   a `SurfaceIntent` (an append/replace marker), never an `ignorable`
+ *   envelope: a non-surface `data-quality/*` type has no third parameter at
+ *   all, so the source-text probe below still finds no `ignorable` handling and
+ *   the result stays **skip** - the storage-domain report is the durable copy
+ *   on alpha.2 exactly as on the earlier lines.
  * @module dsh-data-quality/events
  */
 
@@ -69,7 +76,12 @@ export const DATA_QUALITY_EVENT_TYPES = ['data-quality/profile', 'data-quality/c
 /** Union of the event types this plugin appends. */
 export type DataQualityEventType = (typeof DATA_QUALITY_EVENT_TYPES)[number]
 
-/** Loose append shape probed at runtime (rc.6/rc.8/0.1.2-alpha.1 take no options; pre-0.1.2 master builds took `ignorable`). */
+/**
+ * Loose append shape probed at runtime (rc.6/rc.8/0.1.2-alpha.1 take no
+ * options; pre-0.1.2 master builds took `ignorable`; the 0.1.6-alpha.2 third
+ * parameter is a `SurfaceIntent` and exists only for surface-eligible types,
+ * so a `data-quality/*` call there has no third argument).
+ */
 type AppendProbe = (type: string, data: unknown, options?: { ignorable: true }) => unknown
 
 /**

package/src/index.ts

@@ -102,6 +102,14 @@ export async function apply(ctx: Context, config: Config = {}): Promise<void> {
   let domain: Domain<typeof dataQualityDomainSpec> | undefined
   if (resolved.storeReports) {
     domain = await ctx.storageDomain.open(dataQualityDomainSpec)
+    // Disposal during the open await: the fiber is gone, so nothing may be
+    // registered any more — release the freshly opened handle instead of
+    // leaking it (the storage facility is single-open per name, so an
+    // unreleased handle also blocks a later remount).
+    if (ctx.fiber.uid === null) {
+      await domain.close()
+      return
+    }
     const reports = domain.table('reports')
     store = {
       put: async (record) => {
@@ -118,12 +126,19 @@ export async function apply(ctx: Context, config: Config = {}): Promise<void> {
     }
   }
 
-  // Service Provider: constructs the local DataQualityService (which publishes ctx.dataQuality) and registers the four model tools below through ctx.tools.register.
+  // Service Provider: constructs the local DataQualityService (which publishes ctx.dataQuality) and registers the four model tools below through ctx.tools.register. The registrations live in one effect whose disposer unregisters them in reverse order, so an unmount during apply can neither lose a registration nor leave one behind.
   const service = new LocalDataQualityService(ctx, resolved, { store, now: Date.now })
-  ctx.tools.register(defineProfileTool(service))
-  ctx.tools.register(defineCleanTool(service))
-  ctx.tools.register(defineVerifyTool(service))
-  ctx.tools.register(defineReportTool(service))
+  ctx.effect(() => {
+    const disposers = [
+      ctx.tools.register(defineProfileTool(service)),
+      ctx.tools.register(defineCleanTool(service)),
+      ctx.tools.register(defineVerifyTool(service)),
+      ctx.tools.register(defineReportTool(service)),
+    ]
+    return () => {
+      for (const dispose of disposers.reverse()) dispose()
+    }
+  }, 'dsh-data-quality: tools')
   logger.info(`dsh-data-quality ${VERSION} mounted: ctx.dataQuality + data_profile/data_clean/data_verify/data_report`)
 
   if (domain !== undefined) {

package/src/version.ts

@@ -5,7 +5,7 @@
  */
 
 /** The package version reported in persisted reports. */
-export const VERSION = '0.3.9'
+export const VERSION = '0.3.11'
 
 /**
  * Version of the persisted report schema. Bump it whenever a report's