dsh-context-compression-improved 0.5.1 → 0.5.3

package/packages/selector/tests/review-routes-registry.host.spec.ts

@@ -1,142 +0,0 @@
-/**
- * Production-shaped guard for the review routes' pruner resolution.
- *
- * The older suite provided `toolResultPruner` at the TOP LEVEL, which is a shape
- * production never has: `canonicalCompressionRows()` mounts every pruner inside
- * an agent preset's isolated group, so a top-level `ctx.get('toolResultPruner')`
- * resolves nothing and the queue route answered 503 "review pipeline
- * unavailable" for every request while the pipeline itself ran normally.
- *
- * These cases mount NO top-level service and publish through the review registry
- * from a CHILD fiber instead — the path the fix relies on.
- */
-
-import { Context } from '@deepseek-ai/cordis'
-import { afterEach, describe, expect, it } from 'vitest'
-import { apply } from '../src/index.ts'
-import { registerReviewPruner, type ReviewPrunerFace } from '../src/runtime/tokenpilot/review-registry.ts'
-
-const QUEUE_ROUTE = '/api/dsh-context-compression-improved/review-queue'
-
-interface RegisteredRoute {
-  kind: string
-  path: string
-  handler: (req: unknown, res: unknown) => unknown
-}
-
-let ctx: Context | undefined
-
-afterEach(async () => {
-  await ctx?.fiber.dispose()
-  ctx = undefined
-})
-
-const settle = (): Promise<void> => new Promise(resolve => setTimeout(resolve, 20))
-
-/** A pruner face carrying one pending proposal for session `s1`. */
-const SAMPLE = {
-  id: 'abc123def456',
-  kind: 'read-state',
-  items: [{ seq: 6, kind: 'read-state', component: 'history', tokensBefore: 2401, tokensAfter: 134 }],
-  benefit: { recoveredTokens: 400, penaltyTokens: 900, paybackTurns: 2.25 },
-  enqueuedTurn: 3,
-  lastTurnIndex: 3,
-} as const
-
-function samplePruner(): ReviewPrunerFace {
-  return {
-    listReviewProposals: (session: unknown) => ((session as { id?: string }).id === 's1' ? [SAMPLE] : []),
-    listAllReviewProposals: () => [{ sessionId: 's1', proposals: [SAMPLE] }],
-    reviewSummary: () => ({ autoApplied: 2, reviewApplied: 1, expired: 3, voided: 0 }),
-    decideReviewProposal: (_session: unknown, proposalId: string) => (proposalId === SAMPLE.id
-      ? { ok: true }
-      : { ok: false, reason: 'unknown-proposal' }),
-  }
-}
-
-/** Mount the fake web server the routes register against. */
-async function mountWebServer(runtime: Context, routes: RegisteredRoute[]): Promise<void> {
-  await runtime.plugin({
-    name: 'fake-webserver',
-    apply(webCtx) {
-      webCtx.provide('webServer', {
-        tables: { exact: new Map<string, RegisteredRoute>() },
-        register(this: { tables: { exact: Map<string, RegisteredRoute> } }, route: RegisteredRoute) {
-          const table = this.tables.exact
-          if (table.has(route.path)) throw new Error(`webserver: duplicate ${route.path}`)
-          table.set(route.path, route)
-          routes.push(route)
-          return () => {}
-        },
-      })
-    },
-  })
-}
-
-/** Boot the host plugin with both routes opted in, as the Bundle row does. */
-async function bootWithRoutes(): Promise<RegisteredRoute[]> {
-  const routes: RegisteredRoute[] = []
-  ctx = new Context()
-  await mountWebServer(ctx, routes)
-  apply(ctx, { estimatorCatalogRoute: true, reviewQueueRoute: true })
-  await settle()
-  return routes
-}
-
-async function readQueue(routes: RegisteredRoute[]): Promise<{ status: number, body: string }> {
-  const route = routes.find(candidate => candidate.path === QUEUE_ROUTE)
-  expect(route, `route ${QUEUE_ROUTE} must be registered`).toBeDefined()
-  // `exactOptionalPropertyTypes` forbids assigning an explicit `undefined` to an
-  // optional property, so the widened type must spell it out.
-  const captured: { status?: number, body?: string | undefined } = {}
-  const res = {
-    writeHead(code: number) { captured.status = code },
-    end(body?: string) { captured.body = body },
-  }
-  await route!.handler({ url: QUEUE_ROUTE }, res)
-  return { status: captured.status ?? 0, body: captured.body ?? '' }
-}
-
-describe('review routes resolve a preset-scoped pruner', () => {
-  it('answers 503 while no pruner has been published', async () => {
-    const routes = await bootWithRoutes()
-    const { status, body } = await readQueue(routes)
-    expect(status).toBe(503)
-    expect(body).toContain('review pipeline unavailable')
-  })
-
-  it('reaches a pruner published from a CHILD fiber with no top-level service', async () => {
-    const routes = await bootWithRoutes()
-    // Production shape: the pruner is mounted in a preset's isolated group.
-    await ctx!.plugin({
-      name: 'preset-scoped-pruner',
-      apply(childCtx) {
-        childCtx.effect(() => registerReviewPruner(samplePruner()), 'test-preset-pruner')
-      },
-    })
-    await settle()
-
-    const { status, body } = await readQueue(routes)
-    expect(status).toBe(200)
-    const parsed = JSON.parse(body) as { ok: boolean, total: number, pending: readonly { id: string }[] }
-    expect(parsed.ok).toBe(true)
-    expect(parsed.total).toBe(1)
-    expect(parsed.pending[0]?.id).toBe(SAMPLE.id)
-  })
-
-  it('drops back to 503 once the publishing fiber disposes', async () => {
-    const routes = await bootWithRoutes()
-    const fork = await ctx!.plugin({
-      name: 'preset-scoped-pruner',
-      apply(childCtx) {
-        childCtx.effect(() => registerReviewPruner(samplePruner()), 'test-preset-pruner')
-      },
-    })
-    await settle()
-    expect((await readQueue(routes)).status).toBe(200)
-
-    await fork.dispose()
-    await settle()
-    expect((await readQueue(routes)).status).toBe(503)
-  })
-})

package/packages/selector/tests/review-routes.host.spec.ts

@@ -1,290 +0,0 @@
-/**
- * Host-side guard for the review pipeline's HTTP transport (R4).
- *
- * Pins the client↔runtime contract: the two routes (queue read, decide write)
- * register under both prefixes, the happy path answers a sanitized payload
- * (ids/seqs/counts, never digests or content), and every error path answers a
- * precise status — 400 for malformed input, 404 for unknown session/proposal,
- * 503 when the review pipeline is not serving the session.
- */
-
-import { Context } from '@deepseek-ai/cordis'
-import { afterEach, describe, expect, it } from 'vitest'
-import { apply } from '../src/index.ts'
-
-const QUEUE_ROUTE = '/api/dsh-context-compression-improved/review-queue'
-const DECIDE_ROUTE = '/api/dsh-context-compression-improved/review-decide'
-const LEGACY_QUEUE_ROUTE = '/endpoint/dsh-context-compression-improved/review-queue'
-const LEGACY_DECIDE_ROUTE = '/endpoint/dsh-context-compression-improved/review-decide'
-
-interface RegisteredRoute {
-  kind: string
-  path: string
-  handler: (req: unknown, res: unknown) => unknown
-}
-
-interface FakeResponse {
-  status?: number
-  body?: string
-}
-
-let ctx: Context | undefined
-
-afterEach(async () => {
-  await ctx?.fiber.dispose()
-  ctx = undefined
-})
-
-const settle = (): Promise<void> => new Promise(resolve => setTimeout(resolve, 20))
-
-async function mountWebServer(runtime: Context, routes: RegisteredRoute[]): Promise<void> {
-  await runtime.plugin({
-    name: 'fake-webserver',
-    apply(webCtx) {
-      webCtx.provide('webServer', {
-        tables: { exact: new Map<string, RegisteredRoute>() },
-        register(this: { tables: { exact: Map<string, RegisteredRoute> } }, route: RegisteredRoute) {
-          const table = this.tables.exact
-          if (table.has(route.path)) {
-            throw new Error(`webserver: duplicate ${route.kind} route "${route.path}"`)
-          }
-          table.set(route.path, route)
-          routes.push(route)
-          return () => {}
-        },
-      })
-    },
-  })
-}
-
-interface PrunerBehavior {
-  readonly reviewOn: boolean
-  decideOutcome?: { ok: true } | { ok: false, reason: string } | undefined
-}
-
-function mountReviewServices(runtime: Context, behavior: PrunerBehavior): void {
-  void runtime.plugin({
-    name: 'fake-review-services',
-    apply(serviceCtx) {
-      serviceCtx.provide('agents', {
-        get: (id: unknown) => (id === 's1' ? { session: { id: 's1' } } : undefined),
-      })
-      const sampleProposal = {
-        id: 'abc123def456',
-        kind: 'read-state',
-        status: 'pending',
-        items: [{
-          seq: 6, kind: 'read-state', component: 'history', tokensBefore: 2401, tokensAfter: 134,
-          digest: 'dd'.repeat(32),
-        }],
-        benefit: { recoveredTokens: 400, penaltyTokens: 900, paybackTurns: 2.25 },
-        enqueuedTurn: 3,
-        lastTurnIndex: 3,
-      }
-      serviceCtx.provide('toolResultPruner', {
-        listReviewProposals: (session: unknown) => {
-          const id = (session as { id?: string }).id
-          return id === 's1' && behavior.reviewOn ? [sampleProposal] : []
-        },
-        listAllReviewProposals: () => (behavior.reviewOn
-          ? [{ sessionId: 's1', proposals: [sampleProposal] }]
-          : []),
-        reviewSummary: () => ({ autoApplied: 2, reviewApplied: 1, expired: 3, voided: 0 }),
-        decideReviewProposal: (_session: unknown, proposalId: string) => {
-          if (behavior.reviewOn === false) return undefined
-          if (proposalId !== 'abc123def456') return { ok: false, reason: 'unknown-proposal' }
-          return behavior.decideOutcome ?? { ok: true }
-        },
-      })
-    },
-  })
-}
-
-async function invoke(route: RegisteredRoute, req?: unknown): Promise<FakeResponse> {
-  const captured: FakeResponse = {}
-  const res = {
-    writeHead(code: number) { captured.status = code },
-    end(body?: string) { if (body !== undefined) captured.body = body },
-  }
-  await route.handler(req ?? { method: 'GET' }, res)
-  await settle()
-  return captured
-}
-
-describe('review queue route registration', () => {
-  it('registers both route prefixes only when the row opts in', async () => {
-    const routes: RegisteredRoute[] = []
-    const runtime = new Context()
-    ctx = runtime
-    await mountWebServer(runtime, routes)
-
-    apply(runtime, { reviewQueueRoute: true })
-    await settle()
-
-    expect(routes.map(route => route.path)).toEqual([
-      LEGACY_QUEUE_ROUTE, QUEUE_ROUTE, LEGACY_DECIDE_ROUTE, DECIDE_ROUTE,
-    ])
-
-    const routesAfterOptOut: RegisteredRoute[] = []
-    const plain = new Context()
-    ctx = plain
-    await mountWebServer(plain, routesAfterOptOut)
-    apply(plain, { presetOverlay: false })
-    await settle()
-    expect(routesAfterOptOut).toHaveLength(0)
-  })
-
-  it('answers the queue read with a sanitized payload', async () => {
-    const routes: RegisteredRoute[] = []
-    const runtime = new Context()
-    ctx = runtime
-    await mountWebServer(runtime, routes)
-    mountReviewServices(runtime, { reviewOn: true })
-    apply(runtime, { reviewQueueRoute: true })
-    await settle()
-
-    const route = routes.find(candidate => candidate.path === QUEUE_ROUTE)
-    const response = await invoke(route as RegisteredRoute, { url: `${QUEUE_ROUTE}?sessionId=s1` })
-
-    expect(response.status).toBe(200)
-    const body = JSON.parse(String(response.body)) as {
-      ok: boolean
-      summary?: Record<string, number>
-      pending: readonly { id: string, items: readonly Record<string, unknown>[] }[]
-    }
-    expect(body.ok).toBe(true)
-    expect(body.pending).toHaveLength(1)
-    expect(body.pending[0]!.id).toBe('abc123def456')
-    expect(body.summary).toEqual({ autoApplied: 2, reviewApplied: 1, expired: 3, voided: 0 })
-    // Digests never leave the runtime: the client only needs ids and counts.
-    expect(String(response.body)).not.toContain('digest')
-    expect(String(response.body)).not.toContain('"content"')
-  })
-
-  it('aggregates every live session when the read carries no sessionId', async () => {
-    const routes: RegisteredRoute[] = []
-    const runtime = new Context()
-    ctx = runtime
-    await mountWebServer(runtime, routes)
-    mountReviewServices(runtime, { reviewOn: true })
-    apply(runtime, { reviewQueueRoute: true })
-    await settle()
-
-    const route = routes.find(candidate => candidate.path === QUEUE_ROUTE) as RegisteredRoute
-    const response = await invoke(route, { url: QUEUE_ROUTE })
-
-    expect(response.status).toBe(200)
-    const body = JSON.parse(String(response.body)) as {
-      ok: boolean
-      total: number
-      pending: readonly { sessionId: string, id: string }[]
-    }
-    expect(body).toMatchObject({ ok: true, total: 1 })
-    expect(body.pending[0]).toMatchObject({ sessionId: 's1', id: 'abc123def456' })
-  })
-
-  it('rejects a queue read for an unknown session', async () => {
-    const routes: RegisteredRoute[] = []
-    const runtime = new Context()
-    ctx = runtime
-    await mountWebServer(runtime, routes)
-    mountReviewServices(runtime, { reviewOn: true })
-    apply(runtime, { reviewQueueRoute: true })
-    await settle()
-    const route = routes.find(candidate => candidate.path === QUEUE_ROUTE) as RegisteredRoute
-
-    const unknown = await invoke(route, { url: `${QUEUE_ROUTE}?sessionId=nope` })
-    expect(unknown.status).toBe(404)
-  })
-
-  it('answers 503 when the pruner is not serving review proposals', async () => {
-    const routes: RegisteredRoute[] = []
-    const runtime = new Context()
-    ctx = runtime
-    await mountWebServer(runtime, routes)
-    apply(runtime, { reviewQueueRoute: true })
-    await settle()
-
-    const route = routes.find(candidate => candidate.path === QUEUE_ROUTE) as RegisteredRoute
-    const response = await invoke(route, { url: `${QUEUE_ROUTE}?sessionId=s1` })
-    expect(response.status).toBe(503)
-  })
-
-  it('rejects malformed decide bodies with 400', async () => {
-    const routes: RegisteredRoute[] = []
-    const runtime = new Context()
-    ctx = runtime
-    await mountWebServer(runtime, routes)
-    mountReviewServices(runtime, { reviewOn: true })
-    apply(runtime, { reviewQueueRoute: true })
-    await settle()
-    const route = routes.find(candidate => candidate.path === DECIDE_ROUTE) as RegisteredRoute
-
-    const notJson = await invoke(route, { on: (event: string, listener: (chunk?: Buffer) => void) => {
-      if (event === 'end') listener()
-    } })
-    expect(notJson.status).toBe(400)
-
-    const missingDecision = await invoke(route, { on: (event: string, listener: (chunk?: Buffer) => void) => {
-      if (event === 'data') listener(Buffer.from(JSON.stringify({ sessionId: 's1', proposalId: 'abc123def456' })))
-      if (event === 'end') listener()
-    } })
-    expect(missingDecision.status).toBe(400)
-
-    const badDecision = await invoke(route, { on: (event: string, listener: (chunk?: Buffer) => void) => {
-      if (event === 'data') listener(Buffer.from(JSON.stringify({ sessionId: 's1', proposalId: 'abc123def456', decision: 'maybe' })))
-      if (event === 'end') listener()
-    } })
-    expect(badDecision.status).toBe(400)
-  })
-
-  it('maps decide outcomes to 200, 404, and 503', async () => {
-    const routes: RegisteredRoute[] = []
-    const runtime = new Context()
-    ctx = runtime
-    await mountWebServer(runtime, routes)
-    mountReviewServices(runtime, { reviewOn: true })
-    apply(runtime, { reviewQueueRoute: true })
-    await settle()
-    const route = routes.find(candidate => candidate.path === DECIDE_ROUTE) as RegisteredRoute
-
-    const post = (body: unknown): unknown => ({
-      on: (event: string, listener: (chunk?: Buffer) => void) => {
-        if (event === 'data') listener(Buffer.from(JSON.stringify(body)))
-        if (event === 'end') listener()
-      },
-    })
-
-    const ok = await invoke(route, post({ sessionId: 's1', proposalId: 'abc123def456', decision: 'approved' }))
-    expect(ok.status).toBe(200)
-    expect(JSON.parse(String(ok.body))).toMatchObject({ ok: true, decision: 'approved' })
-
-    const unknownProposal = await invoke(route, post({ sessionId: 's1', proposalId: 'nope', decision: 'approved' }))
-    expect(unknownProposal.status).toBe(404)
-
-    const unknownSession = await invoke(route, post({ sessionId: 'nope', proposalId: 'abc123def456', decision: 'approved' }))
-    expect(unknownSession.status).toBe(404)
-  })
-
-  it('answers 503 when review mode is off for the session', async () => {
-    const routes: RegisteredRoute[] = []
-    const runtime = new Context()
-    ctx = runtime
-    await mountWebServer(runtime, routes)
-    mountReviewServices(runtime, { reviewOn: false })
-    apply(runtime, { reviewQueueRoute: true })
-    await settle()
-
-    const queueRoute = routes.find(candidate => candidate.path === QUEUE_ROUTE) as RegisteredRoute
-    expect((await invoke(queueRoute, { url: `${QUEUE_ROUTE}?sessionId=s1` })).status).toBe(200)
-
-    const decideRoute = routes.find(candidate => candidate.path === DECIDE_ROUTE) as RegisteredRoute
-    const response = await invoke(decideRoute, {
-      on: (event: string, listener: (chunk?: Buffer) => void) => {
-        if (event === 'data') listener(Buffer.from(JSON.stringify({ sessionId: 's1', proposalId: 'abc123def456', decision: 'approved' })))
-        if (event === 'end') listener()
-      },
-    })
-    expect(response.status).toBe(503)
-  })
-})