dsh-context-compression-improved 0.5.0 → 0.5.2

package/packages/selector/tests/settings-seat.client.spec.ts

@@ -3,12 +3,14 @@
  *
  * This spec locks WHERE the compression settings panel mounts: exactly ONE
  * seat — the standalone `settings.section` entry (设置 → 上下文压缩) — and
- * explicitly NOT the Plugins-section surfaces. History this pins against: the
- * 0.1.5 line first lost every entry (a lazy `ctx.get` of locale/settingsScope
- * raced the settings client and apply bailed), then showed the panel twice
- * (item card + tab on top of the standalone section). Both were fixed by the
- * declarative-inject + single-section shape below. When a future DSH line
- * moves the seat again, migrate src/client/index.ts AND this file together.
+ * explicitly NOT the Plugins-section surfaces, and NOT a `shell.overlay` float
+ * (the retired review panel's seat was removed with the gate). History this
+ * pins against: the 0.1.5 line first lost every entry (a lazy `ctx.get` of
+ * locale/settingsScope raced the settings client and apply bailed), then showed
+ * the panel twice (item card + tab on top of the standalone section). Both were
+ * fixed by the declarative-inject + single-section shape below. When a future
+ * DSH line moves the seat again, migrate src/client/index.ts AND this file
+ * together.
  */
 import { describe, expect, it, vi } from 'vitest'
 import type { Context as ClientContext } from '@deepseek-ai/cordis'
@@ -58,12 +60,16 @@ describe('settings-seat contract (standalone settings.section only)', () => {
     expect(inject).toEqual(['slots', 'locale', 'settingsScope'])
   })
 
-  it('injects exactly the settings.section seat plus the shell.overlay float', () => {
+  it('injects exactly the settings.section seat and nothing else', () => {
     const { declared, registrations } = collectRegistrations()
-    expect(declared).toEqual(['settings.section', 'shell.overlay'])
-    expect(registrations).toHaveLength(2)
+    expect(declared).toEqual(['settings.section'])
+    expect(registrations).toHaveLength(1)
     expect(registrations[0]!.slot).toBe('settings.section')
-    expect(registrations[1]!.slot).toBe('shell.overlay')
+  })
+
+  it('no longer claims a shell.overlay float (the review panel it served is gone)', () => {
+    const { declared } = collectRegistrations()
+    expect(declared).not.toContain('shell.overlay')
   })
 
   it('pins the section identity (id/order/label/locale) and the panel component', () => {

package/packages/selector/tests/standing-generation.host.spec.ts

@@ -101,6 +101,37 @@ async function overlayFiles(sourceMarker: string): Promise<{ path: string, rende
   return files
 }
 
+/**
+ * The mtime this platform actually persists for one given stamp.
+ *
+ * `node:fs` `utimes` writes the seconds component through a 32-bit field on
+ * Windows: on node v22 win32, `utimes(file, 4677832452 s)` reads back as
+ * `382865156 s` — exactly `seconds >>> 0` — while sub-second precision
+ * survives. The standing stamp deliberately parks identities around year 2162
+ * (`STANDING_MTIME_EPOCH_SECONDS + 0xffffffff`, src/preset-overlay.ts), so its
+ * seconds component sits past that 2^32-second horizon (max year 2106) and the
+ * persisted literal differs on that platform. Deterministically so: the wrap is
+ * a pure function of the identity stamp, which is why identity → mtime stays
+ * stable and the collision escalation still absorbs any merge.
+ *
+ * Instead of hardcoding the platform or weakening the assertion, calibrate:
+ * ask the filesystem what it stores for exactly this stamp, then require the
+ * overlay to persist that same value. On a platform with a full-width seconds
+ * field this collapses to the stamp itself, so the assertion stays strict.
+ */
+async function platformPersistedMs(stampMs: number): Promise<number> {
+  const directory = await mkdtemp(join(tmpdir(), 'dsh-selector-mtime-probe-'))
+  const probe = join(directory, 'probe')
+  try {
+    await writeFile(probe, 'probe')
+    const stamp = new Date(stampMs)
+    await utimes(probe, stamp, stamp)
+    return (await stat(probe)).mtimeMs
+  } finally {
+    await rm(directory, { recursive: true, force: true })
+  }
+}
+
 let sourceRoot: string | undefined
 
 /** Rewrite the source preset to an equal-length marker module. */
@@ -329,8 +360,17 @@ describe('real AgentPresets standing generations with the overlay threshold', ()
     expect(firstStat.size).toBe(secondStat.size)
     expect(firstStat.mtimeMs % 1000).toBe(0)
     expect(secondStat.mtimeMs % 1000).toBe(0)
-    expect(firstStat.mtimeMs).toBe(Math.floor(standingStampMsAtWindow(collision.firstIdentity, 0) / 1000) * 1000)
-    expect(secondStat.mtimeMs).toBe(Math.floor(standingStampMsAtWindow(collision.secondIdentity, 1) / 1000) * 1000)
+    // The coarse metadata surface floors both stamps to a whole second, and the
+    // platform may additionally wrap the seconds field (platformPersistedMs),
+    // so require exactly what the filesystem stores for those identity stamps.
+    const firstStamp = await platformPersistedMs(
+      Math.floor(standingStampMsAtWindow(collision.firstIdentity, 0) / 1000) * 1000,
+    )
+    const secondStamp = await platformPersistedMs(
+      Math.floor(standingStampMsAtWindow(collision.secondIdentity, 1) / 1000) * 1000,
+    )
+    expect(Math.floor(firstStat.mtimeMs / 1000)).toBe(Math.floor(firstStamp / 1000))
+    expect(Math.floor(secondStat.mtimeMs / 1000)).toBe(Math.floor(secondStamp / 1000))
 
     await installation.dispose()
   })
@@ -382,11 +422,19 @@ describe('real AgentPresets standing generations with the overlay threshold', ()
     expect(files.length).toBeGreaterThanOrEqual(3)
     const buckets = await Promise.all(files.map(async file => Math.floor((await stat(file.path)).mtimeMs / 1000)))
     expect(new Set(buckets).size).toBe(buckets.length)
-    // No staging leftovers survive a publish.
+    // No staging leftovers survive a publish. A spec file running in parallel
+    // disposes its own store while this scan runs, so a vanished directory means
+    // "no leftovers to find" rather than a failure (mirrors overlayFiles).
     const storeDirs = await Promise.all(
       (await readdir(tmpdir(), { withFileTypes: true }))
         .filter(entry => entry.isDirectory() && entry.name.startsWith('dsh-context-compression-presets-'))
-        .map(async entry => readdir(join(tmpdir(), entry.name))),
+        .map(async entry => {
+          try {
+            return await readdir(join(tmpdir(), entry.name))
+          } catch {
+            return []
+          }
+        }),
     )
     expect(storeDirs.flat().some(name => name.endsWith('.tmp'))).toBe(false)
 
@@ -451,8 +499,9 @@ describe('real AgentPresets standing generations with the overlay threshold', ()
       ? /standard-([0-9a-f]+)\.agent\.cordis\.yml$/u.exec(files[0]!.path)?.[1]
       : undefined
     expect(identity).toBeDefined()
+    const persistedStamp = await platformPersistedMs(standingStampMs(identity as string))
     expect(Math.floor(details.mtimeMs / 1000))
-      .toBe(Math.floor(standingStampMs(identity as string) / 1000))
+      .toBe(Math.floor(persistedStamp / 1000))
     const observedSubSecond = details.mtimeMs % 1000
     const expectedSubSecond = standingStampMs(identity as string) % 1000
     expect(observedSubSecond === 0 || Math.abs(observedSubSecond - expectedSubSecond) < 1).toBe(true)

package/scripts/packed-components-smoke.mjs

@@ -561,13 +561,25 @@ try {
       && JSON.stringify(originalImage).includes('packed-image-800x600')
       && JSON.stringify(originalImage).includes('"type":"image"'),
     'packed vision image-bearing result is no longer intact on the surface')
+    // The character basis retired the `exact-tokenizer-unavailable` skip: a
+    // History planning skip can no longer refuse for a missing exact count (see
+    // the HistoryPlanOutcome note in src/pruner/types.ts). A vision session
+    // without the exact tokenizer is therefore judged on characters and its
+    // skip carries a real reason (observed: fresh/aggregate `at-or-below-
+    // trigger`, history `below-profile-trigger`) — assert that observable
+    // contract instead of the removed literal.
     for (const component of ['fresh', 'history']) {
-      assert(visionAudit.some(record => record.kind === 'component-evaluation'
-        && record.sessionId === String(visionImage.id)
-        && record.component === component
-        && record.status === 'skipped'
-        && record.reason === 'exact-tokenizer-unavailable'),
-      `packed vision image session lacks the ${component} exact-tokenizer-unavailable audit`)
+      const record = visionAudit.find(entry => entry.kind === 'component-evaluation'
+        && entry.sessionId === String(visionImage.id)
+        && entry.component === component)
+      assert(record !== undefined,
+        `packed vision image session lacks the ${component} component-evaluation audit`)
+      assert(record.status === 'skipped',
+        `packed vision ${component} status is ${String(record.status)}, expected skipped`)
+      assert(record.measurementKind === 'characters',
+        `packed vision ${component} was decided on ${String(record.measurementKind)}, expected characters`)
+      assert(typeof record.reason === 'string' && record.reason.length > 0,
+        `packed vision ${component} skip carries no diagnostic reason`)
     }
 
     console.info(`PACKED_VISION_E2E ${JSON.stringify({
@@ -651,9 +663,19 @@ try {
     && firstIndex('history') < firstIndex('tail-trim'),
   'installed component rewrite order is wrong')
   const pipelineRewrites = rewrites.filter(record => record.sessionId === String(session.id))
+  // The character basis decides on Unicode code points, so a committed rewrite
+  // may report an unchanged token figure while still reclaiming characters
+  // (observed once here: history `historical-tool-result-aging` landed at
+  // 129 -> 129 with tokensRemoved 0). The rewrite audit carries no character
+  // field yet, so assert what the basis can actually guarantee: integer
+  // accounting, a consistent removal figure, and never an increase. A strict
+  // token decrease would re-encode the retired exact-token authority — see the
+  // measurementBasis note in src/runtime/audit.ts.
   assert(pipelineRewrites.every(record => Number.isSafeInteger(record.tokensBefore)
-    && Number.isSafeInteger(record.tokensAfter) && record.tokensBefore > record.tokensAfter),
-  'installed rewrite lacks exact decreasing token evidence')
+    && Number.isSafeInteger(record.tokensAfter)
+    && record.tokensBefore >= record.tokensAfter
+    && record.tokensRemoved === record.tokensBefore - record.tokensAfter),
+  'installed rewrite token accounting is inconsistent or increasing')
   assert(audit.some(record => record.kind === 'native-auto-compact'
     && record.sessionId === String(session.id)),
   'installed Runtime did not audit official Native summary')

package/scripts/packed-install-e2e.mjs

@@ -2,7 +2,7 @@ import { createHash } from 'node:crypto'
 import { spawn } from 'node:child_process'
 import { createReadStream } from 'node:fs'
 import { copyFile, mkdir, mkdtemp, readFile, readdir, realpath, rm, stat, writeFile } from 'node:fs/promises'
-import { readFileSync } from 'node:fs'
+import { readFileSync, readdirSync } from 'node:fs'
 import { createServer } from 'node:http'
 import { createRequire } from 'node:module'
 import { tmpdir } from 'node:os'
@@ -27,8 +27,17 @@ const officialHostPackages = Object.entries(rootManifest.devDependencies)
   .filter(([name]) => name.startsWith('@deepseek-ai/'))
   .map(([name, version]) => `${name}@${version}`)
 
+// Only the package-manager shims need a shell on Windows; every real executable
+// must be spawned directly, because cmd.exe re-parses arguments: `^` is its
+// escape character, so `HEAD^{tree}` reached git as `HEAD{tree}`, and a
+// multi-line `node -e` settings script was cut at its first newline into
+// `[eval]:1 const` / `SyntaxError: Unexpected end of input`. Both killed the
+// official-clone leg for reasons unrelated to what it asserts.
+const SHELL_COMMANDS = new Set(['npm', 'npm.cmd', 'pnpm', 'pnpm.cmd'])
+const usesShell = (command) => process.platform === 'win32' && SHELL_COMMANDS.has(command)
+
 const run = (command, args, options = {}) => new Promise((resolve, reject) => {
-  const child = spawn(command, args, { stdio: 'inherit', shell: process.platform === 'win32', ...options })
+  const child = spawn(command, args, { stdio: 'inherit', shell: usesShell(command), ...options })
   child.once('error', reject)
   child.once('exit', (code, signal) => {
     if (code === 0) resolve()
@@ -37,7 +46,7 @@ const run = (command, args, options = {}) => new Promise((resolve, reject) => {
 })
 
 const capture = (command, args, options = {}) => new Promise((resolve, reject) => {
-  const child = spawn(command, args, { shell: process.platform === 'win32', ...options, stdio: ['ignore', 'pipe', 'pipe'] })
+  const child = spawn(command, args, { shell: usesShell(command), ...options, stdio: ['ignore', 'pipe', 'pipe'] })
   let stdout = ''
   let stderr = ''
   child.stdout.setEncoding('utf8')
@@ -56,7 +65,7 @@ const capture = (command, args, options = {}) => new Promise((resolve, reject) =
 })
 
 const captureOutcome = (command, args, options = {}) => new Promise((resolve, reject) => {
-  const child = spawn(command, args, { shell: process.platform === 'win32', ...options, stdio: ['ignore', 'pipe', 'pipe'] })
+  const child = spawn(command, args, { shell: usesShell(command), ...options, stdio: ['ignore', 'pipe', 'pipe'] })
   let stdout = ''
   let stderr = ''
   child.stdout.setEncoding('utf8')
@@ -306,7 +315,23 @@ async function runOfficialCloneCliSmoke(referenceRoot, registry, upgradeFrom, ca
   const dshHome = join(temporaryRoot, 'dsh-home')
   let added = false
   const environment = { ...process.env, DSH_HOME: dshHome }
-  const dsh = (...args) => run('pnpm', ['dsh', ...args], { cwd: worktree, env: environment })
+  let lastLifecycle = { command: '(none)', code: 0, stdout: '', stderr: '' }
+  const dsh = async (...args) => {
+    const outcome = await captureOutcome('pnpm', ['dsh', ...args], { cwd: worktree, env: environment })
+    lastLifecycle = {
+      command: `pnpm dsh ${args.join(' ')}`,
+      code: outcome.code ?? -1,
+      stdout: outcome.stdout,
+      stderr: outcome.stderr,
+    }
+    if (outcome.code !== 0) {
+      throw new Error([
+        `${lastLifecycle.command} exited ${String(lastLifecycle.code)}`,
+        outcome.stdout.trim(),
+        outcome.stderr.trim(),
+      ].filter(Boolean).join('\n'))
+    }
+  }
   const dumpConfig = () => capture('pnpm', ['dsh', '--profile', 'web', '--dump-config'], {
     cwd: worktree,
     env: environment,
@@ -316,7 +341,36 @@ async function runOfficialCloneCliSmoke(referenceRoot, registry, upgradeFrom, ca
   const profilePackages = () => {
     const profileRoot = join(dshHome, 'profiles/web')
     const profileRequire = createRequire(join(profileRoot, 'package.json'))
-    const selectorPath = profileRequire.resolve('dsh-context-compression-improved/package.json')
+    let selectorPath
+    try {
+      selectorPath = profileRequire.resolve('dsh-context-compression-improved/package.json')
+    } catch (error) {
+      // A silent no-op lifecycle command is the difference between "the package
+      // manager refused" and "the CLI exited 0 without installing anything";
+      // carry that evidence instead of a bare MODULE_NOT_FOUND.
+      const declared = (() => {
+        try {
+          return JSON.stringify(JSON.parse(readFileSync(join(profileRoot, 'package.json'), 'utf8')).dependencies ?? {})
+        } catch {
+          return '(profile package.json unreadable)'
+        }
+      })()
+      const installed = (() => {
+        try {
+          return JSON.stringify(readdirSync(join(profileRoot, 'node_modules')).slice(0, 40))
+        } catch {
+          return '(profiles/web/node_modules unreadable)'
+        }
+      })()
+      throw new Error([
+        `official profile ${profileRoot} does not resolve dsh-context-compression-improved`,
+        `last lifecycle: ${lastLifecycle.command} (exit ${String(lastLifecycle.code)})`,
+        `lifecycle stdout: ${lastLifecycle.stdout.trim()}`,
+        `lifecycle stderr: ${lastLifecycle.stderr.trim()}`,
+        `profile dependencies: ${declared}`,
+        `profiles/web/node_modules: ${installed}`,
+      ].join('\n'), { cause: error })
+    }
     return {
       profileRoot,
       selectorPath,
@@ -623,8 +677,8 @@ async function runOfficialCloneCliSmoke(referenceRoot, registry, upgradeFrom, ca
     // $DSH_HOME/profiles/node_modules — the shared-module fallback the
     // plugin's harness peers resolve through in every later raw-node proof.
     const addedDump = await dumpConfig()
-    assert(addedDump.includes('context-compression-selector-bundle'),
-      'official post-add dump lacks the selector Bundle layer')
+    assert(addedDump.includes('context-compression-improved-bundle'),
+      'official post-add dump lacks the context-compression Bundle layer')
 
     // Real profile start on the previous release, BEFORE seeding: the
     // previous-release schema predates the autoCompact section, so this probe
@@ -646,11 +700,11 @@ async function runOfficialCloneCliSmoke(referenceRoot, registry, upgradeFrom, ca
     const loadProof = await provePluginLoads()
     const postUpBoot = await runProfileBootProbe('post-up', true)
     const upDump = await dumpConfig()
-    for (const marker of ['context-compression-selector-bundle', 'presetOverlay: true']) {
+    for (const marker of ['context-compression-improved-bundle', 'presetOverlay: true']) {
       assert(upDump.includes(marker), `official post-up dump lacks ${marker}`)
     }
-    assert(upDump.match(/context-compression-selector-bundle/gu)?.length === 1,
-      'official post-up dump contains more than one selector Bundle layer')
+    assert(upDump.match(/context-compression-improved-bundle/gu)?.length === 1,
+      'official post-up dump contains more than one context-compression Bundle layer')
 
     // pnpm's peers check is informational: plugin peers resolve through the
     // healed profiles/node_modules fallback, which pnpm cannot see by design.
@@ -661,14 +715,14 @@ async function runOfficialCloneCliSmoke(referenceRoot, registry, upgradeFrom, ca
 
     await dsh('plugin', '--profile', 'web', 'remove', 'dsh-context-compression-improved')
     const removedDump = await dumpConfig()
-    assert(!removedDump.includes('context-compression-selector-bundle'),
-      'official CLI remove left the selector Bundle layer active')
+    assert(!removedDump.includes('context-compression-improved-bundle'),
+      'official CLI remove left the context-compression Bundle layer active')
 
     await dsh('plugin', '--profile', 'web', 'add',
       'dsh-context-compression-improved@latest', '--registry', registry)
     const secondDump = await dumpConfig()
-    assert(secondDump.includes('context-compression-selector-bundle'),
-      'official CLI reinstall did not restore the selector Bundle layer')
+    assert(secondDump.includes('context-compression-improved-bundle'),
+      'official CLI reinstall did not restore the context-compression Bundle layer')
 
     return {
       tag: before.tag,

package/packages/selector/src/client/ReviewOverlay.tsx

@@ -1,320 +0,0 @@
-/**
- * TokenPilot-inspired R4: the review floating window.
- *
- * Mounted on the host `shell.overlay` slot (dsh-tidychat precedent: the layer
- * is click-through by default and only the card opts back in), showing a
- * bottom-right badge while any session has pending proposals and a card with
- * the four-state summary row plus one row per proposal. Every 10s it polls the
- * review-queue route; when the queue is empty or review mode is off the
- * component renders null, so it never disturbs the session.
- *
- * Styles carry the `dsh-cc-review-` prefix and ride a one-shot style tag.
- */
-import { useEffect, useState } from 'react'
-import type { ReactElement } from 'react'
-import type { SettingsScopeLike } from './review-scope.ts'
-
-const QUEUE_ROUTES = [
-  '/api/dsh-context-compression-improved/review-queue',
-  '/endpoint/dsh-context-compression-improved/review-queue',
-] as const
-const DECIDE_ROUTES = [
-  '/api/dsh-context-compression-improved/review-decide',
-  '/endpoint/dsh-context-compression-improved/review-decide',
-] as const
-
-export interface PendingProposal {
-  readonly sessionId: string
-  readonly id: string
-  readonly kind: string
-  readonly items: readonly { readonly seq: number, readonly tokensBefore: number, readonly tokensAfter: number }[]
-  readonly benefit: {
-    readonly recoveredTokens: number
-    readonly paybackTurns?: number
-    readonly expectedSaving?: number
-  }
-}
-
-export interface ReviewSummary {
-  readonly autoApplied: number
-  readonly reviewApplied: number
-  readonly expired: number
-  readonly voided: number
-}
-
-interface ReviewOverlayProps {
-  /** Bound settings scope; supplies the reviewMode switch. */
-  scope: SettingsScopeLike
-  t: (key: string) => string
-}
-
-const CSS = `
-.dsh-cc-review-badge {
-  position: fixed;
-  right: 20px;
-  bottom: 20px;
-  z-index: 70;
-  pointer-events: auto;
-  box-sizing: border-box;
-  min-width: 34px;
-  height: 34px;
-  padding: 0 10px;
-  border-radius: 17px;
-  border: 1px solid var(--dsw-alias-border-l2, rgba(128,128,128,0.4));
-  background: var(--dsw-alias-bg-layer-3, #fff);
-  color: var(--dsw-alias-label-primary, #222);
-  font-size: 13px;
-  display: flex;
-  align-items: center;
-  justify-content: center;
-  gap: 6px;
-  cursor: pointer;
-  box-shadow: 0 6px 18px rgba(0, 0, 0, 0.14);
-}
-.dsh-cc-review-card {
-  position: fixed;
-  right: 20px;
-  bottom: 62px;
-  z-index: 70;
-  pointer-events: auto;
-  box-sizing: border-box;
-  width: min(420px, calc(100vw - 40px));
-  max-height: min(60vh, 520px);
-  overflow: auto;
-  background: var(--dsw-alias-bg-layer-3, #fff);
-  border: 1px solid var(--dsw-alias-border-l2, rgba(128,128,128,0.4));
-  border-radius: 12px;
-  box-shadow: 0 12px 32px rgba(0, 0, 0, 0.18);
-  padding: 12px 14px;
-  color: var(--dsw-alias-label-primary, #222);
-  font-size: 13px;
-}
-.dsh-cc-review-title {
-  font-weight: 600;
-  margin: 0 0 6px;
-  font-size: 13px;
-}
-.dsh-cc-review-summary {
-  display: flex;
-  flex-wrap: wrap;
-  gap: 4px 12px;
-  color: var(--dsw-alias-label-tertiary, #888);
-  font-size: 12px;
-  margin-bottom: 8px;
-}
-.dsh-cc-review-row {
-  border-top: 1px solid var(--dsw-alias-border-l2, rgba(128,128,128,0.25));
-  padding: 8px 0;
-}
-.dsh-cc-review-row-meta {
-  color: var(--dsw-alias-label-tertiary, #888);
-  font-size: 12px;
-  margin-bottom: 4px;
-}
-.dsh-cc-review-actions {
-  display: flex;
-  gap: 8px;
-}
-.dsh-cc-review-btn {
-  appearance: none;
-  border: 1px solid var(--dsw-alias-border-l2, rgba(128,128,128,0.4));
-  background: transparent;
-  color: inherit;
-  border-radius: 6px;
-  padding: 3px 10px;
-  font-size: 12px;
-  cursor: pointer;
-}
-.dsh-cc-review-btn-primary {
-  background: var(--dsw-alias-state-business-primary, #3b82f6);
-  border-color: transparent;
-  color: #fff;
-}
-`
-
-function injectOnce(): () => void {
-  const tag = document.createElement('style')
-  tag.setAttribute('data-plugin-css', 'dsh-context-compression-improved-review')
-  tag.textContent = CSS
-  document.head.appendChild(tag)
-  return () => { tag.remove() }
-}
-
-async function fetchJson(route: string, init?: RequestInit): Promise<unknown> {
-  const response = await fetch(route, { headers: { 'cache-control': 'no-cache' }, ...init })
-  if (!response.ok) return undefined
-  return response.json()
-}
-
-async function pollQueue(): Promise<{ pending: PendingProposal[], summary?: ReviewSummary | undefined } | undefined> {
-  for (const route of QUEUE_ROUTES) {
-    const body = await fetchJson(route) as {
-      ok?: boolean
-      total?: number
-      pending?: PendingProposal[]
-      summary?: ReviewSummary
-    } | undefined
-    if (body?.ok === true) {
-      return { pending: body.pending ?? [], summary: body.summary }
-    }
-  }
-  return undefined
-}
-
-async function postDecide(proposal: PendingProposal, decision: string): Promise<boolean> {
-  for (const route of DECIDE_ROUTES) {
-    try {
-      const response = await fetch(route, {
-        method: 'POST',
-        headers: { 'content-type': 'application/json' },
-        body: JSON.stringify({ sessionId: proposal.sessionId, proposalId: proposal.id, decision }),
-      })
-      if (response.status !== 404) return response.ok
-    } catch {
-      // Try the next prefix.
-    }
-  }
-  return false
-}
-
-/**
- * Slot factory helper: the client entry is a .ts file and cannot carry JSX,
- * so the element construction lives here.
- */
-export function renderReviewOverlay(
-  scope: SettingsScopeLike,
-  t: (key: string) => string,
-): ReactElement {
-  return <ReviewOverlay scope={scope} t={t} />
-}
-
-/**
- * The floating window itself: renders null (and stays silent) while review
- * mode is off or nothing is pending.
- */
-export function ReviewOverlay({ scope, t }: ReviewOverlayProps) {
-  const [reviewMode, setReviewMode] = useState(false)
-  const [pending, setPending] = useState<PendingProposal[]>([])
-  const [summary, setSummary] = useState<ReviewSummary | undefined>()
-  const [expanded, setExpanded] = useState(false)
-  const [busy, setBusy] = useState(false)
-
-  useEffect(injectOnce, [])
-  useEffect(() => {
-    const pull = (): void => {
-      try {
-        const snapshot = scope.getSnapshot()
-        setReviewMode(snapshot.status === 'ready' && snapshot.value?.presetOptions?.reviewMode === true)
-      } catch {
-        setReviewMode(false)
-      }
-    }
-    pull()
-    let unsubscribe: () => void
-    try {
-      unsubscribe = scope.subscribe(pull)
-    } catch {
-      unsubscribe = (): void => {}
-    }
-    return unsubscribe
-  }, [scope])
-
-  useEffect(() => {
-    if (!reviewMode) return
-    let alive = true
-    let timer: ReturnType<typeof setTimeout> | undefined
-    const tick = (): void => {
-      void pollQueue().then((result) => {
-        if (!alive) return
-        setPending(result?.pending ?? [])
-        setSummary(result?.summary)
-        timer = setTimeout(tick, 10_000)
-      })
-    }
-    tick()
-    return () => {
-      alive = false
-      if (timer !== undefined) clearTimeout(timer)
-    }
-  }, [reviewMode])
-
-  if (!reviewMode || pending.length === 0) return null
-
-  const decide = (proposal: PendingProposal, decision: string): void => {
-    setBusy(true)
-    void postDecide(proposal, decision).then(() => {
-      return pollQueue().then((result) => {
-        setPending(result?.pending ?? [])
-        setSummary(result?.summary)
-        setBusy(false)
-      })
-    }).catch(() => { setBusy(false) })
-  }
-
-  const seqRange = (proposal: PendingProposal): string => {
-    const seqs = proposal.items.map(item => item.seq)
-    const min = Math.min(...seqs)
-    const max = Math.max(...seqs)
-    return min === max ? `#${String(min)}` : `#${String(min)}–#${String(max)}`
-  }
-
-  return (
-    <>
-      {expanded ? (
-        <div className="dsh-cc-review-card">
-          <p className="dsh-cc-review-title">{t('review.title')}</p>
-          {summary !== undefined ? (
-            <div className="dsh-cc-review-summary">
-              <span>{t('review.summary.autoApplied')}: {String(summary.autoApplied)}</span>
-              <span>{t('review.summary.reviewApplied')}: {String(summary.reviewApplied)}</span>
-              <span>{t('review.summary.expired')}: {String(summary.expired)}</span>
-              <span>{t('review.summary.voided')}: {String(summary.voided)}</span>
-            </div>
-          ) : null}
-          {pending.map(proposal => (
-            <div className="dsh-cc-review-row" key={proposal.id}>
-              <div className="dsh-cc-review-row-meta">
-                {proposal.kind} · {seqRange(proposal)} · R ≈ {String(proposal.benefit.recoveredTokens)}
-                {proposal.benefit.paybackTurns !== undefined
-                  ? ` · ${t('review.row.payback')}: ${String(Math.round(proposal.benefit.paybackTurns * 100) / 100)}`
-                  : ''}
-                {proposal.benefit.expectedSaving !== undefined
-                  ? ` · ${t('review.row.expectedSaving')}: ${String(Math.round(proposal.benefit.expectedSaving))} (${t('review.row.estimated')})`
-                  : ''}
-              </div>
-              <div className="dsh-cc-review-actions">
-                <button
-                  type="button" className="dsh-cc-review-btn dsh-cc-review-btn-primary"
-                  disabled={busy}
-                  onClick={() => { decide(proposal, 'approved') }}
-                >
-                  {t('review.action.approve')}
-                </button>
-                <button
-                  type="button" className="dsh-cc-review-btn"
-                  disabled={busy}
-                  onClick={() => { decide(proposal, 'rejected') }}
-                >
-                  {t('review.action.reject')}
-                </button>
-                <button
-                  type="button" className="dsh-cc-review-btn"
-                  disabled={busy}
-                  onClick={() => { decide(proposal, 'ignored') }}
-                >
-                  {t('review.action.ignore')}
-                </button>
-              </div>
-            </div>
-          ))}
-        </div>
-      ) : null}
-      <button
-        type="button" className="dsh-cc-review-badge"
-        onClick={() => { setExpanded(value => !value) }}
-      >
-        {t('review.badge')} {String(pending.length)}
-      </button>
-    </>
-  )
-}