dsh-builtin-browser 0.1.23 → 0.2.0

package/src/browser-electron/history-store.ts

@@ -0,0 +1,162 @@
+/**
+ * Persistent browsing history: which pages the shared browser actually visited,
+ * kept independently from any session's operation log (`browser_history`) and
+ * from the browser process's lifetime.
+ *
+ * It lives beside the browser profile (`$DSH_HOME/dsh-builtin-browser-host/
+ * history.jsonl`), so it follows the same persistence rules as the login state:
+ * closing the interface releases the process, never the record.
+ *
+ * Format: one JSON object per line, append-only. Appending stays cheap for a
+ * long session, and a half-written tail (crash, power loss) is dropped on read
+ * instead of poisoning the whole file.
+ * @module dsh-browser/browser-electron/history-store
+ */
+
+import { appendFileSync, existsSync, mkdirSync, readFileSync, writeFileSync } from 'node:fs'
+import { homedir } from 'node:os'
+import { dirname, join } from 'node:path'
+import type { VisitedPage } from '../browser/types.js'
+
+export type { VisitedPage }
+
+/** Retention limits; whichever is hit first starts trimming. */
+export interface HistoryLimits {
+  /** Maximum retained entries. Default 5000. */
+  readonly maxEntries?: number
+  /** Maximum age in days. Default 90. */
+  readonly maxAgeDays?: number
+}
+
+/** Default entry cap — mirrors the documented retention rule. */
+const DEFAULT_MAX_ENTRIES = 5_000
+/** Default age cap in days. */
+const DEFAULT_MAX_AGE_DAYS = 90
+/** Rewrite the file only once it has grown this far past the cap. */
+const PRUNE_SLACK = 500
+
+/**
+ * Absolute path of the browsing-history file, beside the browser profile so the
+ * record shares the login state's persistence rules.
+ * @returns the history file path.
+ */
+export function visitedHistoryPath(): string {
+  const home = process.env.DSH_HOME ?? join(homedir(), '.dsh')
+  return join(home, 'dsh-builtin-browser-host', 'history.jsonl')
+}
+
+/**
+ * Append-only browsing history with bounded retention. Every method tolerates a
+ * missing or damaged file: recording a visit must never fail a navigation, and
+ * a corrupted line must never hide the rest of the history.
+ */
+export class HistoryStore {
+  private readonly maxEntries: number
+  private readonly maxAgeMs: number
+
+  /**
+   * @param file - absolute path of the JSONL history file.
+   * @param limits - retention overrides (entry count and age).
+   */
+  constructor(
+    private readonly file: string = visitedHistoryPath(),
+    limits: HistoryLimits = {},
+  ) {
+    this.maxEntries = limits.maxEntries ?? DEFAULT_MAX_ENTRIES
+    this.maxAgeMs = (limits.maxAgeDays ?? DEFAULT_MAX_AGE_DAYS) * 24 * 60 * 60 * 1000
+  }
+
+  /** Whether the history file exists yet (diagnostics and tests). */
+  exists(): boolean {
+    return existsSync(this.file)
+  }
+
+  /**
+   * Record one visit. Failures are swallowed by design: history is a
+   * convenience, and losing an entry must never break the tool call that
+   * produced it.
+   * @param page - the visited page.
+   */
+  append(page: VisitedPage): void {
+    try {
+      mkdirSync(dirname(this.file), { recursive: true })
+      appendFileSync(this.file, `${JSON.stringify(page)}\n`)
+    } catch {
+      // Best-effort: history is not worth failing a navigation over.
+    }
+  }
+
+  /**
+   * Read visits, newest first. Unparseable lines are skipped; entries older
+   * than the age limit are filtered out but left on disk until the next prune.
+   * @param options - optional result cap and domain filter.
+   * @returns the matching visits, newest first.
+   */
+  list(options: { readonly limit?: number; readonly domain?: string } = {}): VisitedPage[] {
+    const all = this.readAll()
+    const cutoff = Date.now() - this.maxAgeMs
+    const domain = options.domain?.toLowerCase()
+    const matches = all.filter(page => {
+      if (page.at < cutoff) return false
+      if (domain === undefined) return true
+      try {
+        return new URL(page.url).hostname.toLowerCase().includes(domain)
+      } catch {
+        return page.url.toLowerCase().includes(domain)
+      }
+    })
+    matches.reverse()
+    return options.limit === undefined ? matches : matches.slice(0, Math.max(0, options.limit))
+  }
+
+  /**
+   * Enforce retention: drop entries past the age limit, then the oldest beyond
+   * the count cap. Cheap no-op until the file grows past the cap, so callers can
+   * run it after every append.
+   */
+  prune(): void {
+    const all = this.readAll()
+    const cutoff = Date.now() - this.maxAgeMs
+    const fresh = all.filter(page => page.at >= cutoff)
+    const kept = fresh.length > this.maxEntries ? fresh.slice(fresh.length - this.maxEntries) : fresh
+    // Only rewrite when something actually fell off, and only once the excess
+    // is worth a full rewrite.
+    if (kept.length === all.length) return
+    if (all.length - kept.length < PRUNE_SLACK && fresh.length <= this.maxEntries) return
+    try {
+      const body = kept.map(page => `${JSON.stringify(page)}\n`).join('')
+      writeFileSync(this.file, body)
+    } catch {
+      // Best-effort: an unpruned file still reads correctly.
+    }
+  }
+
+  /** Parse the whole file, skipping blank and damaged lines. */
+  private readAll(): VisitedPage[] {
+    let raw: string
+    try {
+      raw = readFileSync(this.file, 'utf8')
+    } catch {
+      return []
+    }
+    const pages: VisitedPage[] = []
+    for (const line of raw.split('\n')) {
+      const trimmed = line.trim()
+      if (trimmed === '') continue
+      try {
+        const parsed = JSON.parse(trimmed) as Partial<VisitedPage>
+        if (typeof parsed.at !== 'number' || typeof parsed.url !== 'string') continue
+        pages.push({
+          at: parsed.at,
+          url: parsed.url,
+          ...typeof parsed.title === 'string' && parsed.title !== '' ? { title: parsed.title } : {},
+          ...typeof parsed.session === 'string' && parsed.session !== '' ? { session: parsed.session } : {},
+        })
+      } catch {
+        // A damaged line (typically a truncated tail) must not hide the rest.
+        continue
+      }
+    }
+    return pages
+  }
+}

package/src/browser-electron/host-main.ts

@@ -389,7 +389,32 @@ function windowFor(windowId: string | undefined): HostWindow {
   const existing = windows.get(key)
   if (existing !== undefined) return existing
   const w = new BrowserWindow({ width: 1400, height: 900, show: true, title: 'dsh-browser' })
-  w.on('closed', () => { windows.delete(key) })
+  w.on('closed', () => {
+    const closing = windows.get(key)
+    windows.delete(key)
+    // A BrowserWindow does not destroy its child views: their webContents (the
+    // renderer process, its timers and audio) outlive the window unless closed
+    // explicitly, so release them here instead of leaking a renderer per window.
+    if (closing !== undefined) {
+      for (const view of closing.views.values()) {
+        try {
+          view.webContentsView.webContents.close()
+        } catch {
+          // Already destroyed along with the window.
+        }
+      }
+      closing.views.clear()
+    }
+    // The interface is gone for good. Report it, so the plugin ends that session
+    // instead of holding one whose window the human already closed. Browsing
+    // history and login state live on disk, so the next open starts a clean
+    // session rather than resurrecting this one.
+    try {
+      rpcSocket?.write(JSON.stringify({ id: 0, op: 'viewClosed', windowId: key }) + '\n')
+    } catch {
+      // Socket already gone (parent shutting down): nothing left to report to.
+    }
+  })
   const win: HostWindow = { windowId: key, window: w, toolbarView: undefined, views: new Map(), visibleViewId: undefined, lastFocusedViewId: undefined, closeTimer: undefined }
   // Keep every view (and the toolbar) filling the window as the human
   // resizes it; otherwise pages stay at their original size and break.

package/src/browser-electron/provider.ts

@@ -11,6 +11,9 @@ import { randomUUID } from 'node:crypto'
 import { existsSync, mkdirSync, writeFileSync } from 'node:fs'
 import { homedir } from 'node:os'
 import { dirname, isAbsolute, join, resolve, sep } from 'node:path'
+import { HistoryStore, type VisitedPage } from './history-store.js'
+import type { BrowserSettings } from './settings-store.js'
+import { paintCursor, type CursorAction } from './virtual-cursor.js'
 import type {
   BrowserA11yRequest,
   BrowserA11yResult,
@@ -175,6 +178,13 @@ export interface ElectronBrowserViewHost {
    * @param handler - called for every user action; must not throw.
    */
   onUserAction?(handler: (action: BrowserUserAction) => void): void
+  /**
+   * Optional: receive notice that the human closed a browser window. Closing the
+   * interface ends the session it showed — the next call opens a clean one —
+   * while browsing history and login state survive on disk.
+   * @param handler - called with the group (session) key; must not throw.
+   */
+  onViewClosed?(handler: (windowId: string) => void): void
 }
 
 /**
@@ -238,6 +248,28 @@ interface Session {
 export interface ElectronBrowserProviderConfig {
   /** Allow navigation only to HTTP(S) URLs; reject anything else. Default true. */
   readonly httpOnly?: boolean
+  /**
+   * Persistent browsing history (visited pages), independent of session
+   * lifetime. `enabled: false` keeps the browser working but records nothing;
+   * the retained limits ride along so a user's choice from the settings panel
+   * reaches the store without a second configuration path.
+   */
+  readonly history?: {
+    readonly enabled?: boolean
+    readonly maxEntries?: number
+    readonly maxAgeDays?: number
+    /**
+     * Explicit history file path. Default: beside the browser profile
+     * (`$DSH_HOME/dsh-builtin-browser-host/history.jsonl`).
+     */
+    readonly file?: string
+  }
+  /**
+   * Live settings source (the settings panel's document). When present it wins
+   * over the static `history` config, so a switch flipped in the UI takes effect
+   * without restarting DSH.
+   */
+  readonly settings?: () => BrowserSettings
   /** Maximum snapshot elements before truncation. Default 60. */
   readonly snapshotMaxElements?: number
   /** Maximum content characters before truncation when no maxChars is given. Default 100_000. */
@@ -365,6 +397,13 @@ export class ElectronBrowserProvider implements BrowserProvider {
   private readonly snapshotMaxElements: number
   private readonly contentMaxChars: number
   private readonly downloadDir: string | undefined
+  /**
+   * Persistent browsing history, or `undefined` when the user turned it off.
+   * Sessions come and go; this record outlives all of them.
+   */
+  private readonly historyStore: HistoryStore | undefined
+  /** Live settings source; absent when nothing owns a settings document. */
+  private readonly settingsSource: (() => BrowserSettings) | undefined
 
   constructor(
     private readonly host: ElectronBrowserViewHost,
@@ -379,9 +418,21 @@ export class ElectronBrowserProvider implements BrowserProvider {
     // sandbox does not have to arbitrate. The localized name is probed so a
     // Chinese desktop (`~/下载`) works without configuring `downloadDir`.
     this.downloadDir = config.downloadDir ?? defaultDownloadDir()
+    this.settingsSource = config.settings
+    // Browsing history follows the browser profile's persistence rules (close
+    // the interface, lose nothing), and can be switched off from settings.
+    this.historyStore = config.history?.enabled === false
+      ? undefined
+      : new HistoryStore(config.history?.file, {
+        ...config.history?.maxEntries !== undefined ? { maxEntries: config.history.maxEntries } : {},
+        ...config.history?.maxAgeDays !== undefined ? { maxAgeDays: config.history.maxAgeDays } : {},
+      })
     // Route toolbar (host UI) actions into the session model: the human and
     // the agent then always drive the same tabs, history, and navigation.
     this.host.onUserAction?.(action => { void this.handleUserAction(action) })
+    // A window the human closed ends the session it showed: the next call opens a
+    // clean one instead of driving a page nobody can see.
+    this.host.onViewClosed?.(windowId => { void this.handleViewClosed(windowId) })
   }
 
   /**
@@ -556,6 +607,7 @@ export class ElectronBrowserProvider implements BrowserProvider {
       // NEXT observation sees, not whether this action happened).
       this.record(s, 'navigate', { url }, true)
       await this.settleDocument(handle, before, signal)
+      this.recordVisit(s, handle)
       this.showActive(s)
     } catch (error) {
       if (!(error instanceof BrowserError && (error as { code?: string }).code === 'BROWSER_NAVIGATION_BLOCKED')) {
@@ -1244,6 +1296,9 @@ export class ElectronBrowserProvider implements BrowserProvider {
     } catch (error) {
       throw new BrowserError(`browser: click failed: ${String(error)}`, 'BROWSER_CLICK_FAILED', { cause: error })
     }
+    // Paint before the press so the ripple is already on screen when the click
+    // lands — the cursor exists to show the human WHERE the agent acts.
+    this.showCursor(handle, x, y, 'click')
     const release = (): void => {
       void handle
         .sendCommand('Input.dispatchMouseEvent', {
@@ -1293,7 +1348,10 @@ export class ElectronBrowserProvider implements BrowserProvider {
         el.focus()
         return { ok: true }
       `)
-      await this.runTargetScript(this.activeTab(s), script, locateMs, signal, 'BROWSER_TYPE_FAILED', 'browser: type')
+      const locateTab = this.activeTab(s)
+      const out = await this.runTargetScript(locateTab, script, locateMs, signal, 'BROWSER_TYPE_FAILED', 'browser: type')
+      const cursorPoint = scriptPoint(out)
+      if (cursorPoint !== undefined) this.showCursor(locateTab.handle, cursorPoint.x, cursorPoint.y, 'click')
     }
     const text = 'text' in request ? request.text : ''
     const timeoutMs = 30_000
@@ -1383,6 +1441,7 @@ export class ElectronBrowserProvider implements BrowserProvider {
     )
     this.record(s, direction === -1 ? 'back' : 'forward', {}, true)
     await this.settleDocument(handle, before, signal)
+    this.recordVisit(s, handle)
     this.showActive(s)
   }
 
@@ -1415,6 +1474,7 @@ export class ElectronBrowserProvider implements BrowserProvider {
     )
     this.record(s, 'reload', {}, true)
     await this.settleDocument(handle, before, signal)
+    this.recordVisit(s, handle)
     this.showActive(s)
   }
 
@@ -1664,7 +1724,18 @@ export class ElectronBrowserProvider implements BrowserProvider {
         if (Date.now() >= deadline) return { ok: false, error: 'element not found: ' + JSON.stringify(spec) + ' (looked for ' + timeoutMs + 'ms)' }
         await sleep(100)
       }
+      const __result = await (async () => {
       ${body}
+      })()
+      // Report the operated element's viewport center next to the script's own
+      // verdict: the synthetic cursor (and any future feedback) needs the point,
+      // and no individual body should have to compute it a second time. Kept
+      // under a distinct key so a body that already returns x/y keeps them.
+      const __rect = el.getBoundingClientRect()
+      return {
+        ...(typeof __result === 'object' && __result !== null ? __result : { ok: true }),
+        __point: { x: Math.round(__rect.x + __rect.width / 2), y: Math.round(__rect.y + __rect.height / 2) },
+      }
     })()`
   }
 
@@ -1742,6 +1813,8 @@ export class ElectronBrowserProvider implements BrowserProvider {
     `
     const script = this.buildTargetScript(request.target, timeoutMs, body)
     const out = await this.runTargetScript(tab, script, timeoutMs, signal, 'BROWSER_SET_VALUE_FAILED', 'browser: setValue')
+    const cursorPoint = scriptPoint(out)
+    if (cursorPoint !== undefined) this.showCursor(tab.handle, cursorPoint.x, cursorPoint.y, 'click')
     this.record(s, 'setValue', { target: request.target, value: String(request.value) }, true, { result: out.method as string })
     return { method: out.method as string, value: out.value as string }
   }
@@ -1768,6 +1841,8 @@ export class ElectronBrowserProvider implements BrowserProvider {
     `
     const script = this.buildTargetScript(request.target, timeoutMs, body)
     const out = await this.runTargetScript(tab, script, timeoutMs, signal, 'BROWSER_CHECK_FAILED', 'browser: check')
+    const cursorPoint = scriptPoint(out)
+    if (cursorPoint !== undefined) this.showCursor(tab.handle, cursorPoint.x, cursorPoint.y, 'click')
     this.record(s, 'check', { target: request.target, checked: want }, true)
     return { checked: out.checked === true }
   }
@@ -1800,6 +1875,8 @@ export class ElectronBrowserProvider implements BrowserProvider {
     `
     const script = this.buildTargetScript(request.target, timeoutMs, body)
     const out = await this.runTargetScript(tab, script, timeoutMs, signal, 'BROWSER_SELECT_FAILED', 'browser: select')
+    const cursorPoint = scriptPoint(out)
+    if (cursorPoint !== undefined) this.showCursor(tab.handle, cursorPoint.x, cursorPoint.y, 'click')
     this.record(s, 'select', { target: request.target, optionValue: request.optionValue ?? null, optionText: request.optionText ?? null, optionIndex: request.optionIndex ?? null }, true)
     return { value: out.value as string, text: out.text as string }
   }
@@ -1833,7 +1910,9 @@ export class ElectronBrowserProvider implements BrowserProvider {
       return { ok: true }
     `
     const script = this.buildTargetScript(request.target, timeoutMs, body)
-    await this.runTargetScript(tab, script, timeoutMs, signal, 'BROWSER_CLEAR_FAILED', 'browser: clear')
+    const out = await this.runTargetScript(tab, script, timeoutMs, signal, 'BROWSER_CLEAR_FAILED', 'browser: clear')
+    const cursorPoint = scriptPoint(out)
+    if (cursorPoint !== undefined) this.showCursor(tab.handle, cursorPoint.x, cursorPoint.y, 'click')
     this.record(s, 'clear', { target: request.target }, true)
     return { cleared: true }
   }
@@ -2160,6 +2239,60 @@ export class ElectronBrowserProvider implements BrowserProvider {
     return this.session(session).history
   }
 
+  /**
+   * Record one page visit in the persistent browsing history. Fire-and-forget by
+   * design: a visit must never delay or fail the navigation that produced it,
+   * and the title is only worth reading once the document has settled.
+   * @param s - the session that drove the visit.
+   * @param handle - the view whose document just loaded.
+   */
+  private recordVisit(s: Session, handle: ElectronViewHandle): void {
+    const store = this.historyStore
+    if (store === undefined) return
+    // The settings panel can switch recording off at runtime; the static config
+    // only supplies the startup default.
+    if (this.settingsSource !== undefined && !this.settingsSource().history.enabled) return
+    void handleSendEvaluate(handle, 'location.href + "\\u0000" + (document.title || "")')
+      .then(result => {
+        if (!result.ok || typeof result.value !== 'string') return
+        const [url = '', title = ''] = result.value.split('\u0000')
+        // Internal documents are not visits: an untouched browser is not history.
+        if (url === '' || url.startsWith('about:') || url.startsWith('devtools:')) return
+        store.append({
+          at: Date.now(),
+          url,
+          ...title.trim() !== '' ? { title: title.trim() } : {},
+          ...s.label !== undefined ? { session: s.label } : {},
+        })
+        store.prune()
+      })
+      .catch(() => { /* best-effort: history is never worth surfacing an error */ })
+  }
+
+  /**
+   * List persisted visits, newest first — what `browser_visited` reads back.
+   * @param options - result cap and an optional hostname filter.
+   * @returns the matching visits, or an empty list when history is disabled.
+   */
+  visited(options: { readonly limit?: number; readonly domain?: string } = {}): readonly VisitedPage[] {
+    return this.historyStore?.list(options) ?? []
+  }
+
+  /**
+   * Show the synthetic pointer on a view, unless the user switched it off. The
+   * cursor is the "the agent has taken over this tab" signal, so it is painted
+   * for every operation that has a landing point — including DOM-level ones that
+   * move no real pointer.
+   * @param handle - the view to paint into.
+   * @param x - viewport x in CSS pixels.
+   * @param y - viewport y in CSS pixels.
+   * @param action - click pulses a ripple; move only relocates.
+   */
+  private showCursor(handle: ElectronViewHandle, x: number, y: number, action: CursorAction): void {
+    if (this.settingsSource !== undefined && !this.settingsSource().ui.virtualCursor) return
+    paintCursor(handle, x, y, action, (target, expression) => handleSendEvaluate(target, expression))
+  }
+
   /**
    * Replay one recorded operation by sequence number. Navigate/click/type are
    * re-issued against the current page; execute re-runs its script. The
@@ -2272,6 +2405,29 @@ export class ElectronBrowserProvider implements BrowserProvider {
     return s.tabs.find(tab => tab.handle.id === viewId)
   }
 
+  /**
+   * Whether a session is still live. The human closing a window ends its session
+   * (see {@link handleViewClosed}), so callers that cache ids must ask first.
+   * @param session - the session id to test.
+   */
+  exists(session: BrowserSessionId): boolean {
+    return this.sessions.has(session)
+  }
+
+  /**
+   * The human closed a browser window: the session that window showed is over.
+   * Ending it here is what makes the next call a clean start rather than a
+   * resurrection of an invisible window. Browsing history and login state live
+   * on disk, so nothing the human cares about is lost with it.
+   * @param windowId - the group key the host reported, which is the session id.
+   */
+  private async handleViewClosed(windowId: string): Promise<void> {
+    if (typeof windowId !== 'string' || windowId === '') return
+    const s = this.sessions.get(windowId as BrowserSessionId)
+    if (s === undefined) return
+    await this.close(s.id).catch(() => { /* the window is already gone */ })
+  }
+
   /**
    * Route a user-initiated action from the host's UI into the session model.
    * Fire-and-forget by design: a user action failing (e.g. an unreachable
@@ -2477,6 +2633,14 @@ function terminatePage(handle: ElectronViewHandle): void {
  * @param expression - the JS expression.
  * @param signal - optional abort signal; a fired signal rejects the call.
  */
+/** Viewport point a target script reported, when it reported one. */
+function scriptPoint(out: Record<string, unknown> | undefined): { x: number; y: number } | undefined {
+  const point = out?.__point as { x?: unknown; y?: unknown } | undefined
+  const x = Number(point?.x)
+  const y = Number(point?.y)
+  return Number.isFinite(x) && Number.isFinite(y) ? { x, y } : undefined
+}
+
 async function handleSendEvaluate(
   handle: ElectronViewHandle,
   expression: string,

package/src/browser-electron/remote-host.ts

@@ -440,12 +440,28 @@ class ElectronChildClient {
     private readonly token: string,
     private readonly onExit?: () => void,
     private readonly onUserAction?: (action: BrowserUserAction) => void,
+    /**
+     * Called when the human closes a browser window. The session it showed is
+     * over: the provider releases it, while history and login state stay on disk
+     * so the next open is a clean session rather than a resurrected one.
+     */
+    private readonly onViewClosed?: (windowId: string) => void,
     /** Test seam: the executable to spawn instead of the resolved Electron
      *  binary. Absent -> resolveElectronPath() (production behavior). */
     private readonly executable?: string,
   ) {
     const electron = this.executable ?? resolveElectronPath()
+    // Record what is about to be spawned — with existence checks — BEFORE the
+    // attempt. When Electron cannot load the app entry it exits 1 with EMPTY
+    // stderr, and that signature is otherwise indistinguishable from a missing
+    // binary: writing both paths (and whether they exist) in advance is what
+    // turns the next occurrence into a named cause instead of a guess.
     process.stderr.write(`[dsh-browser host] spawning electron: ${electron}\n`)
+    appendHostLog(
+      `${hostStamp()} spawning: electron=${electron} (exists=${String(existsSync(electron))})`
+      + ` hostMain=${this.hostMainPath} (exists=${String(existsSync(this.hostMainPath))})`
+      + ` port=${String(this.port)}\n`,
+    )
     // ELECTRON_RUN_AS_NODE (even an empty string) makes Electron run as plain
     // Node, breaking require('electron'); NODE_OPTIONS can inject flags that
     // break the child. Rebuild the env without either.
@@ -482,15 +498,26 @@ class ElectronChildClient {
     // A failed spawn (bad/corrupt binary) emits 'error' — without a listener
     // that would crash the whole DSH process.
     this.child.on('error', error => {
-      const line = `spawn error: ${String(error)}`
+      const line = `${hostStamp()} spawn error: ${String(error)} electron=${electron} hostMain=${this.hostMainPath}`
       process.stderr.write(`[dsh-browser host] ${line}\n`)
       appendHostLog(`${line}\n`)
       this.fail(new Error(`dsh-builtin-browser: browser host failed to start: ${String(error)}`))
     })
     this.child.on('exit', (code, signal) => {
       // The exit code/signal is the other half of a crash report; without it a
-      // restart loop is indistinguishable from a clean stop.
-      const line = `browser host exited (code=${String(code)} signal=${String(signal)})`
+      // restart loop is indistinguishable from a clean stop. The timestamp, pid
+      // and both paths are what turn a bare `code=1` into a diagnosis: Electron
+      // exits 1 with empty stderr precisely when it cannot load the app entry,
+      // so the dated `exists=` line written at spawn is the other half.
+      const entryExists = existsSync(this.hostMainPath)
+      const line = `${hostStamp()} browser host exited (code=${String(code)} signal=${String(signal)})`
+        + ` pid=${String(this.child?.pid)} electron=${electron} hostMain=${this.hostMainPath}`
+        + ` entryExists=${String(entryExists)}`
+        // Comparing this with the `exists=` recorded at spawn is the whole
+        // diagnosis: present at spawn and absent now means the installation was
+        // replaced underneath a running host, which is exactly how Electron ends
+        // up unable to load the app entry and exits 1 with empty stderr.
+        + (entryExists ? '' : ' [entry script missing at exit]')
       appendHostLog(`${line}\n`)
       this.fail(new Error(`dsh-builtin-browser: ${line}`))
     })
@@ -566,7 +593,7 @@ class ElectronChildClient {
       const line = this.buffer.slice(0, nl).trim()
       this.buffer = this.buffer.slice(nl + 1)
       if (line === '') continue
-      let msg: { id?: number; op?: string; token?: string; ok?: boolean; result?: unknown; err?: string; action?: unknown }
+      let msg: { id?: number; op?: string; token?: string; ok?: boolean; result?: unknown; err?: string; action?: unknown; windowId?: unknown }
       try {
         msg = JSON.parse(line) as typeof msg
       } catch {
@@ -580,6 +607,14 @@ class ElectronChildClient {
         this.onUserAction?.(msg.action as BrowserUserAction)
         continue
       }
+      if (msg.op === 'viewClosed') {
+        // Fire-and-forget notification from the child's own UI: the human closed
+        // the window, so the interface that session showed is gone. The provider
+        // decides what that ends — browsing history and login state survive on
+        // disk, only the session itself does not.
+        this.onViewClosed?.(typeof msg.windowId === 'string' ? msg.windowId : '')
+        continue
+      }
       if (this.awaitingHello) {
         // The FIRST line must be the child's hello carrying the spawn token.
         // Anything else (or a wrong token) means a spoofed connection: drop
@@ -717,6 +752,12 @@ export class RemoteElectronViewHost implements ElectronBrowserViewHost {
   private readonly groups = new Map<string, { windowId: string; label?: string }>()
   /** The provider's user-action handler; routes toolbar actions into sessions. */
   private userActionHandler: ((action: BrowserUserAction) => void) | undefined
+  /**
+   * The provider's handler for a window the human closed. Closing the interface
+   * ends the session it showed: history and login state stay on disk, so the
+   * next open starts clean instead of resuming a window nobody can see.
+   */
+  private viewClosedHandler: ((windowId: string) => void) | undefined
 
   constructor(
     private readonly hostMainPath: string,
@@ -826,6 +867,7 @@ export class RemoteElectronViewHost implements ElectronBrowserViewHost {
       token,
       () => this.onChildExit(),
       action => this.userActionHandler?.(action),
+      windowId => this.viewClosedHandler?.(windowId),
       this.spawnExecutable,
     )
     if (this.pendingSocket !== undefined) {
@@ -959,6 +1001,11 @@ export class RemoteElectronViewHost implements ElectronBrowserViewHost {
     this.userActionHandler = handler
   }
 
+  /** Register the provider's handler for windows the human closed. */
+  onViewClosed(handler: (windowId: string) => void): void {
+    this.viewClosedHandler = handler
+  }
+
   /** Surface a failed user action to the child's toolbar (address bar etc.). */
   notifyUserActionError(windowId: string, message: string): void {
     void this.ready()
@@ -1080,6 +1127,16 @@ class DeferredRemoteView implements ElectronViewHandle {
  */
 const HOST_LOG_MAX_BYTES = 2 * 1024 * 1024
 
+/**
+ * ISO timestamp prefix for host-log lines. This log is the only place a spawn
+ * failure is recorded, and an undated line cannot be lined up with anything else
+ * that happened on the machine — a plugin update replacing the entry script, for
+ * instance — which is precisely the question this log gets asked.
+ */
+function hostStamp(): string {
+  return new Date().toISOString()
+}
+
 function appendHostLog(text: string): void {
   const home = process.env.DSH_HOME
   if (home === undefined || home === '') return
@@ -1087,7 +1144,12 @@ function appendHostLog(text: string): void {
     const dir = join(home, 'logs')
     const file = join(dir, 'dsh-builtin-browser-host.log')
     try {
-      if (statSync(file).size > HOST_LOG_MAX_BYTES) writeFileSync(file, '')
+      if (statSync(file).size > HOST_LOG_MAX_BYTES) {
+        // Discard the old bytes but leave a dated marker: truncating to empty
+        // makes a rotation look like "nothing ever happened", which is how the
+        // history of a crash loop gets silently swallowed.
+        writeFileSync(file, `${hostStamp()} log rotated: previous content exceeded ${String(HOST_LOG_MAX_BYTES)} bytes and was discarded\n`)
+      }
     } catch { /* first write, or unreadable: just append */ }
     mkdirSync(dir, { recursive: true })
     appendFileSync(file, text)