dsh-background-by-model 0.4.2 → 0.4.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dsh-background-by-model",
-  "version": "0.4.2",
+  "version": "0.4.4",
   "description": "Appearance plugin for DeepSeek Harness: an ordered list of model rules, each carrying its own wallpaper, theme color, layout mode, opacity and blur 鈥?the background follows the model you switch to.",
   "keywords": [
     "deepseek-harness",

package/test/host-check.test.mjs

@@ -1,19 +1,19 @@
-/**
- * The host self-check's own tests — run with
+/**
+ * The host self-check's own tests 鈥?run with
  *
  *   pnpm test
  *
  * Three things are covered, and they are the three that can rot silently:
  *
- *  1. **The contract table holds together** — unique ids, machine-checkable
+ *  1. **The contract table holds together** 鈥?unique ids, machine-checkable
  *     sources, a known criticality, and at least one check or an explicit
  *     "documentation only" marker. A contract point added without a source would
  *     otherwise be invisible to the offline scan.
- *  2. **The probe reports what is actually there** — the whole probe is driven
+ *  2. **The probe reports what is actually there** 鈥?the whole probe is driven
  *     against a fixture written in the shape of a host DOM, so "the host renamed
  *     `--dsw-specific-menu`" produces exactly the failure the panel claims, and a
  *     surface that is merely off screen produces `n/a` rather than a false alarm.
- *  3. **The UI stylesheet, and the one piece of version logic** — every `dab-*`
+ *  3. **The UI stylesheet, and the one piece of version logic** 鈥?every `dab-*`
  *     class a component uses is defined in it, and the floor comparison is exact
  *     on the release triple.
  *
@@ -31,12 +31,12 @@ const here = dirname(fileURLToPath(import.meta.url))
 const pluginDir = resolve(here, '..')
 const testingPath = join(pluginDir, 'lib', 'testing.js')
 
-const { HOST_CONTRACTS, DSH_FLOOR, probeContracts, verdictOf, meetsFloor, UI_CSS } =
+const { HOST_CONTRACTS, DSH_FLOOR, probeContracts, verdictOf, meetsFloor, UI_CSS, OWN_SHEET_ATTR, OWN_SHEET_DATASET } =
   await import(pathToFileURL(testingPath).href)
 
 const { readFile, readdir } = await import('node:fs/promises')
 
-// ── 1. the contract table ────────────────────────────────────────────────────
+// 鈹€鈹€ 1. the contract table 鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€
 
 test('contract ids are unique and non-empty', () => {
   const seen = new Set()
@@ -75,25 +75,37 @@ test('critical contracts carry a check that can fail', () => {
   }
 })
 
-// ── 2. the probe, against a fixture in the shape of a host DOM ───────────────
+// 鈹€鈹€ 2. the probe, against a fixture in the shape of a host DOM 鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€
 
 /** A DOM stand-in with just enough selector support for the contract checks. */
 function makeDom(host) {
-  /** `selector → present`, including attribute and comma-OR forms. */
-  const matches = sel => {
-    for (const part of sel.split(',').map(p => p.trim())) {
-      if (host.has(part)) return true
-      const attr = /^\[([a-z-]+)\]$/.exec(part)
-      if (attr !== null && host.has(`[${attr[1]}]`)) return true
-    }
+  /**
+   * `selector 鈫?present`, including attribute and comma-OR forms. A descendant
+   * selector is satisfied when every compound in it is present 鈥?the stand-in has
+   * no tree, and the contracts are written so that "the elements exist" is the
+   * question being asked.
+   */
+  const one = part => {
+    // `*` is the universal selector: always satisfied.
+    if (part === '*') return true
+    if (host.has(part)) return true
+    const attr = /^\[([a-z-]+)\]$/.exec(part)
+    if (attr !== null && host.has(`[${attr[1]}]`)) return true
     return false
   }
+  const matches = sel => sel.split(',').map(p => p.trim()).some(
+    part => part.split(/\s+/).every(one),
+  )
   return {
     querySelector: sel => (matches(sel) ? { style: {} } : null),
-    // `on` is null for an unscoped token check (the probe reads it off the
-    // document root) and the resolved element otherwise. The fixture answers from
-    // its own table either way — whether a value is readable is the host's own
-    // business, and that is exactly what the table stands in for.
+    // Where the host publishes its palette: `body` in the real client, and the
+    // fixture models exactly that. Reading the document element instead is what
+    // made seven healthy tokens report as empty.
+    tokenRoot: () => ({ style: {} }),
+    // `on` is null for an unscoped token check (the probe reads it off the token
+    // root) and the resolved element otherwise. The fixture answers from its own
+    // table either way 鈥?whether a value is readable is the host's own business,
+    // and that is exactly what the table stands in for.
     computedValue: (token, _on) => (host.get(`computed:${token}`) ?? ''),
     styleSheets: () => [],
   }
@@ -127,21 +139,55 @@ const PRESENT_TOKENS = [
 ]
 
 /**
- * A host that also declares every token/class/attribute rule the contracts look
- * for — a complete stylesheet fixture minus whatever a test removes.
+ * The literals the HOST's stylesheets declare. The two halves of a token
+ * contract ask different questions 鈥?`rule` = "does the host still declare this
+ * name", `computed` = "does it resolve to a value" 鈥?so both are listed.
  */
 const HOST_RULES = [
   '--dsw-menu-surface-fill', '--dsw-specific-menu', '--dsw-specific-sidebar-fill',
   '--dsw-specific-input-major', '--dsw-alias-bg-base', '--dsw-alias-bg-layer-1',
-  '.dab-card', '.md-table-wide', '[data-dockkit-content]', '[data-dockkit-empty]',
+  '--dsw-alias-label-caption',
+  '.md-table-wide', '[data-dockkit-content]', '[data-dockkit-empty]',
   '[data-dockkit-float]', '[data-sidebar-right-open]', 'data-ds-dark-theme',
 ]
 
-function hostStyles(literals = HOST_RULES) {
-  return [{
-    ownerNode: { dataset: {} },
+/** The one literal only THIS plugin's stylesheet declares (`.dab-card`, `side: 'own'`). */
+const OWN_RULES = ['.dab-card']
+
+/**
+ * A stylesheet the probe may read.
+ *
+ * `own: true` writes this plugin's marker 鈥?the ONLY thing that tells our sheets
+ * apart from the host's, since the host's own CSS modules set `data-plugin` on
+ * theirs, so a probe keying off that skips the entire host theme.
+ *
+ * The fixture exposes the attribute the way a REAL element does: `getAttribute`
+ * answers the dashed name, and `dataset` only the camel-cased key. Modelling this
+ * wrong is how a probe that reads `dataset['data-dab-side']` passes here and
+ * silently fails in a browser.
+ */
+function sheet(literals, own = false) {
+  const attrs = {}
+  const dataset = {}
+  if (own) {
+    attrs[OWN_SHEET_ATTR] = 'own'
+    dataset[OWN_SHEET_DATASET] = 'own'
+  }
+  return {
+    ownerNode: {
+      dataset,
+      getAttribute: name => (name in attrs ? attrs[name] : null),
+      setAttribute: (name, value) => { attrs[name] = value },
+    },
     cssRules: literals.map(l => ({ cssText: `.x{color:red}/* ${l} */` })),
-  }]
+  }
+}
+
+/** The host's sheets plus our own, minus whatever a test removes. */
+function hostStyles(literals = HOST_RULES, ownLiterals = OWN_RULES) {
+  const sheets = [sheet(literals)]
+  if (ownLiterals.length > 0) sheets.push(sheet(ownLiterals, true))
+  return sheets
 }
 
 /**
@@ -158,8 +204,27 @@ function hostEnv({ ctx, selectors = CORE_PRESENT, rules = HOST_RULES, tokens = P
   return { ...makeDom(host), styleSheets: () => hostStyles(rules), ctx }
 }
 
-/** The healthy fixture: nothing missing, every service published. */
-const healthyEnv = () => hostEnv({ ctx: healthyCtx() })
+/**
+ * The two states the dock alternates between. In the real DOM they live in
+ * different panes (a populated tab host carries `data-dockkit-content`, an empty
+ * pane carries `data-dockkit-empty`), and each contract's anchor is what says
+ * whether its own attribute can be observed 鈥?so the fixture provides the anchor
+ * for every contract it expects to answer, and omits the anchors of the ones it
+ * expects to read as n/a.
+ */
+const DOCK_POPULATED = [
+  'div[data-sidebar-right-panel]',
+  '[data-dockkit-tab]',
+  '[data-dockkit-content]',
+  '[data-dockkit-empty]',
+]
+const DOCK_EMPTY = ['div[data-sidebar-right-panel]', '[data-dockkit-empty]']
+
+/** The healthy fixtures: nothing missing, every service published. */
+const healthyEnv = (dock = DOCK_POPULATED) => hostEnv({
+  ctx: healthyCtx(),
+  selectors: [...CORE_PRESENT, ...dock],
+})
 
 /** A context publishing the four services the model hop needs. */
 function healthyCtx(overrides = {}) {
@@ -173,11 +238,14 @@ function healthyCtx(overrides = {}) {
   return { get: id => services[id] }
 }
 
-test('a healthy host passes every contract', () => {
-  const results = probeContracts(healthyEnv(), 'en')
-  const failed = results.filter(r => r.status === 'fail')
-  assert.deepEqual(failed.map(r => r.id), [], `unexpected failures: ${failed.map(r => `${r.id}: ${r.reason}`).join('; ')}`)
-  assert.equal(verdictOf({ results, summary: { pass: results.length, fail: 0, skip: 0, total: results.length } }), 'ok')
+test('a healthy host passes every contract, in either dock state', () => {
+  for (const [name, dock] of [['populated tab', DOCK_POPULATED], ['empty seat', DOCK_EMPTY]]) {
+    const results = probeContracts(healthyEnv(dock), 'en')
+    const failed = results.filter(r => r.status === 'fail')
+    assert.deepEqual(failed.map(r => r.id), [],
+      `unexpected failures with a ${name}: ${failed.map(r => `${r.id}: ${r.reason}`).join('; ')}`)
+    assert.equal(verdictOf({ results, summary: { pass: results.length, fail: 0, skip: 0, total: results.length } }), 'ok')
+  }
 })
 
 test('a renamed menu token fails exactly that contract, and names the symptom', () => {
@@ -192,6 +260,36 @@ test('a renamed menu token fails exactly that contract, and names the symptom',
   assert.match(row.symptom, /solid band|white band|sticky/i)
 })
 
+test('a renamed token the host still aliases is caught by the rule half', () => {
+  // The 0.1.7 menu split in reverse: the host keeps the OLD name working (aliased)
+  // but stops declaring the new one. `computed` still answers 鈥?which is exactly
+  // how that bug stayed silent 鈥?so the `rule` half is the only thing that can
+  // tell "renamed" from "still there".
+  const env = hostEnv({
+    ctx: healthyCtx(),
+    rules: HOST_RULES.filter(l => l !== '--dsw-menu-surface-fill'),
+  })
+  const results = probeContracts(env, 'en')
+  const row = results.find(r => r.id === 'token.menuSurface')
+  assert.equal(row.status, 'fail')
+  // The computed half would have passed: the token still resolves a value.
+  assert.match(row.detail, /host stylesheet includes/)
+})
+
+test('a host that stops publishing the palette fails the computed half', () => {
+  // The other failure shape: the name is still declared somewhere, but body no
+  // longer carries a value 鈥?the case that made 7 healthy tokens look empty when
+  // the probe read the wrong element.
+  const env = hostEnv({
+    ctx: healthyCtx(),
+    tokens: PRESENT_TOKENS.filter(t => t !== '--dsw-alias-bg-base'),
+  })
+  const results = probeContracts(env, 'en')
+  const row = results.find(r => r.id === 'token.bgBase')
+  assert.equal(row.status, 'fail')
+  assert.match(row.reason, /--dsw-alias-bg-base/)
+})
+
 test('a dropped session service fails the model hop', () => {
   const env = hostEnv({ ctx: healthyCtx({ sessions: undefined }) })
   const results = probeContracts(env, 'en')
@@ -200,24 +298,89 @@ test('a dropped session service fails the model hop', () => {
 })
 
 test('the plugin\'s own token stylesheet cannot make a host check pass', () => {
+  // The situation that produced the 0.1.7 white band: the plugin re-emits the
+  // menu fill itself, so its own sheet declares the token. That re-emission must
+  // never be accepted as evidence about the HOST 鈥?otherwise the check is green
+  // by construction on exactly the host where the token was renamed away.
   const env = hostEnv({
     ctx: healthyCtx(),
-    // The ONLY stylesheet is the plugin's own — exactly the situation that
-    // produced the 0.1.7 white band while the check would have been green.
+    // The host sheet is readable but has moved on: it no longer declares the
+    // menu fill under this name.
     rules: [],
   })
-  env.styleSheets = () => [{
-    ownerNode: { dataset: { plugin: 'dsh-background-by-model-tokens' } },
-    cssRules: [{ cssText: 'body{--dsw-menu-surface-fill:red!important;--dsw-specific-menu:red!important}' }],
-  }]
+  env.styleSheets = () => [
+    sheet([]), // the host's own, readable, declaring nothing
+    sheet(['--dsw-menu-surface-fill', '--dsw-specific-menu', '.dab-card'], true),
+  ]
+  const results = probeContracts(env, 'en')
+  const byId = id => results.find(r => r.id === id)
+  assert.equal(byId('token.menuSurface').status, 'fail')
+  assert.match(byId('token.menuSurface').reason, /no host stylesheet declares/)
+  assert.equal(byId('token.menuAlias').status, 'fail')
+  // 鈥hile the contract whose other half IS our own sheet still passes: this is
+  // what `side: 'own'` is for, and why the two sides must never be merged.
+  assert.equal(byId('settings.card').status, 'pass')
+})
+
+test('a host sheet carrying data-plugin is not mistaken for ours', () => {
+  // Regression for the probe bug that reported 7 healthy tokens as renamed: the
+  // host's CSS modules ALSO set `data-plugin` on their <style> elements, so a
+  // probe that skips "sheets with data-plugin" skips the host's whole theme.
+  const hostSheet = sheet(['--dsw-alias-bg-base'])
+  hostSheet.ownerNode.dataset.plugin = '@deepseek-ai/dsh-client-ui-theme'
+  const env = hostEnv({ ctx: healthyCtx(), rules: [] })
+  env.styleSheets = () => [hostSheet]
+  const results = probeContracts(env, 'en')
+  assert.equal(results.find(r => r.id === 'token.bgBase').status, 'pass')
+})
+
+test('a closed dock holding only its empty seat is n/a, not a failure', () => {
+  // The state a healthy host sits in most of the time: the dock holds no tab, so
+  // `data-dockkit-content` (a JS-set attribute the host never styles) cannot be
+  // observed at all. It used to read as "no host stylesheet declares it" 鈥?a
+  // perfectly healthy host reported as broken.
+  const env = healthyEnv(DOCK_EMPTY)
+  const results = probeContracts(env, 'en')
+  const byId = id => results.find(r => r.id === id)
+  assert.equal(byId('dockkit.content').status, 'skip')
+  // The empty seat IS on screen here, so its own contract answers.
+  assert.equal(byId('dockkit.empty').status, 'pass')
+  assert.equal(byId('dockkit.float').status, 'skip')
+  assert.deepEqual(results.filter(r => r.status === 'fail').map(r => r.id), [])
+})
+
+test('a renamed dock tab attribute still fails once a tab is open', () => {
+  // The guard must not swallow a real rename: with a tab open the host has to
+  // carry `data-dockkit-content` on the tab host, and if the name moved, say so.
+  // A populated tab is on screen (the host marks the tab chip), but the attribute
+  // the contract names no longer matches anything.
+  const env = hostEnv({
+    ctx: healthyCtx(),
+    selectors: ['div[data-sidebar-right-panel]', '[data-dockkit-tab]'],
+  })
+  const results = probeContracts(env, 'en')
+  const row = results.find(r => r.id === 'dockkit.content')
+  assert.equal(row.status, 'fail')
+  assert.match(row.reason, /data-dockkit-content/)
+})
+
+test('a floating pane missing its flag is a failure while it is on screen', () => {
+  // The float flag is a JS attribute too, so it is only observable when the user
+  // has a pane floated 鈥?and then, if the host stopped setting it, the plugin
+  // would paint that pane like a docked one.
+  const env = hostEnv({
+    ctx: healthyCtx(),
+    selectors: [...CORE_PRESENT, ...DOCK_POPULATED, '[data-sidebar-right-mode="float"]'],
+  })
   const results = probeContracts(env, 'en')
-  assert.equal(results.find(r => r.id === 'token.menuSurface').status, 'fail')
-  assert.equal(results.find(r => r.id === 'token.menuAlias').status, 'fail')
+  const row = results.find(r => r.id === 'dockkit.float')
+  assert.equal(row.status, 'fail')
+  assert.match(row.reason, /data-dockkit-float/)
 })
 
 test('a surface that is merely off screen is n/a, not a failure', () => {
   // The app frame and every service are up (the settings section is rendered
-  // inside the frame, so the frame is always there) — but the conversation view,
+  // inside the frame, so the frame is always there) 鈥?but the conversation view,
   // the right panel and the Cordis panel are not. Nothing is broken; those
   // surfaces simply are not there to observe.
   const env = hostEnv({
@@ -237,7 +400,7 @@ test('a surface that is merely off screen is n/a, not a failure', () => {
 })
 
 test('a mounted but marker-less surface is a failure, not n/a', () => {
-  // The dialog is open, so the right panel's anchor is off screen — but the
+  // The dialog is open, so the right panel's anchor is off screen 鈥?but the
   // dialog's own selector still matches. A surface whose anchor IS on screen and
   // whose selector is not is a rename, and must not read as "not observable".
   const env = hostEnv({
@@ -253,7 +416,7 @@ test('a mounted but marker-less surface is a failure, not n/a', () => {
   assert.equal(byId('chat.flow').status, 'skip')
 })
 
-// ── 3. the settings UI's own stylesheet ──────────────────────────────────────
+// 鈹€鈹€ 3. the settings UI's own stylesheet 鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€
 
 test('every dab-* class a component uses is defined in the UI stylesheet', async () => {
   const dir = join(pluginDir, 'src', 'client')
@@ -283,7 +446,7 @@ test('every dab-* class a component uses is defined in the UI stylesheet', async
   assert.deepEqual(missing, [], `classes used but never styled: ${missing.map(m => `${m.cls} (${m.file})`).join(', ')}`)
 })
 
-// ── 4. the floor comparison ──────────────────────────────────────────────────
+// 鈹€鈹€ 4. the floor comparison 鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€
 
 test('the floor comparison is coarse on purpose and exact on the triple', () => {
   assert.equal(meetsFloor('0.1.7-rc.2', DSH_FLOOR), true, 'the floor itself satisfies the floor')