dsh-agy-link 0.4.65 → 0.4.66

package/CHANGELOG.md

@@ -1,5 +1,27 @@
 # Changelog
 
+## 0.4.66 (2026-10-19)
+
+### English
+
+- **Fix: Residual Windows console flash from agy's own auto-updater (Fixes #49).**
+  - Root cause confirmed on agy 1.4.2: `--bg-updater` is spawned *inside* agy, and its `agy --version` grandchild allocates a fresh visible console. The parent's `windowsHide` and `AGY_CLI_DISABLE_AUTO_UPDATE=1` therefore apply too late — the window is already on screen (this invalidates the #23 assumption).
+  - New `src/host/auto-updater.ts` pre-empts the check instead of the child: agy's 15-minute fast path (`auto_updater.go:281 Last check was less than 15 minutes ago, skipping update (fast path)`) only stats `<agy home>/last_check.timestamp`, so the plugin refreshes that mtime immediately before every spawn. The `--bg-updater` chain is then never created.
+  - Covers every spawn path: turns, boot `--version`/`models` probes, model-picker `listModels` refresh, login probes and auxiliary oneshot calls. Verified end-to-end against agy 1.4.2: the run logs `skipping update (fast path)` and spawns no child.
+  - Isolated accounts are respected — the timestamp is resolved through the same `ANTIGRAVITY_APP_DATA_DIR` / `GEMINI_CLI_HOME` / `HOME` / `USERPROFILE` chain the plugin spawns with, so pooled homes are never mixed and the real profile is only touched for the system account.
+  - New config `suppressAgyAutoUpdate` (env `DSH_AGY_SUPPRESS_AUTOUPDATE`), default `true` on Windows and `false` elsewhere; `false` restores agy's own auto-update behaviour. Pre-emption is best-effort and never fails a run.
+  - `/agy doctor` now reports the auto-updater suppression state, and the FAQ documents both this fix and the read-only `update.lock` workaround for older versions.
+
+### 中文
+
+- **修复：agy 自身自动更新链导致的 Windows 残留闪窗（修复 #49）。**
+  - 在 agy 1.4.2 上实锤根因：`--bg-updater` 是 **agy 内部** spawn 的，它再拉起的 `agy --version` 孙进程会自行分配可见控制台，因此父进程的 `windowsHide` 与 `AGY_CLI_DISABLE_AUTO_UPDATE=1` 都来不及生效（#23 的假设在此版本不成立）。
+  - 新增 `src/host/auto-updater.ts`，改从「阻止检查」下手：agy 的 15 分钟 fast path（`auto_updater.go:281 Last check was less than 15 minutes ago, skipping update (fast path)`）只 stat `<agy home>/last_check.timestamp`，插件在每次 spawn 前刷新该文件 mtime，`--bg-updater` 链便完全不产生。
+  - 覆盖全部 spawn 路径：对话轮次、启动 `--version` / `models` 探测、模型选择器的 `listModels` 刷新、登录探测与 oneshot 辅助调用。已用真实 agy 1.4.2 端到端验证：日志为 `skipping update (fast path)`，无任何子进程。
+  - 隔离账号同样生效——时间戳按插件 spawn 时使用的 `ANTIGRAVITY_APP_DATA_DIR` / `GEMINI_CLI_HOME` / `HOME` / `USERPROFILE` 链路解析，号池目录互不串扰，只有系统主账号才会碰到真实 profile。
+  - 新增配置 `suppressAgyAutoUpdate`（环境变量 `DSH_AGY_SUPPRESS_AUTOUPDATE`），Windows 默认 `true`、其他平台默认 `false`；设为 `false` 即恢复 agy 原本的自动更新行为。拦截为 best-effort，失败绝不影响对话。
+  - `/agy doctor` 增加自动更新拦截状态行；FAQ 同时补充本修复说明与旧版本可用的只读 `update.lock` workaround。
+
 ## 0.4.65 (2026-10-19)
 
 ### English

package/README.md

@@ -151,6 +151,7 @@ dsh plugin --profile web add dsh-agy-link
 | `timeoutMs` | `DSH_AGY_TIMEOUT_MS` | `600000` | 单轮活跃看门狗超时（毫秒） |
 | `longToolIdleMinutes` | `DSH_AGY_LONG_TOOL_IDLE_MINUTES` | `240` | 存在未完成工具步骤（ACTIVE）时的空闲预算（分钟）；`0` = 不抬高预算，卡死的工具按 `timeoutMs` 快速失败 |
 | `workspaceRoot` | `DSH_AGY_WORKSPACE_ROOT` | 会话 cwd | agy 工作区根目录（默认跟随当前会话工作区） |
+| `suppressAgyAutoUpdate` | `DSH_AGY_SUPPRESS_AUTOUPDATE` | Windows `true`，其他平台 `false` | 每次 spawn 前刷新 agy 的更新检查时间戳，阻断 `--bg-updater` 子进程链（Windows 闪窗根因）。关闭后 agy 恢复自动更新检查 |
 
 ---
 
@@ -175,6 +176,16 @@ dsh plugin --profile web add dsh-agy-link
   3. 点击右下角 **保存 (Save)**。
   4. **完全退出并重启 DSH**（使新启动的主进程应用更新后的控制台委托注册表），黑框闪烁即可彻底消除。
 
+### agy 自己的自动更新子进程也会闪窗（0.4.66 修复）
+除了上面那种控制台委托导致的闪窗，`agy` **自己**还会在距上次更新检查满 15 分钟后派生一条 `--bg-updater` → `agy --version` 的子进程链，**这条链由 agy 内部创建，会自行分配可见控制台**，父进程的 `windowsHide` 和 `AGY_CLI_DISABLE_AUTO_UPDATE=1` 都来不及生效（这就是 Issue #49 实测确认的结论）。
+
+0.4.66 起的处理方式：每次 spawn agy 之前，插件把 agy 更新检查的 fast-path 时间戳（`<agy home>/last_check.timestamp`）刷新为当前时间。agy 的检查逻辑是「距上次检查 < 15 分钟就直接跳过且不派生子进程」，于是这条可见窗口链根本不会被创建——对话、冷启动探测、模型选择器刷新、登录探测全部覆盖。
+
+- **代价**：插件所使用的那个 agy home 不再自动检查更新；手动 `agy update` 完全不受影响。
+- **开关**：`suppressAgyAutoUpdate`（环境变量 `DSH_AGY_SUPPRESS_AUTOUPDATE`）。Windows 上默认开启，其他平台默认关闭；设为 `false` 即回到 agy 原本的自动更新行为。
+- **旧版本用户的手动 workaround**：把 `%USERPROFILE%\.gemini\antigravity-cli\updater\update.lock` 设为只读（`attrib +R ...`），agy 拿不到更新锁就会跳过检查。代价是手动 `agy update` 会报 `update already in progress`，需要先 `attrib -R`。
+
+
 ---
 
 ## 🙏 参考与致谢
@@ -318,6 +329,7 @@ dsh plugin --profile web add dsh-agy-link
 | `timeoutMs` | `DSH_AGY_TIMEOUT_MS` | `600000` | Activity watchdog timeout in milliseconds |
 | `longToolIdleMinutes` | `DSH_AGY_LONG_TOOL_IDLE_MINUTES` | `240` | Idle budget while a tool step is ACTIVE (minutes); `0` keeps the normal `timeoutMs` budget so wedged tools fail fast |
 | `workspaceRoot` | `DSH_AGY_WORKSPACE_ROOT` | session cwd | Working directory root |
+| `suppressAgyAutoUpdate` | `DSH_AGY_SUPPRESS_AUTOUPDATE` | `true` on Windows, `false` elsewhere | Refreshes agy's update-check timestamp before every spawn so its `--bg-updater` child chain (the Windows console-flash root cause) never starts. `false` restores agy's own auto-update checks |
 
 ---
 
@@ -348,6 +360,29 @@ you explicitly accept unattended tool execution.
   3. Click **Save** in the bottom-right corner.
   4. **Completely exit and restart DSH** so the running host process picks up the updated console delegation setting.
 
+### agy's own auto-updater also flashes a window (fixed in 0.4.66)
+On top of the console-delegation flash above, `agy` itself spawns a
+`--bg-updater` → `agy --version` child chain once its last update check is more
+than 15 minutes old. **That chain is created inside agy and allocates its own
+visible console**, so the parent's `windowsHide` and `AGY_CLI_DISABLE_AUTO_UPDATE=1`
+both apply too late — the exact conclusion of the measurements recorded in issue #49.
+
+Since 0.4.66 the plugin refreshes agy's fast-path timestamp
+(`<agy home>/last_check.timestamp`) right before every spawn. agy skips the
+check entirely when it is under 15 minutes old and spawns nothing, so the
+visible window chain never starts — for turns, boot probes, model-picker
+refreshes and login probes alike.
+
+- **Cost**: the agy home used by this plugin stops auto-checking for updates;
+  a manual `agy update` still works normally.
+- **Switch**: `suppressAgyAutoUpdate` (env `DSH_AGY_SUPPRESS_AUTOUPDATE`).
+  On by default on Windows, off elsewhere; set `false` to restore agy's own behaviour.
+- **Manual workaround on older versions**: make
+  `%USERPROFILE%\.gemini\antigravity-cli\updater\update.lock` read-only
+  (`attrib +R ...`). agy then fails to acquire the update lock and skips the
+  check — at the price of `agy update` reporting `update already in progress`
+  until you run `attrib -R`.
+
 ---
 
 ## ⚠️ Disclaimer

package/dist/index.js

@@ -1,7 +1,7 @@
 import { createRequire } from "node:module";
 import { execFile, execFileSync, spawn } from "node:child_process";
 import path, { delimiter, dirname, extname, isAbsolute, join, relative, resolve } from "node:path";
-import { accessSync, chmodSync, constants, copyFileSync, createReadStream, existsSync, mkdirSync, readFileSync, readdirSync, renameSync, rmSync, statSync, unlinkSync, writeFileSync } from "node:fs";
+import { accessSync, chmodSync, constants, copyFileSync, createReadStream, existsSync, mkdirSync, readFileSync, readdirSync, renameSync, rmSync, statSync, unlinkSync, utimesSync, writeFileSync } from "node:fs";
 import { homedir, tmpdir } from "node:os";
 import * as dshLlm from "@deepseek-ai/dsh-llm";
 import { LlmAdapter, LlmError } from "@deepseek-ai/dsh-llm";
@@ -136,7 +136,8 @@ function defaultConfig() {
 		logRetentionDays: 7,
 		disableTelemetry: true,
 		quotaPollIntervalMs: 9e5,
-		proxyUrl: ""
+		proxyUrl: "",
+		suppressAgyAutoUpdate: process.platform === "win32"
 	};
 }
 /**
@@ -456,7 +457,8 @@ function resolveConfig(entry, env = process.env, overrides = readOverrides()) {
 		logRetentionDays: asNum(get("logRetentionDays")) ?? base.logRetentionDays,
 		disableTelemetry: asBool(get("disableTelemetry")) ?? base.disableTelemetry,
 		quotaPollIntervalMs: asNum(get("quotaPollIntervalMs")) ?? base.quotaPollIntervalMs,
-		proxyUrl: asString(get("proxyUrl")) ?? base.proxyUrl
+		proxyUrl: asString(get("proxyUrl")) ?? base.proxyUrl,
+		suppressAgyAutoUpdate: asBool(get("suppressAgyAutoUpdate")) ?? base.suppressAgyAutoUpdate
 	};
 	if (env.DSH_AGY_ENABLED !== void 0) cfg.enabled = asBool(env.DSH_AGY_ENABLED) ?? cfg.enabled;
 	if (env.DSH_AGY_BIN) cfg.agyBin = env.DSH_AGY_BIN;
@@ -515,6 +517,10 @@ function resolveConfig(entry, env = process.env, overrides = readOverrides()) {
 		if (q && q >= 6e4) cfg.quotaPollIntervalMs = q;
 	}
 	if (env.DSH_AGY_PROXY_URL) cfg.proxyUrl = env.DSH_AGY_PROXY_URL;
+	if (env.DSH_AGY_SUPPRESS_AUTOUPDATE !== void 0) {
+		const sa = asBool(env.DSH_AGY_SUPPRESS_AUTOUPDATE);
+		if (sa !== void 0) cfg.suppressAgyAutoUpdate = sa;
+	}
 	return cfg;
 }
 //#endregion
@@ -2771,6 +2777,85 @@ async function sweepDir(dir, ttlMs, now = Date.now()) {
 function defaultMediaDir(stateDir) {
 	return join(stateDir, "media");
 }
+function nonBlank(v) {
+	return (v ?? "").trim();
+}
+/**
+* agy's application data directory for a given spawn environment.
+*
+* The plugin isolates pooled accounts by rewriting HOME / USERPROFILE /
+* GEMINI_CLI_HOME / ANTIGRAVITY_APP_DATA_DIR (see `isolatedHomeEnv`), and agy
+* resolves its data dir from exactly those variables — an isolated spawn was
+* verified to write `<home>/.gemini/antigravity-cli/last_check.timestamp`.
+*/
+function agyAppDataDir(env = process.env) {
+	const explicit = nonBlank(env.ANTIGRAVITY_APP_DATA_DIR);
+	if (explicit !== "") return explicit;
+	const geminiDir = nonBlank(env.GEMINI_CLI_HOME);
+	if (geminiDir !== "") return join(geminiDir, "antigravity-cli");
+	let home = nonBlank(env.HOME);
+	if (home === "") home = nonBlank(env.USERPROFILE);
+	if (home === "") try {
+		home = homedir();
+	} catch {
+		home = "";
+	}
+	if (home === "") return null;
+	return join(home, ".gemini", "antigravity-cli");
+}
+/**
+* Candidate `last_check.timestamp` locations for one spawn environment.
+*
+* The issue reporter observed `<appData>/updater/last_check.timestamp` on
+* Windows while macOS uses `<appData>/last_check.timestamp`. Refreshing both is
+* cheap and keeps the fix independent of agy's per-platform path choice.
+*/
+function agyUpdateCheckPaths(env = process.env) {
+	const appData = agyAppDataDir(env);
+	if (appData === null) return [];
+	return [join(appData, "last_check.timestamp"), join(appData, "updater", "last_check.timestamp")];
+}
+/**
+* Refresh agy's update-check timestamp so the next spawn takes the fast path.
+* Best-effort: a read-only or missing profile must never fail a run.
+*/
+function preemptAgyAutoUpdate(env = process.env, now = Date.now()) {
+	const result = {
+		touched: [],
+		failures: []
+	};
+	const seconds = Math.floor(now / 1e3);
+	for (const path of agyUpdateCheckPaths(env)) try {
+		mkdirSync(dirname(path), { recursive: true });
+		if (!existsSync(path)) writeFileSync(path, "");
+		utimesSync(path, seconds, seconds);
+		result.touched.push(path);
+	} catch (err) {
+		result.failures.push({
+			path,
+			error: err instanceof Error ? err.message : String(err)
+		});
+	}
+	return result;
+}
+/** Age (ms) of the most recent recorded update check, or null when none exists. */
+function agyUpdateCheckAgeMs(env = process.env, now = Date.now()) {
+	let freshest = null;
+	for (const path of agyUpdateCheckPaths(env)) try {
+		const age = now - statSync(path).mtimeMs;
+		if (freshest === null || age < freshest) freshest = age;
+	} catch {}
+	return freshest;
+}
+/** One-line `/agy doctor` summary of the auto-update suppression state. */
+function describeAgyAutoUpdate(env = process.env, now = Date.now()) {
+	if (agyUpdateCheckPaths(env).length === 0) return "unknown — no agy home directory in the spawn env";
+	const age = agyUpdateCheckAgeMs(env, now);
+	if (age === null) return "armed — no agy update check recorded yet; the next spawn pre-empts it";
+	const minutes = Math.max(0, Math.round(age / 6e4));
+	if (age < 9e5) return "suppressed — last check " + minutes + "m ago (agy fast path < 15m)";
+	return "stale — last check " + minutes + "m ago; the next spawn pre-empts it";
+}
 //#endregion
 //#region src/host/runner.ts
 const IS_WIN$2 = process.platform === "win32";
@@ -3366,6 +3451,7 @@ function startAgyProcess(opts) {
 	const viaCmd = IS_WIN$2 && isCmdShim(opts.bin);
 	const isNode = IS_WIN$2 && /\.(mjs|js|cjs)$/i.test(opts.bin);
 	const env = withAgyQuietEnv(opts.env ?? process.env);
+	if (opts.preemptAutoUpdate !== false && !isNode) preemptAgyAutoUpdate(env);
 	const child = viaCmd ? spawn(process.env.ComSpec ?? "cmd.exe", [
 		"/d",
 		"/s",
@@ -3500,13 +3586,14 @@ function startAgyProcess(opts) {
 	};
 }
 /** Simple one-shot helper for --version / models probes. */
-async function probeProcess(bin, args, timeoutMs = 3e4, signal, env) {
+async function probeProcess(bin, args, timeoutMs = 3e4, signal, env, preemptAutoUpdate) {
 	return startAgyProcess({
 		bin,
 		args,
 		timeoutMs,
 		signal,
-		env
+		env,
+		preemptAutoUpdate
 	}).outcome;
 }
 //#endregion
@@ -30818,6 +30905,7 @@ var AgyAdapter = class AgyAdapter extends LlmAdapter {
 				signal: options.signal,
 				env,
 				stdinPayload,
+				preemptAutoUpdate: cfg.suppressAgyAutoUpdate,
 				stderrKeepalive: true,
 				onLine: (line) => {
 					sawAnyEvent = true;
@@ -31301,6 +31389,7 @@ async function runAgyOnce(deps, req) {
 		timeoutMs,
 		signal: req.signal,
 		stdinPayload,
+		preemptAutoUpdate: cfg.suppressAgyAutoUpdate,
 		onLine: (line) => {
 			for (const ev of parser.feed(line + "\n")) {
 				if (ev.kind === "init" && ev.conversationId) conversationId = ev.conversationId;
@@ -31479,6 +31568,7 @@ const URL_WAIT_MS = 2e4;
 const CODE_SETTLE_MS = 9e4;
 var AuthHelper = class {
 	bin;
+	preemptAutoUpdate;
 	state = { phase: "idle" };
 	probe = null;
 	capturedUrl = null;
@@ -31490,8 +31580,9 @@ var AuthHelper = class {
 	beginSeq = 0;
 	signedInCache = null;
 	signedInFlight = null;
-	constructor(bin) {
+	constructor(bin, preemptAutoUpdate = () => true) {
 		this.bin = bin;
+		this.preemptAutoUpdate = preemptAutoUpdate;
 	}
 	status() {
 		return { ...this.state };
@@ -31518,7 +31609,7 @@ var AuthHelper = class {
 					...process.env,
 					HOME: homeDir
 				} : process.env;
-				const out = await probeProcess(bin, ["models"], 15e3, void 0, env);
+				const out = await probeProcess(bin, ["models"], 15e3, void 0, env, this.preemptAutoUpdate());
 				const tail = out.stderrTail + "\n" + out.stdout.slice(0, 2e3);
 				if (out.code === 0 && !looksLikeAuthFailure(out.stdout)) value = true;
 				else if (out.code !== 0 && looksLikeAuthFailure(tail)) value = false;
@@ -31559,6 +31650,11 @@ var AuthHelper = class {
 		this.cancel();
 		this.capturedUrl = null;
 		if (homeDir) ensureIsolatedKeychain(homeDir);
+		const env = {
+			...process.env,
+			...homeDir ? isolatedHomeEnv(homeDir) : {},
+			...proxyEnvFor(proxyUrl || detectSystemProxy())
+		};
 		const proc = startAgyProcess({
 			bin,
 			args: [
@@ -31572,11 +31668,8 @@ var AuthHelper = class {
 			timeoutMs: 3e5,
 			keepStdin: true,
 			stderrKeepalive: true,
-			env: {
-				...process.env,
-				...homeDir ? isolatedHomeEnv(homeDir) : {},
-				...proxyEnvFor(proxyUrl || detectSystemProxy())
-			},
+			preemptAutoUpdate: this.preemptAutoUpdate(),
+			env,
 			onLine: (line) => {
 				if (this.capturedUrl) return;
 				const url = extractAuthUrl(line);
@@ -31795,6 +31888,7 @@ function writeDoctorReport(deps) {
 	lines.push("- generated: " + (/* @__PURE__ */ new Date()).toISOString());
 	lines.push("- agy binary: " + (deps.bin() ?? "NOT FOUND"));
 	lines.push("- agy version: " + (deps.version() ?? "unknown"));
+	lines.push("- agy auto-updater: " + (cfg.suppressAgyAutoUpdate ? describeAgyAutoUpdate() : "not suppressed (suppressAgyAutoUpdate=false)"));
 	const cfgDump = {
 		...cfg,
 		extraArgs: cfg.extraArgs.length
@@ -33675,11 +33769,11 @@ function apply(ctx, entryConfig = {}) {
 		const poolData = pool.getPoolData();
 		const primaryAcc = poolData.primaryAccountId ? pool.getAccount(poolData.primaryAccountId) : void 0;
 		const candidateAccount = primaryAcc && primaryAcc.enabled && !primaryAcc.authRequired ? primaryAcc : pool.getAccounts().find((a) => a.enabled && !a.authRequired);
-		let out = await probeProcess(b, ["models"], 3e4, signal, getDiscoveryEnv(candidateAccount));
+		let out = await probeProcess(b, ["models"], 3e4, signal, getDiscoveryEnv(candidateAccount), getConfig().suppressAgyAutoUpdate);
 		if ((out.code !== 0 || out.stdout.includes("Please sign in") || /sign in|auth|not logged in/i.test(out.stderrTail)) && (!candidateAccount || !candidateAccount.dir)) {
 			const secondary = pool.getAccounts().find((a) => a.enabled && !a.authRequired && a.dir);
 			if (secondary) {
-				const secondaryOut = await probeProcess(b, ["models"], 3e4, signal, getDiscoveryEnv(secondary));
+				const secondaryOut = await probeProcess(b, ["models"], 3e4, signal, getDiscoveryEnv(secondary), getConfig().suppressAgyAutoUpdate);
 				if (secondaryOut.code === 0 && secondaryOut.stdout.trim() !== "") out = secondaryOut;
 			}
 		}
@@ -33689,7 +33783,7 @@ function apply(ctx, entryConfig = {}) {
 			stderr: out.stderrTail
 		};
 	}, getConfig().fallbackModels, getConfig().modelsCacheTtlMs, notifyPicker);
-	const auth = new AuthHelper(bin);
+	const auth = new AuthHelper(bin, () => getConfig().suppressAgyAutoUpdate);
 	const poolAuth = new PoolAuthFlow(pool, quota, log);
 	const runs = new RunRegistry();
 	try {
@@ -33832,7 +33926,7 @@ function apply(ctx, entryConfig = {}) {
 				return;
 			}
 			try {
-				versionCache = parseVersion((await probeProcess(currentBin, ["--version"], 1e4)).stdout);
+				versionCache = parseVersion((await probeProcess(currentBin, ["--version"], 1e4, void 0, void 0, getConfig().suppressAgyAutoUpdate)).stdout);
 				if (versionCache && compareVersions(versionCache, "1.1.8") < 0) {
 					dormantReason = "agy " + versionCache + " is older than 1.1.8 — run: agy update";
 					log("dormant: " + dormantReason);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dsh-agy-link",
-  "version": "0.4.65",
+  "version": "0.4.66",
   "description": "Google Antigravity (agy CLI) models for DeepSeek Harness — stream Gemini/Claude/GPT-OSS subscriptions into DSH with thinking, tool activity, token usage and in-GUI Google OAuth login.",
   "type": "module",
   "license": "MIT",