dsh-advisor 0.2.2 → 0.2.4

package/README.i18n.yaml

@@ -3,5 +3,5 @@
 # editing either side, bring the other along and re-record with:
 #   git hash-object README.md
 #   git hash-object README.zh.md
-README.md: ef98d163d84f2db4ee6a5345d467eee27644ff3b
-README.zh.md: 228f1d220635cbf7aba0ef72dc32e293a6635eaa
+README.md: 5caf5c759a30682228bc562d914d801b64f94f08
+README.zh.md: 7913542a4f734da470b0f334a8a2870c9a2c06a3

package/README.md

@@ -4,7 +4,8 @@
 
 [![license](https://img.shields.io/badge/license-MIT-blue.svg)](LICENSE)
 ![node](https://img.shields.io/badge/node-%5E22.19%20%7C%7C%20%3E%3D24-339933.svg)
-![dsh](https://img.shields.io/badge/dsh-DeepSeek%20Harness%20compatible-4B32C3.svg)
+![dsh](https://img.shields.io/badge/dsh-0.1.1--rc.1-4B32C3.svg)
+![dsh tui](https://img.shields.io/badge/dsh%20tui-compatible-4B32C3.svg)
 [![dshfind](https://dshfind.com/api/badge/omdsh-dev/dsh-advisor)](https://dshfind.com/plugins/omdsh-dev/dsh-advisor?ref=badge)
 
 A standalone dsh (DeepSeek Harness) plugin bundle porting the omp "advisor" subsystem: a per-session independent reviewer model that observes the primary transcript, reviews each stepped turn with an explicitly configured model (provider + model are required), and injects severity-ranked advice (nit / concern / blocker) back into the session — without polluting or recursively reviewing itself.

package/README.zh.md

@@ -4,7 +4,8 @@
 
 [![license](https://img.shields.io/badge/license-MIT-blue.svg)](LICENSE)
 ![node](https://img.shields.io/badge/node-%5E22.19%20%7C%7C%20%3E%3D24-339933.svg)
-![dsh](https://img.shields.io/badge/dsh-DeepSeek%20Harness%20compatible-4B32C3.svg)
+![dsh](https://img.shields.io/badge/dsh-0.1.1--rc.1-4B32C3.svg)
+![dsh tui](https://img.shields.io/badge/dsh%20tui-compatible-4B32C3.svg)
 [![dshfind](https://dshfind.com/api/badge/omdsh-dev/dsh-advisor?lang=zh)](https://dshfind.com/zh/plugins/omdsh-dev/dsh-advisor?ref=badge)
 
 一个移植 omp「advisor」子系统的独立 dsh（DeepSeek Harness）插件组合包：一个按会话运行的独立评审模型，观察主会话 transcript，用显式配置的模型（provider 与 model 均为必填）评审每个已完成的 stepped turn，并把按严重度排序的建议（nit / concern / blocker）注入回会话——不污染主循环，也不递归地评审自己。

package/lib/client/advisor-card.d.ts

@@ -63,14 +63,18 @@
  */
 import { type ReactNode } from 'react';
 import type { InjectFace, PropsLocale, PropsRuntime } from '@deepseek-ai/dsh-client-ui-slots';
-import type { SnapshotSelectorHook } from '@deepseek-ai/dsh-client-web-react';
+import type { SnapshotStore } from '@deepseek-ai/dsh-client-runtime/client';
 import type { AdvisorSettingsState, AdvisorSettingsStore } from './advisor-store.ts';
-/** Injected dependencies of {@link AdvisorCard} (slot `inject`). */
+/** Injected dependencies of {@link AdvisorCard} (slot `inject`). The `hooks`
+ * compartment carries the bare snapshot store; the slot renderer binds it to
+ * the `useSnapshot` selector hook the component consumes (host renderer contract). */
 export interface AdvisorCardInjected {
     /** The card store (loaded on mount, refreshed on pushed invalidations). */
     controller: AdvisorSettingsStore;
-    /** uSES subscription hook bound to the store. */
-    useSnapshot: SnapshotSelectorHook<AdvisorSettingsState>;
+    /** Bare snapshot source the renderer binds as `useSnapshot`. */
+    hooks: {
+        snapshot: SnapshotStore<AdvisorSettingsState>;
+    };
 }
 /**
  * Props the renderer binds for the card: the `settings.plugin.item` runtime

package/lib/client/advisor-store.d.ts

@@ -39,6 +39,13 @@
  */
 import type { ClientConnectionRpc, IApiClient, SettingsNamespaceView } from '@deepseek-ai/dsh-client-connection/client';
 import type { SnapshotStore } from '@deepseek-ai/dsh-client-runtime/client';
+import type { SettingsSchemaService } from '@deepseek-ai/dsh-client-ui-settings/client';
+/**
+ * The schema face the card store uses: ui-settings owns the immutable
+ * path writers (`ctx.settingsSchema`); this narrow pick hides the Cordis
+ * service identity from the store and its tests.
+ */
+export type SettingsSchemaOperations = Pick<SettingsSchemaService, 'getPath' | 'setPath' | 'deletePath'>;
 /**
  * The wire `config` value the host gateway returns — mirror of the node-side
  * `ResolvedAdvisorConfig` (src/config.ts). Kept as a local structural type
@@ -177,6 +184,7 @@ export interface AdvisorSettingsState {
 export declare class AdvisorSettingsStore {
     private readonly api;
     private readonly rpc;
+    private readonly schema;
     /** The snapshot the card renders from (uSES-safe store). */
     readonly store: SnapshotStore<AdvisorSettingsState>;
     /** Latest load wins; an older response never overwrites a newer one. */
@@ -203,7 +211,9 @@ export declare class AdvisorSettingsStore {
      * @param rpc - the connection's generic RPC caller for the host gateway
      *   channel (`/api`), injected from the connection handle.
      */
-    constructor(api: Pick<IApiClient, 'settings' | 'llm'>, rpc: ClientConnectionRpc);
+    constructor(api: Pick<IApiClient, 'settings' | 'llm'>, rpc: ClientConnectionRpc, schema: SettingsSchemaOperations);
+    /** Profile-declared models (the provider's `models` directory), when the profile has one. */
+    private profileModels;
     /**
      * Refresh the whole page snapshot: the provider directory and the settings
      * namespaces in parallel, then the advisor config over the gateway channel,
@@ -296,9 +306,9 @@ export declare class AdvisorSettingsStore {
      * write (the frozen-snapshot write would be dropped by the snapshot store).
      */
     private recomputeDirty;
-    /** Edit one always-present draft field via the schema-form path writer. */
+    /** Edit one always-present draft field via the settings schema path writer. */
     private setField;
-    /** Remove one optional draft field via the schema-form path writer. */
+    /** Remove one optional draft field via the settings schema path writer. */
     private clearField;
     private clampInt;
 }

package/lib/client/index.d.ts

@@ -7,11 +7,11 @@
  * provider directory through the connection wire, and keeps fresh on pushed
  * invalidations. Export discipline: the client half value-imports ONLY the
  * frozen platform module table (CLIENT_EXTERNALS: react /
- * @deepseek-ai/cordis / ui-slots / web-react / ui-primitives /
- * schema-form / the documented `@deepseek-ai/dsh-client-runtime/client`
- * exemption); every other `@deepseek-ai/*` import is type-only (erased at
- * build) — values arrive via cordis injection (`ctx.get('connection')`, slot
- * inject faces). Mirrors the ui-models reference entry.
+ * @deepseek-ai/cordis / ui-slots / ui-primitives / the documented
+ * `@deepseek-ai/dsh-client-runtime/client` exemption); every other
+ * `@deepseek-ai/*` import is type-only (erased at build) — values arrive via
+ * cordis injection (`ctx.get('connection')`, slot inject faces, the
+ * `settingsSchema` service). Mirrors the ui-models reference entry.
  */
 import type { ClientContext } from '@deepseek-ai/dsh-client-runtime/client';
 import { type AdvisorKey } from './locales.ts';

package/lib/client.js

@@ -29,7 +29,6 @@ __export(index_exports, {
   refreshIfLoaded: () => refreshIfLoaded
 });
 module.exports = __toCommonJS(index_exports);
-var import_dsh_client_web_react = require("@deepseek-ai/dsh-client-web-react");
 
 // src/client/advisor-card.tsx
 var import_react = require("react");
@@ -285,7 +284,6 @@ function AdvisorCard(props) {
 
 // src/client/advisor-store.ts
 var import_client = require("@deepseek-ai/dsh-client-runtime/client");
-var import_dsh_client_schema_form = require("@deepseek-ai/dsh-client-schema-form");
 function defaultDraft() {
   return { enabled: false, systemPrompt: "", immuneTurns: 3, maxDeltaMessages: 60 };
 }
@@ -311,20 +309,6 @@ function gateFailure(draft) {
   if (draft.model === void 0) return "model";
   return void 0;
 }
-function profileModels(profile) {
-  const models = (0, import_dsh_client_schema_form.getPath)(profile, ["models"]);
-  if (!Array.isArray(models)) return void 0;
-  return models.flatMap((entry) => {
-    if (typeof entry !== "object" || entry === null) return [];
-    const model = entry;
-    if (typeof model.id !== "string" || model.id.length === 0) return [];
-    return [{
-      id: model.id,
-      name: typeof model.name === "string" ? model.name : model.id,
-      ...typeof model.description === "string" ? { description: model.description } : {}
-    }];
-  });
-}
 var AdvisorSettingsStore = class {
   /**
    * @param api - the wire face (settings/llm domains) for the provider/model
@@ -332,9 +316,10 @@ var AdvisorSettingsStore = class {
    * @param rpc - the connection's generic RPC caller for the host gateway
    *   channel (`/api`), injected from the connection handle.
    */
-  constructor(api, rpc) {
+  constructor(api, rpc, schema) {
     __publicField(this, "api", api);
     __publicField(this, "rpc", rpc);
+    __publicField(this, "schema", schema);
     /** The snapshot the card renders from (uSES-safe store). */
     __publicField(this, "store", (0, import_client.createSnapshotStore)({
       status: "idle",
@@ -375,6 +360,21 @@ var AdvisorSettingsStore = class {
     /** The resolved advisor config at the last get/apply (patch diff baseline). */
     __publicField(this, "seed", defaultDraft());
   }
+  /** Profile-declared models (the provider's `models` directory), when the profile has one. */
+  profileModels(profile) {
+    const models = this.schema.getPath(profile, ["models"]);
+    if (!Array.isArray(models)) return void 0;
+    return models.flatMap((entry) => {
+      if (typeof entry !== "object" || entry === null) return [];
+      const model = entry;
+      if (typeof model.id !== "string" || model.id.length === 0) return [];
+      return [{
+        id: model.id,
+        name: typeof model.name === "string" ? model.name : model.id,
+        ...typeof model.description === "string" ? { description: model.description } : {}
+      }];
+    });
+  }
   /**
    * Refresh the whole page snapshot: the provider directory and the settings
    * namespaces in parallel, then the advisor config over the gateway channel,
@@ -429,7 +429,7 @@ var AdvisorSettingsStore = class {
     const options = [];
     for (const entry of providers) {
       const namespace = namespaces[entry.settingsNs];
-      const configured = namespace !== void 0 && (entry.settingsPath.length === 0 || (0, import_dsh_client_schema_form.getPath)(namespace.value, entry.settingsPath) !== void 0);
+      const configured = namespace !== void 0 && (entry.settingsPath.length === 0 || this.schema.getPath(namespace.value, entry.settingsPath) !== void 0);
       if (!configured) continue;
       options.push({
         provider: entry.provider,
@@ -483,8 +483,8 @@ var AdvisorSettingsStore = class {
     const option = state.providers.find((candidate) => candidate.provider === provider);
     if (option === void 0) return;
     const namespace = state.namespaces[option.settingsNs];
-    const profile = namespace !== void 0 ? (0, import_dsh_client_schema_form.getPath)(namespace.value, option.settingsPath) : void 0;
-    const declared = profileModels(profile);
+    const profile = namespace !== void 0 ? this.schema.getPath(namespace.value, option.settingsPath) : void 0;
+    const declared = this.profileModels(profile);
     if (declared !== void 0) {
       this.store.update((s) => {
         if (declared.length > 0) {
@@ -553,8 +553,8 @@ var AdvisorSettingsStore = class {
     const trimmed = provider.trim();
     this.store.update((s) => {
       const draft = s.draft;
-      const withoutProvider = trimmed.length === 0 ? (0, import_dsh_client_schema_form.deletePath)(draft, ["provider"]) : (0, import_dsh_client_schema_form.setPath)(draft, ["provider"], trimmed);
-      s.draft = (0, import_dsh_client_schema_form.deletePath)(withoutProvider, ["model"]);
+      const withoutProvider = trimmed.length === 0 ? this.schema.deletePath(draft, ["provider"]) : this.schema.setPath(draft, ["provider"], trimmed);
+      s.draft = this.schema.deletePath(withoutProvider, ["model"]);
       s.applyState = { kind: "idle" };
       s.dirty = this.recomputeDirty(s.draft);
     });
@@ -716,18 +716,18 @@ var AdvisorSettingsStore = class {
   recomputeDirty(draft) {
     return Object.keys(this.patchFor(draft)).length > 0;
   }
-  /** Edit one always-present draft field via the schema-form path writer. */
+  /** Edit one always-present draft field via the settings schema path writer. */
   setField(key, value) {
     this.store.update((s) => {
-      s.draft = (0, import_dsh_client_schema_form.setPath)(s.draft, [key], value);
+      s.draft = this.schema.setPath(s.draft, [key], value);
       s.applyState = { kind: "idle" };
       s.dirty = this.recomputeDirty(s.draft);
     });
   }
-  /** Remove one optional draft field via the schema-form path writer. */
+  /** Remove one optional draft field via the settings schema path writer. */
   clearField(key) {
     this.store.update((s) => {
-      s.draft = (0, import_dsh_client_schema_form.deletePath)(s.draft, [key]);
+      s.draft = this.schema.deletePath(s.draft, [key]);
       s.applyState = { kind: "idle" };
       s.dirty = this.recomputeDirty(s.draft);
     });
@@ -805,12 +805,11 @@ var zh = {
 
 // src/client/index.ts
 var NS = "settings.advisor";
-var inject = ["slots", "locale", "connection"];
+var inject = ["slots", "locale", "connection", "settingsSchema"];
 function apply(ctx) {
   ctx.effect(() => ctx.locale.register(NS, { zh, en }), "advisor: copy dictionaries");
   const connection = ctx.get("connection");
-  const controller = new AdvisorSettingsStore(connection.api, connection.rpc);
-  const useSnapshot = (0, import_dsh_client_web_react.bindSnapshotSelector)(controller.store);
+  const controller = new AdvisorSettingsStore(connection.api, connection.rpc, ctx.settingsSchema);
   ctx.effect(() => {
     let pending = false;
     const refresh = () => {
@@ -834,7 +833,7 @@ function apply(ctx) {
   ctx.slots.inject("settings.plugin.item", function* () {
     yield ctx.slots.register({
       name: "settings.plugin.item",
-      // rc.7 keyed slot: the key is the settings namespace the card edits —
+      // Keyed slot: the key is the settings namespace the card edits —
       // the already-installed `advisor` namespace (ADVISOR_SETTINGS_NAMESPACE
       // in src/settings.ts; spelled as a literal here because the host-half
       // settings module is outside the client bundle's externals). Keyed
@@ -842,7 +841,10 @@ function apply(ctx) {
       // order, which still places this card after the upstream three.
       key: "advisor",
       locale: NS,
-      inject: () => ({ controller, useSnapshot })
+      // Hooks compartment: the renderer binds `hooks.snapshot` to the
+      // component's `useSnapshot` selector hook (the old web-react
+      // bindSnapshotSelector call is gone with that package).
+      inject: () => ({ controller, hooks: { snapshot: controller.store } })
     }, AdvisorCard);
   });
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dsh-advisor",
-  "version": "0.2.2",
+  "version": "0.2.4",
   "type": "module",
   "description": "dsh plugin bundle porting the omp advisor subsystem: a per-session reviewer model that observes the primary transcript and injects severity-ranked advice (nit/concern/blocker).",
   "repository": {
@@ -51,24 +51,22 @@
   },
   "peerDependencies": {
     "@deepseek-ai/cordis": "^4.0.1",
-    "@deepseek-ai/dsh-agent": "^0.1.0-rc.7",
-    "@deepseek-ai/dsh-api-gateway": "^0.1.0-rc.7",
-    "@deepseek-ai/dsh-client-connection": "^0.1.0-rc.7",
-    "@deepseek-ai/dsh-client-locale": "^0.1.0-rc.7",
-    "@deepseek-ai/dsh-client-runtime": "^0.1.0-rc.7",
-    "@deepseek-ai/dsh-client-schema-form": "^0.1.0-rc.7",
-    "@deepseek-ai/dsh-client-ui-settings-plugins": "^0.1.0-rc.7",
-    "@deepseek-ai/dsh-client-ui-primitives": "^0.1.0-rc.7",
-    "@deepseek-ai/dsh-client-ui-settings": "^0.1.0-rc.7",
-    "@deepseek-ai/dsh-client-ui-slots": "^0.1.0-rc.7",
-    "@deepseek-ai/dsh-client-web-react": "^0.1.0-rc.7",
-    "@deepseek-ai/dsh-commands": "^0.1.0-rc.7",
-    "@deepseek-ai/dsh-llm": "^0.1.0-rc.7",
-    "@deepseek-ai/dsh-session": "^0.1.0-rc.7",
-    "@deepseek-ai/dsh-settings": "^0.1.0-rc.7",
-    "@deepseek-ai/dsh-timeout": "^0.1.0-rc.7",
-    "@deepseek-ai/dsh-typert-protocol": "^0.1.0-rc.7",
-    "@deepseek-ai/dsh-typert-registry": "^0.1.0-rc.7",
+    "@deepseek-ai/dsh-agent": "^0.1.1-rc.1",
+    "@deepseek-ai/dsh-api-gateway": "^0.1.1-rc.1",
+    "@deepseek-ai/dsh-client-connection": "^0.1.1-rc.1",
+    "@deepseek-ai/dsh-client-locale": "^0.1.1-rc.1",
+    "@deepseek-ai/dsh-client-runtime": "^0.1.1-rc.1",
+    "@deepseek-ai/dsh-client-ui-settings-plugins": "^0.1.1-rc.1",
+    "@deepseek-ai/dsh-client-ui-primitives": "^0.1.1-rc.1",
+    "@deepseek-ai/dsh-client-ui-settings": "^0.1.1-rc.1",
+    "@deepseek-ai/dsh-client-ui-slots": "^0.1.1-rc.1",
+    "@deepseek-ai/dsh-commands": "^0.1.1-rc.1",
+    "@deepseek-ai/dsh-llm": "^0.1.1-rc.1",
+    "@deepseek-ai/dsh-session": "^0.1.1-rc.1",
+    "@deepseek-ai/dsh-settings": "^0.1.1-rc.1",
+    "@deepseek-ai/dsh-timeout": "^0.1.1-rc.1",
+    "@deepseek-ai/dsh-typert-protocol": "^0.1.1-rc.1",
+    "@deepseek-ai/dsh-typert-registry": "^0.1.1-rc.1",
     "react": "^18.2.0",
     "@deepseek-ai/schemastery": "^3.18.1"
   },

package/scripts/build-client.mjs

@@ -53,9 +53,7 @@ export const CLIENT_EXTERNALS = [
   'react-dom/client',
   '@deepseek-ai/cordis',
   '@deepseek-ai/dsh-client-ui-slots',
-  '@deepseek-ai/dsh-client-web-react',
   '@deepseek-ai/dsh-client-ui-primitives',
-  '@deepseek-ai/dsh-client-schema-form',
   '@deepseek-ai/dsh-client-runtime/client',
 ]
 

package/scripts/prepare-release.mjs

@@ -37,8 +37,8 @@ const CHANGELOG_HEADER =
  * suffix); null when not parseable. The suffix character set matches the
  * workflows' guard regex `[0-9A-Za-z.-]+` (keep-simple: no leading-zero or
  * empty-identifier rules), with one tightening: the suffix MUST contain at
- * least one digit, so `0.1.1-alpha.1` / `0.1.1-rc.2` parse but `0.1.1-alpha`
- * (no numeric identifier) and `0.1.1-` (empty suffix) are rejected. Returns
+ * least one digit, so `1.2.3-alpha.1` / `1.2.3-rc.2` parse but `1.2.3-alpha`
+ * (no numeric identifier) and `1.2.3-` (empty suffix) are rejected. Returns
  * { major, minor, patch, prerelease? } — prerelease is the raw suffix text
  * (e.g. 'alpha.1') when present, undefined for formal versions.
  */