driftdetect-vscode 0.9.32 → 0.9.34

package/src/state/state-manager.ts

@@ -87,7 +87,7 @@ export class StateManager implements vscode.Disposable {
     this.listeners.add(listener);
 
     return {
-      dispose: () => {
+      dispose: (): void => {
         this.listeners.delete(listener);
       },
     };
@@ -99,7 +99,7 @@ export class StateManager implements vscode.Disposable {
   subscribeAll(callback: (state: ExtensionState) => void): vscode.Disposable {
     this.listeners.add(callback);
     return {
-      dispose: () => {
+      dispose: (): void => {
         this.listeners.delete(callback);
       },
     };
@@ -130,8 +130,8 @@ export class StateManager implements vscode.Disposable {
     for (const listener of this.listeners) {
       try {
         listener(this.state);
-      } catch (error) {
-        console.error('[Drift] State listener error:', error);
+      } catch {
+        // Listener error, continue with others
       }
     }
   }
@@ -141,7 +141,7 @@ export class StateManager implements vscode.Disposable {
     
     try {
       const persisted = this.context.globalState.get<Partial<ExtensionState>>(PERSISTENCE_KEY);
-      if (persisted) {
+      if (persisted?.preferences !== undefined) {
         // Only restore preferences, not transient state
         return {
           ...initial,
@@ -151,8 +151,8 @@ export class StateManager implements vscode.Disposable {
           },
         };
       }
-    } catch (error) {
-      console.error('[Drift] Failed to load persisted state:', error);
+    } catch {
+      // Failed to load persisted state, use initial
     }
 
     return initial;
@@ -164,10 +164,7 @@ export class StateManager implements vscode.Disposable {
       preferences: this.state.preferences,
     };
 
-    this.context.globalState.update(PERSISTENCE_KEY, toPersist).then(
-      () => {},
-      (error) => { console.error('[Drift] Failed to persist state:', error); }
-    );
+    void this.context.globalState.update(PERSISTENCE_KEY, toPersist);
   }
 
   private shallowEqual(a: unknown, b: unknown): boolean {

package/src/types/extension-types.ts

@@ -53,6 +53,6 @@ export interface DisposableManager {
  */
 export interface ServiceContainer {
   get<T>(key: string): T;
-  register<T>(key: string, instance: T): void;
+  register(key: string, instance: unknown): void;
   has(key: string): boolean;
 }

package/src/ui/decorations/decoration-controller.ts

@@ -33,8 +33,6 @@ export class DecorationController implements vscode.Disposable {
    * Update decorations for the active editor
    */
   updateDecorations(editor: vscode.TextEditor): void {
-    if (!editor) {return;}
-
     const uri = editor.document.uri;
     const diagnostics = vscode.languages.getDiagnostics(uri);
 
@@ -187,7 +185,7 @@ export class DecorationController implements vscode.Disposable {
 
     for (const d of diagnostics) {
       const severity = this.diagnosticSeverityToString(d.severity);
-      const group = groups.get(severity) || [];
+      const group = groups.get(severity) ?? [];
       group.push(d);
       groups.set(severity, group);
     }
@@ -216,8 +214,9 @@ export class DecorationController implements vscode.Disposable {
     const icon = this.getSeverityIcon(diagnostic.severity);
     md.appendMarkdown(`${icon} **${diagnostic.message}**\n\n`);
 
-    if (diagnostic.code) {
-      md.appendMarkdown(`Pattern: \`${diagnostic.code}\`\n\n`);
+    if (diagnostic.code !== null) {
+      const codeStr = typeof diagnostic.code === 'object' ? String(diagnostic.code.value) : String(diagnostic.code);
+      md.appendMarkdown(`Pattern: \`${codeStr}\`\n\n`);
     }
 
     md.appendMarkdown(`---\n\n`);

package/src/ui/notifications/notification-service.ts

@@ -97,7 +97,7 @@ export class NotificationService {
     const pickOptions: vscode.QuickPickOptions = {
       ...options,
     };
-    if (options.title) {
+    if (options.title !== null && options.title !== '') {
       pickOptions.title = `Drift: ${options.title}`;
     }
     return vscode.window.showQuickPick(items, pickOptions);
@@ -110,7 +110,7 @@ export class NotificationService {
     const inputOptions: vscode.InputBoxOptions = {
       ...options,
     };
-    if (options.title) {
+    if (options.title !== null && options.title !== '') {
       inputOptions.title = `Drift: ${options.title}`;
     }
     return vscode.window.showInputBox(inputOptions);
@@ -134,7 +134,7 @@ export class NotificationService {
     if (options.modal !== undefined) {
       messageOptions.modal = options.modal;
     }
-    if (options.detail !== undefined) {
+    if (options.detail !== null && options.detail !== '' && options.detail !== undefined) {
       messageOptions.detail = options.detail;
     }
 
@@ -144,13 +144,13 @@ export class NotificationService {
       ...actionTitles
     );
 
-    if (selected) {
+    if (selected !== null && selected !== '') {
       const action = actions.find(a => a.title === selected);
       if (action) {
         if (action.callback) {
           await action.callback();
         } else if (action.command) {
-          await vscode.commands.executeCommand(action.command, ...(action.args || []));
+          await vscode.commands.executeCommand(action.command, ...(action.args ?? []));
         }
       }
     }

package/src/ui/status-bar/status-bar-controller.ts

@@ -89,15 +89,15 @@ export class StatusBarController implements vscode.Disposable {
     // Add stats if connected
     if (state.connection.status === 'connected') {
       md.appendMarkdown(`---\n\n`);
-      md.appendMarkdown(`**Patterns:** ${state.patterns.total}\n\n`);
-      md.appendMarkdown(`**Violations:** ${state.violations.total}\n\n`);
+      md.appendMarkdown(`**Patterns:** ${String(state.patterns.total)}\n\n`);
+      md.appendMarkdown(`**Violations:** ${String(state.violations.total)}\n\n`);
 
       if (state.violations.total > 0) {
         md.appendMarkdown(`\n`);
         for (const [severity, count] of Object.entries(state.violations.bySeverity)) {
           if (count > 0) {
             const icon = this.getSeverityIcon(severity);
-            md.appendMarkdown(`- ${icon} ${severity}: ${count}\n`);
+            md.appendMarkdown(`- ${icon} ${severity}: ${String(count)}\n`);
           }
         }
       }

package/src/ui/status-bar/status-bar-modes.ts

@@ -90,30 +90,45 @@ export function getStatusBarMode(
 ): StatusBarMode {
   // Connection states take priority
   if (connectionState !== 'connected') {
-    return StatusBarModes[connectionState] ?? StatusBarModes['disconnected']!;
+    const mode = StatusBarModes[connectionState];
+    return mode ?? StatusBarModes['disconnected'] ?? {
+      icon: '$(circle-slash)',
+      text: 'Drift: Disconnected',
+      tooltip: 'Drift is not connected.',
+    };
   }
 
   // Scanning state
   if (scanning) {
-    return StatusBarModes['scanning']!;
+    const scanningMode = StatusBarModes['scanning'];
+    return scanningMode ?? {
+      icon: '$(sync~spin)',
+      text: 'Drift: Scanning...',
+      tooltip: 'Scanning workspace for patterns...',
+    };
   }
 
   // Violation-based states
   if (violations > 0) {
-    const warningMode = StatusBarModes['warning']!;
+    const warningMode = StatusBarModes['warning'];
     const result: StatusBarMode = {
-      icon: warningMode.icon,
-      text: `Drift: ${violations}`,
-      tooltip: `${violations} violation${violations === 1 ? '' : 's'} found. Click to view.`,
+      icon: warningMode?.icon ?? '$(warning)',
+      text: `Drift: ${String(violations)}`,
+      tooltip: `${String(violations)} violation${violations === 1 ? '' : 's'} found. Click to view.`,
     };
-    if (warningMode.backgroundColor) {
+    if (warningMode?.backgroundColor) {
       result.backgroundColor = warningMode.backgroundColor;
     }
-    if (warningMode.command) {
+    if (warningMode?.command) {
       result.command = warningMode.command;
     }
     return result;
   }
 
-  return StatusBarModes['healthy']!;
+  const healthyMode = StatusBarModes['healthy'];
+  return healthyMode ?? {
+    icon: '$(pass)',
+    text: 'Drift',
+    tooltip: 'No violations found.',
+  };
 }

package/src/views/constants-tree-provider.ts

@@ -102,10 +102,6 @@ export interface ConstantTreeItem extends BaseTreeItem {
 export class ConstantsTreeProvider extends BaseTreeProvider<ConstantTreeItem> {
   private viewMode: 'category' | 'language' | 'issues' = 'category';
 
-  constructor(client: LanguageClient | null) {
-    super(client);
-  }
-
   /**
    * Set the view mode
    */
@@ -162,7 +158,8 @@ export class ConstantsTreeProvider extends BaseTreeProvider<ConstantTreeItem> {
         data: { byCategory: Record<string, number> };
       }>('drift/constants', { action: 'status' });
 
-      const categories = Object.entries(response.data.byCategory || {})
+      const byCategory = response.data.byCategory ?? {};
+      const categories = Object.entries(byCategory)
         .filter(([, count]) => count > 0)
         .sort(([, a], [, b]) => b - a);
 
@@ -180,7 +177,8 @@ export class ConstantsTreeProvider extends BaseTreeProvider<ConstantTreeItem> {
         data: { byLanguage: Record<string, number> };
       }>('drift/constants', { action: 'status' });
 
-      const languages = Object.entries(response.data.byLanguage || {})
+      const byLanguage = response.data.byLanguage ?? {};
+      const languages = Object.entries(byLanguage)
         .filter(([, count]) => count > 0)
         .sort(([, a], [, b]) => b - a);
 
@@ -204,7 +202,7 @@ export class ConstantsTreeProvider extends BaseTreeProvider<ConstantTreeItem> {
         };
       }>('drift/constants', { action: 'status' });
 
-      const issues = response.data.issues || {
+      const issues = response.data.issues ?? {
         potentialSecrets: 0,
         inconsistentValues: 0,
         deadConstants: 0,
@@ -246,11 +244,11 @@ export class ConstantsTreeProvider extends BaseTreeProvider<ConstantTreeItem> {
 
       const items: ConstantTreeItem[] = [];
 
-      for (const constant of response.data.constants || []) {
+      for (const constant of response.data.constants ?? []) {
         items.push(this.createConstantItem(constant));
       }
 
-      for (const enumDef of response.data.enums || []) {
+      for (const enumDef of response.data.enums ?? []) {
         items.push(this.createEnumItem(enumDef));
       }
 
@@ -268,11 +266,11 @@ export class ConstantsTreeProvider extends BaseTreeProvider<ConstantTreeItem> {
 
       const items: ConstantTreeItem[] = [];
 
-      for (const constant of response.data.constants || []) {
+      for (const constant of response.data.constants ?? []) {
         items.push(this.createConstantItem(constant));
       }
 
-      for (const enumDef of response.data.enums || []) {
+      for (const enumDef of response.data.enums ?? []) {
         items.push(this.createEnumItem(enumDef));
       }
 
@@ -289,7 +287,7 @@ export class ConstantsTreeProvider extends BaseTreeProvider<ConstantTreeItem> {
           data: { potentialSecrets: SecretIssue[] };
         }>('drift/constants', { action: 'secrets', limit: 50 });
 
-        return (response.data.potentialSecrets || []).map((secret) =>
+        return (response.data.potentialSecrets ?? []).map((secret) =>
           this.createSecretItem(secret)
         );
       }
@@ -299,7 +297,7 @@ export class ConstantsTreeProvider extends BaseTreeProvider<ConstantTreeItem> {
           data: { inconsistencies: InconsistentIssue[] };
         }>('drift/constants', { action: 'inconsistent', limit: 50 });
 
-        return (response.data.inconsistencies || []).map((inc) =>
+        return (response.data.inconsistencies ?? []).map((inc) =>
           this.createInconsistentItem(inc)
         );
       }
@@ -309,7 +307,7 @@ export class ConstantsTreeProvider extends BaseTreeProvider<ConstantTreeItem> {
           data: { deadConstants: Array<{ id: string; name: string; file: string; line: number }> };
         }>('drift/constants', { action: 'dead', limit: 50 });
 
-        return (response.data.deadConstants || []).map((dead) =>
+        return (response.data.deadConstants ?? []).map((dead) =>
           this.createDeadItem(dead)
         );
       }
@@ -324,7 +322,7 @@ export class ConstantsTreeProvider extends BaseTreeProvider<ConstantTreeItem> {
     return {
       type: 'category',
       label: category.name,
-      description: `${category.count} constants`,
+      description: `${String(category.count)} constants`,
       iconPath: this.getCategoryIcon(category.name),
       collapsibleState: vscode.TreeItemCollapsibleState.Collapsed,
       contextValue: 'constant-category',
@@ -336,7 +334,7 @@ export class ConstantsTreeProvider extends BaseTreeProvider<ConstantTreeItem> {
     return {
       type: 'language',
       label: language.name,
-      description: `${language.count} constants`,
+      description: `${String(language.count)} constants`,
       iconPath: this.getLanguageIcon(language.name),
       collapsibleState: vscode.TreeItemCollapsibleState.Collapsed,
       contextValue: 'constant-language',
@@ -359,7 +357,7 @@ export class ConstantsTreeProvider extends BaseTreeProvider<ConstantTreeItem> {
     return {
       type: 'issue-group',
       label: name,
-      description: `${count} issues`,
+      description: `${String(count)} issues`,
       iconPath: new vscode.ThemeIcon(icon, new vscode.ThemeColor(color)),
       collapsibleState: vscode.TreeItemCollapsibleState.Collapsed,
       contextValue: 'constant-issue-group',
@@ -433,7 +431,7 @@ export class ConstantsTreeProvider extends BaseTreeProvider<ConstantTreeItem> {
     return {
       type: 'inconsistent',
       label: inc.name,
-      description: `${inc.instanceCount} different values`,
+      description: `${String(inc.instanceCount)} different values`,
       iconPath: new vscode.ThemeIcon('warning', new vscode.ThemeColor('charts.yellow')),
       collapsibleState: vscode.TreeItemCollapsibleState.None,
       contextValue: 'constant-inconsistent',
@@ -501,7 +499,7 @@ export class ConstantsTreeProvider extends BaseTreeProvider<ConstantTreeItem> {
 
     md.appendMarkdown(`### ${constant.name}\n\n`);
     md.appendMarkdown(`**Qualified Name:** \`${constant.qualifiedName}\`\n\n`);
-    md.appendMarkdown(`**File:** ${constant.file}:${constant.line}\n\n`);
+    md.appendMarkdown(`**File:** ${constant.file}:${String(constant.line)}\n\n`);
     md.appendMarkdown(`**Language:** ${constant.language}\n\n`);
     md.appendMarkdown(`**Kind:** ${constant.kind}\n\n`);
     md.appendMarkdown(`**Category:** ${constant.category}\n\n`);

package/src/views/files-tree-provider.ts

@@ -29,10 +29,6 @@ export interface FileTreeItem extends BaseTreeItem {
  * Files tree provider
  */
 export class FilesTreeProvider extends BaseTreeProvider<FileTreeItem> {
-  constructor(client: LanguageClient | null) {
-    super(client);
-  }
-
   async getChildren(element?: FileTreeItem): Promise<FileTreeItem[]> {
     if (!this.client) {
       return [];

package/.turbo/turbo-build.log

@@ -1,4 +0,0 @@
-
-> driftdetect-vscode@0.9.32 build /Users/geoffreyfernald/drift/drift/packages/vscode
-> tsc -p tsconfig.json
-

package/.turbo/turbo-lint.log

@@ -1,4 +0,0 @@
-
-> driftdetect-vscode@0.9.30 lint /Users/geoffreyfernald/drift/drift/packages/vscode
-> eslint src --ext .ts,.tsx
-

package/.turbo/turbo-test.log

@@ -1,34 +0,0 @@
-
-> driftdetect-vscode@0.9.30 test /Users/geoffreyfernald/drift/drift/packages/vscode
-> vitest run "--run"
-
-
- RUN  v1.6.1 /Users/geoffreyfernald/drift/drift/packages/vscode
-
-[@drift/core] Config
-include: **/*.{test,spec}.{ts,tsx}, src/**/*.{test,spec}.ts, tests/**/*.{test,spec}.ts
-exclude:  **/node_modules/**, **/dist/**, **/.turbo/**
-[@drift/detectors] Config
-include: **/*.{test,spec}.{ts,tsx}, src/**/*.{test,spec}.ts, tests/**/*.{test,spec}.ts
-exclude:  **/node_modules/**, **/dist/**, **/.turbo/**
-[@drift/lsp] Config
-include: **/*.{test,spec}.{ts,tsx}, src/**/*.{test,spec}.ts, tests/**/*.{test,spec}.ts
-exclude:  **/node_modules/**, **/dist/**, **/.turbo/**
-No test files found, exiting with code 0
-
-[@drift/cli] Config
-include: **/*.{test,spec}.{ts,tsx}, src/**/*.{test,spec}.ts, tests/**/*.{test,spec}.ts
-exclude:  **/node_modules/**, **/dist/**, **/.turbo/**
-[@drift/ai] Config
-include: **/*.{test,spec}.{ts,tsx}, src/**/*.{test,spec}.ts, tests/**/*.{test,spec}.ts
-exclude:  **/node_modules/**, **/dist/**, **/.turbo/**
-[@drift/vscode] Config
-include: **/*.{test,spec}.{ts,tsx}, src/**/*.{test,spec}.ts, tests/**/*.{test,spec}.ts
-exclude:  **/node_modules/**, **/dist/**, **/.turbo/**
-[@drift/dashboard] Config
-include: **/*.{test,spec}.{ts,tsx}, src/**/*.{test,spec}.ts, src/**/*.{test,spec}.tsx, tests/**/*.{test,spec}.ts
-exclude:  **/node_modules/**, **/dist/**, **/.turbo/**
-[@drift/mcp] Config
-include: **/*.{test,spec}.{ts,tsx}, src/**/*.{test,spec}.ts, tests/**/*.{test,spec}.ts
-exclude:  **/node_modules/**, **/dist/**, **/.turbo/**
-watch exclude:  **/node_modules/**, **/dist/**

package/LICENSE

@@ -1,121 +0,0 @@
-Apache License
-Version 2.0, January 2004
-http://www.apache.org/licenses/
-
-TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
-
-1. Definitions.
-
-"License" shall mean the terms and conditions for use, reproduction,
-and distribution as defined by Sections 1 through 9 of this document.
-
-"Licensor" shall mean the copyright owner or entity authorized by
-the copyright owner that is granting the License.
-
-"Legal Entity" shall mean the union of the acting entity and all
-other entities that control, are controlled by, or are under common
-control with that entity. For the purposes of this definition,
-"control" means (i) the power, direct or indirect, to cause the
-direction or management of such entity, whether by contract or
-otherwise, or (ii) ownership of fifty percent (50%) or more of the
-outstanding shares, or (iii) beneficial ownership of such entity.
-
-"You" (or "Your") shall mean an individual or Legal Entity
-exercising permissions granted by this License.
-
-"Source" form shall mean the preferred form for making modifications,
-including but not limited to software source code, documentation
-source, and configuration files.
-
-"Object" form shall mean any form resulting from mechanical
-transformation or translation of a Source form, including but
-not limited to compiled object code, generated documentation,
-and conversions to other media types.
-
-"Work" shall mean the work of authorship, whether in Source or
-Object form, made available under the License, as indicated by a
-copyright notice that is included in or attached to the work.
-
-"Derivative Works" shall mean any work, whether in Source or Object
-form, that is based on (or derived from) the Work and for which the
-editorial revisions, annotations, elaborations, or other modifications
-represent, as a whole, an original work of authorship.
-
-"Contribution" shall mean any work of authorship, including
-the original version of the Work and any modifications or additions
-to that Work or Derivative Works thereof, that is intentionally
-submitted to the Licensor for inclusion in the Work by the copyright owner.
-
-"Contributor" shall mean Licensor and any individual or Legal Entity
-on behalf of whom a Contribution has been received by Licensor and
-subsequently incorporated within the Work.
-
-2. Grant of Copyright License. Subject to the terms and conditions of
-this License, each Contributor hereby grants to You a perpetual,
-worldwide, non-exclusive, no-charge, royalty-free, irrevocable
-copyright license to reproduce, prepare Derivative Works of,
-publicly display, publicly perform, sublicense, and distribute the
-Work and such Derivative Works in Source or Object form.
-
-3. Grant of Patent License. Subject to the terms and conditions of
-this License, each Contributor hereby grants to You a perpetual,
-worldwide, non-exclusive, no-charge, royalty-free, irrevocable
-patent license to make, have made, use, offer to sell, sell, import,
-and otherwise transfer the Work.
-
-4. Redistribution. You may reproduce and distribute copies of the
-Work or Derivative Works thereof in any medium, with or without
-modifications, and in Source or Object form, provided that You
-meet the following conditions:
-
-(a) You must give any other recipients of the Work or
-    Derivative Works a copy of this License; and
-
-(b) You must cause any modified files to carry prominent notices
-    stating that You changed the files; and
-
-(c) You must retain, in the Source form of any Derivative Works
-    that You distribute, all copyright, patent, trademark, and
-    attribution notices from the Source form of the Work; and
-
-(d) If the Work includes a "NOTICE" text file as part of its
-    distribution, then any Derivative Works that You distribute must
-    include a readable copy of the attribution notices contained
-    within such NOTICE file.
-
-5. Submission of Contributions. Unless You explicitly state otherwise,
-any Contribution intentionally submitted for inclusion in the Work
-by You to the Licensor shall be under the terms and conditions of
-this License, without any additional terms or conditions.
-
-6. Trademarks. This License does not grant permission to use the trade
-names, trademarks, service marks, or product names of the Licensor.
-
-7. Disclaimer of Warranty. Unless required by applicable law or
-agreed to in writing, Licensor provides the Work on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND.
-
-8. Limitation of Liability. In no event and under no legal theory,
-shall any Contributor be liable to You for damages, including any
-direct, indirect, special, incidental, or consequential damages.
-
-9. Accepting Warranty or Additional Liability. While redistributing
-the Work or Derivative Works thereof, You may choose to offer,
-and charge a fee for, acceptance of support, warranty, indemnity,
-or other liability obligations.
-
-END OF TERMS AND CONDITIONS
-
-Copyright 2025 Geoffrey Fernald
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.