drafted 1.19.26 → 1.19.27

package/mcp/server.mjs

@@ -2106,6 +2106,51 @@ function desktopAppBinary() {
   return null; // e.g. Linux — no desktop app → device-code fallback
 }
 
+/**
+ * The answer to "am I signed in?", which is a question about the MACHINE, not this
+ * process. Two things went wrong before this existed, and they are the same mistake:
+ *
+ *  - ~/.drafted/auth.json could be missing while the in-process session was fine. The
+ *    desktop's credential burn deletes it on purpose, so `login` answered
+ *    already_authenticated — truthfully, and uselessly — while every other reader on the
+ *    machine stayed signed out. Restore it from the live session.
+ *  - The DESKTOP app could be signed out, which is what actually decides whether an agent
+ *    asking for a human reaches anybody: its focus listener needs desktop.json. An agent
+ *    must never MINT that credential (origin='browser' is the class that may approve
+ *    actions), but opening the app's sign-in window is this tool's documented job — and it
+ *    usually completes with NO interaction, because the shared cookie store still holds a
+ *    valid login.
+ */
+async function alreadyAuthenticated(me, sessionId) {
+  const out = { status: 'already_authenticated', userId: me.userId, email: me.userEmail, org: me.currentOrg?.name };
+  if (!getBootstrapSessionId()) {
+    try {
+      persistAuthSession({ sessionId, userId: me.userId, orgId: me.currentOrg?.id });
+      out.restoredAuthFile = true;
+      out.note = 'This session was signed in but ~/.drafted/auth.json was missing, so other readers on this machine (the desktop app, the CLI) were not. Rewrote it from the live session.';
+    } catch { /* read-only home: report the truth rather than throwing */ }
+  }
+  const bin = desktopAppBinary();
+  if (!bin) return out;                       // no app here: saying anything about it is noise
+  if (!existsSync(DESKTOP_SESSION_FILE)) {
+    if (await launchDesktopSignin()) {
+      out.openedDesktopSignin = true;
+      // Wait for the result rather than reporting an optimistic one — answering before it
+      // lands is the same class of lie this whole helper exists to stop.
+      for (let i = 0; i < 20 && !existsSync(DESKTOP_SESSION_FILE); i++) {
+        await new Promise((r) => setTimeout(r, 500));
+      }
+    }
+  }
+  out.desktopSignedIn = existsSync(DESKTOP_SESSION_FILE);
+  if (out.openedDesktopSignin) {
+    out.desktopNote = out.desktopSignedIn
+      ? 'The desktop app was signed out; opened its sign-in window and it completed on its own from the existing browser session.'
+      : 'The desktop app is signed out and its sign-in window is open — it needs one approval there. Until then it holds no session, so an agent asking for attention cannot reach this machine.';
+  }
+  return out;
+}
+
 async function launchDesktopSignin() {
   const bin = desktopAppBinary();
   if (!bin) return false;
@@ -2186,7 +2231,7 @@ if (!isRemote) tool('auth', 'Sign in to Drafted.\n\n`action=get_link` ALWAYS ret
               await cloneSession();
               connectAgentWs();
             }
-            return ok({ status: 'already_authenticated', userId: me.userId, email: me.userEmail, org: me.currentOrg?.name });
+            return ok(await alreadyAuthenticated(me, existing));
           }
         } catch { /* stale session — continue to sign-in */ }
       }
@@ -2232,51 +2277,7 @@ if (!isRemote) tool('auth', 'Sign in to Drafted.\n\n`action=get_link` ALWAYS ret
             // The desktop's focus listener is one of those readers, so an agent asking
             // for a human reached nobody and the tool that exists to fix it reported
             // success.
-            let restoredAuthFile = false;
-            if (!getBootstrapSessionId()) {
-              try {
-                persistAuthSession({ sessionId: existing, userId: me.userId, orgId: me.currentOrg?.id });
-                restoredAuthFile = true;
-              } catch { /* read-only home: report the truth below rather than throwing */ }
-            }
-            // The DESKTOP's own browser credential is a separate file, and an agent
-            // cannot mint one — it is the origin='browser' class that may approve
-            // actions, which is exactly what the two-credential split protects. But
-            // "cannot mint it" is not "cannot ask for it": opening the app's sign-in
-            // window is this tool's documented job, and the window usually completes
-            // with no interaction at all because the shared cookie store still holds a
-            // valid login. Short-circuiting on the agent session skipped that entirely,
-            // so `login` reported success while the app stayed signed out and every
-            // agent that pinged the human reached nobody.
-            let openedDesktopSignin = false;
-            if (desktopAppBinary() && !existsSync(DESKTOP_SESSION_FILE)) {
-              openedDesktopSignin = await launchDesktopSignin();
-              if (openedDesktopSignin) {
-                // Give the app a moment to re-capture the cookie so the caller can act
-                // on a true answer rather than an optimistic one.
-                for (let i = 0; i < 20 && !existsSync(DESKTOP_SESSION_FILE); i++) {
-                  await new Promise((r) => setTimeout(r, 500));
-                }
-              }
-            }
-            const desktopSignedIn = !desktopAppBinary() ? null : existsSync(DESKTOP_SESSION_FILE);
-            return ok({
-              status: 'already_authenticated',
-              userId: me.userId,
-              email: me.userEmail,
-              org: me.currentOrg?.name,
-              ...(restoredAuthFile ? {
-                restoredAuthFile: true,
-                note: 'This session was signed in but ~/.drafted/auth.json was missing, so other readers on this machine (the desktop app, the CLI) were not. Rewrote it from the live session.',
-              } : {}),
-              ...(desktopSignedIn === null ? {} : { desktopSignedIn }),
-              ...(openedDesktopSignin ? {
-                openedDesktopSignin: true,
-                desktopNote: desktopSignedIn
-                  ? 'The desktop app was signed out; opened its sign-in window and it completed on its own from the existing browser session.'
-                  : 'The desktop app is signed out and its sign-in window is open — it needs one approval there. Until then it holds no session, so an agent asking for attention cannot reach this machine.',
-              } : {}),
-            });
+            return ok(await alreadyAuthenticated(me, existing));
           }
         } catch { /* session invalid, proceed with login */ }
       }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "drafted",
-  "version": "1.19.26",
+  "version": "1.19.27",
   "description": "Drafted — visual thinking surface for humans and AI agents. Renders HTML, markdown, images, and code as frames on a zoomable canvas, with MCP tools for AI agents and real-time sync for humans.",
   "type": "module",
   "files": [