downshift 7.3.2 → 7.3.3

package/dist/src/hooks/utils.d.ts

@@ -75,7 +75,7 @@ export function useEnhancedReducer(reducer: Function, initialState: Object, prop
 export function useLatestRef(val: any): import("react").MutableRefObject<any>;
 export function capitalizeString(string: any): string;
 export function isAcceptedCharacterKey(key: any): boolean;
-export function getItemIndex(index: any, item: any, items: any): any;
+export function getItemAndIndex(itemProp: any, indexProp: any, items: any, errorMessage: any): any[];
 export function useElementIds({ id, labelId, menuId, getItemId, toggleButtonId, inputId, }: {
     id?: string | undefined;
     labelId: any;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "downshift",
-  "version": "7.3.2",
+  "version": "7.3.3",
   "description": "🏎 A set of primitives to build simple, flexible, WAI-ARIA compliant React autocomplete, combobox or select dropdown components.",
   "main": "dist/downshift.cjs.js",
   "react-native": "dist/downshift.native.cjs.js",

package/preact/dist/downshift.cjs.js

@@ -1566,14 +1566,19 @@ function useElementIds(_ref) {
   });
   return elementIdsRef.current;
 }
-function getItemIndex(index, item, items) {
-  if (index !== undefined) {
-    return index;
-  }
-  if (items.length === 0) {
-    return -1;
+function getItemAndIndex(itemProp, indexProp, items, errorMessage) {
+  var item, index;
+  if (itemProp === undefined) {
+    if (indexProp === undefined) {
+      throw new Error(errorMessage);
+    }
+    item = items[indexProp];
+    index = indexProp;
+  } else {
+    index = indexProp === undefined ? items.indexOf(itemProp) : indexProp;
+    item = itemProp;
   }
-  return items.indexOf(item);
+  return [item, index];
 }
 function itemToString(item) {
   return item ? String(item) : '';
@@ -2563,8 +2568,9 @@ function useSelect(userProps) {
     var _latest$current = latest.current,
       latestState = _latest$current.state,
       latestProps = _latest$current.props;
-    var item = itemProp != null ? itemProp : items[indexProp];
-    var index = getItemIndex(indexProp, item, latestProps.items);
+    var _getItemAndIndex = getItemAndIndex(itemProp, indexProp, latestProps.items, 'Pass either item or index to getItemProps!'),
+      item = _getItemAndIndex[0],
+      index = _getItemAndIndex[1];
     var itemHandleMouseMove = function itemHandleMouseMove() {
       if (index === latestState.highlightedIndex) {
         return;
@@ -2582,18 +2588,14 @@ function useSelect(userProps) {
         index: index
       });
     };
-    var itemIndex = getItemIndex(index, item, latestProps.items);
-    if (itemIndex < 0) {
-      throw new Error('Pass either item or item index in getItemProps!');
-    }
     var itemProps = _extends__default["default"]((_extends4 = {
       disabled: disabled,
       role: 'option',
       'aria-selected': "" + (item === selectedItem),
-      id: elementIds.getItemId(itemIndex)
+      id: elementIds.getItemId(index)
     }, _extends4[refKey] = handleRefs(ref, function (itemNode) {
       if (itemNode) {
-        itemRefs.current[elementIds.getItemId(itemIndex)] = itemNode;
+        itemRefs.current[elementIds.getItemId(index)] = itemNode;
       }
     }), _extends4), rest);
     if (!disabled) {
@@ -2604,7 +2606,7 @@ function useSelect(userProps) {
     }
     itemProps.onMouseMove = callAllEventHandlers(onMouseMove, itemHandleMouseMove);
     return itemProps;
-  }, [latest, items, selectedItem, elementIds, shouldScrollRef, dispatch]);
+  }, [latest, selectedItem, elementIds, shouldScrollRef, dispatch]);
   return {
     // prop getters.
     getToggleButtonProps: getToggleButtonProps,
@@ -3133,8 +3135,8 @@ function useCombobox(userProps) {
   var getItemProps = preact.useCallback(function (_temp3) {
     var _extends3, _ref4;
     var _ref3 = _temp3 === void 0 ? {} : _temp3,
-      item = _ref3.item,
-      index = _ref3.index,
+      itemProp = _ref3.item,
+      indexProp = _ref3.index,
       _ref3$refKey = _ref3.refKey,
       refKey = _ref3$refKey === void 0 ? 'ref' : _ref3$refKey,
       ref = _ref3.ref,
@@ -3147,10 +3149,8 @@ function useCombobox(userProps) {
     var _latest$current = latest.current,
       latestProps = _latest$current.props,
       latestState = _latest$current.state;
-    var itemIndex = getItemIndex(index, item, latestProps.items);
-    if (itemIndex < 0) {
-      throw new Error('Pass either item or item index in getItemProps!');
-    }
+    var _getItemAndIndex = getItemAndIndex(itemProp, indexProp, latestProps.items, 'Pass either item or index to getItemProps!'),
+      index = _getItemAndIndex[1];
     var onSelectKey = 'onClick';
     var customClickHandler = onClick;
     var itemHandleMouseMove = function itemHandleMouseMove() {
@@ -3175,9 +3175,9 @@ function useCombobox(userProps) {
     };
     return _extends__default["default"]((_extends3 = {}, _extends3[refKey] = handleRefs(ref, function (itemNode) {
       if (itemNode) {
-        itemRefs.current[elementIds.getItemId(itemIndex)] = itemNode;
+        itemRefs.current[elementIds.getItemId(index)] = itemNode;
       }
-    }), _extends3.disabled = disabled, _extends3.role = 'option', _extends3['aria-selected'] = "" + (itemIndex === latestState.highlightedIndex), _extends3.id = elementIds.getItemId(itemIndex), _extends3), !disabled && (_ref4 = {}, _ref4[onSelectKey] = callAllEventHandlers(customClickHandler, itemHandleClick), _ref4), {
+    }), _extends3.disabled = disabled, _extends3.role = 'option', _extends3['aria-selected'] = "" + (index === latestState.highlightedIndex), _extends3.id = elementIds.getItemId(index), _extends3), !disabled && (_ref4 = {}, _ref4[onSelectKey] = callAllEventHandlers(customClickHandler, itemHandleClick), _ref4), {
       onMouseMove: callAllEventHandlers(onMouseMove, itemHandleMouseMove),
       onMouseDown: callAllEventHandlers(onMouseDown, itemHandleMouseDown)
     }, rest);
@@ -3717,14 +3717,13 @@ function useMultipleSelection(userProps) {
       ref = _ref3.ref,
       onClick = _ref3.onClick,
       onKeyDown = _ref3.onKeyDown,
-      selectedItem = _ref3.selectedItem,
-      index = _ref3.index,
+      selectedItemProp = _ref3.selectedItem,
+      indexProp = _ref3.index,
       rest = _objectWithoutPropertiesLoose__default["default"](_ref3, _excluded);
     var latestState = latest.current.state;
-    var itemIndex = getItemIndex(index, selectedItem, latestState.selectedItems);
-    if (itemIndex < 0) {
-      throw new Error('Pass either selectedItem or index in getSelectedItemProps!');
-    }
+    var _getItemAndIndex = getItemAndIndex(selectedItemProp, indexProp, latestState.selectedItems, 'Pass either item or index to getSelectedItemProps!'),
+      index = _getItemAndIndex[1];
+    var isFocusable = index > -1 && index === latestState.activeIndex;
     var selectedItemHandleClick = function selectedItemHandleClick() {
       dispatch({
         type: SelectedItemClick,
@@ -3741,7 +3740,7 @@ function useMultipleSelection(userProps) {
       if (selectedItemNode) {
         selectedItemRefs.current.push(selectedItemNode);
       }
-    }), _extends2.tabIndex = index === latestState.activeIndex ? 0 : -1, _extends2.onClick = callAllEventHandlers(onClick, selectedItemHandleClick), _extends2.onKeyDown = callAllEventHandlers(onKeyDown, selectedItemHandleKeyDown), _extends2), rest);
+    }), _extends2.tabIndex = isFocusable ? 0 : -1, _extends2.onClick = callAllEventHandlers(onClick, selectedItemHandleClick), _extends2.onKeyDown = callAllEventHandlers(onKeyDown, selectedItemHandleKeyDown), _extends2), rest);
   }, [dispatch, latest, selectedItemKeyDownHandlers]);
   var getDropdownProps = preact.useCallback(function (_temp2, _temp3) {
     var _extends3;

package/preact/dist/downshift.esm.js

@@ -1553,14 +1553,19 @@ function useElementIds(_ref) {
   });
   return elementIdsRef.current;
 }
-function getItemIndex(index, item, items) {
-  if (index !== undefined) {
-    return index;
-  }
-  if (items.length === 0) {
-    return -1;
+function getItemAndIndex(itemProp, indexProp, items, errorMessage) {
+  var item, index;
+  if (itemProp === undefined) {
+    if (indexProp === undefined) {
+      throw new Error(errorMessage);
+    }
+    item = items[indexProp];
+    index = indexProp;
+  } else {
+    index = indexProp === undefined ? items.indexOf(itemProp) : indexProp;
+    item = itemProp;
   }
-  return items.indexOf(item);
+  return [item, index];
 }
 function itemToString(item) {
   return item ? String(item) : '';
@@ -2550,8 +2555,9 @@ function useSelect(userProps) {
     var _latest$current = latest.current,
       latestState = _latest$current.state,
       latestProps = _latest$current.props;
-    var item = itemProp != null ? itemProp : items[indexProp];
-    var index = getItemIndex(indexProp, item, latestProps.items);
+    var _getItemAndIndex = getItemAndIndex(itemProp, indexProp, latestProps.items, 'Pass either item or index to getItemProps!'),
+      item = _getItemAndIndex[0],
+      index = _getItemAndIndex[1];
     var itemHandleMouseMove = function itemHandleMouseMove() {
       if (index === latestState.highlightedIndex) {
         return;
@@ -2569,18 +2575,14 @@ function useSelect(userProps) {
         index: index
       });
     };
-    var itemIndex = getItemIndex(index, item, latestProps.items);
-    if (itemIndex < 0) {
-      throw new Error('Pass either item or item index in getItemProps!');
-    }
     var itemProps = _extends((_extends4 = {
       disabled: disabled,
       role: 'option',
       'aria-selected': "" + (item === selectedItem),
-      id: elementIds.getItemId(itemIndex)
+      id: elementIds.getItemId(index)
     }, _extends4[refKey] = handleRefs(ref, function (itemNode) {
       if (itemNode) {
-        itemRefs.current[elementIds.getItemId(itemIndex)] = itemNode;
+        itemRefs.current[elementIds.getItemId(index)] = itemNode;
       }
     }), _extends4), rest);
     if (!disabled) {
@@ -2591,7 +2593,7 @@ function useSelect(userProps) {
     }
     itemProps.onMouseMove = callAllEventHandlers(onMouseMove, itemHandleMouseMove);
     return itemProps;
-  }, [latest, items, selectedItem, elementIds, shouldScrollRef, dispatch]);
+  }, [latest, selectedItem, elementIds, shouldScrollRef, dispatch]);
   return {
     // prop getters.
     getToggleButtonProps: getToggleButtonProps,
@@ -3120,8 +3122,8 @@ function useCombobox(userProps) {
   var getItemProps = useCallback(function (_temp3) {
     var _extends3, _ref4;
     var _ref3 = _temp3 === void 0 ? {} : _temp3,
-      item = _ref3.item,
-      index = _ref3.index,
+      itemProp = _ref3.item,
+      indexProp = _ref3.index,
       _ref3$refKey = _ref3.refKey,
       refKey = _ref3$refKey === void 0 ? 'ref' : _ref3$refKey,
       ref = _ref3.ref,
@@ -3134,10 +3136,8 @@ function useCombobox(userProps) {
     var _latest$current = latest.current,
       latestProps = _latest$current.props,
       latestState = _latest$current.state;
-    var itemIndex = getItemIndex(index, item, latestProps.items);
-    if (itemIndex < 0) {
-      throw new Error('Pass either item or item index in getItemProps!');
-    }
+    var _getItemAndIndex = getItemAndIndex(itemProp, indexProp, latestProps.items, 'Pass either item or index to getItemProps!'),
+      index = _getItemAndIndex[1];
     var onSelectKey = 'onClick';
     var customClickHandler = onClick;
     var itemHandleMouseMove = function itemHandleMouseMove() {
@@ -3162,9 +3162,9 @@ function useCombobox(userProps) {
     };
     return _extends((_extends3 = {}, _extends3[refKey] = handleRefs(ref, function (itemNode) {
       if (itemNode) {
-        itemRefs.current[elementIds.getItemId(itemIndex)] = itemNode;
+        itemRefs.current[elementIds.getItemId(index)] = itemNode;
       }
-    }), _extends3.disabled = disabled, _extends3.role = 'option', _extends3['aria-selected'] = "" + (itemIndex === latestState.highlightedIndex), _extends3.id = elementIds.getItemId(itemIndex), _extends3), !disabled && (_ref4 = {}, _ref4[onSelectKey] = callAllEventHandlers(customClickHandler, itemHandleClick), _ref4), {
+    }), _extends3.disabled = disabled, _extends3.role = 'option', _extends3['aria-selected'] = "" + (index === latestState.highlightedIndex), _extends3.id = elementIds.getItemId(index), _extends3), !disabled && (_ref4 = {}, _ref4[onSelectKey] = callAllEventHandlers(customClickHandler, itemHandleClick), _ref4), {
       onMouseMove: callAllEventHandlers(onMouseMove, itemHandleMouseMove),
       onMouseDown: callAllEventHandlers(onMouseDown, itemHandleMouseDown)
     }, rest);
@@ -3704,14 +3704,13 @@ function useMultipleSelection(userProps) {
       ref = _ref3.ref,
       onClick = _ref3.onClick,
       onKeyDown = _ref3.onKeyDown,
-      selectedItem = _ref3.selectedItem,
-      index = _ref3.index,
+      selectedItemProp = _ref3.selectedItem,
+      indexProp = _ref3.index,
       rest = _objectWithoutPropertiesLoose(_ref3, _excluded);
     var latestState = latest.current.state;
-    var itemIndex = getItemIndex(index, selectedItem, latestState.selectedItems);
-    if (itemIndex < 0) {
-      throw new Error('Pass either selectedItem or index in getSelectedItemProps!');
-    }
+    var _getItemAndIndex = getItemAndIndex(selectedItemProp, indexProp, latestState.selectedItems, 'Pass either item or index to getSelectedItemProps!'),
+      index = _getItemAndIndex[1];
+    var isFocusable = index > -1 && index === latestState.activeIndex;
     var selectedItemHandleClick = function selectedItemHandleClick() {
       dispatch({
         type: SelectedItemClick,
@@ -3728,7 +3727,7 @@ function useMultipleSelection(userProps) {
       if (selectedItemNode) {
         selectedItemRefs.current.push(selectedItemNode);
       }
-    }), _extends2.tabIndex = index === latestState.activeIndex ? 0 : -1, _extends2.onClick = callAllEventHandlers(onClick, selectedItemHandleClick), _extends2.onKeyDown = callAllEventHandlers(onKeyDown, selectedItemHandleKeyDown), _extends2), rest);
+    }), _extends2.tabIndex = isFocusable ? 0 : -1, _extends2.onClick = callAllEventHandlers(onClick, selectedItemHandleClick), _extends2.onKeyDown = callAllEventHandlers(onKeyDown, selectedItemHandleKeyDown), _extends2), rest);
   }, [dispatch, latest, selectedItemKeyDownHandlers]);
   var getDropdownProps = useCallback(function (_temp2, _temp3) {
     var _extends3;

package/preact/dist/downshift.umd.js

@@ -1836,14 +1836,19 @@
     });
     return elementIdsRef.current;
   }
-  function getItemIndex(index, item, items) {
-    if (index !== undefined) {
-      return index;
-    }
-    if (items.length === 0) {
-      return -1;
+  function getItemAndIndex(itemProp, indexProp, items, errorMessage) {
+    var item, index;
+    if (itemProp === undefined) {
+      if (indexProp === undefined) {
+        throw new Error(errorMessage);
+      }
+      item = items[indexProp];
+      index = indexProp;
+    } else {
+      index = indexProp === undefined ? items.indexOf(itemProp) : indexProp;
+      item = itemProp;
     }
-    return items.indexOf(item);
+    return [item, index];
   }
   function itemToString(item) {
     return item ? String(item) : '';
@@ -2859,8 +2864,9 @@
       var _latest$current = latest.current,
         latestState = _latest$current.state,
         latestProps = _latest$current.props;
-      var item = itemProp != null ? itemProp : items[indexProp];
-      var index = getItemIndex(indexProp, item, latestProps.items);
+      var _getItemAndIndex = getItemAndIndex(itemProp, indexProp, latestProps.items, 'Pass either item or index to getItemProps!'),
+        item = _getItemAndIndex[0],
+        index = _getItemAndIndex[1];
       var itemHandleMouseMove = function itemHandleMouseMove() {
         if (index === latestState.highlightedIndex) {
           return;
@@ -2878,18 +2884,14 @@
           index: index
         });
       };
-      var itemIndex = getItemIndex(index, item, latestProps.items);
-      if (itemIndex < 0) {
-        throw new Error('Pass either item or item index in getItemProps!');
-      }
       var itemProps = _extends((_extends4 = {
         disabled: disabled,
         role: 'option',
         'aria-selected': "" + (item === selectedItem),
-        id: elementIds.getItemId(itemIndex)
+        id: elementIds.getItemId(index)
       }, _extends4[refKey] = handleRefs(ref, function (itemNode) {
         if (itemNode) {
-          itemRefs.current[elementIds.getItemId(itemIndex)] = itemNode;
+          itemRefs.current[elementIds.getItemId(index)] = itemNode;
         }
       }), _extends4), rest);
       if (!disabled) {
@@ -2900,7 +2902,7 @@
       }
       itemProps.onMouseMove = callAllEventHandlers(onMouseMove, itemHandleMouseMove);
       return itemProps;
-    }, [latest, items, selectedItem, elementIds, shouldScrollRef, dispatch]);
+    }, [latest, selectedItem, elementIds, shouldScrollRef, dispatch]);
     return {
       // prop getters.
       getToggleButtonProps: getToggleButtonProps,
@@ -3429,8 +3431,8 @@
     var getItemProps = preact.useCallback(function (_temp3) {
       var _extends3, _ref4;
       var _ref3 = _temp3 === void 0 ? {} : _temp3,
-        item = _ref3.item,
-        index = _ref3.index,
+        itemProp = _ref3.item,
+        indexProp = _ref3.index,
         _ref3$refKey = _ref3.refKey,
         refKey = _ref3$refKey === void 0 ? 'ref' : _ref3$refKey,
         ref = _ref3.ref,
@@ -3443,10 +3445,8 @@
       var _latest$current = latest.current,
         latestProps = _latest$current.props,
         latestState = _latest$current.state;
-      var itemIndex = getItemIndex(index, item, latestProps.items);
-      if (itemIndex < 0) {
-        throw new Error('Pass either item or item index in getItemProps!');
-      }
+      var _getItemAndIndex = getItemAndIndex(itemProp, indexProp, latestProps.items, 'Pass either item or index to getItemProps!'),
+        index = _getItemAndIndex[1];
       var onSelectKey = 'onClick';
       var customClickHandler = onClick;
       var itemHandleMouseMove = function itemHandleMouseMove() {
@@ -3471,9 +3471,9 @@
       };
       return _extends((_extends3 = {}, _extends3[refKey] = handleRefs(ref, function (itemNode) {
         if (itemNode) {
-          itemRefs.current[elementIds.getItemId(itemIndex)] = itemNode;
+          itemRefs.current[elementIds.getItemId(index)] = itemNode;
         }
-      }), _extends3.disabled = disabled, _extends3.role = 'option', _extends3['aria-selected'] = "" + (itemIndex === latestState.highlightedIndex), _extends3.id = elementIds.getItemId(itemIndex), _extends3), !disabled && (_ref4 = {}, _ref4[onSelectKey] = callAllEventHandlers(customClickHandler, itemHandleClick), _ref4), {
+      }), _extends3.disabled = disabled, _extends3.role = 'option', _extends3['aria-selected'] = "" + (index === latestState.highlightedIndex), _extends3.id = elementIds.getItemId(index), _extends3), !disabled && (_ref4 = {}, _ref4[onSelectKey] = callAllEventHandlers(customClickHandler, itemHandleClick), _ref4), {
         onMouseMove: callAllEventHandlers(onMouseMove, itemHandleMouseMove),
         onMouseDown: callAllEventHandlers(onMouseDown, itemHandleMouseDown)
       }, rest);
@@ -4013,14 +4013,13 @@
         ref = _ref3.ref,
         onClick = _ref3.onClick,
         onKeyDown = _ref3.onKeyDown,
-        selectedItem = _ref3.selectedItem,
-        index = _ref3.index,
+        selectedItemProp = _ref3.selectedItem,
+        indexProp = _ref3.index,
         rest = _objectWithoutPropertiesLoose(_ref3, _excluded);
       var latestState = latest.current.state;
-      var itemIndex = getItemIndex(index, selectedItem, latestState.selectedItems);
-      if (itemIndex < 0) {
-        throw new Error('Pass either selectedItem or index in getSelectedItemProps!');
-      }
+      var _getItemAndIndex = getItemAndIndex(selectedItemProp, indexProp, latestState.selectedItems, 'Pass either item or index to getSelectedItemProps!'),
+        index = _getItemAndIndex[1];
+      var isFocusable = index > -1 && index === latestState.activeIndex;
       var selectedItemHandleClick = function selectedItemHandleClick() {
         dispatch({
           type: SelectedItemClick,
@@ -4037,7 +4036,7 @@
         if (selectedItemNode) {
           selectedItemRefs.current.push(selectedItemNode);
         }
-      }), _extends2.tabIndex = index === latestState.activeIndex ? 0 : -1, _extends2.onClick = callAllEventHandlers(onClick, selectedItemHandleClick), _extends2.onKeyDown = callAllEventHandlers(onKeyDown, selectedItemHandleKeyDown), _extends2), rest);
+      }), _extends2.tabIndex = isFocusable ? 0 : -1, _extends2.onClick = callAllEventHandlers(onClick, selectedItemHandleClick), _extends2.onKeyDown = callAllEventHandlers(onKeyDown, selectedItemHandleKeyDown), _extends2), rest);
     }, [dispatch, latest, selectedItemKeyDownHandlers]);
     var getDropdownProps = preact.useCallback(function (_temp2, _temp3) {
       var _extends3;