dotcom-tool-kit 3.4.2 → 3.4.4

package/lib/install.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"install.d.ts","sourceRoot":"","sources":["../src/install.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,EAAE,MAAM,EAAE,MAAM,SAAS,CAAA;AACrC,OAAO,EAAc,WAAW,EAAE,MAAM,UAAU,CAAA;AAalD,wBAA8B,YAAY,CAAC,MAAM,EAAE,MAAM,GAAG,OAAO,CAAC,WAAW,CAAC,CA2D/E"}
+{"version":3,"file":"install.d.ts","sourceRoot":"","sources":["../src/install.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,EAAE,MAAM,EAAE,MAAM,SAAS,CAAA;AACrC,OAAO,EAAc,WAAW,EAAE,MAAM,UAAU,CAAA;AAalD,wBAA8B,YAAY,CAAC,MAAM,EAAE,MAAM,GAAG,OAAO,CAAC,WAAW,CAAC,CAyD/E"}

package/lib/install.js

@@ -6,14 +6,14 @@ const options_1 = require("@dotcom-tool-kit/options");
 const groupBy_1 = tslib_1.__importDefault(require("lodash/groupBy"));
 const config_1 = require("./config");
 const postInstall_1 = require("./postInstall");
-// implementation of the Array.some method that supports asynchronous predicates
-async function asyncSome(arr, pred) {
+// implementation of the Array.every method that supports asynchronous predicates
+async function asyncEvery(arr, pred) {
     for (const val of arr) {
-        if (await pred(val)) {
-            return true;
+        if (!(await pred(val))) {
+            return false;
         }
     }
-    return false;
+    return true;
 }
 async function installHooks(logger) {
     const config = await (0, config_1.loadConfig)(logger);
@@ -23,24 +23,18 @@ async function installHooks(logger) {
         }
     }
     const errors = [];
-    // HACK: achieve backwards compatibility with older versions of the circleci
-    // plugin that required a postinstall function to run instead of the new
-    // commitInstall method. remove in major update of cli.
-    let usesNewCircleCIGroup = false;
     // group hooks without an installGroup separately so that their check()
     // method runs independently
     const groups = (0, groupBy_1.default)(config.hooks, (hook) => hook.installGroup ?? '__' + hook.id);
-    for (const [groupId, group] of Object.entries(groups)) {
+    for (const group of Object.values(groups)) {
         try {
-            if (await asyncSome(group, async (hook) => !(await hook.check()))) {
+            const allChecksPassed = await asyncEvery(group, (hook) => hook.check());
+            if (!allChecksPassed) {
                 let state = undefined;
                 for (const hook of group) {
                     state = await hook.install(state);
                 }
                 if (state) {
-                    if (groupId === 'circleci') {
-                        usesNewCircleCIGroup = true;
-                    }
                     try {
                         await group[0].commitInstall(state);
                     }
@@ -64,6 +58,10 @@ async function installHooks(logger) {
             }
         }
     }
+    // HACK: achieve backwards compatibility with older versions of the circleci
+    // plugin that required a postinstall function to run instead of the new
+    // commitInstall method. remove in major update of cli.
+    const usesNewCircleCIGroup = Object.keys(groups).includes('circleci');
     if (!usesNewCircleCIGroup) {
         await (0, postInstall_1.postInstall)(logger);
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dotcom-tool-kit",
-  "version": "3.4.2",
+  "version": "3.4.4",
   "description": "modern, maintainable, modular developer tooling for FT.com projects",
   "author": "FT.com Platforms Team <platforms-team.customer-products@ft.com>",
   "license": "MIT",
@@ -21,11 +21,11 @@
   },
   "devDependencies": {
     "@dotcom-tool-kit/babel": "^3.2.0",
-    "@dotcom-tool-kit/backend-heroku-app": "^3.1.2",
+    "@dotcom-tool-kit/backend-heroku-app": "^3.1.3",
     "@dotcom-tool-kit/circleci": "^6.0.0",
-    "@dotcom-tool-kit/circleci-deploy": "^3.4.1",
+    "@dotcom-tool-kit/circleci-deploy": "^3.4.2",
     "@dotcom-tool-kit/eslint": "^3.2.0",
-    "@dotcom-tool-kit/frontend-app": "^3.2.2",
+    "@dotcom-tool-kit/frontend-app": "^3.2.3",
     "@dotcom-tool-kit/heroku": "^3.4.1",
     "@dotcom-tool-kit/mocha": "^3.2.0",
     "@dotcom-tool-kit/n-test": "^3.3.1",