dorfl 0.0.0 → 0.1.0

package/dist/review-verdict.d.ts

@@ -0,0 +1,149 @@
+/**
+ * The UNIFIED review-verdict type + parser + the shared JSON-verdict-contract
+ * prompt helper for the runner-invoked **review discipline**
+ * (`work/protocol/REVIEW-PROTOCOL.md`, source-of-truth
+ * `skills/setup/protocol/REVIEW-PROTOCOL.md`).
+ *
+ * This is the keystone of the `runner-invoked-disciplines-into-protocol` prd
+ * (task 1, D4): every runner-invoked review prompt builder
+ * ({@link buildReviewPrompt}, {@link buildTaskAcceptancePrompt} in
+ * `review-gate.ts`; {@link buildLoneTaskReviewPrompt} in `intake.ts`;
+ * {@link buildTaskReviewPrompt} in `tasker-review-loop.ts`) POINTS at
+ * `REVIEW-PROTOCOL.md` for the discipline + calls {@link verdictContractPrompt}
+ * for the JSON-emitted-shape prose. None of them re-inlines the lenses or the
+ * verdict contract; this module is the single home.
+ *
+ * The PARSER is the source of truth for the EMITTED SHAPE (D2):
+ * `REVIEW-PROTOCOL.md` mirrors what `parseReviewVerdict` enforces (a
+ * fixture-matches-doc test pins the two together). Discipline content is owned
+ * by the doc; enforced shape is owned by the parser.
+ */
+/** A single review finding — the `severity`/`question`/`context` triple. */
+export interface ReviewFinding {
+    /** Whether this finding blocks (keeps the work out of "ready") or is a nit. */
+    severity: 'blocking' | 'non-blocking';
+    /** The question / defect, with enough context to act. */
+    question: string;
+    /** The relevant excerpt, `file:line`, or reasoning. */
+    context?: string;
+}
+/**
+ * A full-content edit the review agent wants applied (the improver loop's
+ * between-passes step). `path` is repo-relative; `content` is the FULL
+ * replacement file body. The runner writes it; the agent does no disk/git.
+ */
+export interface TaskEdit {
+    /** Repo-relative path of the candidate task file to write. */
+    path: string;
+    /** The full replacement content for that file. */
+    content: string;
+}
+/**
+ * A task the review judged UNCERTAIN — emit it `needsAnswers: true` with the
+ * questions in its body. Used by the tasker improver loop's non-converge sink.
+ */
+export interface UncertainTask {
+    /** Repo-relative path of the uncertain candidate task. */
+    path: string;
+    /** The open questions to record in the task body. */
+    questions: string[];
+}
+/**
+ * The UNIFIED review verdict — one type across all four runner-invoked review
+ * call sites. The required fields (`verdict`, `findings`) are common; the
+ * optional channels are caller-specific (each builder's prompt names which
+ * channels to fill). The parser tolerates any subset; routing code reads only
+ * the channels its caller asked for.
+ */
+export interface ReviewVerdict {
+    /** `approve` lets the artifact proceed; `block` routes to needs-attention. */
+    verdict: 'approve' | 'block';
+    /** The findings the agent surfaced (may be empty on an approve). */
+    findings: ReviewFinding[];
+    /**
+     * For the PR/code review gate: the deliberately-authored, human-readable
+     * REVIEW prose the in-core PR-comment poster posts. Advisory only — never
+     * gates the verdict (routing uses ONLY `verdict`/`findings`).
+     */
+    review?: string;
+    /** For the tasker improver loop: full-content edits to apply between passes. */
+    edits?: TaskEdit[];
+    /**
+     * For the lone-task review: a single in-memory full-replacement task BODY
+     * (the markdown AFTER the frontmatter), applied before the next round.
+     */
+    edit?: string;
+    /** For the lone-task review: open question(s) carried into the ASK comment. */
+    questions?: string[];
+    /** For the tasker improver loop: specific tasks to emit `needsAnswers: true`. */
+    uncertainTasks?: UncertainTask[];
+    /** For the tasker improver loop: route the WHOLE prd to needs-attention. */
+    decompositionUnclear?: {
+        questions: string[];
+    };
+}
+/** Raised when the review agent ran but produced no parseable verdict. */
+export declare class ReviewParseError extends Error {
+}
+/**
+ * Parse the unified review verdict out of the review agent's textual output.
+ * The agent may wrap the JSON object in prose / a fenced block, so the first
+ * JSON object carrying a `verdict` field is extracted via the shared
+ * {@link extractJsonObjectSpan}, JSON-parsed, and validated. The verdict shape
+ * is the source of truth for what `REVIEW-PROTOCOL.md` describes (D2).
+ *
+ * Throws {@link ReviewParseError} on: no JSON object, invalid JSON, or a
+ * `verdict` not in `{approve, block}`. The caller treats any throw as
+ * needs-attention — NEVER a silent approve.
+ */
+export declare function parseReviewVerdict(output: string): ReviewVerdict;
+/**
+ * The shared JSON-verdict-contract prompt block — ONE function, called by all
+ * four review-prompt builders. Returns the prose describing the unified
+ * {@link ReviewVerdict} emitted shape (the prose mirrors what
+ * {@link parseReviewVerdict} enforces; D2). Per-builder framing (who you are,
+ * what you are reviewing, which optional channels to fill) stays in each
+ * builder; this block is the single source of truth for the shape.
+ *
+ * The block is intentionally generous about optional channels — each caller's
+ * prompt names which ones it wants. Unused channels are ignored by the parser.
+ */
+export declare function verdictContractPrompt(): string;
+/**
+ * The shared "emit DEFENSIVE, parseable, minified JSON" contract block — the
+ * hard-won discipline that stops a weak model from stranding the run with an
+ * unparseable emit (a dropped escape on an inner `"`, a raw newline in a string,
+ * an over-long field). It was learned on the Gate-2 verdict seam
+ * (observation `gate2-review-verdict-json-parse-crash-on-large-diffs`) and is
+ * now SHARED so EVERY agent→JSON→dispatch seam carries it, not just the verdict
+ * gate: {@link verdictContractPrompt} appends it, and so does the SURFACE gate's
+ * `buildSurfacePrompt` (observation
+ * `surface-rung-agent-emits-no-parseable-questions` — the same class of failure
+ * on the surface rung, where the prompt previously lacked this hardening AND
+ * showed a multi-line example that invited pretty-printing).
+ *
+ * @param emitNoun what the emitted object is called in prose (`verdict` /
+ *   `result`) — only the wording differs; the discipline is identical.
+ * @param longestField the name of the field most likely to be long (the one to
+ *   length-cap), or undefined to omit the length-cap bullet.
+ */
+export declare function parseableJsonContractPrompt(emitNoun?: string, longestField?: string): string;
+/**
+ * The shared prompt block that POINTS the spawned agent at the in-band review
+ * discipline doc (`work/protocol/REVIEW-PROTOCOL.md` in the set-up target repo,
+ * or the vendored fallback) instead of re-inlining the lenses. The four review
+ * builders call this so the discipline content lives in ONE place
+ * (`REVIEW-PROTOCOL.md`), never duplicated in the prompt builders.
+ */
+export declare function reviewDisciplinePrompt(): string;
+/**
+ * Resolve `REVIEW-PROTOCOL.md` in the target repo / vendored fallback / dev
+ * walk \u2014 a thin alias around {@link resolveProtocolDoc} for callers (and
+ * tests) that want to assert the doc is reachable. The four builders themselves
+ * do NOT call this (they reference the path BY NAME in the prompt prose, so the
+ * spawned agent reads its repo's own `work/protocol/REVIEW-PROTOCOL.md`), but
+ * keeping the helper here lets the resolver test cover the protocol-doc set in
+ * one place.
+ */
+export declare function resolveReviewProtocolPath(cwd?: string, override?: string): string;
+//# sourceMappingURL=review-verdict.d.ts.map

package/dist/review-verdict.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"review-verdict.d.ts","sourceRoot":"","sources":["../src/review-verdict.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;GAmBG;AAKH,4EAA4E;AAC5E,MAAM,WAAW,aAAa;IAC7B,+EAA+E;IAC/E,QAAQ,EAAE,UAAU,GAAG,cAAc,CAAC;IACtC,yDAAyD;IACzD,QAAQ,EAAE,MAAM,CAAC;IACjB,uDAAuD;IACvD,OAAO,CAAC,EAAE,MAAM,CAAC;CACjB;AAED;;;;GAIG;AACH,MAAM,WAAW,QAAQ;IACxB,8DAA8D;IAC9D,IAAI,EAAE,MAAM,CAAC;IACb,kDAAkD;IAClD,OAAO,EAAE,MAAM,CAAC;CAChB;AAED;;;GAGG;AACH,MAAM,WAAW,aAAa;IAC7B,0DAA0D;IAC1D,IAAI,EAAE,MAAM,CAAC;IACb,qDAAqD;IACrD,SAAS,EAAE,MAAM,EAAE,CAAC;CACpB;AAED;;;;;;GAMG;AACH,MAAM,WAAW,aAAa;IAC7B,8EAA8E;IAC9E,OAAO,EAAE,SAAS,GAAG,OAAO,CAAC;IAC7B,oEAAoE;IACpE,QAAQ,EAAE,aAAa,EAAE,CAAC;IAC1B;;;;OAIG;IACH,MAAM,CAAC,EAAE,MAAM,CAAC;IAChB,gFAAgF;IAChF,KAAK,CAAC,EAAE,QAAQ,EAAE,CAAC;IACnB;;;OAGG;IACH,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,+EAA+E;IAC/E,SAAS,CAAC,EAAE,MAAM,EAAE,CAAC;IACrB,iFAAiF;IACjF,cAAc,CAAC,EAAE,aAAa,EAAE,CAAC;IACjC,4EAA4E;IAC5E,oBAAoB,CAAC,EAAE;QAAC,SAAS,EAAE,MAAM,EAAE,CAAA;KAAC,CAAC;CAC7C;AAED,0EAA0E;AAC1E,qBAAa,gBAAiB,SAAQ,KAAK;CAAG;AAE9C;;;;;;;;;;GAUG;AACH,wBAAgB,kBAAkB,CAAC,MAAM,EAAE,MAAM,GAAG,aAAa,CAqChE;AAoJD;;;;;;;;;;GAUG;AACH,wBAAgB,qBAAqB,IAAI,MAAM,CAqC9C;AAED;;;;;;;;;;;;;;;;;GAiBG;AACH,wBAAgB,2BAA2B,CAC1C,QAAQ,SAAY,EACpB,YAAY,CAAC,EAAE,MAAM,GACnB,MAAM,CAsBR;AAED;;;;;;GAMG;AACH,wBAAgB,sBAAsB,IAAI,MAAM,CAc/C;AAED;;;;;;;;GAQG;AACH,wBAAgB,yBAAyB,CACxC,GAAG,CAAC,EAAE,MAAM,EACZ,QAAQ,CAAC,EAAE,MAAM,GACf,MAAM,CAER"}

package/dist/review-verdict.js

@@ -0,0 +1,332 @@
+/**
+ * The UNIFIED review-verdict type + parser + the shared JSON-verdict-contract
+ * prompt helper for the runner-invoked **review discipline**
+ * (`work/protocol/REVIEW-PROTOCOL.md`, source-of-truth
+ * `skills/setup/protocol/REVIEW-PROTOCOL.md`).
+ *
+ * This is the keystone of the `runner-invoked-disciplines-into-protocol` prd
+ * (task 1, D4): every runner-invoked review prompt builder
+ * ({@link buildReviewPrompt}, {@link buildTaskAcceptancePrompt} in
+ * `review-gate.ts`; {@link buildLoneTaskReviewPrompt} in `intake.ts`;
+ * {@link buildTaskReviewPrompt} in `tasker-review-loop.ts`) POINTS at
+ * `REVIEW-PROTOCOL.md` for the discipline + calls {@link verdictContractPrompt}
+ * for the JSON-emitted-shape prose. None of them re-inlines the lenses or the
+ * verdict contract; this module is the single home.
+ *
+ * The PARSER is the source of truth for the EMITTED SHAPE (D2):
+ * `REVIEW-PROTOCOL.md` mirrors what `parseReviewVerdict` enforces (a
+ * fixture-matches-doc test pins the two together). Discipline content is owned
+ * by the doc; enforced shape is owned by the parser.
+ */
+import { extractJsonObjectSpan } from './verdict-json.js';
+import { resolveProtocolDoc } from './prompt.js';
+/** Raised when the review agent ran but produced no parseable verdict. */
+export class ReviewParseError extends Error {
+}
+/**
+ * Parse the unified review verdict out of the review agent's textual output.
+ * The agent may wrap the JSON object in prose / a fenced block, so the first
+ * JSON object carrying a `verdict` field is extracted via the shared
+ * {@link extractJsonObjectSpan}, JSON-parsed, and validated. The verdict shape
+ * is the source of truth for what `REVIEW-PROTOCOL.md` describes (D2).
+ *
+ * Throws {@link ReviewParseError} on: no JSON object, invalid JSON, or a
+ * `verdict` not in `{approve, block}`. The caller treats any throw as
+ * needs-attention — NEVER a silent approve.
+ */
+export function parseReviewVerdict(output) {
+    const span = extractJsonObjectSpan(output);
+    if (span === undefined) {
+        throw new ReviewParseError('review agent produced no parseable {verdict, findings} result');
+    }
+    const slice = output.slice(span.start, span.end);
+    let parsed;
+    try {
+        // STRICT FIRST: already-valid JSON parses here and is returned UNTOUCHED —
+        // the repair pass never runs for it (no chance to alter a correct payload).
+        parsed = JSON.parse(slice);
+    }
+    catch (strictErr) {
+        // ONE lenient repair pass for the CONTROL-CHAR class (raw newline / tab / CR /
+        // other C0 char left unescaped inside a string field, common on large diffs +
+        // weaker models). The repair is NARROW: it only escapes control chars INSIDE
+        // strings; it NEVER touches JSON structure or token values (no trailing-comma
+        // stripping, no quoting bare tokens, no coercion), so it can never launder a
+        // genuinely-malformed or meaningfully-WRONG verdict into a false approve/block.
+        // A still-failing parse re-throws the ORIGINAL strict error (so direction-1's
+        // `runGate2Review` catch routes it to needs-attention, never a silent approve).
+        // NOTE the boundary: this does NOT fix an unescaped inner double-quote (which
+        // mis-bounds the extracted span before repair even runs); that class is handled
+        // by routing (direction 1) + the tightened contract (direction 3).
+        try {
+            parsed = JSON.parse(repairJsonControlChars(slice));
+        }
+        catch {
+            throw new ReviewParseError(`review verdict was not valid JSON: ${strictErr.message}`);
+        }
+    }
+    // A repaired parse STILL flows through validation, so a repaired
+    // `{"verdict":"maybe"}` (valid JSON, invalid VALUE) still throws here — the
+    // repair recovers SYNTAX, never bypasses the verdict-VALUE contract.
+    return validateVerdict(parsed);
+}
+/**
+ * The NARROW lenient repair (direction 2): walk the extracted JSON slice and
+ * escape any raw control char (a C0 char `< 0x20`, which JSON forbids inside a
+ * string literal) that appears INSIDE a string. OUTSIDE a string the structure
+ * is left byte-for-byte untouched. Escape-tracking is load-bearing: an escaped
+ * `\"` must NOT be read as the string's closing quote (or a following raw
+ * newline would be mis-handled). This recovers ONLY the control-char class; it
+ * performs NO structural change and NO token coercion, so it cannot turn a real
+ * reject into a false approve.
+ */
+function repairJsonControlChars(text) {
+    let out = '';
+    let inString = false;
+    let escaped = false;
+    for (let i = 0; i < text.length; i++) {
+        const ch = text[i];
+        const code = ch.charCodeAt(0);
+        if (inString) {
+            if (escaped) {
+                out += ch;
+                escaped = false;
+                continue;
+            }
+            if (ch === '\\') {
+                out += ch;
+                escaped = true;
+                continue;
+            }
+            if (ch === '"') {
+                out += ch;
+                inString = false;
+                continue;
+            }
+            if (code < 0x20) {
+                if (ch === '\n')
+                    out += '\\n';
+                else if (ch === '\t')
+                    out += '\\t';
+                else if (ch === '\r')
+                    out += '\\r';
+                else
+                    out += '\\u' + code.toString(16).padStart(4, '0');
+                continue;
+            }
+            out += ch;
+            continue;
+        }
+        if (ch === '"') {
+            inString = true;
+        }
+        out += ch;
+    }
+    return out;
+}
+function validateVerdict(parsed) {
+    if (typeof parsed !== 'object' || parsed === null) {
+        throw new ReviewParseError('review verdict was not an object');
+    }
+    const obj = parsed;
+    const verdict = obj.verdict;
+    if (verdict !== 'approve' && verdict !== 'block') {
+        throw new ReviewParseError(`review verdict was not 'approve' or 'block' (got ${JSON.stringify(verdict)})`);
+    }
+    const rawFindings = Array.isArray(obj.findings) ? obj.findings : [];
+    const findings = rawFindings.map((f) => {
+        const item = (typeof f === 'object' && f !== null ? f : {});
+        const severity = item.severity === 'blocking' ? 'blocking' : 'non-blocking';
+        return {
+            severity,
+            question: typeof item.question === 'string' ? item.question : '',
+            ...(typeof item.context === 'string' ? { context: item.context } : {}),
+        };
+    });
+    const edits = parseEdits(obj.edits);
+    const uncertainTasks = parseUncertainTasks(obj.uncertainTasks);
+    const decompositionUnclear = parseDecompositionUnclear(obj.decompositionUnclear);
+    const questions = Array.isArray(obj.questions)
+        ? obj.questions.filter((q) => typeof q === 'string')
+        : [];
+    return {
+        verdict,
+        findings,
+        ...(typeof obj.review === 'string' ? { review: obj.review } : {}),
+        ...(typeof obj.edit === 'string' ? { edit: obj.edit } : {}),
+        ...(edits.length > 0 ? { edits } : {}),
+        ...(questions.length > 0 ? { questions } : {}),
+        ...(uncertainTasks.length > 0 ? { uncertainTasks } : {}),
+        ...(decompositionUnclear ? { decompositionUnclear } : {}),
+    };
+}
+function parseEdits(raw) {
+    if (!Array.isArray(raw)) {
+        return [];
+    }
+    const out = [];
+    for (const e of raw) {
+        if (typeof e !== 'object' || e === null) {
+            continue;
+        }
+        const item = e;
+        if (typeof item.path === 'string' && typeof item.content === 'string') {
+            out.push({ path: item.path, content: item.content });
+        }
+    }
+    return out;
+}
+function parseUncertainTasks(raw) {
+    if (!Array.isArray(raw)) {
+        return [];
+    }
+    const out = [];
+    for (const u of raw) {
+        if (typeof u !== 'object' || u === null) {
+            continue;
+        }
+        const item = u;
+        if (typeof item.path !== 'string') {
+            continue;
+        }
+        const questions = Array.isArray(item.questions)
+            ? item.questions.filter((q) => typeof q === 'string')
+            : [];
+        out.push({ path: item.path, questions });
+    }
+    return out;
+}
+function parseDecompositionUnclear(raw) {
+    if (typeof raw !== 'object' || raw === null) {
+        return undefined;
+    }
+    const item = raw;
+    const questions = Array.isArray(item.questions)
+        ? item.questions.filter((q) => typeof q === 'string')
+        : [];
+    return { questions };
+}
+/**
+ * The shared JSON-verdict-contract prompt block — ONE function, called by all
+ * four review-prompt builders. Returns the prose describing the unified
+ * {@link ReviewVerdict} emitted shape (the prose mirrors what
+ * {@link parseReviewVerdict} enforces; D2). Per-builder framing (who you are,
+ * what you are reviewing, which optional channels to fill) stays in each
+ * builder; this block is the single source of truth for the shape.
+ *
+ * The block is intentionally generous about optional channels — each caller's
+ * prompt names which ones it wants. Unused channels are ignored by the parser.
+ */
+export function verdictContractPrompt() {
+    return [
+        '## Your output \u2014 ONE single JSON object (no prose OUTSIDE it)',
+        '',
+        'Emit a single JSON object of this exact shape (see',
+        '`work/protocol/REVIEW-PROTOCOL.md` \u2192 "Your output" for the prose-described',
+        'contract this mirrors). The example below is EXPANDED over several lines for',
+        'READABILITY, but you MUST emit it MINIFIED \u2014 ONE single line, no newlines',
+        'between the keys:',
+        '',
+        '```json',
+        '{"verdict": "approve" | "block",',
+        ' "findings": [',
+        '   {"severity": "blocking" | "non-blocking", "question": "\u2026", "context": "\u2026"}',
+        ' ],',
+        ' "review": "<the human-readable PR-comment prose, when the caller asks for it>",',
+        ' "edits": [ {"path": "work/tasks/backlog/<slug>.md", "content": "<full replacement>"} ],',
+        ' "edit": "<single in-memory replacement body, for the lone-task review>",',
+        ' "questions": ["<open question for the human>"],',
+        ' "uncertainTasks": [ {"path": "work/tasks/backlog/<slug>.md", "questions": ["\u2026"]} ],',
+        ' "decompositionUnclear": {"questions": ["\u2026"]}}',
+        '```',
+        '',
+        '- `verdict` MUST be exactly `approve` or `block`. Use `block` with at least',
+        '  one blocking finding when the artifact does not deliver / drifts / hides',
+        '  a defect a human reviewer would flag; otherwise `approve`.',
+        "- `findings` is required (may be empty). Each finding's `severity` is",
+        '  `blocking` (keeps the item out of "ready") or `non-blocking` (a nit /',
+        '  future improvement). Give each `question` enough context to act WITHOUT',
+        '  re-deriving it. `context` is the relevant excerpt, `file:line`, or',
+        '  reasoning.',
+        '- The optional channels (`review`, `edits`, `edit`, `questions`,',
+        '  `uncertainTasks`, `decompositionUnclear`) are OPT-IN: only fill the ones',
+        "  the caller's framing names. Unused channels are ignored.",
+        '',
+        parseableJsonContractPrompt('verdict', 'review'),
+    ].join('\n');
+}
+/**
+ * The shared "emit DEFENSIVE, parseable, minified JSON" contract block — the
+ * hard-won discipline that stops a weak model from stranding the run with an
+ * unparseable emit (a dropped escape on an inner `"`, a raw newline in a string,
+ * an over-long field). It was learned on the Gate-2 verdict seam
+ * (observation `gate2-review-verdict-json-parse-crash-on-large-diffs`) and is
+ * now SHARED so EVERY agent→JSON→dispatch seam carries it, not just the verdict
+ * gate: {@link verdictContractPrompt} appends it, and so does the SURFACE gate's
+ * `buildSurfacePrompt` (observation
+ * `surface-rung-agent-emits-no-parseable-questions` — the same class of failure
+ * on the surface rung, where the prompt previously lacked this hardening AND
+ * showed a multi-line example that invited pretty-printing).
+ *
+ * @param emitNoun what the emitted object is called in prose (`verdict` /
+ *   `result`) — only the wording differs; the discipline is identical.
+ * @param longestField the name of the field most likely to be long (the one to
+ *   length-cap), or undefined to omit the length-cap bullet.
+ */
+export function parseableJsonContractPrompt(emitNoun = 'verdict', longestField) {
+    const lengthCap = longestField === undefined
+        ? []
+        : [
+            `- Keep the LONGEST field (\`${longestField}\`) under ~1500 characters; say`,
+            '  less, not more. A long, multi-paragraph field is exactly what corrupts',
+            '  the JSON.',
+        ];
+    return [
+        '### Keep the JSON PARSEABLE (this is where weak models fail)',
+        '',
+        `A malformed ${emitNoun} strands the work, so emit DEFENSIVELY:`,
+        '- Emit it MINIFIED: ONE single line, no pretty-printing, no blank lines.',
+        '- INSIDE every string value, do NOT use a literal double-quote `"`. If you',
+        '  must quote something in prose, PARAPHRASE it or use SINGLE quotes \u2014 a',
+        `  dropped escape on an inner \`"\` is the #1 cause of an unparseable ${emitNoun}.`,
+        '- Keep every string field SHORT and SINGLE-LINE. Do NOT embed a raw newline,',
+        '  tab, or other control char in a string; if you genuinely need a break, write',
+        '  the two characters `\\n` (a backslash then n), never a real newline.',
+        ...lengthCap,
+    ].join('\n');
+}
+/**
+ * The shared prompt block that POINTS the spawned agent at the in-band review
+ * discipline doc (`work/protocol/REVIEW-PROTOCOL.md` in the set-up target repo,
+ * or the vendored fallback) instead of re-inlining the lenses. The four review
+ * builders call this so the discipline content lives in ONE place
+ * (`REVIEW-PROTOCOL.md`), never duplicated in the prompt builders.
+ */
+export function reviewDisciplinePrompt() {
+    return [
+        '## The review discipline',
+        '',
+        'Run the review discipline defined in `work/protocol/REVIEW-PROTOCOL.md`',
+        '(the in-band, protocol-native review protocol every set-up repo carries;',
+        'the human-facing pointer is `skills/review/SKILL.md`). Apply its lenses',
+        'IN ORDER, ENDING in the destination check ("if this is built/merged',
+        'exactly as written, do we end up with the system the prd/task',
+        'goal describes?"). Be ADVERSARIAL; verify against what ACTUALLY LANDED',
+        '(the bytes on disk), not intent. Weight findings by REAL impact \u2014 the',
+        'lenses find candidates, impact decides severity (a technically-true nit',
+        'no one would hit is not a block). Flag, do not guess.',
+    ].join('\n');
+}
+/**
+ * Resolve `REVIEW-PROTOCOL.md` in the target repo / vendored fallback / dev
+ * walk \u2014 a thin alias around {@link resolveProtocolDoc} for callers (and
+ * tests) that want to assert the doc is reachable. The four builders themselves
+ * do NOT call this (they reference the path BY NAME in the prompt prose, so the
+ * spawned agent reads its repo's own `work/protocol/REVIEW-PROTOCOL.md`), but
+ * keeping the helper here lets the resolver test cover the protocol-doc set in
+ * one place.
+ */
+export function resolveReviewProtocolPath(cwd, override) {
+    return resolveProtocolDoc('REVIEW-PROTOCOL.md', cwd, override);
+}
+//# sourceMappingURL=review-verdict.js.map

package/dist/review-verdict.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"review-verdict.js","sourceRoot":"","sources":["../src/review-verdict.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;GAmBG;AAEH,OAAO,EAAC,qBAAqB,EAAC,MAAM,mBAAmB,CAAC;AACxD,OAAO,EAAC,kBAAkB,EAAC,MAAM,aAAa,CAAC;AAoE/C,0EAA0E;AAC1E,MAAM,OAAO,gBAAiB,SAAQ,KAAK;CAAG;AAE9C;;;;;;;;;;GAUG;AACH,MAAM,UAAU,kBAAkB,CAAC,MAAc;IAChD,MAAM,IAAI,GAAG,qBAAqB,CAAC,MAAM,CAAC,CAAC;IAC3C,IAAI,IAAI,KAAK,SAAS,EAAE,CAAC;QACxB,MAAM,IAAI,gBAAgB,CACzB,+DAA+D,CAC/D,CAAC;IACH,CAAC;IACD,MAAM,KAAK,GAAG,MAAM,CAAC,KAAK,CAAC,IAAI,CAAC,KAAK,EAAE,IAAI,CAAC,GAAG,CAAC,CAAC;IACjD,IAAI,MAAe,CAAC;IACpB,IAAI,CAAC;QACJ,2EAA2E;QAC3E,4EAA4E;QAC5E,MAAM,GAAG,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC,CAAC;IAC5B,CAAC;IAAC,OAAO,SAAS,EAAE,CAAC;QACpB,+EAA+E;QAC/E,8EAA8E;QAC9E,6EAA6E;QAC7E,8EAA8E;QAC9E,6EAA6E;QAC7E,gFAAgF;QAChF,8EAA8E;QAC9E,gFAAgF;QAChF,8EAA8E;QAC9E,gFAAgF;QAChF,mEAAmE;QACnE,IAAI,CAAC;YACJ,MAAM,GAAG,IAAI,CAAC,KAAK,CAAC,sBAAsB,CAAC,KAAK,CAAC,CAAC,CAAC;QACpD,CAAC;QAAC,MAAM,CAAC;YACR,MAAM,IAAI,gBAAgB,CACzB,sCAAuC,SAAmB,CAAC,OAAO,EAAE,CACpE,CAAC;QACH,CAAC;IACF,CAAC;IACD,iEAAiE;IACjE,4EAA4E;IAC5E,qEAAqE;IACrE,OAAO,eAAe,CAAC,MAAM,CAAC,CAAC;AAChC,CAAC;AAED;;;;;;;;;GASG;AACH,SAAS,sBAAsB,CAAC,IAAY;IAC3C,IAAI,GAAG,GAAG,EAAE,CAAC;IACb,IAAI,QAAQ,GAAG,KAAK,CAAC;IACrB,IAAI,OAAO,GAAG,KAAK,CAAC;IACpB,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,IAAI,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;QACtC,MAAM,EAAE,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;QACnB,MAAM,IAAI,GAAG,EAAE,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC;QAC9B,IAAI,QAAQ,EAAE,CAAC;YACd,IAAI,OAAO,EAAE,CAAC;gBACb,GAAG,IAAI,EAAE,CAAC;gBACV,OAAO,GAAG,KAAK,CAAC;gBAChB,SAAS;YACV,CAAC;YACD,IAAI,EAAE,KAAK,IAAI,EAAE,CAAC;gBACjB,GAAG,IAAI,EAAE,CAAC;gBACV,OAAO,GAAG,IAAI,CAAC;gBACf,SAAS;YACV,CAAC;YACD,IAAI,EAAE,KAAK,GAAG,EAAE,CAAC;gBAChB,GAAG,IAAI,EAAE,CAAC;gBACV,QAAQ,GAAG,KAAK,CAAC;gBACjB,SAAS;YACV,CAAC;YACD,IAAI,IAAI,GAAG,IAAI,EAAE,CAAC;gBACjB,IAAI,EAAE,KAAK,IAAI;oBAAE,GAAG,IAAI,KAAK,CAAC;qBACzB,IAAI,EAAE,KAAK,IAAI;oBAAE,GAAG,IAAI,KAAK,CAAC;qBAC9B,IAAI,EAAE,KAAK,IAAI;oBAAE,GAAG,IAAI,KAAK,CAAC;;oBAC9B,GAAG,IAAI,KAAK,GAAG,IAAI,CAAC,QAAQ,CAAC,EAAE,CAAC,CAAC,QAAQ,CAAC,CAAC,EAAE,GAAG,CAAC,CAAC;gBACvD,SAAS;YACV,CAAC;YACD,GAAG,IAAI,EAAE,CAAC;YACV,SAAS;QACV,CAAC;QACD,IAAI,EAAE,KAAK,GAAG,EAAE,CAAC;YAChB,QAAQ,GAAG,IAAI,CAAC;QACjB,CAAC;QACD,GAAG,IAAI,EAAE,CAAC;IACX,CAAC;IACD,OAAO,GAAG,CAAC;AACZ,CAAC;AAED,SAAS,eAAe,CAAC,MAAe;IACvC,IAAI,OAAO,MAAM,KAAK,QAAQ,IAAI,MAAM,KAAK,IAAI,EAAE,CAAC;QACnD,MAAM,IAAI,gBAAgB,CAAC,kCAAkC,CAAC,CAAC;IAChE,CAAC;IACD,MAAM,GAAG,GAAG,MAAiC,CAAC;IAC9C,MAAM,OAAO,GAAG,GAAG,CAAC,OAAO,CAAC;IAC5B,IAAI,OAAO,KAAK,SAAS,IAAI,OAAO,KAAK,OAAO,EAAE,CAAC;QAClD,MAAM,IAAI,gBAAgB,CACzB,oDAAoD,IAAI,CAAC,SAAS,CAAC,OAAO,CAAC,GAAG,CAC9E,CAAC;IACH,CAAC;IACD,MAAM,WAAW,GAAG,KAAK,CAAC,OAAO,CAAC,GAAG,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,QAAQ,CAAC,CAAC,CAAC,EAAE,CAAC;IACpE,MAAM,QAAQ,GAAoB,WAAW,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE;QACvD,MAAM,IAAI,GAAG,CAAC,OAAO,CAAC,KAAK,QAAQ,IAAI,CAAC,KAAK,IAAI,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,EAAE,CAGzD,CAAC;QACF,MAAM,QAAQ,GAAG,IAAI,CAAC,QAAQ,KAAK,UAAU,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,CAAC,cAAc,CAAC;QAC5E,OAAO;YACN,QAAQ;YACR,QAAQ,EAAE,OAAO,IAAI,CAAC,QAAQ,KAAK,QAAQ,CAAC,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC,CAAC,EAAE;YAChE,GAAG,CAAC,OAAO,IAAI,CAAC,OAAO,KAAK,QAAQ,CAAC,CAAC,CAAC,EAAC,OAAO,EAAE,IAAI,CAAC,OAAO,EAAC,CAAC,CAAC,CAAC,EAAE,CAAC;SACpE,CAAC;IACH,CAAC,CAAC,CAAC;IACH,MAAM,KAAK,GAAG,UAAU,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC;IACpC,MAAM,cAAc,GAAG,mBAAmB,CAAC,GAAG,CAAC,cAAc,CAAC,CAAC;IAC/D,MAAM,oBAAoB,GAAG,yBAAyB,CACrD,GAAG,CAAC,oBAAoB,CACxB,CAAC;IACF,MAAM,SAAS,GAAG,KAAK,CAAC,OAAO,CAAC,GAAG,CAAC,SAAS,CAAC;QAC7C,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC,CAAC,EAAe,EAAE,CAAC,OAAO,CAAC,KAAK,QAAQ,CAAC;QACjE,CAAC,CAAC,EAAE,CAAC;IACN,OAAO;QACN,OAAO;QACP,QAAQ;QACR,GAAG,CAAC,OAAO,GAAG,CAAC,MAAM,KAAK,QAAQ,CAAC,CAAC,CAAC,EAAC,MAAM,EAAE,GAAG,CAAC,MAAM,EAAC,CAAC,CAAC,CAAC,EAAE,CAAC;QAC/D,GAAG,CAAC,OAAO,GAAG,CAAC,IAAI,KAAK,QAAQ,CAAC,CAAC,CAAC,EAAC,IAAI,EAAE,GAAG,CAAC,IAAI,EAAC,CAAC,CAAC,CAAC,EAAE,CAAC;QACzD,GAAG,CAAC,KAAK,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,EAAC,KAAK,EAAC,CAAC,CAAC,CAAC,EAAE,CAAC;QACpC,GAAG,CAAC,SAAS,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,EAAC,SAAS,EAAC,CAAC,CAAC,CAAC,EAAE,CAAC;QAC5C,GAAG,CAAC,cAAc,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,EAAC,cAAc,EAAC,CAAC,CAAC,CAAC,EAAE,CAAC;QACtD,GAAG,CAAC,oBAAoB,CAAC,CAAC,CAAC,EAAC,oBAAoB,EAAC,CAAC,CAAC,CAAC,EAAE,CAAC;KACvD,CAAC;AACH,CAAC;AAED,SAAS,UAAU,CAAC,GAAY;IAC/B,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC;QACzB,OAAO,EAAE,CAAC;IACX,CAAC;IACD,MAAM,GAAG,GAAe,EAAE,CAAC;IAC3B,KAAK,MAAM,CAAC,IAAI,GAAG,EAAE,CAAC;QACrB,IAAI,OAAO,CAAC,KAAK,QAAQ,IAAI,CAAC,KAAK,IAAI,EAAE,CAAC;YACzC,SAAS;QACV,CAAC;QACD,MAAM,IAAI,GAAG,CAA4B,CAAC;QAC1C,IAAI,OAAO,IAAI,CAAC,IAAI,KAAK,QAAQ,IAAI,OAAO,IAAI,CAAC,OAAO,KAAK,QAAQ,EAAE,CAAC;YACvE,GAAG,CAAC,IAAI,CAAC,EAAC,IAAI,EAAE,IAAI,CAAC,IAAI,EAAE,OAAO,EAAE,IAAI,CAAC,OAAO,EAAC,CAAC,CAAC;QACpD,CAAC;IACF,CAAC;IACD,OAAO,GAAG,CAAC;AACZ,CAAC;AAED,SAAS,mBAAmB,CAAC,GAAY;IACxC,IAAI,CAAC,KAAK,CAAC,OAAO,CAAC,GAAG,CAAC,EAAE,CAAC;QACzB,OAAO,EAAE,CAAC;IACX,CAAC;IACD,MAAM,GAAG,GAAoB,EAAE,CAAC;IAChC,KAAK,MAAM,CAAC,IAAI,GAAG,EAAE,CAAC;QACrB,IAAI,OAAO,CAAC,KAAK,QAAQ,IAAI,CAAC,KAAK,IAAI,EAAE,CAAC;YACzC,SAAS;QACV,CAAC;QACD,MAAM,IAAI,GAAG,CAA4B,CAAC;QAC1C,IAAI,OAAO,IAAI,CAAC,IAAI,KAAK,QAAQ,EAAE,CAAC;YACnC,SAAS;QACV,CAAC;QACD,MAAM,SAAS,GAAG,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,SAAS,CAAC;YAC9C,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC,CAAC,EAAe,EAAE,CAAC,OAAO,CAAC,KAAK,QAAQ,CAAC;YAClE,CAAC,CAAC,EAAE,CAAC;QACN,GAAG,CAAC,IAAI,CAAC,EAAC,IAAI,EAAE,IAAI,CAAC,IAAI,EAAE,SAAS,EAAC,CAAC,CAAC;IACxC,CAAC;IACD,OAAO,GAAG,CAAC;AACZ,CAAC;AAED,SAAS,yBAAyB,CACjC,GAAY;IAEZ,IAAI,OAAO,GAAG,KAAK,QAAQ,IAAI,GAAG,KAAK,IAAI,EAAE,CAAC;QAC7C,OAAO,SAAS,CAAC;IAClB,CAAC;IACD,MAAM,IAAI,GAAG,GAA8B,CAAC;IAC5C,MAAM,SAAS,GAAG,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,SAAS,CAAC;QAC9C,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,MAAM,CAAC,CAAC,CAAC,EAAe,EAAE,CAAC,OAAO,CAAC,KAAK,QAAQ,CAAC;QAClE,CAAC,CAAC,EAAE,CAAC;IACN,OAAO,EAAC,SAAS,EAAC,CAAC;AACpB,CAAC;AAED;;;;;;;;;;GAUG;AACH,MAAM,UAAU,qBAAqB;IACpC,OAAO;QACN,oEAAoE;QACpE,EAAE;QACF,oDAAoD;QACpD,iFAAiF;QACjF,8EAA8E;QAC9E,gFAAgF;QAChF,mBAAmB;QACnB,EAAE;QACF,SAAS;QACT,kCAAkC;QAClC,gBAAgB;QAChB,yFAAyF;QACzF,KAAK;QACL,kFAAkF;QAClF,0FAA0F;QAC1F,2EAA2E;QAC3E,kDAAkD;QAClD,2FAA2F;QAC3F,qDAAqD;QACrD,KAAK;QACL,EAAE;QACF,6EAA6E;QAC7E,4EAA4E;QAC5E,8DAA8D;QAC9D,uEAAuE;QACvE,yEAAyE;QACzE,2EAA2E;QAC3E,sEAAsE;QACtE,cAAc;QACd,kEAAkE;QAClE,4EAA4E;QAC5E,4DAA4D;QAC5D,EAAE;QACF,2BAA2B,CAAC,SAAS,EAAE,QAAQ,CAAC;KAChD,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AACd,CAAC;AAED;;;;;;;;;;;;;;;;;GAiBG;AACH,MAAM,UAAU,2BAA2B,CAC1C,QAAQ,GAAG,SAAS,EACpB,YAAqB;IAErB,MAAM,SAAS,GACd,YAAY,KAAK,SAAS;QACzB,CAAC,CAAC,EAAE;QACJ,CAAC,CAAC;YACA,+BAA+B,YAAY,iCAAiC;YAC5E,0EAA0E;YAC1E,aAAa;SACb,CAAC;IACL,OAAO;QACN,8DAA8D;QAC9D,EAAE;QACF,eAAe,QAAQ,yCAAyC;QAChE,0EAA0E;QAC1E,4EAA4E;QAC5E,8EAA8E;QAC9E,wEAAwE,QAAQ,GAAG;QACnF,8EAA8E;QAC9E,gFAAgF;QAChF,wEAAwE;QACxE,GAAG,SAAS;KACZ,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AACd,CAAC;AAED;;;;;;GAMG;AACH,MAAM,UAAU,sBAAsB;IACrC,OAAO;QACN,0BAA0B;QAC1B,EAAE;QACF,yEAAyE;QACzE,0EAA0E;QAC1E,yEAAyE;QACzE,qEAAqE;QACrE,+DAA+D;QAC/D,wEAAwE;QACxE,4EAA4E;QAC5E,yEAAyE;QACzE,uDAAuD;KACvD,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AACd,CAAC;AAED;;;;;;;;GAQG;AACH,MAAM,UAAU,yBAAyB,CACxC,GAAY,EACZ,QAAiB;IAEjB,OAAO,kBAAkB,CAAC,oBAAoB,EAAE,GAAG,EAAE,QAAQ,CAAC,CAAC;AAChE,CAAC"}