donobu 5.61.3 → 5.63.0

package/dist/utils/PageLogListeners.js

@@ -3,18 +3,34 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.registerPageLogListeners = registerPageLogListeners;
 const Logger_1 = require("./Logger");
 /**
- * Registers Playwright page event listeners that route browser console messages
- * and network request/response data to the {@link browserLogger} and
- * {@link networkLogger} Winston loggers. These loggers include a
- * {@link FlowLogBufferTransport} that captures entries into the per-flow
- * log buffer (when one is available via AsyncLocalStorage or the process-local
- * fallback).
+ * Registers Playwright page event listeners that route browser console
+ * messages and network request/response data to the {@link browserLogger}
+ * and {@link networkLogger} Winston loggers, whose
+ * {@link FlowLogBufferTransport} captures entries into a per-flow log
+ * buffer. Called from both {@link WebTargetInspector.handleNewPage}
+ * (Studio-launched flows) and the Playwright test extension fixture.
  *
- * This function is called from both {@link WebTargetInspector.handleNewPage}
- * (Studio-launched flows) and the Playwright test extension fixture, ensuring
- * identical logging behaviour across both runtime contexts.
+ * By default, entries are routed by the ambient AsyncLocalStorage logging
+ * context (or the process-local fallback). Pass `opts` to bind this page's
+ * listeners to an explicit flow + buffer instead. That binding is required
+ * whenever one test drives multiple pages with distinct flows (e.g.
+ * multi-user collab tests): the ambient context belongs to the primary
+ * page's flow, so an unbound secondary page would leak its entries —
+ * stamped with the wrong flowId — into the primary flow's buffer.
+ *
+ * The binding is stamped onto each entry's meta at emit time (see
+ * {@link FLOW_LOG_ROUTING}) rather than scoped via AsyncLocalStorage:
+ * winston defers format + transport delivery under backpressure, so
+ * ALS-based scoping would resolve against whatever context is live at drain
+ * time and silently misroute entries during synchronous log bursts.
  */
-function registerPageLogListeners(page) {
+function registerPageLogListeners(page, opts) {
+    const routing = opts
+        ? { [Logger_1.FLOW_LOG_ROUTING]: { flowId: opts.flowId, logBuffer: opts.logBuffer } }
+        : undefined;
+    // Merge the routing stamp into a log call's meta. Leaves the unbound
+    // call path byte-identical (meta stays undefined when both are absent).
+    const stamp = (meta) => routing ? { ...meta, ...routing } : meta;
     page.on('console', (msg) => {
         const { url, lineNumber, columnNumber } = msg.location();
         const hasSourceLocation = lineNumber !== 0 || columnNumber !== 0;
@@ -25,24 +41,24 @@ function registerPageLogListeners(page) {
             : undefined;
         switch (msg.type()) {
             case 'error':
-                Logger_1.browserLogger.error(msg.text(), meta);
+                Logger_1.browserLogger.error(msg.text(), stamp(meta));
                 break;
             case 'warning':
-                Logger_1.browserLogger.warn(msg.text(), meta);
+                Logger_1.browserLogger.warn(msg.text(), stamp(meta));
                 break;
             case 'debug':
-                Logger_1.browserLogger.debug(msg.text(), meta);
+                Logger_1.browserLogger.debug(msg.text(), stamp(meta));
                 break;
             default:
-                Logger_1.browserLogger.info(msg.text(), meta);
+                Logger_1.browserLogger.info(msg.text(), stamp(meta));
                 break;
         }
     });
     page.on('pageerror', (error) => {
-        Logger_1.browserLogger.error(error.message, {
+        Logger_1.browserLogger.error(error.message, stamp({
             stack: error.stack,
             url: page.url(),
-        });
+        }));
     });
     // Fallback timing: track request start times keyed by the Request object
     // itself (via WeakMap) so concurrent requests to the same URL don't collide.
@@ -71,24 +87,24 @@ function registerPageLogListeners(page) {
             resourceType: request.resourceType(),
         };
         if (status >= 500) {
-            Logger_1.networkLogger.error(request.url(), meta);
+            Logger_1.networkLogger.error(request.url(), stamp(meta));
         }
         else if (status >= 400) {
-            Logger_1.networkLogger.warn(request.url(), meta);
+            Logger_1.networkLogger.warn(request.url(), stamp(meta));
         }
         else {
-            Logger_1.networkLogger.info(request.url(), meta);
+            Logger_1.networkLogger.info(request.url(), stamp(meta));
         }
     });
     page.on('requestfailed', (request) => {
         const duration = getDuration(request);
-        Logger_1.networkLogger.error(`${request.url()} FAILED: ${request.failure()?.errorText}`, {
+        Logger_1.networkLogger.error(`${request.url()} FAILED: ${request.failure()?.errorText}`, stamp({
             method: request.method(),
             url: request.url(),
             resourceType: request.resourceType(),
             failureReason: request.failure()?.errorText,
             duration,
-        });
+        }));
     });
 }
 //# sourceMappingURL=PageLogListeners.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "donobu",
-  "version": "5.61.3",
+  "version": "5.63.0",
   "description": "Create browser automations with an LLM agent and replay them as Playwright scripts.",
   "main": "dist/main.js",
   "module": "dist/esm/main.js",