donobu 5.53.0 → 5.54.0

package/dist/esm/lib/test/testExtension.js

@@ -908,14 +908,14 @@ async function persistFlowJson(persistence, flowId, fileId, value) {
  * See `fetchBaselineScreenshot` / `gatherTestFailureEvidence` in
  * triageTestFailure.ts.
  *
- * Runs for any meaningful end state; skipped only for `skipped` tests (no real
- * page state), when triage is disabled, or for V1 (legacy self-heal) tests.
- * Best-effort and fails open.
+ * Runs for any meaningful end state, including V1 (objective-annotated) tests;
+ * skipped only for `skipped` tests (no real page state) or when triage is
+ * disabled. Triage reads this screenshot as the current run's failure shot and
+ * as the baseline for a later failing run. Best-effort and fails open.
  */
 async function captureAndPersistFinalState(page, testInfo) {
     if (testInfo.status === 'skipped' ||
-        process.env.DONOBU_TRIAGE_DISABLED === '1' ||
-        isV1Test(testInfo)) {
+        process.env.DONOBU_TRIAGE_DISABLED === '1') {
         return;
     }
     const flowId = page._dnb?.donobuFlowMetadata?.id;
@@ -1015,35 +1015,40 @@ async function finalizeTest(page, testInfo, logBuffer, videoOption) {
     // future failing run reads a successful run's copy as its baseline.
     await captureAndPersistFinalState(page, testInfo);
     if (testInfo.status === 'failed') {
-        if (isV1Test(testInfo)) {
-            if (isV1SelfHealingEnabled(testInfo) &&
-                !MiscUtils_1.MiscUtils.yn(envVars_1.env.data.DONOBU_AUTO_HEAL_ACTIVE)) {
-                if (!sharedState.gptClient) {
-                    Logger_1.appLogger.warn('Will not self-heal due to no GPT client being set up.');
-                }
-                else {
-                    try {
-                        await (0, selfHealing_1.selfHeal)(sharedState.gptClient, testInfo, page);
-                    }
-                    catch (error) {
-                        Logger_1.appLogger.error('Error when attempting to self-heal', error);
-                    }
-                }
+        // Gather failure-triage evidence for every failed test, regardless of its
+        // V1 (objective-annotated) classification or self-heal setting. Triage is a
+        // standalone diagnostic: it writes the failure evidence that populates the
+        // triage run directory, feeds the reports, and supplies the treatment plans
+        // auto-heal consumes. Legacy V1 self-heal runs separately, below.
+        try {
+            const evidenceResult = await (0, triageTestFailure_1.gatherTestFailureEvidence)(testInfo, page);
+            if (evidenceResult?.filePath) {
+                Logger_1.appLogger.info(`Persisted Donobu triage evidence for "${testInfo.title}" to ${evidenceResult.filePath}.`);
+            }
+            else if (evidenceResult?.evidence) {
+                Logger_1.appLogger.info(`Captured Donobu triage evidence for "${testInfo.title}" (schema v${evidenceResult.evidence.schemaVersion}).`);
             }
         }
-        else {
-            try {
-                const evidenceResult = await (0, triageTestFailure_1.gatherTestFailureEvidence)(testInfo, page);
-                if (evidenceResult?.filePath) {
-                    Logger_1.appLogger.info(`Persisted Donobu triage evidence for "${testInfo.title}" to ${evidenceResult.filePath}.`);
+        catch (error) {
+            Logger_1.appLogger.error(`Failed to gather test failure evidence for "${testInfo.title}".`, error);
+        }
+        // Legacy V1 self-heal: only for objective-annotated tests that opt in via
+        // SELF_HEAL_TESTS_ENABLED, and never during an auto-heal rerun (which owns
+        // its own remediation path).
+        if (isV1Test(testInfo) &&
+            isV1SelfHealingEnabled(testInfo) &&
+            !MiscUtils_1.MiscUtils.yn(envVars_1.env.data.DONOBU_AUTO_HEAL_ACTIVE)) {
+            if (!sharedState.gptClient) {
+                Logger_1.appLogger.warn('Will not self-heal due to no GPT client being set up.');
+            }
+            else {
+                try {
+                    await (0, selfHealing_1.selfHeal)(sharedState.gptClient, testInfo, page);
                 }
-                else if (evidenceResult?.evidence) {
-                    Logger_1.appLogger.info(`Captured Donobu triage evidence for "${testInfo.title}" (schema v${evidenceResult.evidence.schemaVersion}).`);
+                catch (error) {
+                    Logger_1.appLogger.error('Error when attempting to self-heal', error);
                 }
             }
-            catch (error) {
-                Logger_1.appLogger.error(`Failed to gather test failure evidence for "${testInfo.title}".`, error);
-            }
         }
     }
     else if (testInfo.status === 'passed' &&

package/dist/lib/test/testExtension.js

@@ -908,14 +908,14 @@ async function persistFlowJson(persistence, flowId, fileId, value) {
  * See `fetchBaselineScreenshot` / `gatherTestFailureEvidence` in
  * triageTestFailure.ts.
  *
- * Runs for any meaningful end state; skipped only for `skipped` tests (no real
- * page state), when triage is disabled, or for V1 (legacy self-heal) tests.
- * Best-effort and fails open.
+ * Runs for any meaningful end state, including V1 (objective-annotated) tests;
+ * skipped only for `skipped` tests (no real page state) or when triage is
+ * disabled. Triage reads this screenshot as the current run's failure shot and
+ * as the baseline for a later failing run. Best-effort and fails open.
  */
 async function captureAndPersistFinalState(page, testInfo) {
     if (testInfo.status === 'skipped' ||
-        process.env.DONOBU_TRIAGE_DISABLED === '1' ||
-        isV1Test(testInfo)) {
+        process.env.DONOBU_TRIAGE_DISABLED === '1') {
         return;
     }
     const flowId = page._dnb?.donobuFlowMetadata?.id;
@@ -1015,35 +1015,40 @@ async function finalizeTest(page, testInfo, logBuffer, videoOption) {
     // future failing run reads a successful run's copy as its baseline.
     await captureAndPersistFinalState(page, testInfo);
     if (testInfo.status === 'failed') {
-        if (isV1Test(testInfo)) {
-            if (isV1SelfHealingEnabled(testInfo) &&
-                !MiscUtils_1.MiscUtils.yn(envVars_1.env.data.DONOBU_AUTO_HEAL_ACTIVE)) {
-                if (!sharedState.gptClient) {
-                    Logger_1.appLogger.warn('Will not self-heal due to no GPT client being set up.');
-                }
-                else {
-                    try {
-                        await (0, selfHealing_1.selfHeal)(sharedState.gptClient, testInfo, page);
-                    }
-                    catch (error) {
-                        Logger_1.appLogger.error('Error when attempting to self-heal', error);
-                    }
-                }
+        // Gather failure-triage evidence for every failed test, regardless of its
+        // V1 (objective-annotated) classification or self-heal setting. Triage is a
+        // standalone diagnostic: it writes the failure evidence that populates the
+        // triage run directory, feeds the reports, and supplies the treatment plans
+        // auto-heal consumes. Legacy V1 self-heal runs separately, below.
+        try {
+            const evidenceResult = await (0, triageTestFailure_1.gatherTestFailureEvidence)(testInfo, page);
+            if (evidenceResult?.filePath) {
+                Logger_1.appLogger.info(`Persisted Donobu triage evidence for "${testInfo.title}" to ${evidenceResult.filePath}.`);
+            }
+            else if (evidenceResult?.evidence) {
+                Logger_1.appLogger.info(`Captured Donobu triage evidence for "${testInfo.title}" (schema v${evidenceResult.evidence.schemaVersion}).`);
             }
         }
-        else {
-            try {
-                const evidenceResult = await (0, triageTestFailure_1.gatherTestFailureEvidence)(testInfo, page);
-                if (evidenceResult?.filePath) {
-                    Logger_1.appLogger.info(`Persisted Donobu triage evidence for "${testInfo.title}" to ${evidenceResult.filePath}.`);
+        catch (error) {
+            Logger_1.appLogger.error(`Failed to gather test failure evidence for "${testInfo.title}".`, error);
+        }
+        // Legacy V1 self-heal: only for objective-annotated tests that opt in via
+        // SELF_HEAL_TESTS_ENABLED, and never during an auto-heal rerun (which owns
+        // its own remediation path).
+        if (isV1Test(testInfo) &&
+            isV1SelfHealingEnabled(testInfo) &&
+            !MiscUtils_1.MiscUtils.yn(envVars_1.env.data.DONOBU_AUTO_HEAL_ACTIVE)) {
+            if (!sharedState.gptClient) {
+                Logger_1.appLogger.warn('Will not self-heal due to no GPT client being set up.');
+            }
+            else {
+                try {
+                    await (0, selfHealing_1.selfHeal)(sharedState.gptClient, testInfo, page);
                 }
-                else if (evidenceResult?.evidence) {
-                    Logger_1.appLogger.info(`Captured Donobu triage evidence for "${testInfo.title}" (schema v${evidenceResult.evidence.schemaVersion}).`);
+                catch (error) {
+                    Logger_1.appLogger.error('Error when attempting to self-heal', error);
                 }
             }
-            catch (error) {
-                Logger_1.appLogger.error(`Failed to gather test failure evidence for "${testInfo.title}".`, error);
-            }
         }
     }
     else if (testInfo.status === 'passed' &&

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "donobu",
-  "version": "5.53.0",
+  "version": "5.54.0",
   "description": "Create browser automations with an LLM agent and replay them as Playwright scripts.",
   "main": "dist/main.js",
   "module": "dist/esm/main.js",