donobu 5.36.4 → 5.36.5

package/dist/esm/lib/test/testExtension.js

@@ -342,7 +342,7 @@ exports.test = test_1.test.extend({
                 return;
             }
             if (initialActive === 0) {
-                Logger_1.appLogger.info('donobuFileUploadDrainGuard: no pending file uploads at end of test ' +
+                Logger_1.appLogger.debug('donobuFileUploadDrainGuard: no pending file uploads at end of test ' +
                     'session; worker is exiting.');
                 return;
             }

package/dist/esm/managers/SuitesManager.d.ts

@@ -19,9 +19,17 @@ export declare class SuitesManager {
     /**
      * Delete a suite from all persistence layers.
      *
-     * After deleting, orphans any tests that belong to this suite by setting
-     * their suiteId to null. This mirrors the DB-level ON DELETE SET NULL
-     * behavior for non-DB persistence layers (Volatile, S3, GCS).
+     * Orphans tests that belong to the suite first, then deletes the suite
+     * row. The orphan pass must run before the suite delete: SQLite has an
+     * ON DELETE SET NULL FK on test_metadata.suite_id, which clears the
+     * column synchronously inside DELETE FROM suite_metadata. If we deleted
+     * first, the subsequent getTests({ suiteId }) filter would find zero
+     * rows in the SQLite layer (column already null) and skip the JSON-blob
+     * rewrite, leaving each affected test's `metadata.suiteId` pointed at a
+     * suite that no longer exists. Orphaning first rewrites both the SQL
+     * column and the JSON blob via updateTest, so the FK cascade is then a
+     * no-op. Non-DB layers (Volatile, S3, GCS) have no FK and rely on this
+     * pass for the cascade behavior in either ordering.
      */
     deleteSuite(suiteId: string): Promise<void>;
 }

package/dist/esm/managers/SuitesManager.js

@@ -103,27 +103,32 @@ class SuitesManager {
     /**
      * Delete a suite from all persistence layers.
      *
-     * After deleting, orphans any tests that belong to this suite by setting
-     * their suiteId to null. This mirrors the DB-level ON DELETE SET NULL
-     * behavior for non-DB persistence layers (Volatile, S3, GCS).
+     * Orphans tests that belong to the suite first, then deletes the suite
+     * row. The orphan pass must run before the suite delete: SQLite has an
+     * ON DELETE SET NULL FK on test_metadata.suite_id, which clears the
+     * column synchronously inside DELETE FROM suite_metadata. If we deleted
+     * first, the subsequent getTests({ suiteId }) filter would find zero
+     * rows in the SQLite layer (column already null) and skip the JSON-blob
+     * rewrite, leaving each affected test's `metadata.suiteId` pointed at a
+     * suite that no longer exists. Orphaning first rewrites both the SQL
+     * column and the JSON blob via updateTest, so the FK cascade is then a
+     * no-op. Non-DB layers (Volatile, S3, GCS) have no FK and rely on this
+     * pass for the cascade behavior in either ordering.
      */
     async deleteSuite(suiteId) {
         for (const { key, persistence, } of await this.suitesPersistenceRegistry.getEntries()) {
             try {
-                await persistence.deleteSuite(suiteId);
-                // Orphan tests in this layer after successfully deleting the suite.
-                // This mirrors the DB-level ON DELETE SET NULL for non-DB layers.
                 // Pair by key — the suites and tests registries can have different
                 // sets of layers (e.g. plugin-only suites persistence) so positional
                 // indexing isn't safe.
                 const testsPersistence = await this.testsPersistenceRegistry.getByKey(key);
-                if (!testsPersistence) {
-                    continue;
-                }
-                const testsResult = await testsPersistence.getTests({ suiteId });
-                for (const test of testsResult.items) {
-                    await testsPersistence.updateTest({ ...test, suiteId: null });
+                if (testsPersistence) {
+                    const testsResult = await testsPersistence.getTests({ suiteId });
+                    for (const test of testsResult.items) {
+                        await testsPersistence.updateTest({ ...test, suiteId: null });
+                    }
                 }
+                await persistence.deleteSuite(suiteId);
             }
             catch {
                 // Ignore errors from layers that don't have this suite.

package/dist/lib/test/testExtension.js

@@ -342,7 +342,7 @@ exports.test = test_1.test.extend({
                 return;
             }
             if (initialActive === 0) {
-                Logger_1.appLogger.info('donobuFileUploadDrainGuard: no pending file uploads at end of test ' +
+                Logger_1.appLogger.debug('donobuFileUploadDrainGuard: no pending file uploads at end of test ' +
                     'session; worker is exiting.');
                 return;
             }

package/dist/managers/SuitesManager.d.ts

@@ -19,9 +19,17 @@ export declare class SuitesManager {
     /**
      * Delete a suite from all persistence layers.
      *
-     * After deleting, orphans any tests that belong to this suite by setting
-     * their suiteId to null. This mirrors the DB-level ON DELETE SET NULL
-     * behavior for non-DB persistence layers (Volatile, S3, GCS).
+     * Orphans tests that belong to the suite first, then deletes the suite
+     * row. The orphan pass must run before the suite delete: SQLite has an
+     * ON DELETE SET NULL FK on test_metadata.suite_id, which clears the
+     * column synchronously inside DELETE FROM suite_metadata. If we deleted
+     * first, the subsequent getTests({ suiteId }) filter would find zero
+     * rows in the SQLite layer (column already null) and skip the JSON-blob
+     * rewrite, leaving each affected test's `metadata.suiteId` pointed at a
+     * suite that no longer exists. Orphaning first rewrites both the SQL
+     * column and the JSON blob via updateTest, so the FK cascade is then a
+     * no-op. Non-DB layers (Volatile, S3, GCS) have no FK and rely on this
+     * pass for the cascade behavior in either ordering.
      */
     deleteSuite(suiteId: string): Promise<void>;
 }

package/dist/managers/SuitesManager.js

@@ -103,27 +103,32 @@ class SuitesManager {
     /**
      * Delete a suite from all persistence layers.
      *
-     * After deleting, orphans any tests that belong to this suite by setting
-     * their suiteId to null. This mirrors the DB-level ON DELETE SET NULL
-     * behavior for non-DB persistence layers (Volatile, S3, GCS).
+     * Orphans tests that belong to the suite first, then deletes the suite
+     * row. The orphan pass must run before the suite delete: SQLite has an
+     * ON DELETE SET NULL FK on test_metadata.suite_id, which clears the
+     * column synchronously inside DELETE FROM suite_metadata. If we deleted
+     * first, the subsequent getTests({ suiteId }) filter would find zero
+     * rows in the SQLite layer (column already null) and skip the JSON-blob
+     * rewrite, leaving each affected test's `metadata.suiteId` pointed at a
+     * suite that no longer exists. Orphaning first rewrites both the SQL
+     * column and the JSON blob via updateTest, so the FK cascade is then a
+     * no-op. Non-DB layers (Volatile, S3, GCS) have no FK and rely on this
+     * pass for the cascade behavior in either ordering.
      */
     async deleteSuite(suiteId) {
         for (const { key, persistence, } of await this.suitesPersistenceRegistry.getEntries()) {
             try {
-                await persistence.deleteSuite(suiteId);
-                // Orphan tests in this layer after successfully deleting the suite.
-                // This mirrors the DB-level ON DELETE SET NULL for non-DB layers.
                 // Pair by key — the suites and tests registries can have different
                 // sets of layers (e.g. plugin-only suites persistence) so positional
                 // indexing isn't safe.
                 const testsPersistence = await this.testsPersistenceRegistry.getByKey(key);
-                if (!testsPersistence) {
-                    continue;
-                }
-                const testsResult = await testsPersistence.getTests({ suiteId });
-                for (const test of testsResult.items) {
-                    await testsPersistence.updateTest({ ...test, suiteId: null });
+                if (testsPersistence) {
+                    const testsResult = await testsPersistence.getTests({ suiteId });
+                    for (const test of testsResult.items) {
+                        await testsPersistence.updateTest({ ...test, suiteId: null });
+                    }
                 }
+                await persistence.deleteSuite(suiteId);
             }
             catch {
                 // Ignore errors from layers that don't have this suite.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "donobu",
-  "version": "5.36.4",
+  "version": "5.36.5",
   "description": "Create browser automations with an LLM agent and replay them as Playwright scripts.",
   "main": "dist/main.js",
   "module": "dist/esm/main.js",